Re: Parameterizing Sling Feature model extensions

2018-11-09 Thread Carsten Ziegeler
lgtm THanks Carsten Am 09.11.2018 um 17:37 schrieb David Bosschaert: Hi all, Looking at how this is now done for the analyse-features mojo [1], I would propose to follow a similar pattern for the extension handlers/post processors. We can add an optional handlerConfiguration tag in the

[jira] [Commented] (SLING-8003) Interpolate Maven variables using the Maven Interpolator APIs rather that iterate string replacing operations

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682069#comment-16682069 ] ASF GitHub Bot commented on SLING-8003: --- simonetripodi opened a new pull request #18: SLING-8003 -

[jira] [Updated] (SLING-8003) Interpolate Maven variables using the Maven Interpolator APIs rather that iterate string replacing operations

2018-11-09 Thread Simone Tripodi (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Simone Tripodi updated SLING-8003: -- Summary: Interpolate Maven variables using the Maven Interpolator APIs rather that iterate

[GitHub] simonetripodi opened a new pull request #18: SLING-8003 - Interpolate Maven variables using the Maven Interpolator APIs rather that iterate string replacing operations

2018-11-09 Thread GitBox
simonetripodi opened a new pull request #18: SLING-8003 - Interpolate Maven variables using the Maven Interpolator APIs rather that iterate string replacing operations URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/18 @bosschaert @cziegeler please have a look at that

[GitHub] ghenzler closed pull request #1: SLING-8083 avoid ClassNotFoundExceptions, take infoProvider.getInstallationState().getInstalledResources() into account

2018-11-09 Thread GitBox
ghenzler closed pull request #1: SLING-8083 avoid ClassNotFoundExceptions, take infoProvider.getInstallationState().getInstalledResources() into account URL: https://github.com/apache/sling-org-apache-sling-installer-provider-installhook/pull/1

[GitHub] bosschaert closed pull request #4: SLING-8085 - adjusting ContentHandler to properly incorporating layer…

2018-11-09 Thread GitBox
bosschaert closed pull request #4: SLING-8085 - adjusting ContentHandler to properly incorporating layer… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/4 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it

[GitHub] bosschaert commented on issue #4: SLING-8085 - adjusting ContentHandler to properly incorporating layer…

2018-11-09 Thread GitBox
bosschaert commented on issue #4: SLING-8085 - adjusting ContentHandler to properly incorporating layer… URL: https://github.com/apache/sling-org-apache-sling-feature-extension-content/pull/4#issuecomment-437315541 Thanks for the pull request @DominikSuess , it's merged.

[jira] [Commented] (SLING-8085) Incorporate layering optimizations for cross layer dependencies

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681209#comment-16681209 ] ASF GitHub Bot commented on SLING-8085: --- bosschaert closed pull request #4: SLING-8085 - adjusting

[jira] [Resolved] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8032. - Resolution: Fixed > Add a MOJO which is able to validate JSON Feature file against the

[jira] [Updated] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-8032: Fix Version/s: Feature Model IO 0.2.2 > Add a MOJO which is able to validate JSON Feature

[jira] [Updated] (SLING-8083) Installer Hook: Installer events are not in all cases received

2018-11-09 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-8083: - Affects Version/s: Installer Vault Package Install Hook 1.0.2 > Installer Hook: Installer events

[jira] [Resolved] (SLING-8083) Installer Hook: Installer events are not in all cases received

2018-11-09 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler resolved SLING-8083. -- Resolution: Fixed > Installer Hook: Installer events are not in all cases received >

[jira] [Updated] (SLING-8083) Installer Hook: Installer events are not in all cases received

2018-11-09 Thread Georg Henzler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georg Henzler updated SLING-8083: - Fix Version/s: Installer Vault Package Install Hook 1.0.4 > Installer Hook: Installer events are

[jira] [Commented] (SLING-7999) Add a `length` property to the AbstractRepeatPlugin

2018-11-09 Thread Radu Cotescu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681181#comment-16681181 ] Radu Cotescu commented on SLING-7999: - [~klcodanr], thanks for assigning the issue to me. I somehow

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-09 Thread Robert Munteanu
On Thu, 2018-11-08 at 17:07 +0100, Oliver Lietz wrote: > I wrote a proposal about how this could look like in terms of > > results > > > > https://cwiki.apache.org/confluence/display/SLING/Moving+integration+tests+c > > loser+to+the+code+they+test > > > > I purposefully avoided looking into

Re: [VOTE] Release Apache Sling Distributed Event Admin 1.1.4

2018-11-09 Thread Robert Munteanu
On Wed, 2018-11-07 at 15:56 +0100, Robert Munteanu wrote: > Anyone else? See :-) Thanks, Robert

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681257#comment-16681257 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on issue #17: SLING-8032 - Add a

[GitHub] simonetripodi commented on issue #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-09 Thread GitBox
simonetripodi commented on issue #17: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/17#issuecomment-437325020 cool, thanks to you for deep review! :)

[jira] [Commented] (SLING-8083) Installer Hook: Installer events are not in all cases received

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681148#comment-16681148 ] ASF GitHub Bot commented on SLING-8083: --- ghenzler closed pull request #1: SLING-8083 avoid

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681213#comment-16681213 ] ASF GitHub Bot commented on SLING-8078: --- cziegeler commented on issue #7: SLING-8078 - New Analyser

[jira] [Commented] (SLING-8085) Incorporate layering optimizations for cross layer dependencies

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681210#comment-16681210 ] ASF GitHub Bot commented on SLING-8085: --- bosschaert commented on issue #4: SLING-8085 - adjusting

[GitHub] cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread GitBox
cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-437316155 @simonetripodi Thanks. We had some more discussion on

Re: [VOTE] Release Apache Sling Installer Vault Package Install Hook 1.0.4

2018-11-09 Thread Konrad Windszus
+1 Konrad > On 9. Nov 2018, at 13:42, Georg Henzler wrote: > > Hi, > > We solved 1 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12344427 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2010 > > You can use

[VOTE] Release Apache Sling Servlets Resolver 2.4.24

2018-11-09 Thread Carsten Ziegeler
Hi, We solved 3 issues in this release https://issues.apache.org/jira/projects/SLING/versions/12342700 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2012 You can use this UNIX script to download the release and verify the signatures:

Re: [VOTE] Release Apache Sling Servlets Get 2.1.38

2018-11-09 Thread Carsten Ziegeler
+1 Am 09.11.2018 um 14:58 schrieb Carsten Ziegeler: Hi, We solved 2 issues in this release https://issues.apache.org/jira/projects/SLING/versions/12344154 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2011 You can use this UNIX script to download the

Re: [VOTE] Release Apache Sling Servlets Resolver 2.4.24

2018-11-09 Thread Carsten Ziegeler
+1 Am 09.11.2018 um 15:00 schrieb Carsten Ziegeler: Hi, We solved 3 issues in this release https://issues.apache.org/jira/projects/SLING/versions/12342700 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2012 You can use this UNIX script to download the

Re: [VOTE] Release Apache Sling Servlets Get 2.1.38

2018-11-09 Thread Daniel Klco
+1 On Fri, Nov 9, 2018 at 9:05 AM Carsten Ziegeler wrote: > +1 > > Am 09.11.2018 um 14:58 schrieb Carsten Ziegeler: > > Hi, > > > > We solved 2 issues in this release > > https://issues.apache.org/jira/projects/SLING/versions/12344154 > > > > > > Staging repository: > >

[GitHub] bosschaert commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread GitBox
bosschaert commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#issuecomment-437375351 Hi @simonetripodi @cziegeler I was playing with the new

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681508#comment-16681508 ] ASF GitHub Bot commented on SLING-8078: --- bosschaert commented on issue #16: SLING-8078 - New

Re: [VOTE] Release Apache Sling App CMS version 0.11.0

2018-11-09 Thread Daniel Klco
Hi, The vote has passed with the following result : +1 (binding): Daniel Klco, Radu Cotescu, Robert Munteanu +1 (non binding): Jason E Bailey I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. On Wed, Nov 7, 2018 at 9:12 AM Radu

[jira] [Closed] (SLING-7974) CMS - Core - Can't Send Email

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7974. --- > CMS - Core - Can't Send Email > - > > Key: SLING-7974 >

[jira] [Closed] (SLING-7963) CMS - Core - Error Handler Post Handling

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7963. --- > CMS - Core - Error Handler Post Handling > > > Key:

[jira] [Closed] (SLING-7951) Expose Import Options

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7951. --- > Expose Import Options > - > > Key: SLING-7951 > URL:

[jira] [Closed] (SLING-7957) CMS - Reference - Fix Path of Reference App Template

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7957. --- > CMS - Reference - Fix Path of Reference App Template > >

[jira] [Closed] (SLING-8055) CMS - UI - Selection Not Cleared

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8055. --- > CMS - UI - Selection Not Cleared > > > Key: SLING-8055 >

[jira] [Closed] (SLING-8059) CMS - UI - Version Actions Broken

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8059. --- > CMS - UI - Version Actions Broken > - > > Key: SLING-8059 >

[jira] [Closed] (SLING-7946) CMS - UI - Expose Load Content Console

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7946. --- > CMS - UI - Expose Load Content Console > -- > > Key:

[jira] [Closed] (SLING-7958) Add Note in Documentation on Name of Site Configuration

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7958. --- > Add Note in Documentation on Name of Site Configuration >

[jira] [Closed] (SLING-7945) CMS - UI - Expose Bulk Replace Console

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7945. --- > CMS - UI - Expose Bulk Replace Console > -- > > Key:

[jira] [Closed] (SLING-7971) CMS - UI - Whole Dialog Add Template Draggable

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7971. --- > CMS - UI - Whole Dialog Add Template Draggable > --- > >

[jira] [Created] (SLING-8087) CMS - UI - Cannot Create Pages

2018-11-09 Thread Dan Klco (JIRA)
Dan Klco created SLING-8087: --- Summary: CMS - UI - Cannot Create Pages Key: SLING-8087 URL: https://issues.apache.org/jira/browse/SLING-8087 Project: Sling Issue Type: Bug Affects Versions: App

[jira] [Closed] (SLING-7986) CMS - introduce new js lib to decorate elems on dom insertion

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-7986. --- > CMS - introduce new js lib to decorate elems on dom insertion >

[jira] [Created] (SLING-8088) CMS - UI - Clicking Background Doesn't Close Component Dialogs

2018-11-09 Thread Dan Klco (JIRA)
Dan Klco created SLING-8088: --- Summary: CMS - UI - Clicking Background Doesn't Close Component Dialogs Key: SLING-8088 URL: https://issues.apache.org/jira/browse/SLING-8088 Project: Sling Issue

[jira] [Resolved] (SLING-8087) CMS - UI - Cannot Create Pages

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8087. - Resolution: Fixed Fixed in 

[jira] [Updated] (SLING-8088) CMS - UI - Clicking Background Doesn't Close Component Dialogs

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-8088: Component/s: App CMS > CMS - UI - Clicking Background Doesn't Close Component Dialogs >

[jira] [Commented] (SLING-7436) Wrong content/type in the Default JSON Renderer

2018-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681041#comment-16681041 ] Carsten Ziegeler commented on SLING-7436: - [~asanso] These are the headers send back < HTTP/1.1

[jira] [Comment Edited] (SLING-7436) Wrong content/type in the Default JSON Renderer

2018-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681041#comment-16681041 ] Carsten Ziegeler edited comment on SLING-7436 at 11/9/18 8:17 AM: --

[jira] [Commented] (SLING-7436) Wrong content/type in the Default JSON Renderer

2018-11-09 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681033#comment-16681033 ] Antonio Sanso commented on SLING-7436: -- [~cziegeler] AFAIR the problem is not the content content

[jira] [Resolved] (SLING-7436) Wrong content/type in the Default JSON Renderer

2018-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-7436. - Resolution: Cannot Reproduce I can't reproduce this, in addition the description

[GitHub] simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread GitBox
simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-437339727 @cziegeler thanks a lot for the follow-up, I just

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681350#comment-16681350 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi commented on issue #7: SLING-8078 - New

Re: [Feature Model] Proposal for feature model inventory printer component

2018-11-09 Thread Karl Pauls
+1 regards, Karl On Fri, Nov 9, 2018 at 1:03 PM Robert Munteanu wrote: > > On Fri, 2018-11-09 at 11:56 +, David Bosschaert wrote: > > I propose that we move this code to a new repository called > > sling-org-apache-sling-feature-inventoryprinter > > +1 > > Robert > -- Karl Pauls

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681383#comment-16681383 ] ASF GitHub Bot commented on SLING-8078: --- cziegeler closed pull request #7: SLING-8078 - New

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681382#comment-16681382 ] ASF GitHub Bot commented on SLING-8078: --- cziegeler commented on issue #7: SLING-8078 - New Analyser

[GitHub] cziegeler closed pull request #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread GitBox
cziegeler closed pull request #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7 This is an

[GitHub] cziegeler closed pull request #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread GitBox
cziegeler closed pull request #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16 This is an

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681385#comment-16681385 ] ASF GitHub Bot commented on SLING-8078: --- cziegeler closed pull request #16: SLING-8078 - New

[GitHub] cziegeler commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread GitBox
cziegeler commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#issuecomment-437345023 Thanks @simonetripodi

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681384#comment-16681384 ] ASF GitHub Bot commented on SLING-8078: --- cziegeler commented on issue #16: SLING-8078 - New

[GitHub] simonetripodi commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread GitBox
simonetripodi commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#issuecomment-437347177 Thanks to you @cziegeler for reviewing and merging my

[feature model] Thoughts about all-in-one jar packaging?

2018-11-09 Thread Robert Munteanu
Hi, For certain scenarios there would be a need to package a feature-based application into a single jar file. I'm thinking mostly about desktop applications, but if we move the Sling Starter to the feature model a single jar deliverable would also be nice. It's probably not too much work to: -

[VOTE] Release Apache Sling Installer Vault Package Install Hook 1.0.4

2018-11-09 Thread Georg Henzler
Hi, We solved 1 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12344427 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2010 You can use this UNIX script to download the release and verify the signatures:

Re: [feature model] Designating a feature as 'complete'

2018-11-09 Thread Carsten Ziegeler
We had a similar discussion in the OSGi expert group about this and basically came to a similar conclusion. Now, in the first version of our code base in Sling we distinguished between a feature and an application, where an application was a complete feature. We dropped the application

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-09 Thread Georg Henzler
+1 to move the tests closer to the code. Regarding the path src/test/it (mentioned in the wiki page): Shouldn't we rather stick with src/test/java for both ITs and regular tests and just use the standard name conventions as configured by default for plugins surefire/failsafe maven plugins,

Re: [feature model] Designating a feature as 'complete'

2018-11-09 Thread David Bosschaert
FWIW the current description of features vs 'complete features' in the OSGi RFP can be found in section 2.4 of [1]. @Robert Munteanu pretty much what you described :) Best regards, David [1] https://github.com/osgi/design/blob/master/rfps/rfp-0188-Features.pdf On Fri, 9 Nov 2018 at 12:49,

Re: [feature model] Thoughts about all-in-one jar packaging?

2018-11-09 Thread David Bosschaert
+1 Would be great :) David On Fri, 9 Nov 2018 at 12:52, Carsten Ziegeler wrote: > I think this is on the wish list, so yes :) > > It just needs "someone" to start the work (hint hint) > > Regards > Carsten > > Am 09.11.2018 um 13:44 schrieb Robert Munteanu: > > Hi, > > > > For certain

Re: [feature model] Designating a feature as 'complete'

2018-11-09 Thread Robert Munteanu
On Fri, 2018-11-09 at 13:49 +0100, Carsten Ziegeler wrote: > - what exactly does complete imply? can it be launched with other > features? etc. I guess we just need to define this. My personal optinion is that we should be able to launch a complete feature with other features. One scenario which

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-09 Thread Robert Munteanu
On Fri, 2018-11-09 at 13:50 +0100, Georg Henzler wrote: > +1 to move the tests closer to the code. > > Regarding the path src/test/it (mentioned in the wiki page): > Shouldn't > we rather stick with src/test/java for both ITs and regular tests > and > just use the standard name conventions as

[Feature Model] Proposal for feature model inventory printer component

2018-11-09 Thread David Bosschaert
Hi all, I would like to propose another new Sling component: the Feature Inventory Printer. This is a small component that adds an inventory printer service that is picked up by the Web Console and displays diagnostic information around the Feature Model. Right now it shows the effective feature

Re: [Feature Model] Proposal for feature model inventory printer component

2018-11-09 Thread Robert Munteanu
On Fri, 2018-11-09 at 11:56 +, David Bosschaert wrote: > I propose that we move this code to a new repository called > sling-org-apache-sling-feature-inventoryprinter +1 Robert

[GitHub] simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread GitBox
simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-437346521 thanks to you for continuous reviews, very

[feature model] Designating a feature as 'complete'

2018-11-09 Thread Robert Munteanu
Hi, I am wondering if it makes sense to mark a feature as 'complete'. A complete feature would be one that is expected to be launched individually, e.g. needs to additions to function. I would see the benefits mainly in tooling: - a complete feature is self-contained, therefore all requirements

[jira] [Resolved] (SLING-8011) Accessing the info.sessionInfo.json endpoint always logs an error: Writer has already been closed

2018-11-09 Thread Jason E Bailey (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason E Bailey resolved SLING-8011. --- Resolution: Fixed > Accessing the info.sessionInfo.json endpoint always logs an error:

Re: [feature model] Thoughts about all-in-one jar packaging?

2018-11-09 Thread Robert Munteanu
Ah, so I basically ruined the chances of someone else beating me to it :-) It's not too high on my priority list, but it's good to know there's interest for it and if I get the time I might start working on it. Thanks, Robert On Fri, 2018-11-09 at 13:09 +, David Bosschaert wrote: > +1 > >

[jira] [Commented] (SLING-8086) Extend distribution queue SPI with the ability to clear and batch remove items

2018-11-09 Thread Timothee Maret (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681424#comment-16681424 ] Timothee Maret commented on SLING-8086: --- Opened PR

[RESULT] [VOTE] Release Apache Sling Distributed Event Admin 1.1.4

2018-11-09 Thread Robert Munteanu
Hi, The vote has passed with the following result : +1 (binding): Radu Cotescu, Georg Henzler, Daniel Klco, Robert Munteanu I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks, Robert

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681387#comment-16681387 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi commented on issue #7: SLING-8078 - New

[jira] [Updated] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-8078: Fix Version/s: slingfeature-maven-plugin 1.0.0 > New Analyser task which is able to detect

[jira] [Resolved] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8078. - Resolution: Fixed > New Analyser task which is able to detect Export-Package

[jira] [Updated] (SLING-8086) Extend distribution queue SPI with the ability to clear and batch remove items

2018-11-09 Thread Timothee Maret (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated SLING-8086: -- Summary: Extend distribution queue SPI with the ability to clear and batch remove items (was:

[jira] [Created] (SLING-8086) Extend queue API with the ability to clear and batch remove items

2018-11-09 Thread Timothee Maret (JIRA)
Timothee Maret created SLING-8086: - Summary: Extend queue API with the ability to clear and batch remove items Key: SLING-8086 URL: https://issues.apache.org/jira/browse/SLING-8086 Project: Sling

Re: [feature model] Thoughts about all-in-one jar packaging?

2018-11-09 Thread Carsten Ziegeler
I think this is on the wish list, so yes :) It just needs "someone" to start the work (hint hint) Regards Carsten Am 09.11.2018 um 13:44 schrieb Robert Munteanu: Hi, For certain scenarios there would be a need to package a feature-based application into a single jar file. I'm thinking mostly

Re: [feature model] Designating a feature as 'complete'

2018-11-09 Thread Robert Munteanu
On Fri, 2018-11-09 at 13:12 +, David Bosschaert wrote: > FWIW the current description of features vs 'complete features' in > the OSGi > RFP can be found in section 2.4 of [1]. > > @Robert Munteanu pretty much what you described > :) Ah OK. I should've read that first :-) Thanks, Robert

[VOTE] Release Apache Sling Servlets Get 2.1.38

2018-11-09 Thread Carsten Ziegeler
Hi, We solved 2 issues in this release https://issues.apache.org/jira/projects/SLING/versions/12344154 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2011 You can use this UNIX script to download the release and verify the signatures:

[jira] [Commented] (SLING-8080) Almost all ITs fail after the Starter 11 release

2018-11-09 Thread Stefan Seifert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681380#comment-16681380 ] Stefan Seifert commented on SLING-8080: --- the problem affects all recent version of

[GitHub] cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread GitBox
cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-437344713 Thanks @simonetripodi

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681391#comment-16681391 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi commented on issue #16: SLING-8078 - New

Re: [VOTE] Release Apache Sling Distributed Event Admin 1.1.4

2018-11-09 Thread Georg Henzler
+1 (I Jörgs one-line & only change for this release looks good to me even though I don't know this module too well) On 2018-10-23 17:21, Robert Munteanu wrote: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12339956 Staging repository:

[GitHub] tmaret opened a new pull request #15: SLING-8086 - Extend distribution queue SPI with the ability to clear …

2018-11-09 Thread GitBox
tmaret opened a new pull request #15: SLING-8086 - Extend distribution queue SPI with the ability to clear … URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/15 …and batch remove items This is an

Re: [VOTE] Release Apache Sling Distributed Event Admin 1.1.4

2018-11-09 Thread Daniel Klco
+1 happy to see this particular warning go away ;-) On Fri, Nov 9, 2018 at 7:36 AM Georg Henzler wrote: > > +1 > > (I Jörgs one-line & only change for this release looks good to me even > though I don't know this module too well) > > On 2018-10-23 17:21, Robert Munteanu wrote: > > Hi, > > > >

[jira] [Comment Edited] (SLING-8086) Extend distribution queue SPI with the ability to clear and batch remove items

2018-11-09 Thread Timothee Maret (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681424#comment-16681424 ] Timothee Maret edited comment on SLING-8086 at 11/9/18 3:52 PM: Opened PR

[jira] [Updated] (SLING-8086) Extend distribution queue SPI with the ability to clear and batch remove items

2018-11-09 Thread Timothee Maret (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated SLING-8086: -- Description: Currently, the {{DistributionQueue}} API only allows to remove a single random

[GitHub] mpetria commented on a change in pull request #15: SLING-8086 - Extend distribution queue SPI with the ability to clear …

2018-11-09 Thread GitBox
mpetria commented on a change in pull request #15: SLING-8086 - Extend distribution queue SPI with the ability to clear … URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/15#discussion_r232304779 ## File path:

Re: Parameterizing Sling Feature model extensions

2018-11-09 Thread David Bosschaert
Hi all, Looking at how this is now done for the analyse-features mojo [1], I would propose to follow a similar pattern for the extension handlers/post processors. We can add an optional handlerConfiguration tag in the aggregate-features task that holds configuration for specific handlers. As the

Re: [VOTE] Release Apache Sling Installer Vault Package Install Hook 1.0.4

2018-11-09 Thread Daniel Klco
+1 On Fri, Nov 9, 2018 at 9:03 AM Konrad Windszus wrote: > +1 > > Konrad > > > On 9. Nov 2018, at 13:42, Georg Henzler wrote: > > > > Hi, > > > > We solved 1 issues in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12344427 > > > > Staging repository: > >

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-09 Thread Andrei Dulvac
+1 for moving the tests to the code as well. However... I would be careful to check what is packaged in the `tests` artifact produced by the build. Should we package the test transient dependencies? Otherwise it will be complicated to run multiple test artifacts under one build, with different

Re: [VOTE] Release Apache Sling Servlets Resolver 2.4.24

2018-11-09 Thread Nicolas Peltier
+1 Le ven. 9 nov. 2018 à 15:10, Daniel Klco a écrit : > +1 > > On Fri, Nov 9, 2018 at 9:05 AM Carsten Ziegeler > wrote: > > > +1 > > > > Am 09.11.2018 um 15:00 schrieb Carsten Ziegeler: > > > Hi, > > > > > > We solved 3 issues in this release > > >

Re: [VOTE] Release Apache Sling Installer Vault Package Install Hook 1.0.4

2018-11-09 Thread Radu Cotescu
+1 > On 9 Nov 2018, at 13:42, Georg Henzler wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.

[jira] [Closed] (SLING-8004) CMS - UI - Fields Not Disabled on Form Submit

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8004. --- > CMS - UI - Fields Not Disabled on Form Submit > - > >

[jira] [Closed] (SLING-8054) CMS - UI - Component Editor Cut Off

2018-11-09 Thread Dan Klco (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco closed SLING-8054. --- > CMS - UI - Component Editor Cut Off > --- > > Key: SLING-8054

  1   2   >