[GitHub] [sling-org-apache-sling-commons-log] DominikSuess opened a new pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…

2020-05-29 Thread GitBox
DominikSuess opened a new pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6 …nagedServiceFactory This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [sling-org-apache-sling-commons-log] bosschaert commented on pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…

2020-05-29 Thread GitBox
bosschaert commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6#issuecomment-635915203 LGTM  This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (SLING-9487) Default for org.apache.sling.commons.log.file only set via metatype breaking the logstatus webconsole.

2020-05-29 Thread Jira
Dominik Süß created SLING-9487: -- Summary: Default for org.apache.sling.commons.log.file only set via metatype breaking the logstatus webconsole. Key: SLING-9487 URL: https://issues.apache.org/jira/browse/SLING-9487

[GitHub] [sling-org-apache-sling-feature-cpconverter] bosschaert commented on pull request #28: Feature Converter doesn't cleanup after itself

2020-05-29 Thread GitBox
bosschaert commented on pull request #28: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#issuecomment-635914387 > do you mind creating an issue for this? Not sure if I have access Creating a sling issue can be done by anyone. Just create an account

[GitHub] [sling-org-apache-sling-commons-log] bosschaert edited a comment on pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…

2020-05-29 Thread GitBox
bosschaert edited a comment on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6#issuecomment-635915203 LGTM  There is a test failure though... ITConfigAdminSupport.testChangeLogLevelWithConfig:118 null

[RESULT][VOTE] Release Apache Sling slingfeature-maven-plugin 1.3.4

2020-05-29 Thread davidb
With 5 binding +1 votes and 1 non-binding +1 vote this release succeeds. I've promoted the artifacts. Best regards, David On Mon, 25 May 2020 at 15:24, wrote: > Hi all, > > I would like to call the release on the Sling Feature Maven Plugin 1.3.4 > > Resolved issues: >

[jira] [Commented] (SLING-9487) Default for org.apache.sling.commons.log.file only set via metatype breaking the logstatus webconsole.

2020-05-29 Thread Jira
[ https://issues.apache.org/jira/browse/SLING-9487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119469#comment-17119469 ] Dominik Süß commented on SLING-9487: PR at

[jira] [Created] (SLING-9488) Do not wait in case of journal not seeded

2020-05-29 Thread Christian Schneider (Jira)
Christian Schneider created SLING-9488: -- Summary: Do not wait in case of journal not seeded Key: SLING-9488 URL: https://issues.apache.org/jira/browse/SLING-9488 Project: Sling Issue

[jira] [Comment Edited] (SLING-9483) Sling Feature is not supporting jar:file URLs on Windows

2020-05-29 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119349#comment-17119349 ] Robert Munteanu edited comment on SLING-9483 at 5/29/20, 7:25 AM: -- I was

[jira] [Commented] (SLING-9483) Sling Feature is not supporting jar:file URLs on Windows

2020-05-29 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119349#comment-17119349 ] Robert Munteanu commented on SLING-9483: I was looking at

[jira] [Commented] (SLING-9397) SAML2 Authentication Handler [initial submission]

2020-05-29 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119625#comment-17119625 ] Robert Munteanu commented on SLING-9397: [~cris_rockwell] - looking at the instructions indeed

[jira] [Resolved] (SLING-9484) CMS - Archetype Missing BND Configurations

2020-05-29 Thread Dan Klco (Jira)
[ https://issues.apache.org/jira/browse/SLING-9484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-9484. - Resolution: Fixed Fixed in

Re: [VOTE] move o.a.s.graphql.samples.website to its own repo

2020-05-29 Thread Robert Munteanu
Hi Bertrand, On Thu, 2020-05-28 at 16:48 +0200, Bertrand Delacretaz wrote: > Hi, > > I'd like to move the org.apache.sling.graphql.samples.website [1] > module to its own Git repository. > > It's a companion module to the GraphQL Core module, which > demonstrates > its features, see the README

Re: [VOTE] move o.a.s.graphql.samples.website to its own repo

2020-05-29 Thread Bertrand Delacretaz
Hi Robert On Fri, May 29, 2020 at 3:40 PM Robert Munteanu wrote: > ...You probably considered this, but I am curious - why a separate > repository vs adding it to sling-samples [2]?... I didn't really consider that so far but you're right that if my code has no need for a Jenkins build for

FYI, deprecated a few very old samples: espblog, javashell, path-based-rtp

2020-05-29 Thread Bertrand Delacretaz
Hi, I have moved those to a DEPRECATED folder in the sling-samples module [1] If someone needs them back, it's easy to revert. -Bertrand [1] https://github.com/apache/sling-samples/commit/863fb0c26238afe22fb231219fca23cf4c9543dd

[jira] [Created] (SLING-9489) Make it possible to compare parts of feature models

2020-05-29 Thread A. J. David Bosschaert (Jira)
A. J. David Bosschaert created SLING-9489: - Summary: Make it possible to compare parts of feature models Key: SLING-9489 URL: https://issues.apache.org/jira/browse/SLING-9489 Project: Sling

[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models

2020-05-29 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119718#comment-17119718 ] A. J. David Bosschaert commented on SLING-9489: --- The use-case is that sometimes

[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models

2020-05-29 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119712#comment-17119712 ] Carsten Ziegeler commented on SLING-9489: - What is the use case? We also already have a diff

[GitHub] [sling-org-apache-sling-commons-log] kwin commented on pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…

2020-05-29 Thread GitBox
kwin commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6#issuecomment-636040989 Switching to https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types is more sustainable but is

[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models

2020-05-29 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119725#comment-17119725 ] Carsten Ziegeler commented on SLING-9489: - This sounds like a strange feature for a maven plugin

Re: [VOTE] move o.a.s.graphql.samples.website to its own repo

2020-05-29 Thread Bertrand Delacretaz
On Fri, May 29, 2020 at 4:21 PM Bertrand Delacretaz wrote: > ...you're right that if my code > has no need for a Jenkins build for example that's good enough... Turns out that a build is already setup for https://github.com/apache/sling-samples/ - I just fixed it by removing the "fling" failing

[jira] [Created] (SLING-9490) Feature Model Converter doesn't clean up tmp directories

2020-05-29 Thread Kaushal Mall (Jira)
Kaushal Mall created SLING-9490: --- Summary: Feature Model Converter doesn't clean up tmp directories Key: SLING-9490 URL: https://issues.apache.org/jira/browse/SLING-9490 Project: Sling Issue

[GitHub] [sling-org-apache-sling-feature-cpconverter] kaushalmall commented on pull request #28: Feature Converter doesn't cleanup after itself

2020-05-29 Thread GitBox
kaushalmall commented on pull request #28: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#issuecomment-636159564 created https://issues.apache.org/jira/browse/SLING-9490 thanks @bosschaert

Framework Properties Override on Feature Launcher

2020-05-29 Thread Andreas Schaefer
Hi Is it just me or does the Feature Launcher not support Framework Properties Overrides? Cheers - Andy

[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models

2020-05-29 Thread A. J. David Bosschaert (Jira)
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119923#comment-17119923 ] A. J. David Bosschaert commented on SLING-9489: --- [~cziegeler] do you think this

[jira] [Resolved] (SLING-9482) Seed the cache from offset persisted in the source repository

2020-05-29 Thread Timothee Maret (Jira)
[ https://issues.apache.org/jira/browse/SLING-9482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret resolved SLING-9482. --- Resolution: Fixed > Seed the cache from offset persisted in the source repository >