[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2022-08-21 Thread GitBox


sonarcloud[bot] commented on PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1221636875

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests=1)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Resolved] (SLING-11551) switch to parent 49

2022-08-21 Thread Nicolas Peltier (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-11551.
-
  Assignee: Nicolas Peltier
Resolution: Fixed

> switch to parent 49
> ---
>
> Key: SLING-11551
> URL: https://issues.apache.org/jira/browse/SLING-11551
> Project: Sling
>  Issue Type: Task
>  Components: pipes
>Affects Versions: pipes 4.5.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 4.5.2
>
>
> task to update to latest parent



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (SLING-11551) switch to parent 49

2022-08-21 Thread Nicolas Peltier (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-11551:

Fix Version/s: pipes 4.5.2

> switch to parent 49
> ---
>
> Key: SLING-11551
> URL: https://issues.apache.org/jira/browse/SLING-11551
> Project: Sling
>  Issue Type: Task
>  Components: pipes
>Affects Versions: pipes 4.5.0
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: pipes 4.5.2
>
>
> task to update to latest parent



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: [VOTE] Release Apache Sling API version 2.27.0, JCR Jackrabbit User Manager version 2.2.26

2022-08-21 Thread Konrad Windszus
+1

Konrad

> On 20. Aug 2022, at 22:32, Eric Norman  wrote:
> 
> Hi,
> 
> We solved 2 issues in the API release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12352198
> 
> We solved 1 issues in the JCR Jackrabbit User Manager release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12352200
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2669/
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2669 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.



Re: [VOTE] Release Apache Sling API version 2.27.0, JCR Jackrabbit User Manager version 2.2.26

2022-08-21 Thread Nicolas Peltier
+1

Le sam. 20 août 2022 à 22:33, Eric Norman  a écrit :

> Hi,
>
> We solved 2 issues in the API release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12352198
>
> We solved 1 issues in the JCR Jackrabbit User Manager release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12352200
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2669/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2669 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>


Re: [VOTE] Release Apache Sling Pipes 4.5.0

2022-08-21 Thread Nicolas Peltier
Thanks! will promote the release & copy the artifacts

(parent update request saved in
https://issues.apache.org/jira/browse/SLING-11551)

Le sam. 20 août 2022 à 12:40, Konrad Windszus  a écrit :

> +1
>
> (Although an update to the latest parent would be nice)
>
> Konrad
>
> > On 20. Aug 2022, at 07:58, Nicolas Peltier  wrote:
> >
> > Gentle bump for a third vote
> >
> > Le jeu. 18 août 2022 à 14:03, Nicolas Peltier  a
> > écrit :
> >
> >> +1 :)
> >>
> >> Le mer. 17 août 2022 à 14:01, Stefan Seifert
> >>  a écrit :
> >>
> >>> +1
> >>>
> >>> stefan
> >>>
> >>
>
>


[jira] [Created] (SLING-11551) switch to parent 49

2022-08-21 Thread Nicolas Peltier (Jira)
Nicolas Peltier created SLING-11551:
---

 Summary: switch to parent 49
 Key: SLING-11551
 URL: https://issues.apache.org/jira/browse/SLING-11551
 Project: Sling
  Issue Type: Task
  Components: pipes
Affects Versions: pipes 4.5.0
Reporter: Nicolas Peltier


task to update to latest parent



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (SLING-11519) Generate adapter metadata json for adaptations natively supported by FileResource

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-11519.
-
Resolution: Fixed

Fixed in 
https://github.com/apache/sling-org-apache-sling-fsresource/commit/20a21bb037bd0db84ebaf459d0ae2eab9169b02c.

> Generate adapter metadata json for adaptations natively supported by 
> FileResource
> -
>
> Key: SLING-11519
> URL: https://issues.apache.org/jira/browse/SLING-11519
> Project: Sling
>  Issue Type: Bug
>Affects Versions: File System Resource Provider 2.2.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: File System Resource Provider 2.2.2
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently the Felix Web Console plugin at {{/system/console/adapters}} 
> doesn't expose the adaptation from {{FileResource}} to {{File}} and {{URL}} 
> as the adapter JSON metadata is not included in the bundle although the 
> annotations are set in 
> https://github.com/apache/sling-org-apache-sling-fsresource/blob/48ea87e1420dbae87874c5f7a147e12483f9ae9f/src/main/java/org/apache/sling/fsprovider/internal/mapper/FileResource.java#L60.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [sling-org-apache-sling-fsresource] sonarcloud[bot] commented on pull request #1: SLING-11519 Include adapter metadata in the resulting bundle

2022-08-21 Thread GitBox


sonarcloud[bot] commented on PR #1:
URL: 
https://github.com/apache/sling-org-apache-sling-fsresource/pull/1#issuecomment-1221527360

   Kudos, SonarCloud Quality Gate passed!  [![Quality Gate 
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
 'Quality Gate 
passed')](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-fsresource=1)
   
   
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png
 
'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=1=false=BUG)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=1=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=1=false=BUG)
  
   
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png
 
'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=1=false=VULNERABILITY)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=1=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=1=false=VULNERABILITY)
  
   [![Security 
Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png
 'Security 
Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-fsresource=1=false=SECURITY_HOTSPOT)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-fsresource=1=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-fsresource=1=false=SECURITY_HOTSPOT)
  
   [![Code 
Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png
 'Code 
Smell')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=1=false=CODE_SMELL)
 
[![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png
 
'A')](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=1=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-fsresource=1=false=CODE_SMELL)
   
   [![No Coverage 
information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png
 'No Coverage 
information')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-fsresource=1=coverage=list)
 No Coverage information  
   
[![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png
 
'0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-fsresource=1=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-fsresource=1=new_duplicated_lines_density=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [sling-org-apache-sling-fsresource] kwin merged pull request #1: SLING-11519 Include adapter metadata in the resulting bundle

2022-08-21 Thread GitBox


kwin merged PR #1:
URL: https://github.com/apache/sling-org-apache-sling-fsresource/pull/1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (SLING-11537) Restrict "mountByFS" parameter to files outside the Maven repository

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-11537.
---

> Restrict "mountByFS" parameter to files outside the Maven repository
> 
>
> Key: SLING-11537
> URL: https://issues.apache.org/jira/browse/SLING-11537
> Project: Sling
>  Issue Type: Bug
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 3.0.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently the {{mountByFS}} parameter is supported by both goals {{install}} 
> and {{install-file}}. The latter also allows to install bundles from a Maven 
> repository (after resolving it) but configuring a Filesystem Resource 
> Provider for that location is never useful, as the local Maven repository 
> path should not be abused for maintaining Sling Initial Content directly on 
> the file system.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-11523) Replace scannotation and asm by classgraph

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-11523.
---

> Replace scannotation and asm by classgraph
> --
>
> Key: SLING-11523
> URL: https://issues.apache.org/jira/browse/SLING-11523
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 3.0.2
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently for goal {{generate-adapter-metadata}} the outdated [Scannotation 
> Library|http://scannotation.sourceforge.net/] is used which received its last 
> update in 2013. In addition also inspecting the class files with an 
> additional library (like ASM) is necessary to get the actual field values.
> Instead we should use https://github.com/classgraph/classgraph to scan for 
> annotations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-11532) Remove old relocation artifact maven-sling-plugin

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-11532.
---

> Remove old relocation artifact maven-sling-plugin
> -
>
> Key: SLING-11532
> URL: https://issues.apache.org/jira/browse/SLING-11532
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Sling Maven Plugin 2.4.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 3.0.2
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In SLING-8204 a new artifact has been introduced with artifactId 
> {{sling-maven-plugin}} and the old artifactId {{maven-sling-plugin}} just 
> contains the relocation information.
> According to 
> https://maven.apache.org/guides/mini/guide-relocation.html#releasing-the-next-version
>  it is not necessary to always release both the relocated and the old 
> artifactId together. Just one version with the relocation information with 
> the old id is sufficient.
> bq. For the release after that, you only need to publish a Maven POM with a 
> groupId of org.bar, since users of the previous version have been informed of 
> the changed groupId.
> We already have two versions with relocation info at 
> https://search.maven.org/artifact/org.apache.sling/maven-sling-plugin/2.4.2/pom
>  and 
> https://search.maven.org/artifact/org.apache.sling/maven-sling-plugin/2.4.0/pom.
>  
> I propose to flatten the multimodule repository at 
> https://github.com/apache/sling-maven-plugin again to a single module one and 
> no longer release anything with old artifactId {{maven-sling-plugin}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-10022) generate-adapter-metadata mojo always emits to "${project.build.directory}/adapter-plugin-generated"

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-10022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-10022.
---

> generate-adapter-metadata mojo always emits to 
> "${project.build.directory}/adapter-plugin-generated"
> 
>
> Key: SLING-10022
> URL: https://issues.apache.org/jira/browse/SLING-10022
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Affects Versions: Sling Maven Plugin 2.4.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 3.0.2
>
>
> The {{SLING-INF/adapters.json}} is always generated in the target folder 
> {{${project.build.directory}/adapter-plugin-generated}} 
> (https://github.com/apache/sling-maven-plugin/blob/ee08451c880cc8cdc554b4cf8964c35792d75326/sling-maven-plugin/src/main/java/org/apache/sling/maven/bundlesupport/GenerateAdapterMetadataMojo.java#L91).
>  From there it is not automatically being picked up for ending up in the 
> generated JAR. 
> That folder was only considered by the maven-bundle-plugin but is not by the 
> maven-jar-plugin.
> The default output directory should instead be 
> {{${project.build.outputDirectory}}, and the parameter should not be 
> read-only (to allow to overwrite).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-11535) Deprecate "deploy" and "deploy-file" goals

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-11535.
---

> Deprecate "deploy" and "deploy-file" goals
> --
>
> Key: SLING-11535
> URL: https://issues.apache.org/jira/browse/SLING-11535
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 3.0.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The goals related to OSGi Bundle Repositories (OBRs) should be deprecated as 
> there is the better maintained alternative nowadays with
> https://felix.apache.org/documentation/_attachments/components/bundle-plugin/deploy-file-mojo.html
>  and 
> https://felix.apache.org/documentation/_attachments/components/bundle-plugin/deploy-mojo.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-9654) Sling Maven Plugin: Include GitHub ribbon in site

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-9654.
--

> Sling Maven Plugin: Include GitHub ribbon in site
> -
>
> Key: SLING-9654
> URL: https://issues.apache.org/jira/browse/SLING-9654
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Minor
> Fix For: Sling Maven Plugin 3.0.2
>
>
> We should include a GitHub ribbon in the header (like outlined 
> https://maven.apache.org/skins/maven-fluido-skin/#GitHub_ribbons) to ease 
> contributing PRs. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-11524) install goal: Use always the artifact file from the underlying Maven project

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-11524.
---

> install goal: Use always the artifact file from the underlying Maven project
> 
>
> Key: SLING-11524
> URL: https://issues.apache.org/jira/browse/SLING-11524
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 3.0.2
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Currently goals "install-file" and "install" behave almost the same, the only 
> difference is that the latter requires a project, but still picks up the 
> bundle to install from the filesystem with a predefined path instead of 
> leveraging the project's artifact(s) directly (irrespective of their 
> path/name).
> Instead of relying on a certain path in the filesystem one should directly 
> leverage {{MavenProject.getArtifact()}} and 
> {{MavenProject.getAttachedArtifacts()}} (in that order) until a bundle file 
> is found and remove the parameter {{bundleFileName}} altogether.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-11536) Remove wrong LifecycleMapping metadata

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-11536.
---

> Remove wrong LifecycleMapping metadata
> --
>
> Key: SLING-11536
> URL: https://issues.apache.org/jira/browse/SLING-11536
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 3.0.2
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The sling-maven-plugin contains Plexus component metadata for a 
> {{org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping}} with role 
> {{assembly}} 
> (https://github.com/apache/sling-maven-plugin/blob/e5da7210376d1951c2fa4ce76f69cb7632cee36f/sling-maven-plugin/src/main/resources/META-INF/plexus/components.xml#L20).
> Although this only is active if {{sling-maven-plugin}} is used with 
> {{true}} it is wrong in any case, as it defines a 
> mapping for packaging "assembly" and also only binds Maven default plugin 
> goals.
> As the {{sling-maven-plugin}} doesn't do any packaging nor defines a custom 
> packaging, providing a custom {{DefaultLifecycleMapping}} is not necessary 
> and in the worst case might have negative side-effects.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-11543) sling-maven-plugin: Install goal fails if executed alone

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-11543.
---

> sling-maven-plugin: Install goal fails if executed alone
> 
>
> Key: SLING-11543
> URL: https://issues.apache.org/jira/browse/SLING-11543
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Reporter: Stefan Seifert
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 3.0.2
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> doing a bundle install using {{mvn clean install sling:install}} works fine, 
> however calling {{mvn sling:install}} directly fails with an NPE for me:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.sling:sling-maven-plugin:3.0.1-SNAPSHOT:install (default-cli) on 
> project de.provision.website.adaptto.core: Execution default-cli of goal 
> org.apache.sling:sling-maven-plugin:3.0.1-SNAPSHOT:install failed.: 
> NullPointerException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.sling:sling-maven-plugin:3.0.1-SNAPSHOT:install (default-cli) 
> on project de.provision.website.adaptto.core: Execution default-cli of goal 
> org.apache.sling:sling-maven-plugin:3.0.1-SNAPSHOT:install failed.
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>     at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:566)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-cli of goal 
> org.apache.sling:sling-maven-plugin:3.0.1-SNAPSHOT:install failed.
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:148)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> 

[jira] [Closed] (SLING-11522) Update parent, plugins and dependencies

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-11522.
---

> Update parent, plugins and dependencies
> ---
>
> Key: SLING-11522
> URL: https://issues.apache.org/jira/browse/SLING-11522
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Sling Maven Plugin 2.4.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 3.0.2
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> The parent should be updated to latest version (49), the dependencies and 
> plugins as well.
> In addition the minimum Maven version should be lifted to 3.3.1 (was 3.0.4) 
> in order to leverage the new Maven Resolver API.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-11542) sling-maven-plugin: GenerateAdapterMetadataMojoTest fails under Windows

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-11542.
---

> sling-maven-plugin: GenerateAdapterMetadataMojoTest fails under Windows
> ---
>
> Key: SLING-11542
> URL: https://issues.apache.org/jira/browse/SLING-11542
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Trivial
> Fix For: Sling Maven Plugin 3.0.2
>
>
> with release 3.0.0, this unit test fails on windows:
> {noformat}
> [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.856 
> s <<< FAILURE! - in 
> org.apache.sling.maven.bundlesupport.GenerateAdapterMetadataMojoTest
> [ERROR] 
> org.apache.sling.maven.bundlesupport.GenerateAdapterMetadataMojoTest.testExecute
>   Time elapsed: 1.856 s  <<< ERROR!
> java.nio.file.InvalidPathException: Illegal char <:> at index 2: 
> /D:/Develop/OpenSource/sling-git/sling-maven-plugin/target/test-classes/
> at 
> java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
> at 
> java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
> ...
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (SLING-11534) uninstall goal: Allow to parameterize Bundle Symbolic Name/Resource Name directly

2022-08-21 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-11534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus closed SLING-11534.
---

> uninstall goal: Allow to parameterize Bundle Symbolic Name/Resource Name 
> directly
> -
>
> Key: SLING-11534
> URL: https://issues.apache.org/jira/browse/SLING-11534
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 3.0.2
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Currently the uninstall goal requires the parameter {{bundleFileName}} which 
> is set to a default path which often reflects the artifact file name bound by 
> the current project.
> In order to ease uninstalling arbitrary packages, it should be allowed to 
> uninstall bundles by just giving their Bundle Symbolic Name (BSN) / file name.
> The file name is used for all deployment methods except for Web Console (to 
> remove the same named resource from the repository), otherwise the BSN is 
> used.
> The old way of determining the BSN from a given file should be used as 
> fallback.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[RESULT] [VOTE] Release Apache Sling Maven Plugin version 3.0.2

2022-08-21 Thread Konrad Windszus
Hi, 
The vote has passed with the following result : 

+1 (binding): Nicolas, Stefan and myself

 I will copy this release to the Sling dist directory and promote the artifacts 
to the central Maven repository.
Thanks for voting,
Konrad

[jira] [Created] (SLING-11550) check_staged_release.sh: Check that public key is contained in https://downloads.apache.org/sling/KEYS

2022-08-21 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-11550:
---

 Summary: check_staged_release.sh: Check that public key is 
contained in https://downloads.apache.org/sling/KEYS
 Key: SLING-11550
 URL: https://issues.apache.org/jira/browse/SLING-11550
 Project: Sling
  Issue Type: Improvement
  Components: Tooling
Reporter: Konrad Windszus


The script at {{check_staged_release.sh}} should be improved so that it 
validates that the public key used for signing a release is part of 
[https://downloads.apache.org/sling/KEYS.]

It happened several times in the past that the key was not added there and 
checking this manually is very error-prone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)