[jira] Resolved: (SLING-1784) Discover Sling in 15 minutes: launchpad/webapp missing

2010-09-20 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-1784. -- Assignee: Felix Meschberger Resolution: Fixed Thanks for reporting. I have fixed

Launchpad port consistency

2010-09-20 Thread Felix Meschberger
Hi all, We currently have an inconsistency in the setup of the jetty:run configuration in the the launchpad/builder module and the default port used by the Sling standalone application. The jetty plugin is configured to use port by default, while the standalone application by default uses

Re: Launchpad port consistency

2010-09-20 Thread Ian Boston
On 20 Sep 2010, at 16:21, Felix Meschberger wrote: Hi all, We currently have an inconsistency in the setup of the jetty:run configuration in the the launchpad/builder module and the default port used by the Sling standalone application. The jetty plugin is configured to use port by

[jira] Created: (SLING-1785) Support optional request parameters after login redirect

2010-09-20 Thread Felix Meschberger (JIRA)
Support optional request parameters after login redirect Key: SLING-1785 URL: https://issues.apache.org/jira/browse/SLING-1785 Project: Sling Issue Type: Improvement

[jira] Commented: (SLING-1785) Support optional request parameters after login redirect

2010-09-20 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912397#action_12912397 ] Felix Meschberger commented on SLING-1785: -- Using the new redirect helper in the

[jira] Commented: (SLING-1785) Support optional request parameters after login redirect

2010-09-20 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912396#action_12912396 ] Felix Meschberger commented on SLING-1785: -- In Rev. 998828 implemented a helper

Re: Launchpad port consistency

2010-09-20 Thread Felix Meschberger
Hi, Am 20.09.2010 10:29, schrieb Ian Boston: On 20 Sep 2010, at 16:21, Felix Meschberger wrote: Hi all, We currently have an inconsistency in the setup of the jetty:run configuration in the the launchpad/builder module and the default port used by the Sling standalone application. The

Hudson build is back to stable : sling-trunk-1.5 » Apache Sling OSGi Installer Integration Tests #895

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.osgi.installer.it/895/

[jira] Resolved: (SLING-1785) Support optional request parameters after login redirect

2010-09-20 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-1785. -- Resolution: Fixed In Rev. 998847 adapted the OpenID authentication handler to use the

Hudson build is back to stable : sling-trunk-1.6 » Apache Sling OSGi Installer Integration Tests #583

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.osgi.installer.it/583/

Hudson build is back to stable : sling-trunk-1.6 #583

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.6/583/changes

Re: Launchpad port consistency

2010-09-20 Thread Bertrand Delacretaz
On Mon, Sep 20, 2010 at 11:01 AM, Felix Meschberger fmesc...@gmail.com wrote: ...IIUIC the launchpad/testing module uses a build-helper plugin to use a random port for integration testing That's correct. Apart from that, I agree with Felix about having a consistent port number, don't care

Hudson build is back to stable : sling-trunk-1.5 #896

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.5/896/changes

Re: Authentication Issue

2010-09-20 Thread Felix Meschberger
Hi, Am 17.09.2010 23:48, schrieb Ian Boston: On 18 Sep 2010, at 00:59, Felix Meschberger wrote: Hi all, I am trying to tackle issues SLING-1400 [1] and SLING-1745 [2]. The first issue is about WebDAV clients connecting to Sling on root with an OPTIONS request and not being happy with a

Build failed in Hudson: sling-contrib-1.5 » Apache Sling Launchpad Contrib Testing #596

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-contrib-1.5/org.apache.sling$org.apache.sling.launchpad.contrib-testing/596/ -- [...truncated 20 lines...] [INFO] Copying bundle from

Build failed in Hudson: sling-contrib-1.5 #596

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-contrib-1.5/596/ -- [...truncated 3444 lines...] [INFO] snapshot org.apache.sling:org.apache.sling.engine:2.1.1-SNAPSHOT: checking for updates from scala-tools.org [INFO] Copying bundle from

What's our test coverage on the authentication stuff?

2010-09-20 Thread Bertrand Delacretaz
Hi, I'm busy with non-Sling stuff at the moment, haven't been able to follow the details but I see lots of changes around authentication lately. Do people feel we have adequate integration test coverage of those things? I think the whole authentication process involves a number of services,

Re: What's our test coverage on the authentication stuff?

2010-09-20 Thread Felix Meschberger
Hi, No, test coverage is not the best possible Though I do rather thorough (but still) manual testing. Some tests can and should probably done in isolation while other tests can only be done on an integration basis Would be cool if you would find cycles to create some tests ;-)

[VOTE RESULT] Release Commons Testing 2.0.6, OSGi Installer 3.0.0, JCR Installer 3.0.0, and File Installer 1.0.0

2010-09-20 Thread Carsten Ziegeler
Hi, the vote to release Carsten Ziegeler wrote - OSGi Installer 3.0.0 - JCR Installer 3.0.0 - File Installer 1.0.0 has been cancelled. However, the vote to release Commons Testing 2.0.6 passed successfully with +1 votes from Carsten Ziegeler (*), Stefan Seifert, Justin Edelson(*), Bertrand

Re: Fwd: Builds that have been failing for a while

2010-09-20 Thread Felix Meschberger
Hi, Am 20.09.2010 14:26, schrieb Justin Edelson: Looks like the sling-contrib build is going to be disabled soon... Thanks for bringing this up... I once looked after why those tests are failing, but failed to follow-up on. Anyway, here is the reason: [INFO] Checking legal files in:

[jira] Created: (SLING-1786) Integration tests for authentication

2010-09-20 Thread Bertrand Delacretaz (JIRA)
Integration tests for authentication Key: SLING-1786 URL: https://issues.apache.org/jira/browse/SLING-1786 Project: Sling Issue Type: Test Components: Authentication Reporter:

Re: What's our test coverage on the authentication stuff?

2010-09-20 Thread Bertrand Delacretaz
On Mon, Sep 20, 2010 at 3:24 PM, Felix Meschberger fmesc...@gmail.com wrote: ...No, test coverage is not the best possible Though I do rather thorough (but still) manual testing. Some tests can and should probably done in isolation while other tests can only be done on an integration

Re: What's our test coverage on the authentication stuff?

2010-09-20 Thread Felix Meschberger
Hi, Am 20.09.2010 15:36, schrieb Bertrand Delacretaz: On Mon, Sep 20, 2010 at 3:24 PM, Felix Meschberger fmesc...@gmail.com wrote: ...No, test coverage is not the best possible Though I do rather thorough (but still) manual testing. Some tests can and should probably done in isolation

[jira] Created: (SLING-1787) Unify symbolic names and check package names

2010-09-20 Thread Carsten Ziegeler (JIRA)
Unify symbolic names and check package names Key: SLING-1787 URL: https://issues.apache.org/jira/browse/SLING-1787 Project: Sling Issue Type: Task Components: Installer Affects

[jira] Commented: (SLING-1787) Unify symbolic names and check package names

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912469#action_12912469 ] Carsten Ziegeler commented on SLING-1787: - It makes more sense to move the api

[jira] Commented: (SLING-1745) Do not redirect AJAX requests with expired cookie to login form

2010-09-20 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912471#action_12912471 ] Felix Meschberger commented on SLING-1745: -- Proposed patch here:

Re: Launchpad port consistency

2010-09-20 Thread Carsten Ziegeler
Bertrand Delacretaz wrote On Mon, Sep 20, 2010 at 11:01 AM, Felix Meschberger fmesc...@gmail.com wrote: ...IIUIC the launchpad/testing module uses a build-helper plugin to use a random port for integration testing That's correct. Apart from that, I agree with Felix about having a

[jira] Commented: (SLING-1400) OPTIONS request on / returns login form if Allow Anonymous Access set to false

2010-09-20 Thread Felix Meschberger (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912472#action_12912472 ] Felix Meschberger commented on SLING-1400: -- Proposed patch here:

Re: Authentication Issue

2010-09-20 Thread Felix Meschberger
Hi all, I have uploaded a proposed patch including support for both issues to http://codereview.appspot.com/2192046/. Please comment. Thanks. Regards Felix Am 17.09.2010 16:59, schrieb Felix Meschberger: Hi all, I am trying to tackle issues SLING-1400 [1] and SLING-1745 [2]. The first

Re: What's our test coverage on the authentication stuff?

2010-09-20 Thread Justin Edelson
FWIW, the coverage is better than I thought - http://people.apache.org/~justin/coverage/ I'm trying to get back to integrating emma fully into our build. But before I get too far, does anyone know if we have access to a Clover license? Clover, IMHO, produces nicer looking reports. Justin On

[jira] Created: (SLING-1788) Fail early if loaded job should not be processed on the current app node

2010-09-20 Thread Carsten Ziegeler (JIRA)
Fail early if loaded job should not be processed on the current app node Key: SLING-1788 URL: https://issues.apache.org/jira/browse/SLING-1788 Project: Sling Issue

[jira] Resolved: (SLING-1788) Fail early if loaded job should not be processed on the current app node

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-1788. - Resolution: Fixed Changed in revision 998952 Fail early if loaded job should not be

[jira] Closed: (SLING-1166) Provide helper class for simpler unit testing of sling code

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-1166. --- Provide helper class for simpler unit testing of sling code

[jira] Closed: (SLING-1407) add a method to SlingIntegrationTestClient which accept multiple parameters with the same name

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-1407. --- add a method to SlingIntegrationTestClient which accept multiple parameters with the same

[jira] Closed: (SLING-1406) Upgrade to JCR 2.0/Jackrabbit 2.0

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-1406. --- Upgrade to JCR 2.0/Jackrabbit 2.0 - Key:

[jira] Closed: (SLING-1488) Move EventHelper from JCRInstall to Commons Testing

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-1488. --- Move EventHelper from JCRInstall to Commons Testing

[jira] Closed: (SLING-1371) Patch with added functionality for the mocks in o.a.s.commons.testing

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-1371. --- Patch with added functionality for the mocks in o.a.s.commons.testing

[jira] Closed: (SLING-1659) log each integration test case in a separate file

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-1659. --- log each integration test case in a separate file

Re: Authentication Issue

2010-09-20 Thread Justin Edelson
Two comments: 1) As mentioned, I think we should use the Accepts header instead of specifically checking for the OPTIONS method and return a 401 response unless the Accepts header is included in the request and *explicitly* contains text/html. Since I don't have the time right now to research

[jira] Commented: (SLING-1787) Unify symbolic names and check package names

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912559#action_12912559 ] Carsten Ziegeler commented on SLING-1787: - First step: Changed the directory layout

[jira] Commented: (SLING-1787) Unify symbolic names and check package names

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912566#action_12912566 ] Carsten Ziegeler commented on SLING-1787: - Renamed symbolic name of core to

[jira] Commented: (SLING-1787) Unify symbolic names and check package names

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912571#action_12912571 ] Carsten Ziegeler commented on SLING-1787: - Renamed the two providers to

[jira] Commented: (SLING-1787) Unify symbolic names and check package names

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912578#action_12912578 ] Carsten Ziegeler commented on SLING-1787: - Moved the packages in the IT module

Build failed in Hudson: sling-trunk-1.5 » Apache Sling JCR WebConsole Bundle #897

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.webconsole/897/ -- [INFO] [INFO] Building Apache Sling JCR WebConsole Bundle [INFO]

Build failed in Hudson: sling-trunk-1.5 #897

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.5/897/changes Changes: [cziegeler] SLING-1787 : Unify symbolic names and check package names [cziegeler] SLING-1787 : Unify symbolic names and check package names [cziegeler] SLING-1787 : Unify symbolic names and check package names

[jira] Resolved: (SLING-1787) Unify symbolic names and check package names

2010-09-20 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-1787. - Resolution: Fixed Test cases are running again - everything seems fine - setting to

Re: Authentication Issue

2010-09-20 Thread Felix Meschberger
Hi, Am 20.09.2010 17:16, schrieb Justin Edelson: Two comments: 1) As mentioned, I think we should use the Accepts header instead of specifically checking for the OPTIONS method and return a 401 response unless the Accepts header is included in the request and *explicitly* contains

Welcome Mike Mueller as a new member of the Sling PMC

2010-09-20 Thread Felix Meschberger
Hi all, It is with utmost pleasure that I announce that the Apache Sling PMC recently voted to invite Mike Müller as a new PMC member and he accepted. Mike has been doing and is continuing to do a great job on all fronts of Sling, most notably documentation and mentoring our new committer

Build failed in Hudson: sling-contrib-1.5 » Apache Sling Launchpad Contrib Testing #597

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-contrib-1.5/org.apache.sling$org.apache.sling.launchpad.contrib-testing/597/changes Changes: [cziegeler] Use released version of commons testing. -- [INFO]

Build failed in Hudson: sling-contrib-1.5 #597

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-contrib-1.5/597/changes Changes: [cziegeler] Use spaces [cziegeler] Use released version of commons testing. -- [...truncated 3396 lines...] [INFO] Executing tasks [echo] ** WARNING

Re: Fwd: Builds that have been failing for a while

2010-09-20 Thread Carsten Ziegeler
Felix Meschberger wrote Hi, Am 20.09.2010 14:26, schrieb Justin Edelson: Looks like the sling-contrib build is going to be disabled soon... Thanks for bringing this up... I once looked after why those tests are failing, but failed to follow-up on. Anyway, here is the reason:

Re: What's our test coverage on the authentication stuff?

2010-09-20 Thread Felix Meschberger
Hi, Yes, we do have a 2.6.x license available for committers only (I would assume) working on ASF projects (packages below org.apache) and obviously also supporting IntelliJ and Eclipse. Regards Felix Am 20.09.2010 16:43, schrieb Justin Edelson: FWIW, the coverage is better than I thought -

Re: Authentication Issue

2010-09-20 Thread Justin Edelson
On 9/20/10 1:56 PM, Felix Meschberger wrote: Hi, Am 20.09.2010 17:16, schrieb Justin Edelson: Two comments: 1) As mentioned, I think we should use the Accepts header instead of specifically checking for the OPTIONS method and return a 401 response unless the Accepts header is included in

Hudson build is back to normal : sling-trunk- 1.5 » Apache Sling JCR WebConsole Bundle #898

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.jcr.webconsole/898/

Hudson build is back to normal : sling-trunk-1.5 #898

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-trunk-1.5/898/changes

[jira] Commented: (SLING-1745) Do not redirect AJAX requests with expired cookie to login form

2010-09-20 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/SLING-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12912723#action_12912723 ] Ian Boston commented on SLING-1745: --- LGTM. Ian Do not redirect AJAX requests with

Re: Launchpad port consistency

2010-09-20 Thread Ian Boston
On 21 Sep 2010, at 00:16, Carsten Ziegeler wrote: Bertrand Delacretaz wrote On Mon, Sep 20, 2010 at 11:01 AM, Felix Meschberger fmesc...@gmail.com wrote: ...IIUIC the launchpad/testing module uses a build-helper plugin to use a random port for integration testing That's correct.

Re: Authentication Issue

2010-09-20 Thread Ian Boston
On 21 Sep 2010, at 00:19, Felix Meschberger wrote: Hi all, I have uploaded a proposed patch including support for both issues to http://codereview.appspot.com/2192046/. Please comment. Thanks. The patch addresses all my earlier concerns with Ajax calls, thank you. I can see that Justin

Build failed in Hudson: sling-contrib-1.5 #598

2010-09-20 Thread Apache Hudson Server
See https://hudson.apache.org/hudson/job/sling-contrib-1.5/598/changes Changes: [cziegeler] Adding missing notice and license files -- Failed to access build log hudson.util.IOException2: remote file operation failed:

Re: Welcome Mike Mueller as a new member of the Sling PMC

2010-09-20 Thread Ian Boston
On 21 Sep 2010, at 04:07, Felix Meschberger wrote: Hi all, It is with utmost pleasure that I announce that the Apache Sling PMC recently voted to invite Mike Müller as a new PMC member and he accepted. Mike has been doing and is continuing to do a great job on all fronts of Sling, most

RE: Welcome Mike Mueller as a new member of the Sling PMC

2010-09-20 Thread Mike Müller
Hi all Thank you very much for the confidence you have in me. best regards mike Hi all, It is with utmost pleasure that I announce that the Apache Sling PMC recently voted to invite Mike Müller as a new PMC member and he accepted. Mike has been doing and is continuing to do a great