Re: Trunk Build Failure

I knew I saw that before and the issue is the Timezone. California does already have Daylight Savings Time and I would guess that’s the issue here. This line is causing the failure: Assert.assertEquals(expected.getTimeZone().getRawOffset(), actual.getTimeZone().getRawOffset()); inside

Re: Trunk Build Failure

On Tue, Mar 15, 2016 at 7:29 PM, Andreas Schaefer Sr. wrote: > Got the same when checked out the code from SVN:... Ok, I have no idea what's going on unfortunately, and the build also worked on Jenkins earlier today at

Re: Trunk Build Failure

Got the same when checked out the code from SVN: Andreass-MacBook-Pro:sling-trunk schaefa$ svn info Path: . Working Copy Root Path: /Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling.Development/apache.svn/sling-trunk URL: https://svn.apache.org/repos/asf/sling/trunk

Re: Trunk Build Failure

On Tue, Mar 15, 2016 at 7:11 PM, Andreas Schaefer Sr. wrote: > ...Do I need to work with SVN?.. That shouldn't make a difference, Git catches up quite quickly AFAIK. Anyway, I have posted the md5 digests the code that I have, at https://paste.apache.org/nlui - if you think you

Re: Trunk Build Failure

I use git and this is the latest: git-svn-id: https://svn.apache.org/repos/asf/sling/trunk@1735140 Do I need to work with SVN? - Andy > On Mar 15, 2016, at 10:44 AM, Bertrand Delacretaz > wrote: > > Hi, > > On

[jira] [Commented] (SLING-5603) Upgrade Commons Lang to 3.4

[ https://issues.apache.org/jira/browse/SLING-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195803#comment-15195803 ] Konrad Windszus commented on SLING-5603: Can you clarify which bundles are affected? > Upgrade

[jira] [Commented] (SLING-5603) Upgrade Commons Lang to 3.4

[ https://issues.apache.org/jira/browse/SLING-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195801#comment-15195801 ] Oliver Lietz commented on SLING-5603: - Yes, see the found versions above. > Upgrade Commons Lang to

Re: Trunk Build Failure

Hi, On Tue, Mar 15, 2016 at 6:27 PM, Andreas Schaefer Sr. wrote: > Failed tests: > JcrModifiablePropertyMapTest>JcrPropertyMapTest.testJCRType:... That test passes for me at revision 1735149, with both jdk 1.7 and 1.8. -Bertrand

[jira] [Commented] (SLING-5603) Upgrade Commons Lang to 3.4

[ https://issues.apache.org/jira/browse/SLING-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195763#comment-15195763 ] Konrad Windszus commented on SLING-5603: Was Commons-Lang3 in use except for the validator bundle

[jira] [Commented] (SLING-5609) Do not embed dependency commons-lang3

[ https://issues.apache.org/jira/browse/SLING-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195750#comment-15195750 ] Konrad Windszus commented on SLING-5609: Ah sorry, forgot that commons-lang3 can be installed in

Trunk Build Failure

The current trunk of sling fails in the JCR Resource Resolver with these tests: Failed tests: JcrModifiablePropertyMapTest>JcrPropertyMapTest.testJCRType:76->JcrPropertyMapTest.testValue:258 expected:<-2880> but was:<-2520> JcrPropertyMapTest.testJCRType:76->testValue:258

[jira] [Commented] (SLING-5609) Do not embed dependency commons-lang3

[ https://issues.apache.org/jira/browse/SLING-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195708#comment-15195708 ] Oliver Lietz commented on SLING-5609: - It's not the case.

[jira] [Commented] (SLING-5611) Remove the obsolete testing/samples/integration-tests module

[ https://issues.apache.org/jira/browse/SLING-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195685#comment-15195685 ] Bertrand Delacretaz commented on SLING-5611: Also removed references to those bundles in our

Re: [LAZY] Ok to remove the testing/samples/integration-tests and related modules?

On Fri, Mar 11, 2016 at 10:46 AM, Bertrand Delacretaz wrote: > I'd like to remove the following modules from our codebase... I've done this now, details at https://issues.apache.org/jira/browse/SLING-5611 -Bertrand

[jira] [Commented] (SLING-5609) Do not embed dependency commons-lang3

[ https://issues.apache.org/jira/browse/SLING-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195680#comment-15195680 ] Oliver Lietz commented on SLING-5609: - We were affected by security issues in dependencies in the past

[jira] [Resolved] (SLING-5611) Remove the obsolete testing/samples/integration-tests module

[ https://issues.apache.org/jira/browse/SLING-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-5611. Resolution: Fixed Removed the 3 above modules in rev 1735140 > Remove the obsolete

[jira] [Created] (SLING-5611) Remove the obsolete testing/samples/integration-tests module

Bertrand Delacretaz created SLING-5611: -- Summary: Remove the obsolete testing/samples/integration-tests module Key: SLING-5611 URL: https://issues.apache.org/jira/browse/SLING-5611 Project:

[jira] [Updated] (SLING-5577) Distribution package implementation should be independent of serialization

[ https://issues.apache.org/jira/browse/SLING-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated SLING-5577: --- Attachment: SLING-5577.1.patch new patch, with this one, for example, the code for

[jira] [Commented] (SLING-5609) Do not embed dependency commons-lang3

[ https://issues.apache.org/jira/browse/SLING-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195453#comment-15195453 ] Bertrand Delacretaz commented on SLING-5609: bq. That makes Sling Validation incompatible with

[jira] [Commented] (SLING-5609) Do not embed dependency commons-lang3

[ https://issues.apache.org/jira/browse/SLING-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195450#comment-15195450 ] Konrad Windszus commented on SLING-5609: That makes Sling Validation incompatible with older

[jira] [Resolved] (SLING-5610) ResourceUtil.getValueMap() contains a wrong @Nonnull annotation

[ https://issues.apache.org/jira/browse/SLING-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-5610. Resolution: Fixed Fix Version/s: API 2.12.0 Fixed with

[jira] [Commented] (SLING-5609) Do not embed dependency commons-lang3

[ https://issues.apache.org/jira/browse/SLING-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195438#comment-15195438 ] Bertrand Delacretaz commented on SLING-5609: Could you add a bit more detail, why this is done

[jira] [Commented] (SLING-5603) Upgrade Commons Lang to 3.4

[ https://issues.apache.org/jira/browse/SLING-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195432#comment-15195432 ] Oliver Lietz commented on SLING-5603: - Validation: [r1735089|https://svn.apache.org/r1735089] >

[jira] [Assigned] (SLING-5610) ResourceUtil.getValueMap() contains a wrong @Nonnull annotation

[ https://issues.apache.org/jira/browse/SLING-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-5610: -- Assignee: Konrad Windszus > ResourceUtil.getValueMap() contains a wrong @Nonnull

[jira] [Resolved] (SLING-5609) Do not embed dependency commons-lang3

[ https://issues.apache.org/jira/browse/SLING-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-5609. - Resolution: Done [r1735089|https://svn.apache.org/r1735089] > Do not embed dependency

[jira] [Updated] (SLING-5603) Upgrade Commons Lang to 3.4

[ https://issues.apache.org/jira/browse/SLING-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz updated SLING-5603: Fix Version/s: Validation 1.0.0 > Upgrade Commons Lang to 3.4 > --- > >

[jira] [Created] (SLING-5610) ResourceUtil.getValueMap() contains a wrong @Nonnull annotation

Dominik Lienemann created SLING-5610: Summary: ResourceUtil.getValueMap() contains a wrong @Nonnull annotation Key: SLING-5610 URL: https://issues.apache.org/jira/browse/SLING-5610 Project:

[jira] [Created] (SLING-5609) Do not embed dependency commons-lang3

Oliver Lietz created SLING-5609: --- Summary: Do not embed dependency commons-lang3 Key: SLING-5609 URL: https://issues.apache.org/jira/browse/SLING-5609 Project: Sling Issue Type: Improvement

[jira] [Commented] (SLING-5602) The Discovery module does not work any more after a ResourceResolverFactory reactivation

[ https://issues.apache.org/jira/browse/SLING-5602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195410#comment-15195410 ] Carsten Ziegeler commented on SLING-5602: - [~egli] I think this is slightly different: it's rather

[jira] [Resolved] (SLING-5608) Manage version of JSR-305 dependency in Sling parent

[ https://issues.apache.org/jira/browse/SLING-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-5608. - Resolution: Done [r1735082|https://svn.apache.org/r1735082] > Manage version of JSR-305

[jira] [Created] (SLING-5608) Manage version of JSR-305 dependency in Sling parent

Oliver Lietz created SLING-5608: --- Summary: Manage version of JSR-305 dependency in Sling parent Key: SLING-5608 URL: https://issues.apache.org/jira/browse/SLING-5608 Project: Sling Issue Type:

[jira] [Resolved] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-5605. - Resolution: Fixed As discussed we should rather change the api than the implementation. A

[jira] [Updated] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-5605: Fix Version/s: API 2.12.0 > Wrong null annotations on ServletResolver interface >

[jira] [Reopened] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reopened SLING-5605: - Assignee: Carsten Ziegeler (was: Konrad Windszus) > Wrong null annotations on

[jira] [Resolved] (SLING-5607) SlingServletResolver.resolveServlet should never return null

[ https://issues.apache.org/jira/browse/SLING-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-5607. - Resolution: Invalid > SlingServletResolver.resolveServlet should never return null >

Re: Changing behaviour of ServletResolver.resolveServlet (SLING-5607)

Konrad Windszus wrote > >> On 15 Mar 2016, at 13:09, Carsten Ziegeler wrote: >> >> Hi, >> >> first of all sorry for the back and forth from my side :) >> >> Rethinking this, I think we should update the javadocs to the >> implementation. I think a good service should rather

Re: Changing behaviour of ServletResolver.resolveServlet (SLING-5607)

> On 15 Mar 2016, at 13:09, Carsten Ziegeler wrote: > > Hi, > > first of all sorry for the back and forth from my side :) > > Rethinking this, I think we should update the javadocs to the > implementation. I think a good service should rather return null instead > of

Re: Changing behaviour of ServletResolver.resolveServlet (SLING-5607)

Hi, first of all sorry for the back and forth from my side :) Rethinking this, I think we should update the javadocs to the implementation. I think a good service should rather return null instead of throwing a runtime exception - and as the code which is using the service is prepared for the

[jira] [Comment Edited] (SLING-5607) SlingServletResolver.resolveServlet should never return null

[ https://issues.apache.org/jira/browse/SLING-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195147#comment-15195147 ] Konrad Windszus edited comment on SLING-5607 at 3/15/16 12:06 PM: -- The

[jira] [Commented] (SLING-5607) SlingServletResolver.resolveServlet should never return null

[ https://issues.apache.org/jira/browse/SLING-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195147#comment-15195147 ] Konrad Windszus commented on SLING-5607: The exceptions are different though. Maybe it would be

[jira] [Commented] (SLING-5607) SlingServletResolver.resolveServlet should never return null

[ https://issues.apache.org/jira/browse/SLING-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195143#comment-15195143 ] Carsten Ziegeler commented on SLING-5607: - JSP Taglib throws an exception if servlet is null

[jira] [Updated] (SLING-5607) SlingServletResolver.resolveServlet should never return null

[ https://issues.apache.org/jira/browse/SLING-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-5607: --- Issue Type: Bug (was: Improvement) > SlingServletResolver.resolveServlet should never return

[jira] [Comment Edited] (SLING-5607) SlingServletResolver.resolveServlet should never return null

[ https://issues.apache.org/jira/browse/SLING-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195122#comment-15195122 ] Konrad Windszus edited comment on SLING-5607 at 3/15/16 11:43 AM: -- I

[jira] [Updated] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-5605: Fix Version/s: (was: API 2.12.0) > Wrong null annotations on ServletResolver interface

[jira] [Comment Edited] (SLING-5607) SlingServletResolver.resolveServlet should never return null

[ https://issues.apache.org/jira/browse/SLING-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195122#comment-15195122 ] Konrad Windszus edited comment on SLING-5607 at 3/15/16 11:29 AM: -- I

[jira] [Commented] (SLING-5607) SlingServletResolver.resolveServlet should never return null

[ https://issues.apache.org/jira/browse/SLING-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195122#comment-15195122 ] Konrad Windszus commented on SLING-5607: I found only within Sling

[jira] [Commented] (SLING-5607) SlingServletResolver.resolveServlet should never return null

[ https://issues.apache.org/jira/browse/SLING-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195116#comment-15195116 ] Konrad Windszus commented on SLING-5607: Changing the implementation for the methods

[jira] [Commented] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195113#comment-15195113 ] Konrad Windszus commented on SLING-5605: I created SLING-5607 to fix {{SlingServletResolver}}. >

[jira] [Created] (SLING-5607) SlingServletResolver.resolveServlet should never return null

Konrad Windszus created SLING-5607: -- Summary: SlingServletResolver.resolveServlet should never return null Key: SLING-5607 URL: https://issues.apache.org/jira/browse/SLING-5607 Project: Sling

[jira] [Resolved] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-5605. Resolution: Invalid > Wrong null annotations on ServletResolver interface >

[jira] [Commented] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195111#comment-15195111 ] Konrad Windszus commented on SLING-5605: Ok, I reverted with

[jira] [Updated] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-5605: --- Description: Currently all methods being defined on {{org.apache.sling.api.servlets}} are

[jira] [Commented] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195107#comment-15195107 ] Carsten Ziegeler commented on SLING-5605: - Right, but SLING-2920 is a totally different story >

[jira] [Commented] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195104#comment-15195104 ] Carsten Ziegeler commented on SLING-5605: - While I agree in general that such a change could break

[jira] [Commented] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195101#comment-15195101 ] Konrad Windszus commented on SLING-5605: I just remember that aligning the impl with the

[jira] [Comment Edited] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195099#comment-15195099 ] Konrad Windszus edited comment on SLING-5605 at 3/15/16 11:02 AM: -- Ok,

[jira] [Commented] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195099#comment-15195099 ] Konrad Windszus commented on SLING-5605: Ok, but if we change the implementation a lot of clients

[jira] [Reopened] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reopened SLING-5605: - Please revert, the javadoc *is* correct. The implementation is not > Wrong null annotations

[jira] [Resolved] (SLING-5606) Require Java7 for build

[ https://issues.apache.org/jira/browse/SLING-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-5606. Resolution: Fixed Fix Version/s: Parent 27 Fixed with

[jira] [Created] (SLING-5606) Require Java7 for build

Konrad Windszus created SLING-5606: -- Summary: Require Java7 for build Key: SLING-5606 URL: https://issues.apache.org/jira/browse/SLING-5606 Project: Sling Issue Type: Improvement

[jira] [Resolved] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-5605. Resolution: Fixed Fix Version/s: API 2.12.0 Fixed in

[jira] [Comment Edited] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195018#comment-15195018 ] Carsten Ziegeler edited comment on SLING-5605 at 3/15/16 9:52 AM: --

[jira] [Commented] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195018#comment-15195018 ] Carsten Ziegeler commented on SLING-5605: - Shouldn't there always be a default servlet? > Wrong

[jira] [Commented] (SLING-5604) Upgrade Commons Collections to 4.1

[ https://issues.apache.org/jira/browse/SLING-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195013#comment-15195013 ] Oliver Lietz commented on SLING-5604: - {{org.apache.commons/commons-collections4/4.1}} added to

[jira] [Commented] (SLING-5603) Upgrade Commons Lang to 3.4

[ https://issues.apache.org/jira/browse/SLING-5603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195009#comment-15195009 ] Oliver Lietz commented on SLING-5603: - {{org.apache.commons/commons-lang3/3.4}} added to Launchpad in

[jira] [Assigned] (SLING-5605) Wrong null annotations on ServletResolver interface

[ https://issues.apache.org/jira/browse/SLING-5605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-5605: -- Assignee: Konrad Windszus > Wrong null annotations on ServletResolver interface >

[jira] [Created] (SLING-5605) Wrong null annotations on ServletResolver interface

Konrad Windszus created SLING-5605: -- Summary: Wrong null annotations on ServletResolver interface Key: SLING-5605 URL: https://issues.apache.org/jira/browse/SLING-5605 Project: Sling Issue

[jira] [Created] (SLING-5604) Upgrade Commons Collections to 4.1

Oliver Lietz created SLING-5604: --- Summary: Upgrade Commons Collections to 4.1 Key: SLING-5604 URL: https://issues.apache.org/jira/browse/SLING-5604 Project: Sling Issue Type: Task

[jira] [Created] (SLING-5603) Upgrade Commons Lang to 3.4

Oliver Lietz created SLING-5603: --- Summary: Upgrade Commons Lang to 3.4 Key: SLING-5603 URL: https://issues.apache.org/jira/browse/SLING-5603 Project: Sling Issue Type: Task

RE: [VOTE] Accept the donation of the Sling Dynamic Include module, SLING-5594

+1 it would be nice if some unit tests and/or integration tests could be added (this can be done later after the initial contribution) stefan

RE: [VOTE] Release Apache Sling Scripting Sightly Engine 1.0.18

+1

RE: [VOTE] Release Apache Sling Maven Sling Plugin 2.1.8

+1