Re: [VOTE] Release Apache Sling Oak Restrictions version 1.0.0

2016-09-27 Thread Karl Pauls
> > It needs to be the key fingerprint I think - not the key id (just in > > case > > that isn't what you have set there). > > > > Otherwise, the release looks good to me. > > Good point, I updated it to be the full key fingerprint. > > I'll wait a bit for the .asc file to be updated, it's a batch

RE: [VOTE] Release Apache Sling Discovery Commons 1.0.16 and Discovery Oak 1.2.14

2016-09-27 Thread Stefan Seifert
signatures and build are fine, but i've one question: rev. 1761756 for SLING-5995 breaks the API compatibility and increases the package version of package org.apache.sling.discovery.commons.providers.spi.base to 2.0.0, forcing all existing implementations to recompile or adapt their version ra

[jira] [Comment Edited] (SLING-6056) achieve 1:1 mapping between observation and resource change listener

2016-09-27 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528529#comment-15528529 ] Carsten Ziegeler edited comment on SLING-6056 at 9/28/16 5:59 AM: --

[jira] [Commented] (SLING-6056) achieve 1:1 mapping between observation and resource change listener

2016-09-27 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528529#comment-15528529 ] Carsten Ziegeler commented on SLING-6056: - [~egli] We can't make a major version c

Re: [VOTE] Release Apache Sling Oak Restrictions version 1.0.0

2016-09-27 Thread Georg Henzler
+1 (and thanks for taking care of the release) Georg On 2016-09-27 23:17, Daniel Klco wrote: +1 I updated my GPG keys as such: wget https://people.apache.org/keys/group/sling.asc -q -O /tmp/sling.asc gpg --import /tmp/sling.asc &> /dev/null And the signatures look good. On Tue, Sep 27, 2

Re: [VOTE] Release Apache Sling Oak Restrictions version 1.0.0

2016-09-27 Thread Robert Munteanu
On Tue, 2016-09-27 at 23:24 +0200, Karl Pauls wrote: > I > > On Tue, Sep 27, 2016 at 11:13 PM, Robert Munteanu > > wrote: > > > On Tue, 2016-09-27 at 22:50 +0200, Karl Pauls wrote: > > > I'm getting bad sigs. I think i don't see your key in > > > https://people.apache.org/keys/group/sling.asc -

Re: [VOTE] Release Apache Sling Oak Restrictions version 1.0.0

2016-09-27 Thread Karl Pauls
I On Tue, Sep 27, 2016 at 11:13 PM, Robert Munteanu wrote: > On Tue, 2016-09-27 at 22:50 +0200, Karl Pauls wrote: > > I'm getting bad sigs. I think i don't see your key in > > https://people.apache.org/keys/group/sling.asc - is it possible that > > you > > didn't add your gpg key id to your id.a

Re: Build failed in Jenkins: sling-bundles-extensions-discovery-api-1.8 #1

2016-09-27 Thread Robert Munteanu
I've configured the jobs to not fail if no JUnit test results are found, the build should be fixed on the next run. Robert On Tue, 2016-09-27 at 21:20 +, Apache Jenkins Server wrote: > See -api-1.8/1/> > > --

Re: [VOTE] Release Apache Sling Oak Restrictions version 1.0.0

2016-09-27 Thread Robert Munteanu
On Tue, 2016-09-27 at 23:20 +0200, Karl Pauls wrote: > On Tue, Sep 27, 2016 at 11:17 PM, Daniel Klco > wrote: > > > +1 > > > > I updated my GPG keys as such: > > > > wget https://people.apache.org/keys/group/sling.asc -q -O > > /tmp/sling.asc > > gpg --import /tmp/sling.asc &> /dev/null > > >

Re: [VOTE] Release Apache Sling Oak Restrictions version 1.0.0

2016-09-27 Thread Karl Pauls
On Tue, Sep 27, 2016 at 11:17 PM, Daniel Klco wrote: > +1 > > I updated my GPG keys as such: > > wget https://people.apache.org/keys/group/sling.asc -q -O /tmp/sling.asc > gpg --import /tmp/sling.asc &> /dev/null > Are you sure you didn't have it imported before? Because I can't see it in sling.

Re: [VOTE] Release Apache Sling Oak Restrictions version 1.0.0

2016-09-27 Thread Daniel Klco
+1 I updated my GPG keys as such: wget https://people.apache.org/keys/group/sling.asc -q -O /tmp/sling.asc gpg --import /tmp/sling.asc &> /dev/null And the signatures look good. On Tue, Sep 27, 2016 at 5:13 PM, Robert Munteanu wrote: > On Tue, 2016-09-27 at 22:50 +0200, Karl Pauls wrote: > >

Re: [VOTE] Release Apache Sling Oak Restrictions version 1.0.0

2016-09-27 Thread Robert Munteanu
On Tue, 2016-09-27 at 22:50 +0200, Karl Pauls wrote: > I'm getting bad sigs. I think i don't see your key in > https://people.apache.org/keys/group/sling.asc - is it possible that > you > didn't add your gpg key id to your id.apache.org account (or that it > is not > available via a public server)?

Re: [VOTE] Release Apache Sling Oak Restrictions version 1.0.0

2016-09-27 Thread Karl Pauls
I'm getting bad sigs. I think i don't see your key in https://people.apache.org/keys/group/sling.asc - is it possible that you didn't add your gpg key id to your id.apache.org account (or that it is not available via a public server)? regards, Karl On Tue, Sep 27, 2016 at 10:32 PM, Robert Muntea

[VOTE] Release Apache Sling Oak Restrictions version 1.0.0

2016-09-27 Thread Robert Munteanu
Hi, We solved 4 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12337877 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1527 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.

[jira] [Updated] (SLING-6072) The testing rules do not call CloseableHttpClient.close()

2016-09-27 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-6072: --- Assignee: Andrei Dulvac > The testing rules do not call CloseableHttpClient.close() >

[jira] [Created] (SLING-6072) The testing rules do not call CloseableHttpClient.close()

2016-09-27 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-6072: -- Summary: The testing rules do not call CloseableHttpClient.close() Key: SLING-6072 URL: https://issues.apache.org/jira/browse/SLING-6072 Project: Sling I

Failing distribution ITs (Was: Build failed in Jenkins: sling-contrib-extensions-distribution-1.8 #2)

2016-09-27 Thread Robert Munteanu
Hi, Seems that the distribution ITs are failing, can someone please look into it? Thanks, Robert On Tue, 2016-09-27 at 17:37 +, Apache Jenkins Server wrote: > See ion-1.8/2/changes> > > Changes: > > [rombert] SLING-6061 -

[GitHub] sling pull request #169: SLING-6045 Moving module to contrib/jcr

2016-09-27 Thread ghenzler
Github user ghenzler closed the pull request at: https://github.com/apache/sling/pull/169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (SLING-6045) Improve java package and GAV for oak restrictions

2016-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526725#comment-15526725 ] ASF GitHub Bot commented on SLING-6045: --- Github user ghenzler closed the pull reques

[jira] [Resolved] (SLING-6071) JcrModifiableValueMap#remove(key) breaks Map contract

2016-09-27 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-6071. Resolution: Fixed Fix Version/s: JCR Resource 2.8.2 Fixed in [r1762513|https://svn.ap

Re: Using FileSet in htl-maven-plugin

2016-09-27 Thread Konrad Windszus
Hi Radu, I am no longer convinced this is a good idea: http://dev.eclipse.org/mhonarc/lists/m2e-users/msg05577.html . Therefore I don't think it is worth the effort. Also I agree that dealing with default values is much harder then. S

Re: Using FileSet in htl-maven-plugin

2016-09-27 Thread Radu Cotescu
Hi Konrad, We could attempt to integrate FileSet into the HTL's plugin configuration, but what I don't like is that you're forced to specify a directory no matter what (or at least that's what I understand from the documentation). Could you send a patch? Then we could work together on this. Thank

[jira] [Assigned] (SLING-6071) JcrModifiableValueMap#remove(key) breaks Map contract

2016-09-27 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-6071: -- Assignee: Konrad Windszus > JcrModifiableValueMap#remove(key) breaks Map contract > ---

[jira] [Commented] (SLING-6071) JcrModifiableValueMap#remove(key) breaks Map contract

2016-09-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526525#comment-15526525 ] ASF GitHub Bot commented on SLING-6071: --- GitHub user Buuhuu opened a pull request:

[GitHub] sling pull request #175: SLING-6071

2016-09-27 Thread Buuhuu
GitHub user Buuhuu opened a pull request: https://github.com/apache/sling/pull/175 SLING-6071 - returned value of valueCache instead of the one from cache - added unti test for the remove method You can merge this pull request into a Git repository by running: $ git pull

[jira] [Updated] (SLING-6071) JcrModifiableValueMap#remove(key) breaks Map contract

2016-09-27 Thread Dirk Rudolph (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dirk Rudolph updated SLING-6071: Summary: JcrModifiableValueMap#remove(key) breaks Map contract (was: JcrModifiableValueMap#remove(k

[jira] [Created] (SLING-6071) JcrModifiableValueMap#remove(key) break Map contract

2016-09-27 Thread Dirk Rudolph (JIRA)
Dirk Rudolph created SLING-6071: --- Summary: JcrModifiableValueMap#remove(key) break Map contract Key: SLING-6071 URL: https://issues.apache.org/jira/browse/SLING-6071 Project: Sling Issue Type:

[jira] [Commented] (SLING-6061) Create per-module Jenkins jobs

2016-09-27 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526427#comment-15526427 ] Robert Munteanu commented on SLING-6061: I've also migrated the distribution job f

Re: [VOTE] Release Apache Sling Discovery Commons 1.0.16 and Discovery Oak 1.2.14

2016-09-27 Thread Daniel Klco
+1 On Tue, Sep 27, 2016 at 8:47 AM, Stefan Egli wrote: > +1 > > Cheers, > Stefan > > On 26/09/16 12:08, "Stefan Egli" wrote: > > >Hi, > > > >We solved 4 issues in these 2 related releases: > > > >https://issues.apache.org/jira/browse/SLING/fixforversion/12338296 > >https://issues.apache.org/jir

[jira] [Resolved] (SLING-5309) Install OSGi subsystem through the maven-sling-plugin

2016-09-27 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-5309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roy Teeuwen resolved SLING-5309. Resolution: Won't Fix No longer relevant seeing as AEM removed the subsystem feature > Install OSGi

[jira] [Commented] (SLING-6061) Create per-module Jenkins jobs

2016-09-27 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526141#comment-15526141 ] Robert Munteanu commented on SLING-6061: I've excluded the i18n job from the main

Re: Error importing org.apache.sling.contextaware.config.impl into Eclipse

2016-09-27 Thread Konrad Windszus
I requested to remove the MavenBundlePluginConfigurator from the m2e-tycho extension (https://github.com/tesla/m2eclipse-tycho/issues/31 ). Hopefully they will update also the catalog listing to point to a newer release afterwards so that this

[jira] [Commented] (SLING-6070) Reduce temporary storage required in JcrResourceListener, call reportChanges earlier

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526129#comment-15526129 ] Stefan Egli commented on SLING-6070: Depending on the outcome of OAK-4853 this might b

[jira] [Resolved] (SLING-6045) Improve java package and GAV for oak restrictions

2016-09-27 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-6045. Resolution: Fixed Applied in https://svn.apache.org/r1762476, thanks a lot for the contribut

[jira] [Updated] (SLING-6045) Improve java package and GAV for oak restrictions

2016-09-27 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-6045: --- Fix Version/s: Oak Restrictions 1.0.0 > Improve java package and GAV for oak restrictions > --

Re: [VOTE] Release Apache Sling Discovery Commons 1.0.16 and Discovery Oak 1.2.14

2016-09-27 Thread Stefan Egli
+1 Cheers, Stefan On 26/09/16 12:08, "Stefan Egli" wrote: >Hi, > >We solved 4 issues in these 2 related releases: > >https://issues.apache.org/jira/browse/SLING/fixforversion/12338296 >https://issues.apache.org/jira/browse/SLING/fixforversion/12338297 > >Staging repository: >https://repository.

[jira] [Updated] (SLING-6056) achieve 1:1 mapping between observation and resource change listener

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-6056: --- Fix Version/s: API 2.15.0 JCR Resource 2.8.2 > achieve 1:1 mapping between observat

Re: Error importing org.apache.sling.contextaware.config.impl into Eclipse

2016-09-27 Thread Konrad Windszus
Thanks for that pointer. Indeed it seems related: https://github.com/tesla/m2eclipse-tycho/blob/a096bd5549d46bbc7644a6e5f42938dd93336251/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/internal/OsgiBundleProjectConfigurator.java#L76

[jira] [Updated] (SLING-6056) achieve 1:1 mapping between observation and resource change listener

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-6056: --- Affects Version/s: JCR Resource 2.8.0 API 2.14.2 > achieve 1:1 mapping between

[jira] [Commented] (SLING-6070) Reduce temporary storage required in JcrResourceListener, call reportChanges earlier

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525986#comment-15525986 ] Stefan Egli commented on SLING-6070: Open question here is: are we allowed to make thi

[jira] [Created] (SLING-6070) Reduce temporary storage required in JcrResourceListener, call reportChanges earlier

2016-09-27 Thread Stefan Egli (JIRA)
Stefan Egli created SLING-6070: -- Summary: Reduce temporary storage required in JcrResourceListener, call reportChanges earlier Key: SLING-6070 URL: https://issues.apache.org/jira/browse/SLING-6070 Projec

[jira] [Created] (SLING-6069) Error: Multiple matches found for unary reference 'factory'

2016-09-27 Thread Christoph Thodte (JIRA)
Christoph Thodte created SLING-6069: --- Summary: Error: Multiple matches found for unary reference 'factory' Key: SLING-6069 URL: https://issues.apache.org/jira/browse/SLING-6069 Project: Sling

Re: Error importing org.apache.sling.contextaware.config.impl into Eclipse

2016-09-27 Thread Robert Munteanu
Hi Konrad, On Tue, 2016-09-27 at 13:57 +0200, Konrad Windszus wrote: > Whenever I import the Maven project from "https://github.com/apache/s > ling/tree/trunk/contrib/extensions/contextaware-config/impl > taware-config/impl>"

Error importing org.apache.sling.contextaware.config.impl into Eclipse

2016-09-27 Thread Konrad Windszus
Whenever I import the Maven project from "https://github.com/apache/sling/tree/trunk/contrib/extensions/contextaware-config/impl " I am getting an error in Eclipse: java.lang.IllegalArgumentException

[jenkins] Per-module build jobs

2016-09-27 Thread Robert Munteanu
Hi, I finished by POC for creating per-module build jobs, starting with - bundles/extensions/i18n - contrib/extensions/sling-pipes These jobs are generated using the code from   https://svn.apache.org/repos/asf/sling/trunk/tooling/jenkins/create_j obs.groovy This code in turn is invoked on Jen

[jira] [Commented] (SLING-920) Sling Jenkins setup

2016-09-27 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525856#comment-15525856 ] Robert Munteanu commented on SLING-920: --- The syntax is correct, but it seems that exc

[jira] [Commented] (SLING-920) Sling Jenkins setup

2016-09-27 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525842#comment-15525842 ] Robert Munteanu commented on SLING-920: --- Apparently the correct syntax is {{-pl !org.

Re: Build failed in Jenkins: sling-trunk-1.8 #4054

2016-09-27 Thread Robert Munteanu
On Tue, 2016-09-27 at 10:30 +, Apache Jenkins Server wrote: > See ... > Waiting for Jenkins to finish collecting data[ERROR] Unknown > lifecycle phase "l". You must specify a valid lifecycle phase or a > goal in the format : or id

[jira] [Updated] (SLING-6056) achieve 1:1 mapping between observation and resource change listener

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-6056: --- Attachment: SLING-6056.patch Attaching patch [^SLING-6056.patch] for review. Note that I'm also sugges

[jira] [Commented] (SLING-920) Sling Jenkins setup

2016-09-27 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525702#comment-15525702 ] Robert Munteanu commented on SLING-920: --- Removed the org.apache.sling.i18n module fro

[jira] [Commented] (SLING-920) Sling Jenkins setup

2016-09-27 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525628#comment-15525628 ] Robert Munteanu commented on SLING-920: --- Updated the Sling view to include all jobs w

[jira] [Commented] (SLING-6061) Create per-module Jenkins jobs

2016-09-27 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525614#comment-15525614 ] Robert Munteanu commented on SLING-6061: * Committed a initial version of the scri

[jira] [Commented] (SLING-6056) achieve 1:1 mapping between observation and resource change listener

2016-09-27 Thread Stefan Egli (JIRA)
[ https://issues.apache.org/jira/browse/SLING-6056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525450#comment-15525450 ] Stefan Egli commented on SLING-6056: [~cziegeler], I can't see how it can be done isol