Re: [VOTE] Release Apache Sling Commons Metrics 1.2.4

[Bertrand Delacretaz]

On Fri, Dec 1, 2017 at 12:03 PM, Chetan Mehrotra  wrote:
>... Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1823 ...

+1, checked signatures, digests and build.

-Bertrand

[jira] [Resolved] (SLING-7283) ModelPackageBundleListener: lower log level when registering servlets

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-7283.
---
Resolution: Fixed

fixed: 
https://github.com/apache/sling-org-apache-sling-models-impl/commit/378221953827f67e04cfdb3d14857476032b9d07

> ModelPackageBundleListener: lower log level when registering servlets
> -
>
> Key: SLING-7283
> URL: https://issues.apache.org/jira/browse/SLING-7283
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Sling Models Impl 1.4.4
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Trivial
> Fix For: Sling Models Impl 1.4.6
>
>
> ModelPackageBundleListener logs messages like this when registering exporters:
> {noformat}
> [pool-1-thread-1] INFO 
> org.apache.sling.models.impl.ModelPackageBundleListener - registering servlet 
> for core/wcm/components/form/container/v1/container, model, [json]
> {noformat}
> we should lower the log level for this message to debug to avoid spamming log 
> files - especially in sling-mock based unit tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7283) ModelPackageBundleListener: lower log level when registering servlets

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-7283:
-

 Summary: ModelPackageBundleListener: lower log level when 
registering servlets
 Key: SLING-7283
 URL: https://issues.apache.org/jira/browse/SLING-7283
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Sling Models Impl 1.4.4
Reporter: Stefan Seifert
Assignee: Stefan Seifert
Priority: Trivial
 Fix For: Sling Models Impl 1.4.6


ModelPackageBundleListener logs messages like this when registering exporters:
{noformat}
[pool-1-thread-1] INFO org.apache.sling.models.impl.ModelPackageBundleListener 
- registering servlet for core/wcm/components/form/container/v1/container, 
model, [json]
{noformat}

we should lower the log level for this message to debug to avoid spamming log 
files - especially in sling-mock based unit tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-6741) Migrate to R6 annotations, clean up dependencies

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-6741.
---

> Migrate to R6 annotations, clean up dependencies
> 
>
> Key: SLING-6741
> URL: https://issues.apache.org/jira/browse/SLING-6741
> Project: Sling
>  Issue Type: Bug
>  Components: i18n
>Reporter: Karl Pauls
>Assignee: Carsten Ziegeler
> Fix For: i18n 2.5.10
>
>
> The build works fine when switching to sling parent 29.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-4547) JcrResourceBundle does not support multiple base names

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4547.
---

> JcrResourceBundle does not support multiple base names
> --
>
> Key: SLING-4547
> URL: https://issues.apache.org/jira/browse/SLING-4547
> Project: Sling
>  Issue Type: Bug
>  Components: i18n
>Affects Versions: i18n 2.5.8
>Reporter: Andrei Pilets
>Assignee: Konrad Windszus
> Fix For: i18n 2.5.10
>
>
> The sling:basename property may be multi-valued, that is the messages of a 
> mix:language nodes may belong to multiple base names and thus ResourceBundle 
> instances, as stated at 
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html.
>  
> The latest codebase does not work in that way.
> JcrResourceBundle#loadPotentialLanguageRoots():
> if (baseName == null || baseName.equals(properties.get(PROP_BASENAME, ""))) {
>  paths.add(bundle.getPath());
> }
> In case if property sling:basename have multiple values, only the first base 
> name is considered, others are skipped.
> The correct implementation would be to use properties.get(PROP_BASENAME) - 
> method version without default value parameter, which would return array. You 
> would need to iterate over its items and check equality.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7112) ResourceBundle cannot be retrieved for private-use country codes

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-7112.
---

> ResourceBundle cannot be retrieved for private-use country codes
> 
>
> Key: SLING-7112
> URL: https://issues.apache.org/jira/browse/SLING-7112
> Project: Sling
>  Issue Type: Bug
>  Components: i18n
>Affects Versions: i18n 2.5.8
> Environment: Mac OS, AEM
>Reporter: Harold Putman
>Assignee: Konrad Windszus
>Priority: Minor
> Fix For: i18n 2.5.10
>
>
> In HTL the @​i18n tag fails when jcr:language not in ISO list. 
> es_PY falls back to es, but es_XL falls back to default en. 
> I think this is related to the check for valid countries in 
> JcrResourceBundleProvider::toLocale().
> If you feel you must check for valid country code, please also allow case 
> where country code starts with X which is allowed by the [IANA 
> spec](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry).
> ```
> %%
> Type: region
> Subtag: XA..XZ
> Description: Private use
> Added: 2005-10-16 
> ```



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7244) Correct require capability for http whiteboard

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-7244.
---

> Correct require capability for http whiteboard
> --
>
> Key: SLING-7244
> URL: https://issues.apache.org/jira/browse/SLING-7244
> Project: Sling
>  Issue Type: Bug
>  Components: Engine, Extensions
>Affects Versions: i18n 2.5.8, Feature Flags 1.2.0, Engine 2.6.8, Security 
> 1.1.6
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Feature Flags 1.2.2, Engine 2.6.10, Security 1.1.10, 
> i18n 2.5.10
>
>
> The require capability should not use a fixed version but a version range, 
> otherwise it will not resolve once we update the http implementation



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Sling Commons Metrics 1.2.4

[Carsten Ziegeler]

+1


Chetan Mehrotra wrote
> Hi,
> 
> We solved 5 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12340679
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1823
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 1823 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> regards
> Chetan
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE] Release Apache Sling Commons Metrics 1.2.4

[Chetan Mehrotra]

Hi,

We solved 5 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12340679

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1823

You can use this UNIX script to download the release and verify the
signatures:
https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh

Usage:
sh check_staged_release.sh 1823 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

regards
Chetan

[jira] [Updated] (SLING-6474) Commons Metrics DOES not declare provide capability for Metrics service

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated SLING-6474:
---
Fix Version/s: (was: commons metrics 1.2.4)
   Commons Metrics 1.2.6

> Commons Metrics DOES not declare provide capability for Metrics service
> ---
>
> Key: SLING-6474
> URL: https://issues.apache.org/jira/browse/SLING-6474
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons Metrics 1.2.0
>Reporter: Nino Martinez
>Assignee: Chetan Mehrotra
> Fix For: Commons Metrics 1.2.6
>
>
> Commons Metrics needs to declare provide capability for 
> org.apache.sling.commons.metrics.MetricsService in manifest.MF
> otherwise other bundles that specifies require capability on the 
> MetricsService will fail to start.
> AS of maven bundle plugin 3.2.0 this will become a problem, since they fixed 
> the capabilities generation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-6702) Make MetricsService accessible as easily as a Logger

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved SLING-6702.

Resolution: Fixed

> Make MetricsService accessible as easily as a Logger
> 
>
> Key: SLING-6702
> URL: https://issues.apache.org/jira/browse/SLING-6702
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Commons Metrics 1.2.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: commons metrics 1.2.4
>
>
> Metrics are useful in all classes, not only OSGi components, so getting the 
> {{MetricsService}} should be as useful as getting a {{Logger}} for example.
> I'll add a public {{MetricsServiceFactory}} class to our metrics module, 
> usable like
> {code}
>   MetricsService ms = 
> MetricsServiceFactory.getMetricsService(this.getClass());
> {code}
> There's already a private {{MetricsServiceFactory}} class in that module, 
> I'll rename that to {{InternalMetricsServiceFactory}} to avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-6702) Make MetricsService accessible as easily as a Logger

[Chetan Mehrotra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274245#comment-16274245
 ] 

Chetan Mehrotra commented on SLING-6702:


Had an offline discussion with [~bdelacretaz] - We decided to add a note in 
MetricServiceImpl to ensure that later if any support for OSGi config is added 
then rewiring of metric service should be looked into

Done that with e041e99219f544

> Make MetricsService accessible as easily as a Logger
> 
>
> Key: SLING-6702
> URL: https://issues.apache.org/jira/browse/SLING-6702
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Commons Metrics 1.2.0
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: commons metrics 1.2.4
>
>
> Metrics are useful in all classes, not only OSGi components, so getting the 
> {{MetricsService}} should be as useful as getting a {{Logger}} for example.
> I'll add a public {{MetricsServiceFactory}} class to our metrics module, 
> usable like
> {code}
>   MetricsService ms = 
> MetricsServiceFactory.getMetricsService(this.getClass());
> {code}
> There's already a private {{MetricsServiceFactory}} class in that module, 
> I'll rename that to {{InternalMetricsServiceFactory}} to avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7045) OSGi services should be managed by DS

[Chetan Mehrotra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved SLING-7045.

   Resolution: Won't Fix
Fix Version/s: (was: commons metrics 1.2.4)

> OSGi services should be managed by DS
> -
>
> Key: SLING-7045
> URL: https://issues.apache.org/jira/browse/SLING-7045
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Carsten Ziegeler
>
> MetricsServiceImpl is currently registering two services in its activate 
> method - there seems to be no real reason doing this manually and the 
> services should rather be registered by DS



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)