[jira] [Commented] (SLING-7567) Unable to logout from Sling Starter Index page , Comopsum Browser , system/console

[Oliver Lietz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427565#comment-16427565
 ] 

Oliver Lietz commented on SLING-7567:
-

[~pursingh], I cannot reproduce your issues. Please describe exactly your steps 
and which browser you are using. See FELIX-3006 also.

> Unable to logout from Sling Starter Index page , Comopsum Browser , 
> system/console
> --
>
> Key: SLING-7567
> URL: https://issues.apache.org/jira/browse/SLING-7567
> Project: Sling
>  Issue Type: Bug
>  Components: Karaf
>Reporter: Purnendra Pratap Singh
>Assignee: Oliver Lietz
>Priority: Major
>
> I have installed Sling feature on Apache Karaf .
> I am able to login into Sling using admin/admin and Felix console using 
> karaf/karaf .
> but for any of the logout link for  : bin/browser.html ,  and /system/console 
> is not logging me out.
>  
> I am not sure if this is because of Sling feature or Karaf issue in itself.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7570) Add missing OSGi capability: service ITemplateEngine

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7570.
-
Resolution: Done

> Add missing OSGi capability: service ITemplateEngine
> 
>
> Key: SLING-7570
> URL: https://issues.apache.org/jira/browse/SLING-7570
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Thymeleaf 1.1.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] rombert opened a new pull request #1: [discuss] SLING-5648 - Make Non-Eclipse Module regular Maven Packages

[GitBox]

rombert opened a new pull request #1: [discuss] SLING-5648 - Make Non-Eclipse 
Module regular Maven Packages 
URL: https://github.com/apache/sling-ide-tooling/pull/1
 
 
   Preparatory work for making non-eclipse modules Maven packages, and 
therefore much easier to reuse.
   
   i've extracted several modules from the Eclipse build and made them regular 
Maven modules, which should be easily consumable by other IDEs/environments. 
Being a regular bnd project means that it's impossible to slip by a dependency 
on Eclipse - I've removed one for impl-vlt.

   The modules are not yet OSGi-free due to the `EventAdmin` dependencies, that 
will require more work and will probably be tracked with 
[SLING-5618](https://issues.apache.org/jira/browse/SLING-5618).
   
   I'm almost done with this, but I'd like to put this up for review since I 
won't be available until Wednesday.
   
   What does not yet work:
   
   - `BundleDeploymentIT` ; although bundle deployment works from the IDE
   - running tests from Eclipse; did not spend too much time with this, getting 
weird errors as is the workspace is already provisioned
   
   @schaefa - does this fit your expectation on what reusable modules would 
look like?
   @kwin  - your feedback would be welcome, given that you have contributed 
extensively to the IDE tooling in the past


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (SLING-7573) Migrate to newest parent, bnd-maven-plugin and OSGi annotations

[Konrad Windszus (JIRA)]

Konrad Windszus created SLING-7573:
--

 Summary: Migrate to newest parent, bnd-maven-plugin and OSGi 
annotations
 Key: SLING-7573
 URL: https://issues.apache.org/jira/browse/SLING-7573
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: Installer Health Checks 1.0.0
Reporter: Konrad Windszus
Assignee: Konrad Windszus
 Fix For: Installer Health Checks 1.0.2






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7569) Also warn in case if only one of the supplied bundles/configurations within a group below the configured paths are valid

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427288#comment-16427288
 ] 

Konrad Windszus commented on SLING-7569:


Resolved with 
https://github.com/apache/sling-org-apache-sling-installer-hc/commit/3544ff88b1bb6cdf6bb7c68b9cad6c87b042f5b3.

> Also warn in case if only one of the supplied bundles/configurations within a 
> group below the configured paths are valid
> 
>
> Key: SLING-7569
> URL: https://issues.apache.org/jira/browse/SLING-7569
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Health Checks 1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Health Checks 1.0.2
>
>
> Currently the OSGI Installer Health Check (contributed with SLING-5888) does 
> not emit a warning in case there is one config not installed, if another one 
> with the same PID is installed below /apps. 
> Since the runmode specifics are checked, before the artifact is put to the 
> OSGi installer we should also warn if there are multiple artifacts of the 
> same ID (PID/Bundle Symbolic Name) below the given checked folder as this is 
> almost always a mistake which should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7569) Also warn in case if only one of the supplied bundles/configurations within a group below the configured paths are valid

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-7569.

Resolution: Fixed

> Also warn in case if only one of the supplied bundles/configurations within a 
> group below the configured paths are valid
> 
>
> Key: SLING-7569
> URL: https://issues.apache.org/jira/browse/SLING-7569
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Health Checks 1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Health Checks 1.0.2
>
>
> Currently the OSGI Installer Health Check (contributed with SLING-5888) does 
> not emit a warning in case there is one config not installed, if another one 
> with the same PID is installed below /apps. 
> Since the runmode specifics are checked, before the artifact is put to the 
> OSGi installer we should also warn if there are multiple artifacts of the 
> same ID (PID/Bundle Symbolic Name) below the given checked folder as this is 
> almost always a mistake which should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-5648) Make Non-Eclipse Module regular Maven Packages

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427116#comment-16427116
 ] 

Robert Munteanu commented on SLING-5648:


The test execution is due to the extended OSGi metadata added by bnd, (or maybe 
by the older DS implementation). Rather than work around that, I'd upgrade to 
the latest Eclipse release (Oxygen) as a baseline for compilation and testing 
and also to Java 8 ( SLING-7151, SLING-7152 )

> Make Non-Eclipse Module regular Maven Packages
> --
>
> Key: SLING-5648
> URL: https://issues.apache.org/jira/browse/SLING-5648
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.10
>Reporter: Andreas Schaefer
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>
> Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be 
> regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to 
> support development of it by other IDEs like IntelliJ IDEA.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-5648) Make Non-Eclipse Module regular Maven Packages

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427116#comment-16427116
 ] 

Robert Munteanu edited comment on SLING-5648 at 4/5/18 3:32 PM:


The test execution is due to the extended OSGi metadata added by bnd, (or maybe 
by the older DS implementation). Rather than work around that, I'd upgrade to 
the latest Eclipse release (Oxygen) as a baseline for compilation and testing 
and also to Java 8 ( SLING-7571, SLING-7572 )


was (Author: rombert):
The test execution is due to the extended OSGi metadata added by bnd, (or maybe 
by the older DS implementation). Rather than work around that, I'd upgrade to 
the latest Eclipse release (Oxygen) as a baseline for compilation and testing 
and also to Java 8 ( SLING-7151, SLING-7152 )

> Make Non-Eclipse Module regular Maven Packages
> --
>
> Key: SLING-5648
> URL: https://issues.apache.org/jira/browse/SLING-5648
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.10
>Reporter: Andreas Schaefer
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>
> Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be 
> regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to 
> support development of it by other IDEs like IntelliJ IDEA.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7572) Upgrade to Java 8

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7572:
--

 Summary: Upgrade to Java 8
 Key: SLING-7572
 URL: https://issues.apache.org/jira/browse/SLING-7572
 Project: Sling
  Issue Type: Task
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.2.4


At this point it should be safe to upgrade to Java 8 as an LTS release which is 
more that 4 years old.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7571) Upgrade to Eclipse Oxygen

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7571:
--

 Summary: Upgrade to Eclipse Oxygen
 Key: SLING-7571
 URL: https://issues.apache.org/jira/browse/SLING-7571
 Project: Sling
  Issue Type: Task
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.2.4


Use Eclipse Oxygen for the enhanced DS support which is needed for SLING-5648.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-5648) Make Non-Eclipse Module regular Maven Packages

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427054#comment-16427054
 ] 

Robert Munteanu edited comment on SLING-5648 at 4/5/18 2:58 PM:


The PDE issue can be worked around by configuring the 
{{maven-resources-plugin}} to copy the MANIFEST.MF file under 
META-INF/MANIFEST.MF, so that PDE considers the project a bundle and uses it 
for dependency resolution. A patch for a single project is below

{noformat}diff --git a/shared/modules/api/.gitignore 
b/shared/modules/api/.gitignore
new file mode 100644
index ..219f4178
--- /dev/null
+++ b/shared/modules/api/.gitignore
@@ -0,0 +1 @@
+/META-INF/MANIFEST.MF
diff --git a/shared/modules/api/pom.xml b/shared/modules/api/pom.xml
index 2f6a2c1c..05a80f59 100644
--- a/shared/modules/api/pom.xml
+++ b/shared/modules/api/pom.xml
@@ -93,4 +93,44 @@
 provided
 
 
+
+
+
+m2e
+
+
+
+m2e.version
+
+
+
+
+
+maven-resources-plugin
+
+
+copy-manifest-for-pde
+process-classes
+
+copy-resources
+
+
+META-INF
+
+
+
${project.build.outputDirectory}/META-INF
+
+MANIFEST.MF
+
+
+
+
+
+
+
+
+
+
+
 
{noformat}

_edit_: raised a feature request with PDE - 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=533263


was (Author: rombert):
The PDE issue can be worked around by configuring the 
{{maven-resources-plugin}} to copy the MANIFEST.MF file under 
META-INF/MANIFEST.MF, so that PDE considers the project a bundle and uses it 
for dependency resolution. A patch for a single project is below

{noformat}diff --git a/shared/modules/api/.gitignore 
b/shared/modules/api/.gitignore
new file mode 100644
index ..219f4178
--- /dev/null
+++ b/shared/modules/api/.gitignore
@@ -0,0 +1 @@
+/META-INF/MANIFEST.MF
diff --git a/shared/modules/api/pom.xml b/shared/modules/api/pom.xml
index 2f6a2c1c..05a80f59 100644
--- a/shared/modules/api/pom.xml
+++ b/shared/modules/api/pom.xml
@@ -93,4 +93,44 @@
 provided
 
 
+
+
+
+m2e
+
+
+
+m2e.version
+
+
+
+
+
+maven-resources-plugin
+
+
+copy-manifest-for-pde
+process-classes
+
+copy-resources
+
+
+META-INF
+
+
+
${project.build.outputDirectory}/META-INF
+
+MANIFEST.MF
+
+
+
+
+
+
+
+
+
+
+
 
{noformat}

> Make Non-Eclipse Module regular Maven Packages
> --
>
> Key: SLING-5648
> URL: https://issues.apache.org/jira/browse/SLING-5648
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.10
>Reporter: Andreas Schaefer
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>
> Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be 
> regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to 
> support development of it by other IDEs like IntelliJ IDEA.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-5648) Make Non-Eclipse Module regular Maven Packages

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427054#comment-16427054
 ] 

Robert Munteanu commented on SLING-5648:


The PDE issue can be worked around by configuring the 
{{maven-resources-plugin}} to copy the MANIFEST.MF file under 
META-INF/MANIFEST.MF, so that PDE considers the project a bundle and uses it 
for dependency resolution. A patch for a single project is below

{noformat}diff --git a/shared/modules/api/.gitignore 
b/shared/modules/api/.gitignore
new file mode 100644
index ..219f4178
--- /dev/null
+++ b/shared/modules/api/.gitignore
@@ -0,0 +1 @@
+/META-INF/MANIFEST.MF
diff --git a/shared/modules/api/pom.xml b/shared/modules/api/pom.xml
index 2f6a2c1c..05a80f59 100644
--- a/shared/modules/api/pom.xml
+++ b/shared/modules/api/pom.xml
@@ -93,4 +93,44 @@
 provided
 
 
+
+
+
+m2e
+
+
+
+m2e.version
+
+
+
+
+
+maven-resources-plugin
+
+
+copy-manifest-for-pde
+process-classes
+
+copy-resources
+
+
+META-INF
+
+
+
${project.build.outputDirectory}/META-INF
+
+MANIFEST.MF
+
+
+
+
+
+
+
+
+
+
+
 
{noformat}

> Make Non-Eclipse Module regular Maven Packages
> --
>
> Key: SLING-5648
> URL: https://issues.apache.org/jira/browse/SLING-5648
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.10
>Reporter: Andreas Schaefer
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>
> Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be 
> regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to 
> support development of it by other IDEs like IntelliJ IDEA.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7570) Add missing OSGi capability: service ITemplateEngine

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7570:
---

 Summary: Add missing OSGi capability: service ITemplateEngine
 Key: SLING-7570
 URL: https://issues.apache.org/jira/browse/SLING-7570
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Scripting Thymeleaf 1.1.2






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-5648) Make Non-Eclipse Module regular Maven Packages

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426782#comment-16426782
 ] 

Robert Munteanu commented on SLING-5648:


I've started working on this topic at 
https://github.com/apache/sling-ide-tooling/tree/feature/intellij . Currently I 
have a shared folder which holds the common parts

- maven modules
- tycho build

and an eclipse folder which holds the eclipse-specific plug-ins.

The CLI build works and the built features seems to run succesfully in a new 
Eclipse instance. There are 2 major issues to address:

- The tests no longer run with Tycho ; the build errors out with 
{{java.lang.RuntimeException: Bundle org.apache.sling.ide.eclipse-test is not 
found}}
- Eclipse PDE no longer recognizes the 'shared' modules as OSGi bundles and 
therefore does not add them to the plug-in classpath, leading to errors.

> Make Non-Eclipse Module regular Maven Packages
> --
>
> Key: SLING-5648
> URL: https://issues.apache.org/jira/browse/SLING-5648
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.10
>Reporter: Andreas Schaefer
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>
> Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be 
> regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to 
> support development of it by other IDEs like IntelliJ IDEA.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Sling Testing Clients version 1.2.0 and Apache Sling Testing Rules 1.0.8

[Konrad Windszus]

+1
Konrad

> On 2. Apr 2018, at 12:30, Andrei Dulvac  wrote:
> 
> Bump.
> 
> On Fri, Mar 30, 2018, 09:41 Andrei Dulvac  wrote:
> 
>> Hi Robert.
>> 
>> There were no issues specifically fixed in the rules, just a commit to
>> update to this version of the clients.
>> 
>> 
>> On Thu, Mar 29, 2018, 14:23 Robert Munteanu  wrote:
>> 
>>> Hi Andrei,
>>> 
>>> On Thu, 2018-03-29 at 11:55 +, Andrei Dulvac wrote:
 We solved 4 issues in this release:
 
 https://issues.apache.org/jira/projects/SLING/versions/12342572
>>> 
>>> What is the changelog for the testing rules release?
>>> 
>>> Robert
>>> 
>> 

[jira] [Updated] (SLING-7569) Also warn in case if only one of the supplied bundles/configurations within a group below the configured paths are valid

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-7569:
---
Summary: Also warn in case if only one of the supplied 
bundles/configurations within a group below the configured paths are valid  
(was: Also warn in case if only one of the supplied bundles/configurations 
below the configured paths are valid)

> Also warn in case if only one of the supplied bundles/configurations within a 
> group below the configured paths are valid
> 
>
> Key: SLING-7569
> URL: https://issues.apache.org/jira/browse/SLING-7569
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Health Checks 1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Health Checks 1.0.2
>
>
> Currently the OSGI Installer Health Check (contributed with SLING-5888) does 
> not emit a warning in case there is one config not installed, if another one 
> with the same PID is installed below /apps. 
> Since the runmode specifics are checked, before the artifact is put to the 
> OSGi installer we should also warn if there are multiple artifacts of the 
> same ID (PID/Bundle Symbolic Name) below the given checked folder as this is 
> almost always a mistake which should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7569) Also warn in case if only one of the supplied bundles/configurations below the configured paths are valid

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426602#comment-16426602
 ] 

Konrad Windszus commented on SLING-7569:


The code responsible for this is in 
https://github.com/apache/sling-org-apache-sling-installer-hc/blob/6de934ee71fb1fa065e095806a2b31a60bafd141/src/main/java/org/apache/sling/installer/hc/OsgiInstallerHealthCheck.java#L153

> Also warn in case if only one of the supplied bundles/configurations below 
> the configured paths are valid
> -
>
> Key: SLING-7569
> URL: https://issues.apache.org/jira/browse/SLING-7569
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Health Checks 1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Health Checks 1.0.2
>
>
> Currently the OSGI Installer Health Check (contributed with SLING-5888) does 
> not emit a warning in case there is one config not installed, if another one 
> with the same PID is installed below /apps. 
> Since the runmode specifics are checked, before the artifact is put to the 
> OSGi installer we should also warn if there are multiple artifacts of the 
> same ID (PID/Bundle Symbolic Name) below the given checked folder as this is 
> almost always a mistake which should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)