[jira] [Assigned] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

2018-05-23 Thread David Bosschaert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert reassigned SLING-7677: --- Assignee: David Bosschaert > FeatureJSONWriter uses isOptional instead of isRequired

[jira] [Commented] (SLING-2463) Sling Script Console Plugin

2018-05-23 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488459#comment-16488459 ] Chetan Mehrotra commented on SLING-2463: [~bdelacretaz] Probably we can remove thi

[GitHub] paul-bjorkstrand commented on issue #6: SLING-7586 - using weak references as cache values to avoid memory leak

2018-05-23 Thread GitBox
paul-bjorkstrand commented on issue #6: SLING-7586 - using weak references as cache values to avoid memory leak URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/6#issuecomment-391569488 Not sure if this is the best approach. If the leak is related to the `adaptableCa

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-23 Thread Daniel Klco
I added the list in, but I'm not 100% sure what all should be included. There are a number of repositories in GitHub which haven't been touched since they were migrated, but that could just be modules that are very basic / stable: https://github.com/search?p=25&q=user%3Aapache+sling&s=updated&type

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-23 Thread Jason E Bailey
The deprecated list is what I was looking at doing. You got that? Or should I? - Jason On Wed, May 23, 2018, at 10:19 AM, Daniel Klco wrote: > I'd be inclined to update the downloads page AND add a depreciation badge. > IMO these are two different use cases, people visiting the downloads site > a

[jira] [Created] (SLING-7678) create gogo command provider for running & building pipe

2018-05-23 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7678: -- Summary: create gogo command provider for running & building pipe Key: SLING-7678 URL: https://issues.apache.org/jira/browse/SLING-7678 Project: Sling Is

[jira] [Commented] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

2018-05-23 Thread Andrei Tuicu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487601#comment-16487601 ] Andrei Tuicu commented on SLING-7677: - Submitted PR: [https://github.com/apache/sling

[jira] [Commented] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487588#comment-16487588 ] ASF GitHub Bot commented on SLING-7677: --- andreituicu commented on issue #1: SLING-76

[jira] [Commented] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

2018-05-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487587#comment-16487587 ] ASF GitHub Bot commented on SLING-7677: --- andreituicu commented on issue #1: SLING-76

[GitHub] andreituicu commented on issue #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired

2018-05-23 Thread GitBox
andreituicu commented on issue #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1#issuecomment-391412489 @rombert @bosschaert : Created JIRA issue, added tests, updated commit and PR title. Thank

[GitHub] andreituicu commented on issue #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired

2018-05-23 Thread GitBox
andreituicu commented on issue #1: SLING-7677 - FeatureJSONWriter uses isOptional instead of isRequired URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1#issuecomment-391412489 @rombert @bosschaert : Created JIRA issue, added tests, updated commit and PR description.

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-23 Thread Bertrand Delacretaz
On Wed, May 23, 2018 at 5:56 PM, Daniel Klco wrote: > ...Shields.io seems to be a pretty common standard for GitHub projects so what > if we just use these rather than self-hosting?... Why not, especially if you need dynamic badges. > Ideally, it'd be great to update our README like this one: >

[jira] [Created] (SLING-7677) FeatureJSONWriter uses isOptional instead of isRequired

2018-05-23 Thread Andrei Tuicu (JIRA)
Andrei Tuicu created SLING-7677: --- Summary: FeatureJSONWriter uses isOptional instead of isRequired Key: SLING-7677 URL: https://issues.apache.org/jira/browse/SLING-7677 Project: Sling Issue Typ

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-23 Thread Daniel Klco
How do these icons work: deprecated -> https://img.shields.io/badge/style-deprecated-lightgrey. svg?longCache=true&style=cool&label=Status contrib -> https://img.shields.io/badge/style-contrib-green.svg? longCache=true&style=cool&label=Status It'd be great if we could also add some dynamic badges

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-23 Thread Bertrand Delacretaz
On Wed, May 23, 2018 at 4:19 PM, Daniel Klco wrote: > ...How does this look for a deprecation list on the downloads page: > > https://imgur.com/a/dYxXKp7 > > Does deprecated seem like the right term? Or obsolete?... Deprecated works for me. -Bertrand

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-23 Thread Robert Munteanu
On Wed, 2018-05-23 at 10:19 -0400, Daniel Klco wrote: > How does this look for a deprecation list on the downloads page: > > https://imgur.com/a/dYxXKp7 +1 > Does deprecated seem like the right term? Or obsolete? Deprecated works for me. Robert

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-23 Thread Daniel Klco
I'd be inclined to update the downloads page AND add a depreciation badge. IMO these are two different use cases, people visiting the downloads site are looking for a bundle to install into their Sling instance whereas people looking at the Github site are looking for the code / to contribute. We s

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-23 Thread Robert Munteanu
On Wed, 2018-05-23 at 15:57 +0200, Bertrand Delacretaz wrote: > On Wed, May 23, 2018 at 9:34 AM, Robert Munteanu > wrote: > > ...That's a very good idea. Would it make sense to add > > "(Deprecated)" or > > "(replaced by ...)" next to this entry?... > > Or add a deprecation badge at [1] ? I thin

Re: deprecated bundles

2018-05-23 Thread Robert Munteanu
On Tue, 2018-05-22 at 12:44 -0400, Jason E Bailey wrote: > I'd like to go ahead and separate them out into a deprecated section > if people are cool with that. +1 Robert

RE: [VOTE] Release Apache Sling Commons Log 5.1.8

2018-05-23 Thread Stefan Seifert
+1

RE: [RESULT] [VOTE] Release Apache Sling Servlets Get 2.1.32

2018-05-23 Thread Stefan Seifert
>If a PMC member can copy this release to the Sling dist directory. I will >promote the artifacts to the central Maven repository and update pages. done - sorry for the delay stefan

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-23 Thread Bertrand Delacretaz
On Wed, May 23, 2018 at 9:34 AM, Robert Munteanu wrote: > ...That's a very good idea. Would it make sense to add "(Deprecated)" or > "(replaced by ...)" next to this entry?... Or add a deprecation badge at [1] ? I meant to use GitHub Topics for such things but we're not allowed to change them, s

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-23 Thread Daniel Klco
Robert, Absolutely, I agree and I think this makes sense with what Jason Bailey brought up with creating a separate list of the deprecated downloads. Regards, Dan On Wed, May 23, 2018 at 3:34 AM, Robert Munteanu wrote: > Hi Dan, > > > > On Tue, 2018-05-22 at 17:01 +, dk...@apache.org wrote

Re: [Dev][GSoC] How to expose a HTML page using a URL

2018-05-23 Thread Daniel Klco
Hasini, You can include content in your bundle similar to how it's done in Starter Content. You create the content in your source folder: https://github.com/apache/sling-org-apache-sling-starter-content/tree/master/src/main/resources/content/content/starter And then use the Sling-Initial-Content

Re: [VOTE] Release Apache Sling Commons Log 5.1.8

2018-05-23 Thread Julian Sedding
I'm missing one binding vote. Anyone? Thanks Julian On Mon, May 21, 2018 at 6:40 AM, Chetan Mehrotra wrote: > +1 > Chetan Mehrotra > > > On Sun, May 20, 2018 at 7:51 PM, Daniel Klco wrote: >> +1 >> >> On Sun, May 20, 2018, 7:23 AM Julian Sedding wrote: >> >>> Here's my +1. >>> >>> Regards >>>

[Dev][GSoC] How to expose a HTML page using a URL

2018-05-23 Thread Hasini Witharana
Hi all, Currently I am working on the GSoC project: OpenID Connect Handler. I have created a dummy login page with a button in html format in the project. I need to expose this page from a URL(e.g: localhost:8080/oidc/login). What is the best way to do this? Thank You. -- *Hasini Witharana* Und

[GitHub] rombert commented on issue #1: trivial - Fix Json Writer for extensions

2018-05-23 Thread GitBox
rombert commented on issue #1: trivial - Fix Json Writer for extensions URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1#issuecomment-391318189 Thanks for the PR @andreituicu . It would be great to get a Jira issue and a test, as this impacts the runtime behaviour. "

[GitHub] andreituicu opened a new pull request #1: trivial - Fix Json Writer for extensions

2018-05-23 Thread GitBox
andreituicu opened a new pull request #1: trivial - Fix Json Writer for extensions URL: https://github.com/apache/sling-org-apache-sling-feature-io/pull/1 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (SLING-7662) Cannot use slingstart-maven-plugin for starting a server only with referencing a launchpad by dependency due to the DependencyLifecycleParticipant

2018-05-23 Thread David Bosschaert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487093#comment-16487093 ] David Bosschaert commented on SLING-7662: - [~kwin] thanks for confirming. Would it

Re: [proposal][scripting console] http API for terminal usage

2018-05-23 Thread Robert Munteanu
On Wed, 2018-05-23 at 11:46 +0200, Nicolas Peltier wrote: > What i'm unclear now is wether we should go the route of a provider > for > scripting in general, or "just" pipe (which is my direct interest), > so > something like a command where first argument specify a context, > second is > the actua

[jira] [Commented] (SLING-7662) Cannot use slingstart-maven-plugin for starting a server only with referencing a launchpad by dependency due to the DependencyLifecycleParticipant

2018-05-23 Thread Konrad Windszus (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487054#comment-16487054 ] Konrad Windszus commented on SLING-7662: [~bosschaert] Thanks for the fix, works f

Re: [proposal][scripting console] http API for terminal usage

2018-05-23 Thread Nicolas Peltier
yes i am, thanks Bertrand! the first proposal is for exposing same scripting capability through gogo (aka implementing a command provider in scripting console project) 2018-05-23 11:58 GMT+02:00 Bertrand Delacretaz : > Hi Nicolas, > > On Mon, May 14, 2018 at 12:05 PM, Nicolas Peltier > wrote: >

Re: [proposal][scripting console] http API for terminal usage

2018-05-23 Thread Bertrand Delacretaz
Hi Nicolas, On Mon, May 14, 2018 at 12:05 PM, Nicolas Peltier wrote: > ...thought about using terminal rather than felix html page for scripting > (when scripting take one line like for pipes, htis might be useful)... Are you aware of https://github.com/apache/sling-org-apache-sling-scripting-co

[jira] [Commented] (SLING-2463) Sling Script Console Plugin

2018-05-23 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-2463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487002#comment-16487002 ] Bertrand Delacretaz commented on SLING-2463: Coming back to this much later..

Re: [proposal][scripting console] http API for terminal usage

2018-05-23 Thread Nicolas Peltier
Thanks for this Robert. It looks like gogo is indeed the way to go (sounds good :-)). What i'm unclear now is wether we should go the route of a provider for scripting in general, or "just" pipe (which is my direct interest), so something like a command where first argument specify a context, seco

[jira] [Commented] (SLING-7242) [Shiny] Sling Website Design

2018-05-23 Thread Nicolas Peltier (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486976#comment-16486976 ] Nicolas Peltier commented on SLING-7242: i'm really impatient to see that live, [~

[jira] [Resolved] (SLING-7662) Cannot use slingstart-maven-plugin for starting a server only with referencing a launchpad by dependency due to the DependencyLifecycleParticipant

2018-05-23 Thread David Bosschaert (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert resolved SLING-7662. - Resolution: Fixed Fix Version/s: Slingstart Maven Plugin 1.8.0 Fixed with https://

Re: Sling Hackathon Sept. 13th, 2018 in Berlin

2018-05-23 Thread Carsten Ziegeler
Count me on for the hackathon Regards Carsten Stefan Seifert wrote > same as last year, we have the possibility to host a "Sling Hackathon" in > berlin in september. > > the date is thursday 13.09.18 which is directly after the adaptTo() which > takes place 10-12.9.18 in potsdam (20min with

Re: [sling-site] branch master updated: Re-adding launchpad content since though it's deprecated, it still may need to be available to download

2018-05-23 Thread Robert Munteanu
Hi Dan, On Tue, 2018-05-22 at 17:01 +, dk...@apache.org wrote: > commit d94aef441bf10e047f5af0038538e0dde1c92082 > Author: Dan Klco > AuthorDate: Tue May 22 13:00:59 2018 -0400 > > Re-adding launchpad content since though it's deprecated, it > still may need to be available to download

[jira] [Commented] (SLING-7242) [Shiny] Sling Website Design

2018-05-23 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486854#comment-16486854 ] Bertrand Delacretaz commented on SLING-7242: Thank you Chris, looks great! The