Re: Release of Sling Kickstart and Sling FAR file
The "archive" configuration for the feature archive has a boolean "attach" property defaulting to true. If you set it to false, the FAR will not be attached to the project. Regards Carsten Am 24.06.2020 um 20:55 schrieb Andreas Schaefer: Hi While I was doing the release of Sling Kickstart 0.0.6 after removing the FAR file from the Git Repo I discovered that we have both the Sling Kickstart JAR file (the artifact) but also Sling Kickstart FAR file and both are about 80MB. Now the Sling Kickstart needs to be this big and it goes along with Sling Starter which is about 70GB. That said I do not think we need the Sling FAR file to be in the Maven repository but that is done automatically because the creation of the FAR file will place it in the local Maven repositories and hence install it during the release. If the Sling FAR file should not be placed into the repository then I think we need to adjust the way we create the FAR file. I have no problem redoing the release so let me know what you guys want to do with the FAR files. Cheers - Andy -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Commented] (SLING-8946) Non-deterministic shadowing of resource observation
[ https://issues.apache.org/jira/browse/SLING-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144645#comment-17144645 ] Carsten Ziegeler commented on SLING-8946: - [~rombert] I have no idea, that's why I repeatedly asked. Especially if we take the comments from SLING-9040 into account it gets even more confusing where failing tests have been mentioned - but we don't have any strong confirmation that they are solved now. > Non-deterministic shadowing of resource observation > --- > > Key: SLING-8946 > URL: https://issues.apache.org/jira/browse/SLING-8946 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.5.34 >Reporter: Dirk Rudolph >Assignee: Robert Munteanu >Priority: Critical > Fix For: Resource Resolver 1.6.18 > > Attachments: PerformanceScript.sh > > Time Spent: 1.5h > Remaining Estimate: 0h > > The BasicObservationReporter implements shadowing of events being propagated > per ResourceProvider instance [1]. Assuming we do have 2 ResourceProviders > registered, where the one shadows the other like this: > - RP A registered on / > - RP B registered on /path > then currently the excludes given to the BasicObservationReporter are > different depending on either RP A or RP B gets registered first: > - RP A before RP B => excludes are empty > - RP B before RP A => excludes contain /path > This is because only the newly registered RP gets its ProviderContext updated > [2] > Same applies if RP B is registered before RP A and gets unregistered. In that > case the ObservationReporter of RP A stays untouched. > [1] > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/observation/BasicObservationReporter.java#L102] > [2] > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/providers/ResourceProviderTracker.java#L358] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9549) Pin dependencies in o.a.s.launchpad.integration-tests
[ https://issues.apache.org/jira/browse/SLING-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-9549. Resolution: Fixed More fixes with [sling-org-apache-sling-launchpad-integration-tests commit 95ffc1c|https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/commit/95ffc1c]. > Pin dependencies in o.a.s.launchpad.integration-tests > - > > Key: SLING-9549 > URL: https://issues.apache.org/jira/browse/SLING-9549 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Launchpad Integration Tests 12 > > > The current integration-tests module contains a mixture of dependencies that > are conflicting. Maven resolves them mostly fine, but fails with: > - jackrabbit versions > - httpclient 4.x versions > This has no impact when running with a classpath that is enriched via the > provisioning model, but fails running with the feature model. > The key dependencies should be pinned instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (SLING-9549) Pin dependencies in o.a.s.launchpad.integration-tests
[
https://issues.apache.org/jira/browse/SLING-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reopened SLING-9549:
Some Jackrabbit dependencies are still not aligned, causing IT failures on Java
11:
{noformat}Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0 s
<<< FAILURE! - in
org.apache.sling.launchpad.webapp.integrationtest.DavExIntegrationTest
testDescriptor(org.apache.sling.launchpad.webapp.integrationtest.DavExIntegrationTest)
Time elapsed: 0 s <<< ERROR!
java.lang.IllegalArgumentException: javax.jcr.RepositoryFactory is not an
ImageIO SPI class
at
org.apache.sling.launchpad.webapp.integrationtest.DavExIntegrationTest.setUp(DavExIntegrationTest.java:47)
{noformat}
> Pin dependencies in o.a.s.launchpad.integration-tests
> -
>
> Key: SLING-9549
> URL: https://issues.apache.org/jira/browse/SLING-9549
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Launchpad Integration Tests 12
>
>
> The current integration-tests module contains a mixture of dependencies that
> are conflicting. Maven resolves them mostly fine, but fails with:
> - jackrabbit versions
> - httpclient 4.x versions
> This has no impact when running with a classpath that is enriched via the
> provisioning model, but fails running with the feature model.
> The key dependencies should be pinned instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] removed a comment on pull request #1: [SLING-9417] Added test for an nt:file child of a versioned node
sonarcloud[bot] removed a comment on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/1#issuecomment-647070558 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list) The version of Java (1.8.0_241) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-launchpad-integration-tests] sonarcloud[bot] commented on pull request #1: [SLING-9417] Added test for an nt:file child of a versioned node
sonarcloud[bot] commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/pull/1#issuecomment-649099623 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-launchpad-integration-tests=1=new_duplicated_lines_density=list) The version of Java (1.8.0_241) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-9549) Pin dependencies in o.a.s.launchpad.integration-tests
[ https://issues.apache.org/jira/browse/SLING-9549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-9549. Resolution: Fixed Fixed with [sling-org-apache-sling-launchpad-integration-tests commit a221fa6|https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/commit/a221fa6] > Pin dependencies in o.a.s.launchpad.integration-tests > - > > Key: SLING-9549 > URL: https://issues.apache.org/jira/browse/SLING-9549 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Launchpad Integration Tests 12 > > > The current integration-tests module contains a mixture of dependencies that > are conflicting. Maven resolves them mostly fine, but fails with: > - jackrabbit versions > - httpclient 4.x versions > This has no impact when running with a classpath that is enriched via the > provisioning model, but fails running with the feature model. > The key dependencies should be pinned instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9549) Pin dependencies in o.a.s.launchpad.integration-tests
Robert Munteanu created SLING-9549: -- Summary: Pin dependencies in o.a.s.launchpad.integration-tests Key: SLING-9549 URL: https://issues.apache.org/jira/browse/SLING-9549 Project: Sling Issue Type: Improvement Components: Testing Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Launchpad Integration Tests 12 The current integration-tests module contains a mixture of dependencies that are conflicting. Maven resolves them mostly fine, but fails with: - jackrabbit versions - httpclient 4.x versions This has no impact when running with a classpath that is enriched via the provisioning model, but fails running with the feature model. The key dependencies should be pinned instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9548) Remove support for o.a.s.jcr.jackrabbit.server from o.a.s.launchpad-test-services
[ https://issues.apache.org/jira/browse/SLING-9548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-9548. Resolution: Fixed Fixed with [sling-org-apache-sling-launchpad-test-services commit d5a3560|https://github.com/apache/sling-org-apache-sling-launchpad-test-services/commit/d5a3560]. > Remove support for o.a.s.jcr.jackrabbit.server from > o.a.s.launchpad-test-services > - > > Key: SLING-9548 > URL: https://issues.apache.org/jira/browse/SLING-9548 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Launchpad Test Services 12 > > > The test services have not been used in the plain Jackrabbit context since we > migrated to Oak. Since the test services are also used as dependencies to > test projects, this messes up the classpath. The effect is visible when > switching to the feature model, as the dependencies from the feature model > files are no longer automatically imported to the current project. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9548) Remove support for o.a.s.jcr.jackrabbit.server from o.a.s.launchpad-test-services
Robert Munteanu created SLING-9548: -- Summary: Remove support for o.a.s.jcr.jackrabbit.server from o.a.s.launchpad-test-services Key: SLING-9548 URL: https://issues.apache.org/jira/browse/SLING-9548 Project: Sling Issue Type: Improvement Components: Testing Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Launchpad Test Services 12 The test services have not been used in the plain Jackrabbit context since we migrated to Oak. Since the test services are also used as dependencies to test projects, this messes up the classpath. The effect is visible when switching to the feature model, as the dependencies from the feature model files are no longer automatically imported to the current project. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-whiteboard] rombert merged pull request #64: SLING-9526 - Allow launching feature model applications in external processes, non-blocking
rombert merged pull request #64: URL: https://github.com/apache/sling-whiteboard/pull/64 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] rombert commented on a change in pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11
rombert commented on a change in pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#discussion_r445181864 ## File path: saml-handler/README.md ## @@ -1,43 +1,140 @@ # Apache Sling SAML2 Handler (NOT FOR PRODUCTION) -This project is intended to be a contribution to the [Apache Sling](https://sling.apache.org) project; - it has a SAML2 Service Provider Authentication Handler and the associated SAML2 servlets and utilities. It is a work in progress and not production ready! +This contribution to the [Apache Sling](https://sling.apache.org) project; + provides a SAML2 Web Profile Service Provider Authentication. + ## Overview https://en.wikipedia.org/wiki/SAML_2.0 * The SAMLRequest uses HTTP Redirect Binding, and the contained Authn Request object instructs the IDP to use HTTP Post Binding.  - -## Features -Sling applications to authenticate users against Identity Providers (idp) -such as Keycloak or Shibboleth using SAML2 protocols. + +Sling applications may authenticate users against an Identity Provider (idp) +such as Keycloak Server or Shibboleth IDP. + +### Requirements +- Java 11 +- Sling 11 or 12 +- The bundle will not activate without [org.apache.jackrabbit.oak-auth-external](https://mvnrepository.com/artifact/org.apache.jackrabbit/oak-auth-external) +- An external SAML2 identity provider + + + +### User Management +User management is based on the OSGi bundle configuration and SAML2 Assertion + - Upon successful authentication, a user is created + - The user may be added to a JCR group membership under certain conditions: +- An OSGI config is set `saml2groupMembershipAttr` with the value of the group membership attribute +- The users' assertion contains an attribute where the key is value of `saml2groupMembershipAttr` and the attribute value is an existing JCR group. + Note that if the assertion group membership attribute value contains values that are not existing JCR groups, then the value is ignored. + - Other user attributes from the assertion may be configured. This allows profile properties such as given name, family name, email, and phone which are leased by the Identity Provider and added to the JCR User's properties. Such attributes are configured by setting `syncAttrs` to the corresponding attribute keys. + + + + +## Localhost Setup +Procedure for localhost testing + +### Start and Configure an External Identity Provider +1. Start a Keycloak Server +`docker run -p 8484:8080 -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=admin quay.io/keycloak/keycloak:10.0.2` +2. Login using http://localhost:8484/auth/admin/ + - username: admin, password: admin +3. Configure a Realm + - Click "Add Realm" + - Select the file located at `saml-handler/src/main/resources/sling-realm-export.json` + +Note. The preconfigured realm contains configuration for the client and the groups, but does not contain users. +4. Add user(s) + - Select Users under the "Sling" Realm +  + - Set user attributes +  + - Set user password +  + - Set user groups +  + + + + +### Sling SAML2 Service Provider Setup + +1. Start Sling +2. Use Felix "/system/console" to install bundle [org.apache.jackrabbit.oak-auth-external](https://mvnrepository.com/artifact/org.apache.jackrabbit/oak-auth-external) corresponding to the JCR Oak version in your instance (e.g. 1.26.0) +3. Run `mvn clean install -P autoInstallBundle` to the SAML2 Bundle. Verify the state is Active +4. Use Composum to install the localhost test package "src/main/resources/localhostExample-1.zip" Review comment: For content packages I would suggest the WCMIO one, I've used it successfullly with Sling. I think the Adobe-provided ones only work with the CRX Package Manager (not 100% sure). For JKS, would it be possible to generate it with a shell script? That script can then be added to the repository. For context, I think there are three main issues with checking in binaries: - repository bloat ( but it's ok for files under 10 KB ) ; they are checked in as they are, and git won't be able to generate meaningful diffs - unable to track changes made to them - hard to understand how they were created; instructions can be added, but they can diverge. (And BTW, sorry for jumping on this, I just saw now that it's marked as a draft) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at:
[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #64: SLING-9526 - Allow launching feature model applications in external processes, non-blocking
sonarcloud[bot] commented on pull request #64: URL: https://github.com/apache/sling-whiteboard/pull/64#issuecomment-649079677 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=64=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=64=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=64=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=64=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=64=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=64=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=64=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=64=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=64=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=64=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=64=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=64=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=64=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=64=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=64=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] rombert opened a new pull request #64: SLING-9526 - Allow launching feature model applications in external processes, non-blocking
rombert opened a new pull request #64: URL: https://github.com/apache/sling-whiteboard/pull/64 Switch to Java 8 as we still need to run the Sling ITs with that version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] cmrockwell commented on a change in pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11
cmrockwell commented on a change in pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#discussion_r445175401 ## File path: saml-handler/README.md ## @@ -1,43 +1,140 @@ # Apache Sling SAML2 Handler (NOT FOR PRODUCTION) -This project is intended to be a contribution to the [Apache Sling](https://sling.apache.org) project; - it has a SAML2 Service Provider Authentication Handler and the associated SAML2 servlets and utilities. It is a work in progress and not production ready! +This contribution to the [Apache Sling](https://sling.apache.org) project; + provides a SAML2 Web Profile Service Provider Authentication. + ## Overview https://en.wikipedia.org/wiki/SAML_2.0 * The SAMLRequest uses HTTP Redirect Binding, and the contained Authn Request object instructs the IDP to use HTTP Post Binding.  - -## Features -Sling applications to authenticate users against Identity Providers (idp) -such as Keycloak or Shibboleth using SAML2 protocols. + +Sling applications may authenticate users against an Identity Provider (idp) +such as Keycloak Server or Shibboleth IDP. + +### Requirements +- Java 11 +- Sling 11 or 12 +- The bundle will not activate without [org.apache.jackrabbit.oak-auth-external](https://mvnrepository.com/artifact/org.apache.jackrabbit/oak-auth-external) +- An external SAML2 identity provider + + + +### User Management +User management is based on the OSGi bundle configuration and SAML2 Assertion + - Upon successful authentication, a user is created + - The user may be added to a JCR group membership under certain conditions: +- An OSGI config is set `saml2groupMembershipAttr` with the value of the group membership attribute +- The users' assertion contains an attribute where the key is value of `saml2groupMembershipAttr` and the attribute value is an existing JCR group. + Note that if the assertion group membership attribute value contains values that are not existing JCR groups, then the value is ignored. + - Other user attributes from the assertion may be configured. This allows profile properties such as given name, family name, email, and phone which are leased by the Identity Provider and added to the JCR User's properties. Such attributes are configured by setting `syncAttrs` to the corresponding attribute keys. + + + + +## Localhost Setup +Procedure for localhost testing + +### Start and Configure an External Identity Provider +1. Start a Keycloak Server +`docker run -p 8484:8080 -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=admin quay.io/keycloak/keycloak:10.0.2` +2. Login using http://localhost:8484/auth/admin/ + - username: admin, password: admin +3. Configure a Realm + - Click "Add Realm" + - Select the file located at `saml-handler/src/main/resources/sling-realm-export.json` + +Note. The preconfigured realm contains configuration for the client and the groups, but does not contain users. +4. Add user(s) + - Select Users under the "Sling" Realm +  + - Set user attributes +  + - Set user password +  + - Set user groups +  + + + + +### Sling SAML2 Service Provider Setup + +1. Start Sling +2. Use Felix "/system/console" to install bundle [org.apache.jackrabbit.oak-auth-external](https://mvnrepository.com/artifact/org.apache.jackrabbit/oak-auth-external) corresponding to the JCR Oak version in your instance (e.g. 1.26.0) +3. Run `mvn clean install -P autoInstallBundle` to the SAML2 Bundle. Verify the state is Active +4. Use Composum to install the localhost test package "src/main/resources/localhostExample-1.zip" Review comment: What Maven plugin do you recommend for building content packages? https://wcm.io/tooling/maven/plugins/wcmio-content-package-maven-plugin/ or https://helpx.adobe.com/experience-manager/6-3/sites/developing/using/vlt-mavenplugin.html or something else? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] rombert merged pull request #63: SLING-9526 - Allow launching feature model applications in external processes, non-blocking
rombert merged pull request #63: URL: https://github.com/apache/sling-whiteboard/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #63: SLING-9526 - Allow launching feature model applications in external processes, non-blocking
sonarcloud[bot] commented on pull request #63: URL: https://github.com/apache/sling-whiteboard/pull/63#issuecomment-649064204 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=63=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=63=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=63=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=63=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=63=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=63=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=63=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=63=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=63=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=63=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=63=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=63=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=63=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=63=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] rombert opened a new pull request #63: SLING-9526 - Allow launching feature model applications in external processes, non-blocking
rombert opened a new pull request #63: URL: https://github.com/apache/sling-whiteboard/pull/63 Include the feature-launcher-maven-plugin in the reactor This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] cmrockwell commented on a change in pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11
cmrockwell commented on a change in pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#discussion_r445147208 ## File path: saml-handler/README.md ## @@ -1,43 +1,140 @@ # Apache Sling SAML2 Handler (NOT FOR PRODUCTION) -This project is intended to be a contribution to the [Apache Sling](https://sling.apache.org) project; - it has a SAML2 Service Provider Authentication Handler and the associated SAML2 servlets and utilities. It is a work in progress and not production ready! +This contribution to the [Apache Sling](https://sling.apache.org) project; + provides a SAML2 Web Profile Service Provider Authentication. + ## Overview https://en.wikipedia.org/wiki/SAML_2.0 * The SAMLRequest uses HTTP Redirect Binding, and the contained Authn Request object instructs the IDP to use HTTP Post Binding.  - -## Features -Sling applications to authenticate users against Identity Providers (idp) -such as Keycloak or Shibboleth using SAML2 protocols. + +Sling applications may authenticate users against an Identity Provider (idp) +such as Keycloak Server or Shibboleth IDP. + +### Requirements +- Java 11 +- Sling 11 or 12 +- The bundle will not activate without [org.apache.jackrabbit.oak-auth-external](https://mvnrepository.com/artifact/org.apache.jackrabbit/oak-auth-external) +- An external SAML2 identity provider + + + +### User Management +User management is based on the OSGi bundle configuration and SAML2 Assertion + - Upon successful authentication, a user is created + - The user may be added to a JCR group membership under certain conditions: +- An OSGI config is set `saml2groupMembershipAttr` with the value of the group membership attribute +- The users' assertion contains an attribute where the key is value of `saml2groupMembershipAttr` and the attribute value is an existing JCR group. + Note that if the assertion group membership attribute value contains values that are not existing JCR groups, then the value is ignored. + - Other user attributes from the assertion may be configured. This allows profile properties such as given name, family name, email, and phone which are leased by the Identity Provider and added to the JCR User's properties. Such attributes are configured by setting `syncAttrs` to the corresponding attribute keys. + + + + +## Localhost Setup +Procedure for localhost testing + +### Start and Configure an External Identity Provider +1. Start a Keycloak Server +`docker run -p 8484:8080 -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=admin quay.io/keycloak/keycloak:10.0.2` +2. Login using http://localhost:8484/auth/admin/ + - username: admin, password: admin +3. Configure a Realm + - Click "Add Realm" + - Select the file located at `saml-handler/src/main/resources/sling-realm-export.json` + +Note. The preconfigured realm contains configuration for the client and the groups, but does not contain users. +4. Add user(s) + - Select Users under the "Sling" Realm +  + - Set user attributes +  + - Set user password +  + - Set user groups +  + + + + +### Sling SAML2 Service Provider Setup + +1. Start Sling +2. Use Felix "/system/console" to install bundle [org.apache.jackrabbit.oak-auth-external](https://mvnrepository.com/artifact/org.apache.jackrabbit/oak-auth-external) corresponding to the JCR Oak version in your instance (e.g. 1.26.0) +3. Run `mvn clean install -P autoInstallBundle` to the SAML2 Bundle. Verify the state is Active +4. Use Composum to install the localhost test package "src/main/resources/localhostExample-1.zip" Review comment: For JCR Packages I can do as you suggest. I was just about to add another binary of a JKS to test signing and encryption. Similar to this https://bitbucket.org/srasmusson/webprofile-ref-project-v3/src/master/src/main/resources/ Used here https://bitbucket.org/srasmusson/webprofile-ref-project-v3/src/master/src/main/java/no/steras/opensamlbook/sp/SPCredentials.java I want to use this JKS for unit tests. I prefer to keep the JKS out of the JCR repository instead getting it from the file system. What would you suggest? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144257#comment-17144257 ] Roy Teeuwen commented on SLING-7768: [~rombert] ok perfect because I also had to build a workaround for that specific issue two years ago when upgrading to AEM 6.3, would be nice to have that fixed! > Add String Interpolation support to /etc/map > > > Key: SLING-7768 > URL: https://issues.apache.org/jira/browse/SLING-7768 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver > Environment: Sling 11-SNAPSHOT, JDK 1.8 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Resource Resolver 1.6.18 > > Attachments: Screenshot 2018-07-06 11.41.58.png, Screenshot > 2018-07-06 11.42.41.png, Screenshot 2018-07-06 11.43.34.png > > > Having worked on migrations of a Sling derivate Ruben & I ran into issues > where the /etc/map would map to production instead of testing environment. > Many big customer have extensive /etc/maps and also many different > environments like dev, qa, staging, prod etc. > It would be great to have a tool where for example items like the host name > or external links in /etc/map could be configured outside so that just one > entry has to adjusted rather than creating a full copy of the /etc/map tree. > > Example: > > /etc/map/http/phv.fq.host.name.8080 > > Placeholder provides: > DEV: phv.fq.host.name=localhost > QA: phv.fq.host.name=qa.author.acme.com > STAGING: > phv.fq.host.name=[staging.author.acme.com|http://staging.author.acme.com/] > PROD: phv.fq.host.name=[acme.com|http://acme.com/] > > At runtime these are the resolved values: > DEV: http/localhost.8080 > QA: http/qa.author.acme.com.8080 > STAGING: http/[staging.author.acme.com|http://staging.author.acme.com/].8080 > PROD: http/[acme.com|http://acme.com/].8080 > > Not only does that make it easier and faster to create new test environments > but it also cuts down on the chance of copy-n-paste errors. > > I have a working POC with an PlaceholderProvider OSGi service and an > enhanced MapEntries that resolved any placeholders if found. > > Attached are 3 screenshots: > 1. OSGi Placeholder Provider Configuration > 2. /etc/map (Composum) > 3. Result of [http://andreass.local:8080/] call -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-whiteboard] cmrockwell commented on a change in pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11
cmrockwell commented on a change in pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#discussion_r445133924 ## File path: saml-handler/META-INF/NOTICE ## @@ -0,0 +1,11 @@ + Review comment: Good catch. This was not intentional. I made a mistake somewhere probably with git rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] cmrockwell commented on a change in pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11
cmrockwell commented on a change in pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#discussion_r445131948 ## File path: saml-handler/src/main/java/org/apache/sling/auth/saml2/AuthenticationHandlerSAML2Config.java ## @@ -15,6 +15,8 @@ * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. + * + * Contributed by Cris Rockwell and the Regents of the University of Michigan. Review comment: Ok. I can remove it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-8946) Non-deterministic shadowing of resource observation
[ https://issues.apache.org/jira/browse/SLING-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144244#comment-17144244 ] Robert Munteanu commented on SLING-8946: [~cziegeler] [~diru] [~karlpauls] - I am not sure where we stand here. Dirk mentioned that SLING-9365 actually fixed the performance problem. On the other hand, I see Karl mentioning a configurable property in that issue. Is there a scenario where the performance problems will come up if we release the Resource Resolver bundle as-is now? > Non-deterministic shadowing of resource observation > --- > > Key: SLING-8946 > URL: https://issues.apache.org/jira/browse/SLING-8946 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.5.34 >Reporter: Dirk Rudolph >Assignee: Robert Munteanu >Priority: Critical > Fix For: Resource Resolver 1.6.18 > > Attachments: PerformanceScript.sh > > Time Spent: 1.5h > Remaining Estimate: 0h > > The BasicObservationReporter implements shadowing of events being propagated > per ResourceProvider instance [1]. Assuming we do have 2 ResourceProviders > registered, where the one shadows the other like this: > - RP A registered on / > - RP B registered on /path > then currently the excludes given to the BasicObservationReporter are > different depending on either RP A or RP B gets registered first: > - RP A before RP B => excludes are empty > - RP B before RP A => excludes contain /path > This is because only the newly registered RP gets its ProviderContext updated > [2] > Same applies if RP B is registered before RP A and gets unregistered. In that > case the ObservationReporter of RP A stays untouched. > [1] > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/observation/BasicObservationReporter.java#L102] > [2] > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/providers/ResourceProviderTracker.java#L358] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144240#comment-17144240 ] Robert Munteanu commented on SLING-7768: [~royteeuwen] - I see SLING-8946 is still open and I consider it a blocker. Will try to clarify whether it's indeed fixed or not. > Add String Interpolation support to /etc/map > > > Key: SLING-7768 > URL: https://issues.apache.org/jira/browse/SLING-7768 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver > Environment: Sling 11-SNAPSHOT, JDK 1.8 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Resource Resolver 1.6.18 > > Attachments: Screenshot 2018-07-06 11.41.58.png, Screenshot > 2018-07-06 11.42.41.png, Screenshot 2018-07-06 11.43.34.png > > > Having worked on migrations of a Sling derivate Ruben & I ran into issues > where the /etc/map would map to production instead of testing environment. > Many big customer have extensive /etc/maps and also many different > environments like dev, qa, staging, prod etc. > It would be great to have a tool where for example items like the host name > or external links in /etc/map could be configured outside so that just one > entry has to adjusted rather than creating a full copy of the /etc/map tree. > > Example: > > /etc/map/http/phv.fq.host.name.8080 > > Placeholder provides: > DEV: phv.fq.host.name=localhost > QA: phv.fq.host.name=qa.author.acme.com > STAGING: > phv.fq.host.name=[staging.author.acme.com|http://staging.author.acme.com/] > PROD: phv.fq.host.name=[acme.com|http://acme.com/] > > At runtime these are the resolved values: > DEV: http/localhost.8080 > QA: http/qa.author.acme.com.8080 > STAGING: http/[staging.author.acme.com|http://staging.author.acme.com/].8080 > PROD: http/[acme.com|http://acme.com/].8080 > > Not only does that make it easier and faster to create new test environments > but it also cuts down on the chance of copy-n-paste errors. > > I have a working POC with an PlaceholderProvider OSGi service and an > enhanced MapEntries that resolved any placeholders if found. > > Attached are 3 screenshots: > 1. OSGi Placeholder Provider Configuration > 2. /etc/map (Composum) > 3. Result of [http://andreass.local:8080/] call -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-whiteboard] rombert commented on a change in pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11
rombert commented on a change in pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#discussion_r445126359 ## File path: saml-handler/README.md ## @@ -1,43 +1,140 @@ # Apache Sling SAML2 Handler (NOT FOR PRODUCTION) -This project is intended to be a contribution to the [Apache Sling](https://sling.apache.org) project; - it has a SAML2 Service Provider Authentication Handler and the associated SAML2 servlets and utilities. It is a work in progress and not production ready! +This contribution to the [Apache Sling](https://sling.apache.org) project; + provides a SAML2 Web Profile Service Provider Authentication. + ## Overview https://en.wikipedia.org/wiki/SAML_2.0 * The SAMLRequest uses HTTP Redirect Binding, and the contained Authn Request object instructs the IDP to use HTTP Post Binding.  - -## Features -Sling applications to authenticate users against Identity Providers (idp) -such as Keycloak or Shibboleth using SAML2 protocols. + +Sling applications may authenticate users against an Identity Provider (idp) +such as Keycloak Server or Shibboleth IDP. + +### Requirements +- Java 11 +- Sling 11 or 12 +- The bundle will not activate without [org.apache.jackrabbit.oak-auth-external](https://mvnrepository.com/artifact/org.apache.jackrabbit/oak-auth-external) +- An external SAML2 identity provider + + + +### User Management +User management is based on the OSGi bundle configuration and SAML2 Assertion + - Upon successful authentication, a user is created + - The user may be added to a JCR group membership under certain conditions: +- An OSGI config is set `saml2groupMembershipAttr` with the value of the group membership attribute +- The users' assertion contains an attribute where the key is value of `saml2groupMembershipAttr` and the attribute value is an existing JCR group. + Note that if the assertion group membership attribute value contains values that are not existing JCR groups, then the value is ignored. + - Other user attributes from the assertion may be configured. This allows profile properties such as given name, family name, email, and phone which are leased by the Identity Provider and added to the JCR User's properties. Such attributes are configured by setting `syncAttrs` to the corresponding attribute keys. + + + + +## Localhost Setup +Procedure for localhost testing + +### Start and Configure an External Identity Provider +1. Start a Keycloak Server +`docker run -p 8484:8080 -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=admin quay.io/keycloak/keycloak:10.0.2` +2. Login using http://localhost:8484/auth/admin/ Review comment: FYI, for follow-up PRs, you can experiment with auto-importing realms as described at https://hub.docker.com/r/jboss/keycloak/, in the _Importing a realm_ section. I noticed the docker images are different. (Not a high-priority item for me, but might make testing more streamlined for everyone looking into this.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] rombert commented on a change in pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11
rombert commented on a change in pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#discussion_r445120968 ## File path: saml-handler/META-INF/NOTICE ## @@ -0,0 +1,11 @@ + Review comment: Isn't this handled through the pom mechanism? If I run `mvn clean package` in the code from the Sling Whiteboard, I get a proper notice in the packaged jar. ## File path: saml-handler/src/main/java/org/apache/sling/auth/saml2/AuthenticationHandlerSAML2Config.java ## @@ -15,6 +15,8 @@ * KIND, either express or implied. See the License for the * specific language governing permissions and limitations * under the License. + * + * Contributed by Cris Rockwell and the Regents of the University of Michigan. Review comment: I don't believe this belongs in the license header. Attribution is done using the git author field. ## File path: saml-handler/README.md ## @@ -1,43 +1,140 @@ # Apache Sling SAML2 Handler (NOT FOR PRODUCTION) -This project is intended to be a contribution to the [Apache Sling](https://sling.apache.org) project; - it has a SAML2 Service Provider Authentication Handler and the associated SAML2 servlets and utilities. It is a work in progress and not production ready! +This contribution to the [Apache Sling](https://sling.apache.org) project; + provides a SAML2 Web Profile Service Provider Authentication. + ## Overview https://en.wikipedia.org/wiki/SAML_2.0 * The SAMLRequest uses HTTP Redirect Binding, and the contained Authn Request object instructs the IDP to use HTTP Post Binding.  - -## Features -Sling applications to authenticate users against Identity Providers (idp) -such as Keycloak or Shibboleth using SAML2 protocols. + +Sling applications may authenticate users against an Identity Provider (idp) +such as Keycloak Server or Shibboleth IDP. + +### Requirements +- Java 11 +- Sling 11 or 12 +- The bundle will not activate without [org.apache.jackrabbit.oak-auth-external](https://mvnrepository.com/artifact/org.apache.jackrabbit/oak-auth-external) +- An external SAML2 identity provider + + + +### User Management +User management is based on the OSGi bundle configuration and SAML2 Assertion + - Upon successful authentication, a user is created + - The user may be added to a JCR group membership under certain conditions: +- An OSGI config is set `saml2groupMembershipAttr` with the value of the group membership attribute +- The users' assertion contains an attribute where the key is value of `saml2groupMembershipAttr` and the attribute value is an existing JCR group. + Note that if the assertion group membership attribute value contains values that are not existing JCR groups, then the value is ignored. + - Other user attributes from the assertion may be configured. This allows profile properties such as given name, family name, email, and phone which are leased by the Identity Provider and added to the JCR User's properties. Such attributes are configured by setting `syncAttrs` to the corresponding attribute keys. + + + + +## Localhost Setup +Procedure for localhost testing + +### Start and Configure an External Identity Provider +1. Start a Keycloak Server +`docker run -p 8484:8080 -e KEYCLOAK_USER=admin -e KEYCLOAK_PASSWORD=admin quay.io/keycloak/keycloak:10.0.2` +2. Login using http://localhost:8484/auth/admin/ + - username: admin, password: admin +3. Configure a Realm + - Click "Add Realm" + - Select the file located at `saml-handler/src/main/resources/sling-realm-export.json` + +Note. The preconfigured realm contains configuration for the client and the groups, but does not contain users. +4. Add user(s) + - Select Users under the "Sling" Realm +  + - Set user attributes +  + - Set user password +  + - Set user groups +  + + + + +### Sling SAML2 Service Provider Setup + +1. Start Sling +2. Use Felix "/system/console" to install bundle [org.apache.jackrabbit.oak-auth-external](https://mvnrepository.com/artifact/org.apache.jackrabbit/oak-auth-external) corresponding to the JCR Oak version in your instance (e.g. 1.26.0) +3. Run `mvn clean install -P autoInstallBundle` to the SAML2 Bundle. Verify the state is Active +4. Use Composum to install the localhost test package "src/main/resources/localhostExample-1.zip" Review comment: (adding here because I can't comment on the file itself, as it's a zip). Please don't check in binaries to git. Content packages can be generated using Maven, and the simplest way is to add another project here. If that's too inconvenient, maybe add them as a separate directory and instruct the user
Release of Sling Kickstart and Sling FAR file
Hi While I was doing the release of Sling Kickstart 0.0.6 after removing the FAR file from the Git Repo I discovered that we have both the Sling Kickstart JAR file (the artifact) but also Sling Kickstart FAR file and both are about 80MB. Now the Sling Kickstart needs to be this big and it goes along with Sling Starter which is about 70GB. That said I do not think we need the Sling FAR file to be in the Maven repository but that is done automatically because the creation of the FAR file will place it in the local Maven repositories and hence install it during the release. If the Sling FAR file should not be placed into the repository then I think we need to adjust the way we create the FAR file. I have no problem redoing the release so let me know what you guys want to do with the FAR files. Cheers - Andy
[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11
sonarcloud[bot] commented on pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#issuecomment-648983478 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_duplicated_lines_density=list) [4.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] sonarcloud[bot] removed a comment on pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11
sonarcloud[bot] removed a comment on pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#issuecomment-648942671 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144104#comment-17144104 ] Roy Teeuwen commented on SLING-7768: any ETA on a release date for this? > Add String Interpolation support to /etc/map > > > Key: SLING-7768 > URL: https://issues.apache.org/jira/browse/SLING-7768 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver > Environment: Sling 11-SNAPSHOT, JDK 1.8 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Resource Resolver 1.6.18 > > Attachments: Screenshot 2018-07-06 11.41.58.png, Screenshot > 2018-07-06 11.42.41.png, Screenshot 2018-07-06 11.43.34.png > > > Having worked on migrations of a Sling derivate Ruben & I ran into issues > where the /etc/map would map to production instead of testing environment. > Many big customer have extensive /etc/maps and also many different > environments like dev, qa, staging, prod etc. > It would be great to have a tool where for example items like the host name > or external links in /etc/map could be configured outside so that just one > entry has to adjusted rather than creating a full copy of the /etc/map tree. > > Example: > > /etc/map/http/phv.fq.host.name.8080 > > Placeholder provides: > DEV: phv.fq.host.name=localhost > QA: phv.fq.host.name=qa.author.acme.com > STAGING: > phv.fq.host.name=[staging.author.acme.com|http://staging.author.acme.com/] > PROD: phv.fq.host.name=[acme.com|http://acme.com/] > > At runtime these are the resolved values: > DEV: http/localhost.8080 > QA: http/qa.author.acme.com.8080 > STAGING: http/[staging.author.acme.com|http://staging.author.acme.com/].8080 > PROD: http/[acme.com|http://acme.com/].8080 > > Not only does that make it easier and faster to create new test environments > but it also cuts down on the chance of copy-n-paste errors. > > I have a working POC with an PlaceholderProvider OSGi service and an > enhanced MapEntries that resolved any placeholders if found. > > Attached are 3 screenshots: > 1. OSGi Placeholder Provider Configuration > 2. /etc/map (Composum) > 3. Result of [http://andreass.local:8080/] call -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11
sonarcloud[bot] commented on pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62#issuecomment-648942671 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=62=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=62=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] cmrockwell opened a new pull request #62: Saml2 auth handler/upgrade sling12 open samlv4 java11
cmrockwell opened a new pull request #62: URL: https://github.com/apache/sling-whiteboard/pull/62 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] cmrockwell commented on pull request #60: Saml2 auth handler/upgrade sling12 open samlv4 java11
cmrockwell commented on pull request #60: URL: https://github.com/apache/sling-whiteboard/pull/60#issuecomment-648921173 I'm going to close #60 and try the build again with #61 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] cmrockwell closed pull request #60: Saml2 auth handler/upgrade sling12 open samlv4 java11
cmrockwell closed pull request #60: URL: https://github.com/apache/sling-whiteboard/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143852#comment-17143852
]
Robert Munteanu commented on SLING-9545:
Glad to hear you got it working!
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png, Screen Shot
> 2020-06-24 at 8.38.26 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Created] (SLING-9547) markdown renderer for pipe configurations
Nicolas Peltier created SLING-9547: -- Summary: markdown renderer for pipe configurations Key: SLING-9547 URL: https://issues.apache.org/jira/browse/SLING-9547 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Pipes 3.2.0 Reporter: Nicolas Peltier it's often pretty difficult to read what a pipe is doing by looking at JCR serialization. This is for generating markdown out of a pipe so it's easy to read what it's doing in a browser or in a PR -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143843#comment-17143843
]
Cris Rockwell commented on SLING-9545:
--
Ah ok! I was missing the distribution.api bundle. Thank you very much.
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png, Screen Shot
> 2020-06-24 at 8.38.26 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Resolved] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-9545.
Resolution: Invalid
I have deployed the following two bundles in the latest Sling Starter:
{noformat}
org.apache.sling/org.apache.sling.distribution.core/0.4.2
org.apache.sling/org.apache.sling.distribution.api/0.4.0
{noformat}
The starter was build and started just fine, will all bundles active. I have
used
{noformat}$ java -version
openjdk version "11.0.7" 2020-04-14
OpenJDK Runtime Environment (build 11.0.7+10-suse-1.5-x8664)
OpenJDK 64-Bit Server VM (build 11.0.7+10-suse-1.5-x8664, mixed mode){noformat}
Please make sure that you have all the required dependencies deployed. If that
still does not work, please come back to the users' list with the errors.
Thanks!
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png, Screen Shot
> 2020-06-24 at 8.38.26 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143814#comment-17143814 ] Bertrand Delacretaz commented on SLING-7768: FWIW, as the rest of the /etc/map documentation was already on the Sling website, I have moved, the interpolation docs there with https://github.com/apache/sling-site/commit/eb5cf32c986f3ea60158e0808cf92634cbedb35d They are now (live in a few minutes) at https://sling.apache.org/documentation/the-sling-engine/mappings-for-resource-resolution.html > Add String Interpolation support to /etc/map > > > Key: SLING-7768 > URL: https://issues.apache.org/jira/browse/SLING-7768 > Project: Sling > Issue Type: Improvement > Components: ResourceResolver > Environment: Sling 11-SNAPSHOT, JDK 1.8 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: Resource Resolver 1.6.18 > > Attachments: Screenshot 2018-07-06 11.41.58.png, Screenshot > 2018-07-06 11.42.41.png, Screenshot 2018-07-06 11.43.34.png > > > Having worked on migrations of a Sling derivate Ruben & I ran into issues > where the /etc/map would map to production instead of testing environment. > Many big customer have extensive /etc/maps and also many different > environments like dev, qa, staging, prod etc. > It would be great to have a tool where for example items like the host name > or external links in /etc/map could be configured outside so that just one > entry has to adjusted rather than creating a full copy of the /etc/map tree. > > Example: > > /etc/map/http/phv.fq.host.name.8080 > > Placeholder provides: > DEV: phv.fq.host.name=localhost > QA: phv.fq.host.name=qa.author.acme.com > STAGING: > phv.fq.host.name=[staging.author.acme.com|http://staging.author.acme.com/] > PROD: phv.fq.host.name=[acme.com|http://acme.com/] > > At runtime these are the resolved values: > DEV: http/localhost.8080 > QA: http/qa.author.acme.com.8080 > STAGING: http/[staging.author.acme.com|http://staging.author.acme.com/].8080 > PROD: http/[acme.com|http://acme.com/].8080 > > Not only does that make it easier and faster to create new test environments > but it also cuts down on the chance of copy-n-paste errors. > > I have a working POC with an PlaceholderProvider OSGi service and an > enhanced MapEntries that resolved any placeholders if found. > > Attached are 3 screenshots: > 1. OSGi Placeholder Provider Configuration > 2. /etc/map (Composum) > 3. Result of [http://andreass.local:8080/] call -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143812#comment-17143812
]
Cris Rockwell commented on SLING-9545:
--
When you docs
https://cwiki.apache.org/confluence/display/SLING/Java+version+support has the
statement, but the bundle only works with Java 8.
"Sling currently supports the following releases of Java
8, as it is a version that many are currently using as a basline
11, as it is the most recent version for which Oracle provides Long-Term
Support"
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png, Screen Shot
> 2020-06-24 at 8.38.26 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Commented] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143810#comment-17143810
]
Robert Munteanu commented on SLING-9545:
[~tmaret]/[~cschneider] - any ideas?
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png, Screen Shot
> 2020-06-24 at 8.38.26 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Comment Edited] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143803#comment-17143803
]
Cris Rockwell edited comment on SLING-9545 at 6/24/20, 12:39 PM:
-
Do you think even it is not required (optional import)? Usually there is an
osgi wiring error in the logs, which I could not find. I'll try your suggestion.
--
After resolving the optional dependency, org.apache.sling.distribution.core
bundle still not Active.
!Screen Shot 2020-06-24 at 8.38.26 AM.png!
was (Author: cris_rockwell):
Do you think even it is not required (optional import)? Usually there is an
osgi wiring error in the logs, which I could not find. I'll try your suggestion.
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png, Screen Shot
> 2020-06-24 at 8.38.26 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Commented] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143808#comment-17143808
]
Robert Munteanu commented on SLING-9545:
[~cris_rockwell] - we tend to use users@sling for support questions, so I
closed the issue. Feel free to leave this open, but this is not a bug in the
bundle, just an unsatisfied requirement in your deployment,
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Reopened] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cris Rockwell reopened SLING-9545:
--
Unless you actually got this bundle Active, do not mark as resolved please.
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Comment Edited] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143803#comment-17143803
]
Cris Rockwell edited comment on SLING-9545 at 6/24/20, 12:32 PM:
-
Do you think even it is not required (optional import)? Usually there is an
osgi wiring error in the logs, which I could not find. I'll try your suggestion.
was (Author: cris_rockwell):
Do you think even it is not required (optional import)? Usually there is an
osgi wiring error in the logs, which I could not find.
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Commented] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143803#comment-17143803
]
Cris Rockwell commented on SLING-9545:
--
Do you think even it is not required (optional import)? Usually there is an
osgi wiring error in the logs, which I could not find.
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Resolved] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-9545.
Resolution: Information Provided
The reason for the failure is visible in the package import - an import for
{{org.apache.http.impl.nio.client}} cannot be resolved.
Searching on Maven Central for that package (
https://search.maven.org/search?q=fc:%20%22org.apache.http.impl.nio.client%22 )
indicates that it should be included in the {{httpasyncclient-osgi}} bundle.
Please deploy that to your installation and it should work.
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Commented] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143787#comment-17143787
]
Cris Rockwell commented on SLING-9545:
--
No. I don't think so. I downloaded the bundle at 0.3.4 and 0.4.2 from maven
central and tried uploading and installing to /system/console/bundles. The
bundle state is Installed and not active. Maybe the Java 11 build issue is
separate. I thought maybe it's related to the header
Bundle-RequiredExecutionEnvironment: JavaSE-1.8
https://mvnrepository.com/artifact/org.apache.sling/org.apache.sling.distribution.core/0.3.4
https://mvnrepository.com/artifact/org.apache.sling/org.apache.sling.distribution.core/0.4.2
!Screen Shot 2020-06-24 at 8.09.38 AM.png!
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[jira] [Updated] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cris Rockwell updated SLING-9545:
-
Attachment: Screen Shot 2020-06-24 at 8.09.38 AM.png
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
> Attachments: Screen Shot 2020-06-24 at 8.09.38 AM.png
>
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
Re: [VOTE][CANCELLED] Release Apache Sling Kickstart and Kickstart Maven Plugin version 0.0.4
On Tue, Jun 23, 2020 at 7:05 PM Andreas Schaefer wrote: > > ...Due to the issue with the big FAR file I do cancel this release, find a > solution and then retry the vote on a later date Thank you very much, and sorry that this is delaying this release, but I think it's important. -Bertrand
[jira] [Resolved] (SLING-9546) SubscriberTest.testReceiveDelete is prone to timing issues
[
https://issues.apache.org/jira/browse/SLING-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret resolved SLING-9546.
---
Resolution: Fixed
> SubscriberTest.testReceiveDelete is prone to timing issues
> --
>
> Key: SLING-9546
> URL: https://issues.apache.org/jira/browse/SLING-9546
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> The test started to fail in Jenkins but not reproducible locally.
>
> {code}
> Error Message
> Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> Stacktrace
> org.awaitility.core.ConditionTimeoutException: Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.waitSubscriber(SubscriberTest.java:345)
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.testReceiveDelete(SubscriberTest.java:252)
> Standard Output
> 2020-06-24 09:15:39,935 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.DistributionSubscriber [DistributionSubscriber.java : 282]
> Started Queue processor -
> 2020-06-24 09:15:39,938 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 202] Started Subscriber agent sub1agent at
> offset 0, subscribed to agent names [pub1agent] with package builder journal
> editable false maxRetries -1 errorQueueEnabled false -
> 2020-06-24 09:15:39,943 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.BookKeeper [BookKeeper.java : 144] Importing distribution
> package myid of type DELETE at offset 0 -
> 2020-06-24 09:15:39,945 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.PackageHandler [PackageHandler.java : 107] Deleting paths
> [/test] - retries=0, paths=/test, sub-sling-id=sub1sling,
> module=distribution, sub-agent-name=sub1agent, pub-sling-id=pub1sling,
> distribution-message-type=DELETE, package-id=myid, pub-agent-name=pub1agent
> 2020-06-24 09:15:50,007 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 227] Stopped Subscriber agent sub1agent,
> subscribed to Publisher agent names [pub1agent] with package builder journal
> -
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9546) SubscriberTest#testReceiveDelete is prone to timing issues
[
https://issues.apache.org/jira/browse/SLING-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-9546:
--
Summary: SubscriberTest#testReceiveDelete is prone to timing issues (was:
SubscriberTest.testReceiveDelete is prone to timing issues)
> SubscriberTest#testReceiveDelete is prone to timing issues
> --
>
> Key: SLING-9546
> URL: https://issues.apache.org/jira/browse/SLING-9546
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> The test started to fail in Jenkins but not reproducible locally.
>
> {code}
> Error Message
> Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> Stacktrace
> org.awaitility.core.ConditionTimeoutException: Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.waitSubscriber(SubscriberTest.java:345)
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.testReceiveDelete(SubscriberTest.java:252)
> Standard Output
> 2020-06-24 09:15:39,935 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.DistributionSubscriber [DistributionSubscriber.java : 282]
> Started Queue processor -
> 2020-06-24 09:15:39,938 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 202] Started Subscriber agent sub1agent at
> offset 0, subscribed to agent names [pub1agent] with package builder journal
> editable false maxRetries -1 errorQueueEnabled false -
> 2020-06-24 09:15:39,943 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.BookKeeper [BookKeeper.java : 144] Importing distribution
> package myid of type DELETE at offset 0 -
> 2020-06-24 09:15:39,945 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.PackageHandler [PackageHandler.java : 107] Deleting paths
> [/test] - retries=0, paths=/test, sub-sling-id=sub1sling,
> module=distribution, sub-agent-name=sub1agent, pub-sling-id=pub1sling,
> distribution-message-type=DELETE, package-id=myid, pub-agent-name=pub1agent
> 2020-06-24 09:15:50,007 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 227] Stopped Subscriber agent sub1agent,
> subscribed to Publisher agent names [pub1agent] with package builder journal
> -
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9546) SubscriberTest.testReceiveDelete is prone to timing issues
[
https://issues.apache.org/jira/browse/SLING-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143718#comment-17143718
]
Timothee Maret commented on SLING-9546:
---
Merged PR
[#44|https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/44]
which fixes the test.
> SubscriberTest.testReceiveDelete is prone to timing issues
> --
>
> Key: SLING-9546
> URL: https://issues.apache.org/jira/browse/SLING-9546
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> The test started to fail in Jenkins but not reproducible locally.
>
> {code}
> Error Message
> Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> Stacktrace
> org.awaitility.core.ConditionTimeoutException: Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.waitSubscriber(SubscriberTest.java:345)
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.testReceiveDelete(SubscriberTest.java:252)
> Standard Output
> 2020-06-24 09:15:39,935 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.DistributionSubscriber [DistributionSubscriber.java : 282]
> Started Queue processor -
> 2020-06-24 09:15:39,938 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 202] Started Subscriber agent sub1agent at
> offset 0, subscribed to agent names [pub1agent] with package builder journal
> editable false maxRetries -1 errorQueueEnabled false -
> 2020-06-24 09:15:39,943 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.BookKeeper [BookKeeper.java : 144] Importing distribution
> package myid of type DELETE at offset 0 -
> 2020-06-24 09:15:39,945 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.PackageHandler [PackageHandler.java : 107] Deleting paths
> [/test] - retries=0, paths=/test, sub-sling-id=sub1sling,
> module=distribution, sub-agent-name=sub1agent, pub-sling-id=pub1sling,
> distribution-message-type=DELETE, package-id=myid, pub-agent-name=pub1agent
> 2020-06-24 09:15:50,007 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 227] Stopped Subscriber agent sub1agent,
> subscribed to Publisher agent names [pub1agent] with package builder journal
> -
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9546) SubscriberTest.testReceiveDelete is prone to timing issues
[
https://issues.apache.org/jira/browse/SLING-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-9546:
--
Summary: SubscriberTest.testReceiveDelete is prone to timing issues (was:
SubscriberTest.testReceiveDelete fails)
> SubscriberTest.testReceiveDelete is prone to timing issues
> --
>
> Key: SLING-9546
> URL: https://issues.apache.org/jira/browse/SLING-9546
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> The test started to fail in Jenkins but not reproducible locally.
>
> {code}
> Error Message
> Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> Stacktrace
> org.awaitility.core.ConditionTimeoutException: Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.waitSubscriber(SubscriberTest.java:345)
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.testReceiveDelete(SubscriberTest.java:252)
> Standard Output
> 2020-06-24 09:15:39,935 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.DistributionSubscriber [DistributionSubscriber.java : 282]
> Started Queue processor -
> 2020-06-24 09:15:39,938 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 202] Started Subscriber agent sub1agent at
> offset 0, subscribed to agent names [pub1agent] with package builder journal
> editable false maxRetries -1 errorQueueEnabled false -
> 2020-06-24 09:15:39,943 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.BookKeeper [BookKeeper.java : 144] Importing distribution
> package myid of type DELETE at offset 0 -
> 2020-06-24 09:15:39,945 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.PackageHandler [PackageHandler.java : 107] Deleting paths
> [/test] - retries=0, paths=/test, sub-sling-id=sub1sling,
> module=distribution, sub-agent-name=sub1agent, pub-sling-id=pub1sling,
> distribution-message-type=DELETE, package-id=myid, pub-agent-name=pub1agent
> 2020-06-24 09:15:50,007 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 227] Stopped Subscriber agent sub1agent,
> subscribed to Publisher agent names [pub1agent] with package builder journal
> -
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-9546) SubscriberTest.testReceiveDelete is prone to timing issues
[
https://issues.apache.org/jira/browse/SLING-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret reassigned SLING-9546:
-
Assignee: Timothee Maret
> SubscriberTest.testReceiveDelete is prone to timing issues
> --
>
> Key: SLING-9546
> URL: https://issues.apache.org/jira/browse/SLING-9546
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> The test started to fail in Jenkins but not reproducible locally.
>
> {code}
> Error Message
> Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> Stacktrace
> org.awaitility.core.ConditionTimeoutException: Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.waitSubscriber(SubscriberTest.java:345)
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.testReceiveDelete(SubscriberTest.java:252)
> Standard Output
> 2020-06-24 09:15:39,935 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.DistributionSubscriber [DistributionSubscriber.java : 282]
> Started Queue processor -
> 2020-06-24 09:15:39,938 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 202] Started Subscriber agent sub1agent at
> offset 0, subscribed to agent names [pub1agent] with package builder journal
> editable false maxRetries -1 errorQueueEnabled false -
> 2020-06-24 09:15:39,943 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.BookKeeper [BookKeeper.java : 144] Importing distribution
> package myid of type DELETE at offset 0 -
> 2020-06-24 09:15:39,945 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.PackageHandler [PackageHandler.java : 107] Deleting paths
> [/test] - retries=0, paths=/test, sub-sling-id=sub1sling,
> module=distribution, sub-agent-name=sub1agent, pub-sling-id=pub1sling,
> distribution-message-type=DELETE, package-id=myid, pub-agent-name=pub1agent
> 2020-06-24 09:15:50,007 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 227] Stopped Subscriber agent sub1agent,
> subscribed to Publisher agent names [pub1agent] with package builder journal
> -
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9546) SubscriberTest.testReceiveDelete fails
[
https://issues.apache.org/jira/browse/SLING-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143700#comment-17143700
]
Timothee Maret commented on SLING-9546:
---
The test expects the subscriber to go from RUNNING to IDLE when processing an
item,
[here|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/f4af344894622eec9cf61aedbfe0efb07a8f3530/src/test/java/org/apache/sling/distribution/journal/impl/subscriber/SubscriberTest.java#L252-L253].
That assumption is invalid and prone to timing issues.
> SubscriberTest.testReceiveDelete fails
> --
>
> Key: SLING-9546
> URL: https://issues.apache.org/jira/browse/SLING-9546
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> The test started to fail in Jenkins but not reproducible locally.
>
> {code}
> Error Message
> Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> Stacktrace
> org.awaitility.core.ConditionTimeoutException: Lambda expression in
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that
> uses
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
> expected but was within 10 seconds.
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.waitSubscriber(SubscriberTest.java:345)
> at
> org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.testReceiveDelete(SubscriberTest.java:252)
> Standard Output
> 2020-06-24 09:15:39,935 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.DistributionSubscriber [DistributionSubscriber.java : 282]
> Started Queue processor -
> 2020-06-24 09:15:39,938 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 202] Started Subscriber agent sub1agent at
> offset 0, subscribed to agent names [pub1agent] with package builder journal
> editable false maxRetries -1 errorQueueEnabled false -
> 2020-06-24 09:15:39,943 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.BookKeeper [BookKeeper.java : 144] Importing distribution
> package myid of type DELETE at offset 0 -
> 2020-06-24 09:15:39,945 INFO [Queue Processor for Subscriber agent sub1agent]
> o.a.s.d.j.i.s.PackageHandler [PackageHandler.java : 107] Deleting paths
> [/test] - retries=0, paths=/test, sub-sling-id=sub1sling,
> module=distribution, sub-agent-name=sub1agent, pub-sling-id=pub1sling,
> distribution-message-type=DELETE, package-id=myid, pub-agent-name=pub1agent
> 2020-06-24 09:15:50,007 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
> [DistributionSubscriber.java : 227] Stopped Subscriber agent sub1agent,
> subscribed to Publisher agent names [pub1agent] with package builder journal
> -
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9546) SubscriberTest.testReceiveDelete fails
[
https://issues.apache.org/jira/browse/SLING-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated SLING-9546:
--
Description:
The test started to fail in Jenkins but not reproducible locally.
{code}
Error Message
Lambda expression in
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that uses
org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
expected but was within 10 seconds.
Stacktrace
org.awaitility.core.ConditionTimeoutException: Lambda expression in
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that uses
org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
expected but was within 10 seconds.
at
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.waitSubscriber(SubscriberTest.java:345)
at
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.testReceiveDelete(SubscriberTest.java:252)
Standard Output
2020-06-24 09:15:39,935 INFO [Queue Processor for Subscriber agent sub1agent]
o.a.s.d.j.i.s.DistributionSubscriber [DistributionSubscriber.java : 282]
Started Queue processor -
2020-06-24 09:15:39,938 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
[DistributionSubscriber.java : 202] Started Subscriber agent sub1agent at
offset 0, subscribed to agent names [pub1agent] with package builder journal
editable false maxRetries -1 errorQueueEnabled false -
2020-06-24 09:15:39,943 INFO [Queue Processor for Subscriber agent sub1agent]
o.a.s.d.j.i.s.BookKeeper [BookKeeper.java : 144] Importing distribution package
myid of type DELETE at offset 0 -
2020-06-24 09:15:39,945 INFO [Queue Processor for Subscriber agent sub1agent]
o.a.s.d.j.i.s.PackageHandler [PackageHandler.java : 107] Deleting paths [/test]
- retries=0, paths=/test, sub-sling-id=sub1sling, module=distribution,
sub-agent-name=sub1agent, pub-sling-id=pub1sling,
distribution-message-type=DELETE, package-id=myid, pub-agent-name=pub1agent
2020-06-24 09:15:50,007 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
[DistributionSubscriber.java : 227] Stopped Subscriber agent sub1agent,
subscribed to Publisher agent names [pub1agent] with package builder journal -
{code}
was:
The test started to fail in Jenkins but not reproducible locally.
{code}
Error Message
Lambda expression in
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that uses
org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
expected but was within 10 seconds.
Stacktrace
org.awaitility.core.ConditionTimeoutException: Lambda expression in
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that uses
org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
expected but was within 10 seconds.
at
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.waitSubscriber(SubscriberTest.java:345)
at
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.testReceiveDelete(SubscriberTest.java:252)
Standard Output
2020-06-24 09:15:39,935 INFO [Queue Processor for Subscriber agent sub1agent]
o.a.s.d.j.i.s.DistributionSubscriber [DistributionSubscriber.java : 282]
Started Queue processor -
2020-06-24 09:15:39,938 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
[DistributionSubscriber.java : 202] Started Subscriber agent sub1agent at
offset 0, subscribed to agent names [pub1agent] with package builder journal
editable false maxRetries -1 errorQueueEnabled false -
2020-06-24 09:15:39,943 INFO [Queue Processor for Subscriber agent sub1agent]
o.a.s.d.j.i.s.BookKeeper [BookKeeper.java : 144] Importing distribution package
myid of type DELETE at offset 0 -
2020-06-24 09:15:39,945 INFO [Queue Processor for Subscriber agent sub1agent]
o.a.s.d.j.i.s.PackageHandler [PackageHandler.java : 107] Deleting paths [/test]
- retries=0, paths=/test, sub-sling-id=sub1sling, module=distribution,
sub-agent-name=sub1agent, pub-sling-id=pub1sling,
distribution-message-type=DELETE, package-id=myid, pub-agent-name=pub1agent
2020-06-24 09:15:50,007 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
[DistributionSubscriber.java : 227] Stopped Subscriber agent sub1agent,
subscribed to Publisher agent names [pub1agent] with package builder journal -
{code}
> SubscriberTest.testReceiveDelete fails
> --
>
> Key: SLING-9546
> URL: https://issues.apache.org/jira/browse/SLING-9546
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> The test started to fail in Jenkins but not reproducible locally.
>
> {code}
> Error Message
> Lambda expression in
>
[jira] [Resolved] (SLING-9537) Emit metric for error accessing queues
[ https://issues.apache.org/jira/browse/SLING-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret resolved SLING-9537. --- Resolution: Fixed The test regression does not seem related to the change. Filled SLING-9546. > Emit metric for error accessing queues > -- > > Key: SLING-9537 > URL: https://issues.apache.org/jira/browse/SLING-9537 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Amit Jain >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Currently the errors (exceptions) when getting the queues are not measurred. > This error measure correspond to an API entry point (e.g. SCD > [getQueue|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributionPublisher.java#L235-L236] > for DistributionAgent API). It will capture errors such as failures to seed > caches and more generally any failure getting the queues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9546) SubscriberTest.testReceiveDelete fails
Timothee Maret created SLING-9546:
-
Summary: SubscriberTest.testReceiveDelete fails
Key: SLING-9546
URL: https://issues.apache.org/jira/browse/SLING-9546
Project: Sling
Issue Type: Bug
Components: Content Distribution
Reporter: Timothee Maret
Fix For: Content Distribution Journal Core 0.1.18
The test started to fail in Jenkins but not reproducible locally.
{code}
Error Message
Lambda expression in
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that uses
org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
expected but was within 10 seconds.
Stacktrace
org.awaitility.core.ConditionTimeoutException: Lambda expression in
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest that uses
org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber:
expected but was within 10 seconds.
at
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.waitSubscriber(SubscriberTest.java:345)
at
org.apache.sling.distribution.journal.impl.subscriber.SubscriberTest.testReceiveDelete(SubscriberTest.java:252)
Standard Output
2020-06-24 09:15:39,935 INFO [Queue Processor for Subscriber agent sub1agent]
o.a.s.d.j.i.s.DistributionSubscriber [DistributionSubscriber.java : 282]
Started Queue processor -
2020-06-24 09:15:39,938 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
[DistributionSubscriber.java : 202] Started Subscriber agent sub1agent at
offset 0, subscribed to agent names [pub1agent] with package builder journal
editable false maxRetries -1 errorQueueEnabled false -
2020-06-24 09:15:39,943 INFO [Queue Processor for Subscriber agent sub1agent]
o.a.s.d.j.i.s.BookKeeper [BookKeeper.java : 144] Importing distribution package
myid of type DELETE at offset 0 -
2020-06-24 09:15:39,945 INFO [Queue Processor for Subscriber agent sub1agent]
o.a.s.d.j.i.s.PackageHandler [PackageHandler.java : 107] Deleting paths [/test]
- retries=0, paths=/test, sub-sling-id=sub1sling, module=distribution,
sub-agent-name=sub1agent, pub-sling-id=pub1sling,
distribution-message-type=DELETE, package-id=myid, pub-agent-name=pub1agent
2020-06-24 09:15:50,007 INFO [main] o.a.s.d.j.i.s.DistributionSubscriber
[DistributionSubscriber.java : 227] Stopped Subscriber agent sub1agent,
subscribed to Publisher agent names [pub1agent] with package builder journal -
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (SLING-9537) Emit metric for error accessing queues
[ https://issues.apache.org/jira/browse/SLING-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reopened SLING-9537: --- Reopeing, the tests seem to fail in Jenkins (not locally) > Emit metric for error accessing queues > -- > > Key: SLING-9537 > URL: https://issues.apache.org/jira/browse/SLING-9537 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Amit Jain >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Currently the errors (exceptions) when getting the queues are not measurred. > This error measure correspond to an API entry point (e.g. SCD > [getQueue|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributionPublisher.java#L235-L236] > for DistributionAgent API). It will capture errors such as failures to seed > caches and more generally any failure getting the queues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-9537) Emit metric for error accessing queues
[ https://issues.apache.org/jira/browse/SLING-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reassigned SLING-9537: - Assignee: Timothee Maret > Emit metric for error accessing queues > -- > > Key: SLING-9537 > URL: https://issues.apache.org/jira/browse/SLING-9537 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Amit Jain >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Currently the errors (exceptions) when getting the queues are not measurred. > This error measure correspond to an API entry point (e.g. SCD > [getQueue|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributionPublisher.java#L235-L236] > for DistributionAgent API). It will capture errors such as failures to seed > caches and more generally any failure getting the queues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9537) Emit metric for error accessing queues
[ https://issues.apache.org/jira/browse/SLING-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated SLING-9537: -- Fix Version/s: Content Distribution Journal 0.1. > Emit metric for error accessing queues > -- > > Key: SLING-9537 > URL: https://issues.apache.org/jira/browse/SLING-9537 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Amit Jain >Priority: Major > Fix For: Content Distribution Journal 0.1. > > > Currently the errors (exceptions) when getting the queues are not measurred. > This error measure correspond to an API entry point (e.g. SCD > [getQueue|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributionPublisher.java#L235-L236] > for DistributionAgent API). It will capture errors such as failures to seed > caches and more generally any failure getting the queues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9537) Emit metric for error accessing queues
[ https://issues.apache.org/jira/browse/SLING-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated SLING-9537: -- Fix Version/s: (was: Content Distribution Journal 0.1.) Content Distribution Journal Core 0.1.18 > Emit metric for error accessing queues > -- > > Key: SLING-9537 > URL: https://issues.apache.org/jira/browse/SLING-9537 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Amit Jain >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Currently the errors (exceptions) when getting the queues are not measurred. > This error measure correspond to an API entry point (e.g. SCD > [getQueue|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributionPublisher.java#L235-L236] > for DistributionAgent API). It will capture errors such as failures to seed > caches and more generally any failure getting the queues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9537) Emit metric for error accessing queues
[ https://issues.apache.org/jira/browse/SLING-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret resolved SLING-9537. --- Resolution: Fixed > Emit metric for error accessing queues > -- > > Key: SLING-9537 > URL: https://issues.apache.org/jira/browse/SLING-9537 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Amit Jain >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Journal Core 0.1.18 > > > Currently the errors (exceptions) when getting the queues are not measurred. > This error measure correspond to an API entry point (e.g. SCD > [getQueue|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributionPublisher.java#L235-L236] > for DistributionAgent API). It will capture errors such as failures to seed > caches and more generally any failure getting the queues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9537) Emit metric for error accessing queues
[ https://issues.apache.org/jira/browse/SLING-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143664#comment-17143664 ] Timothee Maret commented on SLING-9537: --- Thanks [~amitj]! Merged your PR. > Emit metric for error accessing queues > -- > > Key: SLING-9537 > URL: https://issues.apache.org/jira/browse/SLING-9537 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Amit Jain >Priority: Major > > Currently the errors (exceptions) when getting the queues are not measurred. > This error measure correspond to an API entry point (e.g. SCD > [getQueue|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributionPublisher.java#L235-L236] > for DistributionAgent API). It will capture errors such as failures to seed > caches and more generally any failure getting the queues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-whiteboard] rombert merged pull request #61: Build whiteboard with Java 11 on Jenkins
rombert merged pull request #61: URL: https://github.com/apache/sling-whiteboard/pull/61 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] rombert commented on pull request #60: Saml2 auth handler/upgrade sling12 open samlv4 java11
rombert commented on pull request #60: URL: https://github.com/apache/sling-whiteboard/pull/60#issuecomment-648638483 @cmrockwell - I've switched the Jenkins build to Java 11 with https://github.com/apache/sling-whiteboard/pull/61 . Please rebase on top of that, the build should be fine now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-whiteboard] sonarcloud[bot] commented on pull request #61: Build whiteboard with Java 11 on Jenkins
sonarcloud[bot] commented on pull request #61: URL: https://github.com/apache/sling-whiteboard/pull/61#issuecomment-648637755 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=61=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=61=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=61=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=61=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=61=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=61=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=61=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=61=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=61=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-whiteboard=61=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=61=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-whiteboard=61=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9545) Distribution Core bundle with Java 11
[
https://issues.apache.org/jira/browse/SLING-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143584#comment-17143584
]
Robert Munteanu commented on SLING-9545:
I think this is a problem when building, right? It's just a matter of using the
latest parent pom.
> Distribution Core bundle with Java 11
> -
>
> Key: SLING-9545
> URL: https://issues.apache.org/jira/browse/SLING-9545
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.3.4, Content Distribution
> Core 0.4.2
>Reporter: Cris Rockwell
>Priority: Major
>
> Apache Sling Distribution Core (org.apache.sling.distribution.core) bundle
> does not activate on Sling12 using Java 11
> https://github.com/apache/sling-org-apache-sling-distribution-core
> {{mvn clean install}} results in the error below
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
> (set-bundle-required-execution-environment) on project
> org.apache.sling.distribution.core: An Ant BuildException has occured: Unable
> to create javax script engine for javascript
> [ERROR] around Ant part
[GitHub] [sling-whiteboard] rombert opened a new pull request #61: Build whiteboard with Java 11 on Jenkins
rombert opened a new pull request #61: URL: https://github.com/apache/sling-whiteboard/pull/61 The saml-handler module is moving to Java 11 and, since all other projects are ready for that, we move the Jenkins build to Java 11 as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Rewriting git repo history (was: [VOTE][CANCELLED] Release Apache Sling Kickstart and Kickstart Maven Plugin version 0.0.4)
Hi Andy, On Tue, 2020-06-23 at 10:04 -0700, Andreas Schaefer wrote: > Do you want me to remove that file from the git repository with ‘git > filter-branch’? I used that in the past and it works but I am not > sure if it works with GitHub or if I am allowed to do it in the > Apache repo. I think it would be nice and probably carries little risk, as the repository is still 'young'. People who have this checked out, and probably Jenkins and SonarCloud may be affected. Could you create an issue for this and push the results on a separate repository outside of the apache org? We can then ask infra and sonarcloud about side effects of this. Thanks, Robert
