[jira] [Commented] (SLING-9800) Extract a service to be able to execute GraphQL queries directly

2020-10-09 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211452#comment-17211452 ] Andreas Schaefer commented on SLING-9800: - The isValid() is ok but as a caller I would need to

Re: [VOTE] Release Apache Sling Parent 40, Apache Sling Bundle Parent 40

2020-10-09 Thread Daniel Klco
+1 On Fri, Oct 9, 2020 at 12:58 PM Andreas Schaefer wrote: > +1 (non-binding) > > - Andy > > > On Oct 9, 2020, at 7:28 AM, Radu Cotescu wrote: > > > > Hi, > > > > We solved 4 issues in these releases: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12348259 < >

Re: [VOTE] Release Apache Sling Parent 40, Apache Sling Bundle Parent 40

2020-10-09 Thread Andreas Schaefer
+1 (non-binding) - Andy > On Oct 9, 2020, at 7:28 AM, Radu Cotescu wrote: > > Hi, > > We solved 4 issues in these releases: > https://issues.apache.org/jira/browse/SLING/fixforversion/12348259 > >

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] removed a comment on pull request #8: SLING-9796 - Add support for using Unions

2020-10-09 Thread GitBox
sonarcloud[bot] removed a comment on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/8#issuecomment-706203144 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #8: SLING-9796 - Add support for using Unions

2020-10-09 Thread GitBox
sonarcloud[bot] commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/8#issuecomment-706281422 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=8=false=BUG)

[jira] [Resolved] (SLING-9800) Extract a service to be able to execute GraphQL queries directly

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-9800. - Resolution: Fixed Implemented in [commit

[VOTE] Release Apache Sling Parent 40, Apache Sling Bundle Parent 40

2020-10-09 Thread Radu Cotescu
Hi, We solved 4 issues in these releases: https://issues.apache.org/jira/browse/SLING/fixforversion/12348259 https://issues.apache.org/jira/browse/SLING/fixforversion/12348260

Re: [VOTE] Release Apache Sling Parent 40, Apache Sling Bundle Parent 40

2020-10-09 Thread Radu Cotescu
+1 > On 9 Oct 2020, at 16:28, Radu Cotescu wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...

[jira] [Updated] (SLING-8738) Trigger an error during build if an API uses a private reference in its public methods' signatures

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-8738: Fix Version/s: (was: Bundle Parent 40) Bundle Parent 41 > Trigger an error

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on pull request #6: SLING-9796 - Add support for using Unions

2020-10-09 Thread GitBox
raducotescu commented on pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6#issuecomment-706197961 I've applied a slightly modified patch in https://github.com/apache/sling-org-apache-sling-graphql-core/pull/8, since my change from

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #8: SLING-9796 - Add support for using Unions

2020-10-09 Thread GitBox
sonarcloud[bot] commented on pull request #8: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/8#issuecomment-706203144 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=8=false=BUG)

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu closed pull request #6: SLING-9796 - Add support for using Unions

2020-10-09 Thread GitBox
raducotescu closed pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu opened a new pull request #8: SLING-9796 - Add support for using Unions

2020-10-09 Thread GitBox
raducotescu opened a new pull request #8: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/8 Co-authored-by: Radu Cotescu Co-authored-by: Adrian Kozma This is an automated message from the Apache

[GitHub] [sling-org-apache-sling-commons-johnzon] sonarcloud[bot] commented on pull request #2: SLING-9806 - Export the johnzon.core packages provided by org.apache.johnzon:johnzon-core

2020-10-09 Thread GitBox
sonarcloud[bot] commented on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-commons-johnzon/pull/2#issuecomment-705710589 Kudos, SonarCloud Quality Gate passed!

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu merged pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly

2020-10-09 Thread GitBox
raducotescu merged pull request #7: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (SLING-9729) Bundle-Parent: Check if resolvable against latest Sling Starter

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-9729: Fix Version/s: (was: Bundle Parent 40) Bundle Parent 41 > Bundle-Parent:

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] removed a comment on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-09 Thread GitBox
sonarcloud[bot] removed a comment on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705186049 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [sling-org-apache-sling-testing-sling-mock] sonarcloud[bot] commented on pull request #4: SLING-9680 Add easy way to inject SlingBindings into MockSlingHttpServletRequest

2020-10-09 Thread GitBox
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/4#issuecomment-705649544 Kudos, SonarCloud Quality Gate passed!

[jira] [Updated] (SLING-9189) release:perform issues [WARNING] The requested profile "pom.xml" could not be activated because it does not exist.

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-9189: Fix Version/s: (was: Parent 40) Parent 41 Parent 41 >

[jira] [Updated] (SLING-9611) Enforce setting the "project.build.outputTimestamp" property

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-9611: Fix Version/s: (was: Parent 40) Parent 41 > Enforce setting the

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on a change in pull request #6: SLING-9796 - Add support for using Unions

2020-10-09 Thread GitBox
raducotescu commented on a change in pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6#discussion_r502351919 ## File path: src/main/java/org/apache/sling/graphql/core/engine/ScriptedTypeResolverProvider.java ## @@ -0,0 +1,91 @@ + +/*

[jira] [Updated] (SLING-7534) Release policy - stop providing MD5 and start providing SHA-512 checksums

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-7534: Fix Version/s: (was: Parent 40) Parent 41 Parent 41 >

[jira] [Updated] (SLING-9463) Document reproducible builds and check automatically via check-staged-release

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-9463: Fix Version/s: (was: Parent 40) Parent 41 Parent 41 >

[jira] [Updated] (SLING-9509) Merge all enforcer rules into one execution

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-9509: Fix Version/s: (was: Bundle Parent 40) (was: Parent 40)

[GitHub] [sling-org-apache-sling-commons-johnzon] raducotescu merged pull request #2: SLING-9806 - Export the johnzon.core packages provided by org.apache.johnzon:johnzon-core

2020-10-09 Thread GitBox
raducotescu merged pull request #2: URL: https://github.com/apache/sling-org-apache-sling-commons-johnzon/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [sling-org-apache-sling-feature-analyser] sonarcloud[bot] removed a comment on pull request #25: SLING-8481: add a caching extension for meta-data.

2020-10-09 Thread GitBox
sonarcloud[bot] removed a comment on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/25#issuecomment-705529491 SonarCloud Quality Gate failed.

[GitHub] [sling-org-apache-sling-api] ghenzler commented on a change in pull request #25: SLING-9745 Sling Uri Mapping SPI

2020-10-09 Thread GitBox
ghenzler commented on a change in pull request #25: URL: https://github.com/apache/sling-org-apache-sling-api/pull/25#discussion_r502041988 ## File path: src/main/java/org/apache/sling/api/resource/mapping/PathToUriMappingService.java ## @@ -0,0 +1,77 @@ +/* + * Licensed to

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on a change in pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly

2020-10-09 Thread GitBox
bdelacretaz commented on a change in pull request #7: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7#discussion_r501813901 ## File path: src/main/java/org/apache/sling/graphql/core/schema/RankedSchemaProviders.java ## @@ -43,7 +43,7 @@

[GitHub] [sling-org-apache-sling-commons-johnzon] raducotescu commented on pull request #2: SLING-9806 - Export the johnzon.core packages provided by org.apache.johnzon:johnzon-core

2020-10-09 Thread GitBox
raducotescu commented on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-commons-johnzon/pull/2#issuecomment-705710013 @karlpauls, @kwin - anything against this? See the reasoning in https://issues.apache.org/jira/browse/SLING-9806

[GitHub] [sling-org-apache-sling-feature-analyser] bosschaert commented on pull request #25: SLING-8481: add a caching extension for meta-data.

2020-10-09 Thread GitBox
bosschaert commented on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/25#issuecomment-705559816 Since it says 'caching' I was thinking that the [TRANSIENT

[GitHub] [sling-org-apache-sling-api] ghenzler merged pull request #24: SLING-9777 Better handling for invalid URIs when using SlingUri (special characters, spaces)

2020-10-09 Thread GitBox
ghenzler merged pull request #24: URL: https://github.com/apache/sling-org-apache-sling-api/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [sling-org-apache-sling-junit-core] sonarcloud[bot] commented on pull request #4: SLING-9795 - JUnit 5 support for server-side tests

2020-10-09 Thread GitBox
sonarcloud[bot] commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-junit-core/pull/4#issuecomment-705543843 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] commented on pull request #25: SLING-9745 Sling Uri Mapping SPI

2020-10-09 Thread GitBox
sonarcloud[bot] commented on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-api/pull/25#issuecomment-705847318 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [sling-org-apache-sling-api] sonarcloud[bot] removed a comment on pull request #25: SLING-9745 Sling Uri Mapping SPI

2020-10-09 Thread GitBox
sonarcloud[bot] removed a comment on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-api/pull/25#issuecomment-701581756 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [sling-org-apache-sling-feature-analyser] cziegeler commented on pull request #25: SLING-8481: add a caching extension for meta-data.

2020-10-09 Thread GitBox
cziegeler commented on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/25#issuecomment-705604409 Agreed, transient sounds better - our feature readers/writers for json do support this

[GitHub] [sling-org-apache-sling-feature-analyser] karlpauls merged pull request #25: SLING-8481: add a caching extension for meta-data.

2020-10-09 Thread GitBox
karlpauls merged pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [sling-org-apache-sling-feature-analyser] sonarcloud[bot] commented on pull request #25: SLING-8481: add a caching extension for meta-data.

2020-10-09 Thread GitBox
sonarcloud[bot] commented on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/25#issuecomment-705529491 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [sling-org-apache-sling-api] ghenzler commented on pull request #25: SLING-9745 Sling Uri Mapping SPI

2020-10-09 Thread GitBox
ghenzler commented on pull request #25: URL: https://github.com/apache/sling-org-apache-sling-api/pull/25#issuecomment-705854489 An aspect that was missing is that sometimes, independent of if you have a request at hand or not, you need to force an absolute URI to be generated. E.g.

[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly

2020-10-09 Thread GitBox
bdelacretaz commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7#issuecomment-705650614 The build failed as it was not finding the parent pom 40-SNAPSHOT - in the meantime I have mvn:deployed that pom.

Re: [VOTE] Release Apache Sling Commons Johnzon 1.2.6

2020-10-09 Thread Daniel Klco
+1 On Fri, Oct 9, 2020 at 6:46 AM Radu Cotescu wrote: > +1 > > > On 9 Oct 2020, at 12:45, Radu Cotescu wrote: > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > >

[jira] [Assigned] (SLING-9796) Add support for using Unions

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu reassigned SLING-9796: --- Assignee: Radu Cotescu > Add support for using Unions > > >

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on a change in pull request #6: SLING-9796 - Add support for using Unions

2020-10-09 Thread GitBox
raducotescu commented on a change in pull request #6: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/6#discussion_r502351919 ## File path: src/main/java/org/apache/sling/graphql/core/engine/ScriptedTypeResolverProvider.java ## @@ -0,0 +1,91 @@ + +/*

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu merged pull request #7: SLING-9800 - Extract a service to be able to execute GraphQL queries directly

2020-10-09 Thread GitBox
raducotescu merged pull request #7: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [VOTE] Release Apache Sling Commons Johnzon 1.2.6

2020-10-09 Thread Radu Cotescu
+1 > On 9 Oct 2020, at 12:45, Radu Cotescu wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...

[VOTE] Release Apache Sling Commons Johnzon 1.2.6

2020-10-09 Thread Radu Cotescu
Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12348653 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2352

[jira] [Closed] (SLING-9783) The HTL compiler will trigger a NPE if a null value should be written into an HTML attribute

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-9783. --- > The HTL compiler will trigger a NPE if a null value should be written into an > HTML attribute >

[RESULT] [VOTE] Release Apache Sling Scripting HTL Compiler 1.2.10-1.4.0, Apache Sling Scripting HTL Testing Content 1.0.24-1.4.0, Apache Sling Scripting HTL Testing 1.0.26-1.4.0

2020-10-09 Thread Radu Cotescu
Hi, The vote has passed with the following result: +1 (binding): Dan Klco, Karl Pauls, Stefan Seifert +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Radu Cotescu

[jira] [Closed] (SLING-9655) Caching support for the GraphQL core

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-9655. --- > Caching support for the GraphQL core > > > Key:

[jira] [Closed] (SLING-9626) "Writer has already been closed" exception in GraphQLServlet

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-9626. --- > "Writer has already been closed" exception in GraphQLServlet >

[jira] [Closed] (SLING-9720) Present the persisted queries endpoints using the same extension the GraphQL servlet uses

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-9720. --- > Present the persisted queries endpoints using the same extension the GraphQL > servlet uses >

[jira] [Closed] (SLING-9724) Validate queries before persisting

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-9724. --- > Validate queries before persisting > -- > > Key:

[jira] [Closed] (SLING-9744) Add metrics for the persisted queries

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-9744. --- > Add metrics for the persisted queries > - > > Key:

[jira] [Closed] (SLING-9763) Use the "application/graphql" mime type for the org.apache.sling.graphql.core.scripting.GraphQLScriptEngineFactory

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-9763. --- > Use the "application/graphql" mime type for the >

[jira] [Closed] (SLING-9753) Return a 500 status code if the persisted query cannot be stored in the cache

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-9753. --- > Return a 500 status code if the persisted query cannot be stored in the cache >

[RESULT] [VOTE] Release Apache Sling GraphQL Core 0.0.6

2020-10-09 Thread Radu Cotescu
Hi, The vote has passed with the following result: +1 (binding): Robert Munteanu, Nicolas Peltier, Dan Klco, Bertrand Delacretaz +1 (non-binding): Andreas Schaefer I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Radu

[jira] [Resolved] (SLING-9806) Export the johnzon.core packages provided by org.apache.johnzon:johnzon-core

2020-10-09 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-9806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-9806. - Resolution: Fixed Fixed in [commit

[GitHub] [sling-org-apache-sling-commons-johnzon] raducotescu merged pull request #2: SLING-9806 - Export the johnzon.core packages provided by org.apache.johnzon:johnzon-core

2020-10-09 Thread GitBox
raducotescu merged pull request #2: URL: https://github.com/apache/sling-org-apache-sling-commons-johnzon/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub