[GitHub] [sling-org-apache-sling-scripting-sightly] kwin commented on pull request #20: SLING-11538 add output context for JSON string

2022-08-29 Thread GitBox
kwin commented on PR #20: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/20#issuecomment-1230621407 @raducotescu Any feedback on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (SLING-11248) Post empty body should fail gracefully

2022-08-29 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597291#comment-17597291 ] Radu Cotescu commented on SLING-11248: -- Fixed in

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu merged pull request #31: SLING-11248 - Post empty body should fail gracefully

2022-08-29 Thread GitBox
raducotescu merged PR #31: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu closed pull request #28: SLING-11248 QueryParser.fromRequest(...) calls possible exceptions sh…

2022-08-29 Thread GitBox
raducotescu closed pull request #28: SLING-11248 QueryParser.fromRequest(...) calls possible exceptions sh… URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on pull request #28: SLING-11248 QueryParser.fromRequest(...) calls possible exceptions sh…

2022-08-29 Thread GitBox
raducotescu commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/28#issuecomment-1230538825 Closing in favour of #31. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu opened a new pull request, #31: SLING-11248 - Post empty body should fail gracefully

2022-08-29 Thread GitBox
raducotescu opened a new pull request, #31: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/31 * applied slightly modified patch from #28 Co-authored-by: Thierry Ygé -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #30: Bump commons-io from 2.4 to 2.7

2022-08-29 Thread GitBox
sonarcloud[bot] commented on PR #30: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/30#issuecomment-1230531218 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-graphql-core] dependabot[bot] opened a new pull request, #30: Bump commons-io from 2.4 to 2.7

2022-08-29 Thread GitBox
dependabot[bot] opened a new pull request, #30: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/30 Bumps commons-io from 2.4 to 2.7. [![Dependabot compatibility

[jira] [Resolved] (SLING-10883) Update the GraphQL implementation to use the Builder API for internal requests

2022-08-29 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-10883. -- Resolution: Fixed Fixed in

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu merged pull request #26: SLING-10883 - Update the GraphQL implementation to use the Builder API for internal requests

2022-08-29 Thread GitBox
raducotescu merged PR #26: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #26: SLING-10883 - Update the GraphQL implementation to use the Builder API for internal requests

2022-08-29 Thread GitBox
sonarcloud[bot] commented on PR #26: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/26#issuecomment-1230508639 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Updated] (SLING-11429) OSGi configs on same resource type cause IAE

2022-08-29 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-11429: - Fix Version/s: GraphQL Core 0.0.14 > OSGi configs on same resource type cause IAE >

[jira] [Resolved] (SLING-11545) HTL documentation improvements

2022-08-29 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-11545. -- Resolution: Fixed > HTL documentation improvements > -- > >

[jira] [Closed] (SLING-11545) HTL documentation improvements

2022-08-29 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-11545. > HTL documentation improvements > -- > > Key:

Re: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0

2022-08-29 Thread Carsten Ziegeler
+1 Carsten Am 29.08.2022 um 15:41 schrieb Stefan Seifert: Hi, Testing ResourceResolver Mock 1.4.0 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12351705 Testing OSGi Mock 3.3.2 (1 issue) https://issues.apache.org/jira/browse/SLING/fixforversion/12351706 Testing

[jira] [Commented] (SLING-11504) BundleResource fallback sling:resourceType should be consistent with JcrNodeResource

2022-08-29 Thread Michal Cukierman (Jira)
[ https://issues.apache.org/jira/browse/SLING-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597215#comment-17597215 ] Michal Cukierman commented on SLING-11504: -- The PR has already two approves. What else is

[jira] [Closed] (SLING-11364) Allow dedicated handling of networking issues

2022-08-29 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh closed SLING-11364. - > Allow dedicated handling of networking issues > - > >

RE: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0

2022-08-29 Thread Stefan Seifert
+1

[VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0

2022-08-29 Thread Stefan Seifert
Hi, Testing ResourceResolver Mock 1.4.0 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12351705 Testing OSGi Mock 3.3.2 (1 issue) https://issues.apache.org/jira/browse/SLING/fixforversion/12351706 Testing Sling Mock 3.4.0 (3 issues)

[jira] [Updated] (SLING-11507) Field injection should not inject static fields

2022-08-29 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11507: -- Description: Currently this injection works: {noformat} @SlingObject private static

[jira] [Comment Edited] (SLING-11507) Field injection should not inject static fields

2022-08-29 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597070#comment-17597070 ] Joerg Hoh edited comment on SLING-11507 at 8/29/22 9:17 AM: [~cziegeler]

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

2022-08-29 Thread Joerg Hoh (Jira)
[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597070#comment-17597070 ] Joerg Hoh commented on SLING-11507: --- [~cziegeler] Valid point. We should always print a warning and

[RESULT] [VOTE] Release Apache Sling Testing Clients 3.0.14

2022-08-29 Thread Jörg Hoh
Hi, The vote has passed with the following result : +1 (binding): Jörg Hoh, Eric Norman, Stefan Seifert, Nicolas Peltier, Daniel Klco +1 (non binding): - I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks, Jörg Am Mo., 22.

[jira] [Commented] (SLING-11498) Race condition in MapEntries: Resource resolver is already closed (Error while dispatching observation events for //*[11111b]@org.apache.sling.jcr.resource.internal.Jc

2022-08-29 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597063#comment-17597063 ] Carsten Ziegeler commented on SLING-11498: -- The idea behing the "initializing" lock was to

[jira] [Commented] (SLING-11507) Field injection should not inject static fields

2022-08-29 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597025#comment-17597025 ] Carsten Ziegeler commented on SLING-11507: -- This is clearly a developer error and should be