[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #3: SLING-11382: Sling update to 47

2022-09-02 Thread GitBox
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1236009763 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

2022-09-02 Thread GitBox
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1236002981 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Closed] (SLING-11197) GraphQLServlet cache hit rate metric produces invalid json

2022-09-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-11197. > GraphQLServlet cache hit rate metric produces invalid json >

[jira] [Closed] (SLING-11429) OSGi configs on same resource type cause IAE

2022-09-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-11429. > OSGi configs on same resource type cause IAE > > >

[jira] [Closed] (SLING-10883) Update the GraphQL implementation to use the Builder API for internal requests

2022-09-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-10883. > Update the GraphQL implementation to use the Builder API for internal requests >

[jira] [Closed] (SLING-11248) Post empty body should fail gracefully

2022-09-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-11248. > Post empty body should fail gracefully > -- > >

[jira] [Closed] (SLING-11563) Update to Apache Sling Bundle Parent 49

2022-09-02 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-11563. > Update to Apache Sling Bundle Parent 49 > --- > >

[RESULT] [VOTE] Release Apache Sling GraphQL Core 0.0.14

2022-09-02 Thread Radu Cotescu
Hi, The vote has passed with the following result: +1 (binding): Radu Cotescu, Karl Pauls, Nicolas Peltier, Bertrand Delacretaz +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Radu Cotescu

[GitHub] [sling-org-apache-sling-distribution-core] kwin commented on pull request #61: SLING-11560 - Allow configuring the IdConflictPolicy and set the default to LEGACY

2022-09-02 Thread GitBox
kwin commented on PR #61: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/61#issuecomment-1235689929 I don’t think you need to maintain your own policy but rather rely on the default which should kick in whenever

[GitHub] [sling-org-apache-sling-distribution-core] balasoiuroxana commented on a diff in pull request #61: SLING-11560 - Allow configuring the IdConflictPolicy and set the default to LEGACY

2022-09-02 Thread GitBox
balasoiuroxana commented on code in PR #61: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/61#discussion_r961794155 ## pom.xml: ## @@ -324,7 +324,7 @@ org.apache.jackrabbit.vault org.apache.jackrabbit.vault -

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results

2022-09-02 Thread GitBox
sonarcloud[bot] commented on PR #81: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#issuecomment-1235583773 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Created] (SLING-11566) Add methods to check whether recording is enabled

2022-09-02 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-11566: Summary: Add methods to check whether recording is enabled Key: SLING-11566 URL: https://issues.apache.org/jira/browse/SLING-11566 Project: Sling

[jira] [Resolved] (SLING-11566) Add methods to check whether recording is enabled

2022-09-02 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11566. -- Resolution: Fixed

[GitHub] [sling-org-apache-sling-distribution-core] tmaret commented on a diff in pull request #61: SLING-11560 - Allow configuring the IdConflictPolicy and set the default to LEGACY

2022-09-02 Thread GitBox
tmaret commented on code in PR #61: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/61#discussion_r961672308 ## pom.xml: ## @@ -324,7 +324,7 @@ org.apache.jackrabbit.vault org.apache.jackrabbit.vault -

[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results

2022-09-02 Thread GitBox
reschke commented on code in PR #81: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961658414 ## src/test/java/org/apache/sling/resourceresolver/impl/mapping/InMemoryResourceProvider.java: ## @@ -103,7 +103,7 @@ public Iterator

[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results

2022-09-02 Thread GitBox
reschke commented on code in PR #81: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961655432 ## src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java: ## @@ -1275,25 +1276,40 @@ private static boolean

[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results

2022-09-02 Thread GitBox
reschke commented on code in PR #81: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961654779 ## src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java: ## @@ -1303,7 +1319,13 @@ private Map>

[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results

2022-09-02 Thread GitBox
reschke commented on code in PR #81: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961653653 ## src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java: ## @@ -1275,25 +1276,40 @@ private static boolean

[GitHub] [sling-org-apache-sling-resourceresolver] thomasmueller commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results

2022-09-02 Thread GitBox
thomasmueller commented on code in PR #81: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961648494 ## src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java: ## @@ -1275,25 +1276,40 @@ private static boolean

[jira] [Commented] (SLING-11490) Provide JUnit Option

2022-09-02 Thread Oliver Lietz (Jira)
[ https://issues.apache.org/jira/browse/SLING-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599463#comment-17599463 ] Oliver Lietz commented on SLING-11490: -- Different/newer JUnit versions cause more issues (see [Make

[GitHub] [sling-org-apache-sling-xss] rombert commented on pull request #28: SLING-7231 Move to owasp sanitizer library

2022-09-02 Thread GitBox
rombert commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28#issuecomment-1235417417 @kwin - I think this is ready for a re-review, except for https://github.com/apache/sling-org-apache-sling-xss/pull/28#discussion_r915033485 , which I will try to

[GitHub] [sling-org-apache-sling-xss] sonarcloud[bot] commented on pull request #28: SLING-7231 Move to owasp sanitizer library

2022-09-02 Thread GitBox
sonarcloud[bot] commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28#issuecomment-1235415949 SonarCloud Quality Gate failed. [![Quality Gate

[jira] [Closed] (SLING-11505) implement MockBundleContext.getProperty(key)

2022-09-02 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-11505. -- > implement MockBundleContext.getProperty(key) > > >

[jira] [Closed] (SLING-10937) Resource in tested Sling Model not equal to Resource it was adapted from (RESOURCERESOLVER_MOCK)

2022-09-02 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-10937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-10937. -- > Resource in tested Sling Model not equal to Resource it was adapted from >

[jira] [Closed] (SLING-11548) sling-mock: Introduce RESOURCEPROVIDER_MOCK resource resolver type

2022-09-02 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-11548. -- > sling-mock: Introduce RESOURCEPROVIDER_MOCK resource resolver type >

[jira] [Closed] (SLING-11252) RRMockResourceResolverWrapper supports no way of mocking searches

2022-09-02 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-11252. -- > RRMockResourceResolverWrapper supports no way of mocking searches >

[jira] [Closed] (SLING-11455) ResourceResolver Mock: ResourceProvider implementation

2022-09-02 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-11455. -- > ResourceResolver Mock: ResourceProvider implementation >

[jira] [Closed] (SLING-11457) ResourceResolver Mock: Use compile scope for OSGi dependencies

2022-09-02 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-11457. -- > ResourceResolver Mock: Use compile scope for OSGi dependencies >

[RESULT] [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0

2022-09-02 Thread Stefan Seifert
(resent again with proper subject - "[RESULT]" was missing) -Original Message- From: Stefan Seifert Sent: Friday, September 2, 2022 1:11 PM To: dev@sling.apache.org Subject: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0 Hi, The

[VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0

2022-09-02 Thread Stefan Seifert
Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Carsten Ziegeler, Jörg Hoh I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. stefan

Re: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0

2022-09-02 Thread Jörg Hoh
+1 Am Fr., 2. Sept. 2022 um 11:44 Uhr schrieb Stefan Seifert : > one binding vote is missing - anyone? > > stefan > > -Original Message- > From: Stefan Seifert > Sent: Monday, August 29, 2022 3:42 PM > To: dev@sling.apache.org > Subject: [VOTE] Release Apache Sling Testing

RE: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0

2022-09-02 Thread Stefan Seifert
one binding vote is missing - anyone? stefan -Original Message- From: Stefan Seifert Sent: Monday, August 29, 2022 3:42 PM To: dev@sling.apache.org Subject: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0 Hi, Testing