[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #3: SLING-11382: Sling update to 47
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1236009763 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jms=3) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1236002981 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SLING-11197) GraphQLServlet cache hit rate metric produces invalid json
[
https://issues.apache.org/jira/browse/SLING-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu closed SLING-11197.
> GraphQLServlet cache hit rate metric produces invalid json
> --
>
> Key: SLING-11197
> URL: https://issues.apache.org/jira/browse/SLING-11197
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.12
>Reporter: Dirk Rudolph
>Assignee: Dirk Rudolph
>Priority: Major
> Fix For: GraphQL Core 0.0.14
>
>
> The GraphQLServlet may produce a NaN for the cache hit rate metric resulting
> in a hard to parse json.
>
> {code:java}
> "sling:org.apache.sling.graphql.core.servlet.GraphQLServlet.rt:my/rt.m:GET_POST.e:json.cache_hit_rate":
> {
> "value": NaN
> }{code}
> NaN is not an allowed value according to https://www.json.org/json-en.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11429) OSGi configs on same resource type cause IAE
[
https://issues.apache.org/jira/browse/SLING-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu closed SLING-11429.
> OSGi configs on same resource type cause IAE
>
>
> Key: SLING-11429
> URL: https://issues.apache.org/jira/browse/SLING-11429
> Project: Sling
> Issue Type: Improvement
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.12
>Reporter: Stefan Grimm
>Assignee: Radu Cotescu
>Priority: Minor
> Fix For: GraphQL Core 0.0.14
>
>
> Currently, if we have more than one OSGi configuration for {{GraphQLServlet}}
> registered on the same resource type, the {{activate}} method throws an
> {{InvalidArgumentException}}.
> Stacktrace is:
> {noformat}
> org.apache.sling.graphql.core.servlet.GraphQLServlet bundle
> org.apache.sling.graphql.core:0.0.12
> (528)[org.apache.sling.graphql.core.servlet.GraphQLServlet(3271)] : The
> activate method has thrown an exception (java.lang.IllegalArgumentException:
> A metric named
> org.apache.sling.graphql.core.servlet.GraphQLServlet.rt:graphql/sites/components/endpoint.m:GET_POST.e:json.cache_hit_rate
> already exists)
> java.lang.IllegalArgumentException: A metric named
> org.apache.sling.graphql.core.servlet.GraphQLServlet.rt:graphql/sites/components/endpoint.m:GET_POST.e:json.cache_hit_rate
> already exists
> at com.codahale.metrics.MetricRegistry.register(MetricRegistry.java:91)
> at
> org.apache.sling.graphql.core.servlet.GraphQLServlet.activate(GraphQLServlet.java:199)
> {noformat}
> Probably some additional data should be used on top of the resource type to
> create the name for the metric(s). If that's not possible, it would at least
> be great to handle this more gracefully (log a proper error message instead
> of throwing an {{IllegalArgumentException}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-10883) Update the GraphQL implementation to use the Builder API for internal requests
[ https://issues.apache.org/jira/browse/SLING-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-10883. > Update the GraphQL implementation to use the Builder API for internal requests > -- > > Key: SLING-10883 > URL: https://issues.apache.org/jira/browse/SLING-10883 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.14 > > > Since Sling API provides a new Builder API for request objects starting with > SLING-10871, it makes sense to switch to this API rather than using the > Servlet Helpers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11248) Post empty body should fail gracefully
[
https://issues.apache.org/jira/browse/SLING-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu closed SLING-11248.
> Post empty body should fail gracefully
> --
>
> Key: SLING-11248
> URL: https://issues.apache.org/jira/browse/SLING-11248
> Project: Sling
> Issue Type: Bug
> Components: GraphQL
>Affects Versions: GraphQL Core 0.0.12
>Reporter: Thierry Ygé
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: GraphQL Core 0.0.14
>
>
> We observed following stacktrace, while this is apparently produced by some
> bot YandexBot, it seems that if an empty body is sent, it fails with 500,
> while it should gracefully fail with 400 instead.
> {noformat}
> 02.04.2022 15:43:06.848 *ERROR* [77.88.5.82 [1648914186845] POST
> /content/some_endpoint.json HTTP/1.1]
> org.apache.sling.engine.impl.SlingRequestProcessorImpl service: Uncaught
> Throwable
> at
> org.apache.sling.graphql.core.servlet.QueryParser.fromRequest(QueryParser.java:85)
> [org.apache.sling.graphql.core:0.0.12]
> at
> org.apache.sling.graphql.core.servlet.GraphQLServlet.execute(GraphQLServlet.java:304)
> [org.apache.sling.graphql.core:0.0.12]
> at
> org.apache.sling.graphql.core.servlet.GraphQLServlet.doPost(GraphQLServlet.java:273)
> [org.apache.sling.graphql.core:0.0.12]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11563) Update to Apache Sling Bundle Parent 49
[ https://issues.apache.org/jira/browse/SLING-11563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu closed SLING-11563. > Update to Apache Sling Bundle Parent 49 > --- > > Key: SLING-11563 > URL: https://issues.apache.org/jira/browse/SLING-11563 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.14 > > > Update to the latest bundle parent pom available to avoid costlier migrations > in the future. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling GraphQL Core 0.0.14
Hi, The vote has passed with the following result: +1 (binding): Radu Cotescu, Karl Pauls, Nicolas Peltier, Bertrand Delacretaz +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Radu Cotescu
[GitHub] [sling-org-apache-sling-distribution-core] kwin commented on pull request #61: SLING-11560 - Allow configuring the IdConflictPolicy and set the default to LEGACY
kwin commented on PR #61: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/61#issuecomment-1235689929 I don’t think you need to maintain your own policy but rather rely on the default which should kick in whenever https://github.com/apache/jackrabbit-filevault/blob/0b8a264140b23daf474443e30117bd77a70667de/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/ImportOptions.java#L466 returns false in https://github.com/apache/jackrabbit-filevault/blob/4062332786a31b38866be2ebd468eeb92e204150/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L389. Please rather implement the same fallback for SCD. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] balasoiuroxana commented on a diff in pull request #61: SLING-11560 - Allow configuring the IdConflictPolicy and set the default to LEGACY
balasoiuroxana commented on code in PR #61: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/61#discussion_r961794155 ## pom.xml: ## @@ -324,7 +324,7 @@ org.apache.jackrabbit.vault org.apache.jackrabbit.vault -3.4.0 +3.6.1-T20220805092633-0b8a2641 Review Comment: In that version we don't have the `LEGACY` conflict policy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results
sonarcloud[bot] commented on PR #81: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#issuecomment-1235583773 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=81) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=81=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=81=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=81=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=81=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=81=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=81=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=81=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=81=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=81=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=81=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=81=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=81=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=81=new_coverage=list) [84.1% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=81=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=81=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=81=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11566) Add methods to check whether recording is enabled
Carsten Ziegeler created SLING-11566: Summary: Add methods to check whether recording is enabled Key: SLING-11566 URL: https://issues.apache.org/jira/browse/SLING-11566 Project: Sling Issue Type: Improvement Components: Engine Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Engine 2.10.4 We should add methods to RequestInfoProvider to check whether recording is enabled in general and whether recording for a specific path is enabled. In addition, ProviderType annotation should be added to the interfaces and getMayNumberOfInfos should be deprecated (due to the name type) in favour of getMaxNumberOfInfos -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11566) Add methods to check whether recording is enabled
[ https://issues.apache.org/jira/browse/SLING-11566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11566. -- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-engine/commit/647f0a97a091224b6cc568b3e20dfe20425ff2a4 > Add methods to check whether recording is enabled > - > > Key: SLING-11566 > URL: https://issues.apache.org/jira/browse/SLING-11566 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.10.4 > > > We should add methods to RequestInfoProvider to check whether recording is > enabled in general and whether recording for a specific path is enabled. > In addition, ProviderType annotation should be added to the interfaces and > getMayNumberOfInfos should be deprecated (due to the name type) in favour of > getMaxNumberOfInfos -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-distribution-core] tmaret commented on a diff in pull request #61: SLING-11560 - Allow configuring the IdConflictPolicy and set the default to LEGACY
tmaret commented on code in PR #61: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/61#discussion_r961672308 ## pom.xml: ## @@ -324,7 +324,7 @@ org.apache.jackrabbit.vault org.apache.jackrabbit.vault -3.4.0 +3.6.1-T20220805092633-0b8a2641 Review Comment: Could you depend on the latest officially released version, `3.6.0` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results
reschke commented on code in PR #81:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961658414
##
src/test/java/org/apache/sling/resourceresolver/impl/mapping/InMemoryResourceProvider.java:
##
@@ -103,7 +103,7 @@ public Iterator findResources(@NotNull
ResolveContext ctx, Strin
.iterator();
}
-if ( "JCR-SQL2".equals(language) && "SELECT
[sling:vanityPath], [sling:redirect], [sling:redirectStatus] FROM [nt:base]
WHERE NOT isdescendantnode('/jcr:system') AND [sling:vanityPath] IS NOT
NULL".equals(query) ) {
+if ( "JCR-SQL2".equals(language) && "SELECT
[sling:vanityPath], [sling:redirect], [sling:redirectStatus] FROM [nt:base]
WHERE NOT isdescendantnode('/jcr:system') AND [sling:vanityPath] IS NOT NULL
ORDER BY FIRST([sling:vanityPath]), [jcr:path]".equals(query) ) {
Review Comment:
Yes, we'll get to that next.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results
reschke commented on code in PR #81:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961655432
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1275,25 +1276,40 @@ private static boolean isAliasValid(String alias) {
return invalid;
}
+private Iterator queryAllVanityPaths(String query) {
+log.debug("start vanityPath query: {}", query);
+long queryStart = System.nanoTime();
+final Iterator i = resolver.findResources(query, "JCR-SQL2");
+long queryElapsed = System.nanoTime() - queryStart;
Review Comment:
We do that as well (and have been doing so...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results
reschke commented on code in PR #81:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961654779
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1303,7 +1319,13 @@ private Map>
loadVanityPaths(ResourceResolver resolver) {
countInScope += 1;
final boolean addToCache = isAllVanityPathEntriesCached()
|| vanityCounter.longValue() <
this.factory.getMaxCachedVanityPathEntries();
-loadVanityPath(resource, resolveMapsMap, targetPaths,
addToCache);
+String firstVanityPath = loadVanityPath(resource,
resolveMapsMap, targetPaths, addToCache);
+if (supportsSort && firstVanityPath != null) {
+if (previousVanityPath != null &&
firstVanityPath.compareTo(previousVanityPath) < 0) {
+log.error("Sorting by first(vanityPath) does not
appear to work; got " + firstVanityPath + " after " + previousVanityPath);
Review Comment:
We're on the same server, no? Unless I'm missing something, sorting should
be strictly by Unicode code points, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] reschke commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results
reschke commented on code in PR #81:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961653653
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1275,25 +1276,40 @@ private static boolean isAliasValid(String alias) {
return invalid;
}
+private Iterator queryAllVanityPaths(String query) {
+log.debug("start vanityPath query: {}", query);
+long queryStart = System.nanoTime();
+final Iterator i = resolver.findResources(query, "JCR-SQL2");
+long queryElapsed = System.nanoTime() - queryStart;
+log.debug("end vanityPath query; elapsed {}ms",
TimeUnit.NANOSECONDS.toMillis(queryElapsed));
+return i;
+}
+
/**
* Load vanity paths - search for all nodes (except under /jcr:system)
* having a sling:vanityPath property
*/
private Map> loadVanityPaths(ResourceResolver
resolver) {
final Map> targetPaths = new
ConcurrentHashMap<>();
-final String queryString = "SELECT [sling:vanityPath],
[sling:redirect], [sling:redirectStatus]" + " FROM [nt:base]"
+final String baseQueryString = "SELECT [sling:vanityPath],
[sling:redirect], [sling:redirectStatus]" + " FROM [nt:base]"
+ " WHERE NOT isdescendantnode('" +
queryLiteral(JCR_SYSTEM_PATH) + "')"
+ " AND [sling:vanityPath] IS NOT NULL";
+final String queryStringWithSort = baseQueryString + " ORDER BY
FIRST([sling:vanityPath]), [jcr:path]";
-log.debug("start vanityPath query: {}", queryString);
-long queryStart = System.nanoTime();
-final Iterator i = resolver.findResources(queryString,
"JCR-SQL2");
-long queryElapsed = System.nanoTime() - queryStart;
-log.debug("end vanityPath query; elapsed {}ms",
TimeUnit.NANOSECONDS.toMillis(queryElapsed));
+boolean supportsSort = true;
+Iterator i;
Review Comment:
ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] thomasmueller commented on a diff in pull request #81: SLING-11541: vanity path query: attempt to query sorted by first vanity path, check results
thomasmueller commented on code in PR #81:
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/81#discussion_r961648494
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1275,25 +1276,40 @@ private static boolean isAliasValid(String alias) {
return invalid;
}
+private Iterator queryAllVanityPaths(String query) {
+log.debug("start vanityPath query: {}", query);
+long queryStart = System.nanoTime();
+final Iterator i = resolver.findResources(query, "JCR-SQL2");
+long queryElapsed = System.nanoTime() - queryStart;
Review Comment:
This will probably not do what you want, because JCR queries are processed
lazily (while iterating, not when executed). So, I would not log at this stage.
Instead, I would measure the time on a higher level, while iterating over the
result.
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1303,7 +1319,13 @@ private Map>
loadVanityPaths(ResourceResolver resolver) {
countInScope += 1;
final boolean addToCache = isAllVanityPathEntriesCached()
|| vanityCounter.longValue() <
this.factory.getMaxCachedVanityPathEntries();
-loadVanityPath(resource, resolveMapsMap, targetPaths,
addToCache);
+String firstVanityPath = loadVanityPath(resource,
resolveMapsMap, targetPaths, addToCache);
+if (supportsSort && firstVanityPath != null) {
+if (previousVanityPath != null &&
firstVanityPath.compareTo(previousVanityPath) < 0) {
+log.error("Sorting by first(vanityPath) does not
appear to work; got " + firstVanityPath + " after " + previousVanityPath);
Review Comment:
It might be that sorting on the server and sorting on the client doesn't
match for some edge cases (like, client locale doesn't match server locale).
For this reason, I would recommend to log a warning, not an error.
##
src/main/java/org/apache/sling/resourceresolver/impl/mapping/MapEntries.java:
##
@@ -1275,25 +1276,40 @@ private static boolean isAliasValid(String alias) {
return invalid;
}
+private Iterator queryAllVanityPaths(String query) {
+log.debug("start vanityPath query: {}", query);
+long queryStart = System.nanoTime();
+final Iterator i = resolver.findResources(query, "JCR-SQL2");
+long queryElapsed = System.nanoTime() - queryStart;
+log.debug("end vanityPath query; elapsed {}ms",
TimeUnit.NANOSECONDS.toMillis(queryElapsed));
+return i;
+}
+
/**
* Load vanity paths - search for all nodes (except under /jcr:system)
* having a sling:vanityPath property
*/
private Map> loadVanityPaths(ResourceResolver
resolver) {
final Map> targetPaths = new
ConcurrentHashMap<>();
-final String queryString = "SELECT [sling:vanityPath],
[sling:redirect], [sling:redirectStatus]" + " FROM [nt:base]"
+final String baseQueryString = "SELECT [sling:vanityPath],
[sling:redirect], [sling:redirectStatus]" + " FROM [nt:base]"
+ " WHERE NOT isdescendantnode('" +
queryLiteral(JCR_SYSTEM_PATH) + "')"
+ " AND [sling:vanityPath] IS NOT NULL";
+final String queryStringWithSort = baseQueryString + " ORDER BY
FIRST([sling:vanityPath]), [jcr:path]";
-log.debug("start vanityPath query: {}", queryString);
-long queryStart = System.nanoTime();
-final Iterator i = resolver.findResources(queryString,
"JCR-SQL2");
-long queryElapsed = System.nanoTime() - queryStart;
-log.debug("end vanityPath query; elapsed {}ms",
TimeUnit.NANOSECONDS.toMillis(queryElapsed));
+boolean supportsSort = true;
+Iterator i;
Review Comment:
Nitpicking: "i" is typically used for "int i"; I would use "it" for
iterators.
##
src/test/java/org/apache/sling/resourceresolver/impl/mapping/InMemoryResourceProvider.java:
##
@@ -103,7 +103,7 @@ public Iterator findResources(@NotNull
ResolveContext ctx, Strin
.iterator();
}
-if ( "JCR-SQL2".equals(language) && "SELECT
[sling:vanityPath], [sling:redirect], [sling:redirectStatus] FROM [nt:base]
WHERE NOT isdescendantnode('/jcr:system') AND [sling:vanityPath] IS NOT
NULL".equals(query) ) {
+if ( "JCR-SQL2".equals(language) && "SELECT
[sling:vanityPath], [sling:redirect], [sling:redirectStatus] FROM [nt:base]
WHERE NOT isdescendantnode('/jcr:system') AND [sling:vanityPath] IS NOT NULL
ORDER BY FIRST([sling:vanityPath]), [jcr:path]".equals(query) ) {
Review Comment:
This query doesn't use keyset pagination currently, so it can still fail
when there are many entries.
--
This is an automated message from the Apache Git Service.
To respond to
[jira] [Commented] (SLING-11490) Provide JUnit Option
[
https://issues.apache.org/jira/browse/SLING-11490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599463#comment-17599463
]
Oliver Lietz commented on SLING-11490:
--
Different/newer JUnit versions cause more issues (see [Make Pax Exam compatible
with JUnit 4.13|https://github.com/ops4j/org.ops4j.pax.exam2/issues/1072]),
sticking to JUnit 4.12 for now.
> Provide JUnit Option
>
>
> Key: SLING-11490
> URL: https://issues.apache.org/jira/browse/SLING-11490
> Project: Sling
> Issue Type: New Feature
> Components: Testing
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Testing PaxExam 4.0.0
>
>
> JUnit in Pax Exam's {{junitBundles}} Option is outdated
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-xss] rombert commented on pull request #28: SLING-7231 Move to owasp sanitizer library
rombert commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28#issuecomment-1235417417 @kwin - I think this is ready for a re-review, except for https://github.com/apache/sling-org-apache-sling-xss/pull/28#discussion_r915033485 , which I will try to complete in the following days. But it would be nice for @nonanalou to know if there are any other items which she can work on, before merging the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-xss] sonarcloud[bot] commented on pull request #28: SLING-7231 Move to owasp sanitizer library
sonarcloud[bot] commented on PR #28: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/28#issuecomment-1235415949 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-xss=28) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=28=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=28=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=28=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=28=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=28=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=28=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=28=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=28=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-xss=28=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=28=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=28=false=CODE_SMELL) [30 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-xss=28=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=28=new_coverage=list) [73.5% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=28=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=28=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-xss=28=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SLING-11505) implement MockBundleContext.getProperty(key)
[ https://issues.apache.org/jira/browse/SLING-11505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-11505. -- > implement MockBundleContext.getProperty(key) > > > Key: SLING-11505 > URL: https://issues.apache.org/jira/browse/SLING-11505 > Project: Sling > Issue Type: Task > Components: Testing >Affects Versions: Testing OSGi Mock 3.3.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Testing OSGi Mock 3.3.2 > > Time Spent: 20m > Remaining Estimate: 0h > > MockBundleContext.getProperty(key) should not return null, instead it should > at least fallback to the System.getProperty(key). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-10937) Resource in tested Sling Model not equal to Resource it was adapted from (RESOURCERESOLVER_MOCK)
[
https://issues.apache.org/jira/browse/SLING-10937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed SLING-10937.
--
> Resource in tested Sling Model not equal to Resource it was adapted from
> (RESOURCERESOLVER_MOCK)
>
>
> Key: SLING-10937
> URL: https://issues.apache.org/jira/browse/SLING-10937
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: Testing Sling Mock 3.1.2
>Reporter: Konrad Windszus
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Testing Sling Mock 3.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The resources returned from
> {{org.apache.sling.testing.mock.sling.RRMockResourceResolverWrapper}} are of
> type {{ResourceResolverResourceWrapper}} (in case the resource providers are
> empty).
> When these resources are adapted to a Sling Model, the injected resource is
> the unwrapped resource which is not equal to the wrapped resource from
> outside.
> This is due to the fact that {{ResourceResolverResourceWrapper.adaptTo(...)}}
> is not overwritten but just delegated to the underlying Resource. That makes
> the Adapter only acting on the unwrapped resource which is not equal to the
> wrapped one.
> This leads to unexpected behaviour when verifying interactions with mocks
> taking the resource as argument, as the wrapped resource is never equal to
> the resource used in the Sling Model given to the mock.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11548) sling-mock: Introduce RESOURCEPROVIDER_MOCK resource resolver type
[
https://issues.apache.org/jira/browse/SLING-11548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed SLING-11548.
--
> sling-mock: Introduce RESOURCEPROVIDER_MOCK resource resolver type
> --
>
> Key: SLING-11548
> URL: https://issues.apache.org/jira/browse/SLING-11548
> Project: Sling
> Issue Type: New Feature
> Components: Testing
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Testing Sling Mock 3.4.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> based on the new MockResourceProvider implemention in resourceresolver-mock
> (SLING-11455) we introduce a new resource resolver type
> {{RESOURCEPROVIDER_MOCK}} that's uses the ResourceProvider implementation
> instead of the MockResourceResolver.
> with this change we remove the additional wrapper layers for
> MockResourceResolverFactory and MockResourceResolver in sling-mock there were
> introduced for SLING-5922/SLING-10753 and caused various trouble because the
> wrapper layer was too simplicisty (examples for problems: SLING-10937,
> SLING-11252, [WTES-74|https://wcm-io.atlassian.net/browse/WTES-74])
> benefits of {{RESOURCEPROVIDER_MOCK}} compared to
> {{{}RESOURCERESOLVER_MOCK{}}}:
> * it used the "real" sling resource resolver implementation with full
> support for combinding multiple ResourceProvider
> * fully supports loading folders of JSON or FileVault XML content as
> described in SLING-5922/SLING-10753.
> this feature is no longer supported with {{RESOURCERESOLVER_MOCK}} and the
> error message indicated to switch to {{RESOURCEPROVIDER_MOCK}} for those
> tests that make use of this feature.
> * overall the resourceresolver behaves "closer" to the real resourceresolver
> than using MockResourceResolver alone
> drawbacks:
> * the test execution has more overhead initializing the sling
> resourceresolver implementation with a lot of magic happening behinde the
> scenes
> that's why we introduced a new resource resolver type, and did not just
> change the implementation of {{{}RESOURCERESOLVER_MOCK{}}}, and
> {{RESOURCERESOLVER_MOCK}} is still the default mode as it still serves well
> for the majority of typical use cases
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11252) RRMockResourceResolverWrapper supports no way of mocking searches
[
https://issues.apache.org/jira/browse/SLING-11252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert closed SLING-11252.
--
> RRMockResourceResolverWrapper supports no way of mocking searches
> -
>
> Key: SLING-11252
> URL: https://issues.apache.org/jira/browse/SLING-11252
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: Testing Sling Mock 3.2.2
>Reporter: Henry Kuijpers
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Testing Sling Mock 3.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Previously, it was possible to call
> ((MockResourceResolver)context.resourceResolver()).addFindResourceHandler(...)
> Currently, we have to add a "find resource handler" this way:
> {code:java}
> final Field wrappedField =
> ResourceResolverWrapper.class.getDeclaredField("wrapped");
> wrappedField.setAccessible(true);
> ((MockResourceResolver)
> wrappedField.get(context.resourceResolver())).addFindResourceHandler((s, s1)
> -> {
> assertEquals("my-language", s);
> assertEquals("search term", s1);
> return contentResource.listChildren();
> });
> {code}
> This wrapping seems to have been added in:
> https://github.com/apache/sling-org-apache-sling-testing-sling-mock/commit/a6d01ff058d422ff544c2a137b42291bd550f603
> We could add logic that consults the ResourceProviders to see if they can
> execute the custom search that we'd like to do, or, we could add the methods
> also on RRMockResourceResolverWrapper.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11455) ResourceResolver Mock: ResourceProvider implementation
[ https://issues.apache.org/jira/browse/SLING-11455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-11455. -- > ResourceResolver Mock: ResourceProvider implementation > -- > > Key: SLING-11455 > URL: https://issues.apache.org/jira/browse/SLING-11455 > Project: Sling > Issue Type: New Feature > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing ResourceResolver Mock 1.4.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > ResourceResolver Mock currently supports only directly creating a mocked > ResourceResolver instances, which is fine for most testing use cases. > however, since introduction of SLING-5922 we allow mounting of additional > test resources into the resource tree via FSResourceProvider, and are > currently using a rough hand-build intergration of MockResourceResolver and > this resource provider. this has some flaws and unwanted side-effects, > SLING-10937 is one of it. > we need a ResourceProvider implementation as alternative, backed by all the > existing functionality. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11457) ResourceResolver Mock: Use compile scope for OSGi dependencies
[ https://issues.apache.org/jira/browse/SLING-11457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert closed SLING-11457. -- > ResourceResolver Mock: Use compile scope for OSGi dependencies > -- > > Key: SLING-11457 > URL: https://issues.apache.org/jira/browse/SLING-11457 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Minor > Fix For: Testing ResourceResolver Mock 1.4.0 > > > similar to the other sling-mock and related modules the dependencies to the > individual OSGi artifacts should be defined with "compile" scope - to ensure > that projects that are importing this in test scope for testing do not have > to declare them additionally. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0
(resent again with proper subject - "[RESULT]" was missing) -Original Message- From: Stefan Seifert Sent: Friday, September 2, 2022 1:11 PM To: dev@sling.apache.org Subject: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0 Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Carsten Ziegeler, Jörg Hoh I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. stefan
[VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0
Hi, The vote has passed with the following result : +1 (binding): Stefan Seifert, Carsten Ziegeler, Jörg Hoh I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. stefan
Re: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0
+1 Am Fr., 2. Sept. 2022 um 11:44 Uhr schrieb Stefan Seifert : > one binding vote is missing - anyone? > > stefan > > -Original Message- > From: Stefan Seifert > Sent: Monday, August 29, 2022 3:42 PM > To: dev@sling.apache.org > Subject: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, > OSGi Mock 3.3.2, Sling Mock 3.4.0 > > Hi, > > Testing ResourceResolver Mock 1.4.0 (2 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12351705 > > Testing OSGi Mock 3.3.2 (1 issue) > https://issues.apache.org/jira/browse/SLING/fixforversion/12351706 > > Testing Sling Mock 3.4.0 (3 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12352060 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2671/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2671 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
RE: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0
one binding vote is missing - anyone? stefan -Original Message- From: Stefan Seifert Sent: Monday, August 29, 2022 3:42 PM To: dev@sling.apache.org Subject: [VOTE] Release Apache Sling Testing ResourceResolver Mock 1.4.0, OSGi Mock 3.3.2, Sling Mock 3.4.0 Hi, Testing ResourceResolver Mock 1.4.0 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12351705 Testing OSGi Mock 3.3.2 (1 issue) https://issues.apache.org/jira/browse/SLING/fixforversion/12351706 Testing Sling Mock 3.4.0 (3 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12352060 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2671/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2671 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan
