[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #3: SLING-11382: Sling update to 47

sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1444833856 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0

sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1444806781 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Commented] (SLING-11421) Use DocView serialisation classes from FileVault

[ https://issues.apache.org/jira/browse/SLING-11421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693186#comment-17693186 ] Stefan Seifert commented on SLING-11421: SLING-11785 describes one escaping problem which exists

[jira] [Updated] (SLING-11421) Use DocView serialisation classes from FileVault

[ https://issues.apache.org/jira/browse/SLING-11421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-11421: --- Fix Version/s: Content-Package to Feature Model Converter 1.3.2 > Use DocView serialisation

[jira] [Resolved] (SLING-11616) Fix Sling-Initial-Content Handling on Windows, Fix Unit Tests on Windows

[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-11616. Resolution: Fixed > Fix Sling-Initial-Content Handling on Windows, Fix Unit Tests on

[jira] [Updated] (SLING-11616) Fix Sling-Initial-Content Handling on Windows, Fix Unit Tests on Windows

[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-11616: --- Summary: Fix Sling-Initial-Content Handling on Windows, Fix Unit Tests on Windows (was:

[GitHub] [sling-org-apache-sling-feature-cpconverter] stefanseifert merged pull request #159: SLING-11616 Fix build and unit tests with Windows

stefanseifert merged PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin closed pull request #147: Build on ASF Jenkins with Windows

kwin closed pull request #147: Build on ASF Jenkins with Windows URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #147: Build on ASF Jenkins with Windows

kwin commented on PR #147: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/147#issuecomment-1443594241 Superseded by #159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [sling-org-apache-sling-feature-cpconverter] stefanseifert commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

stefanseifert commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116878148 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private

[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #43: SLING-11748 - Improve logging output of HTTP retries in testing clients

sonarcloud[bot] commented on PR #43: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/43#issuecomment-1443560621 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #159: SLING-11616 Fix build and unit tests with Windows

sonarcloud[bot] commented on PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#issuecomment-1443557738 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-testing-clients] marcpf opened a new pull request, #43: SLING-11748 - Improve logging output of HTTP retries in testing clients

marcpf opened a new pull request, #43: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/43 https://issues.apache.org/jira/browse/SLING-11748 This is a follow up of #42. I came to conclude that logging the request headers is a security risk and propose to

[jira] [Closed] (SLING-11781) Update to commons fileupload 1.5

[ https://issues.apache.org/jira/browse/SLING-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-11781. > Update to commons fileupload 1.5 > > >

[jira] [Closed] (SLING-11740) DefaultErrorHandler should not catch Error

[ https://issues.apache.org/jira/browse/SLING-11740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-11740. > DefaultErrorHandler should not catch Error > -- > >

[jira] [Closed] (SLING-11722) The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API

[ https://issues.apache.org/jira/browse/SLING-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-11722. > The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher > API >

[jira] [Closed] (SLING-11766) Revert parts of SLING-11702 and invoke error handlers on include again

[ https://issues.apache.org/jira/browse/SLING-11766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-11766. > Revert parts of SLING-11702 and invoke error handlers on include again >

[VOTE RESULT] Release Apache Sling Engine 2.14.0

The vote passed with five binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe cziege...@apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

kwin commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116837763 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private void

[GitHub] [sling-org-apache-sling-feature-cpconverter] stefanseifert commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

stefanseifert commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116832196 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private

[GitHub] [sling-org-apache-sling-feature-cpconverter] stefanseifert commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

stefanseifert commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116832196 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

kwin commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116814303 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private void

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

kwin commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116814303 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private void

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

kwin commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116814303 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private void

[GitHub] [sling-org-apache-sling-feature-cpconverter] reschke merged pull request #160: fix header markup (bad WS?)

reschke merged PR #160: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows

kwin commented on code in PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116806497 ## src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java: ## @@ -145,7 +147,7 @@ private void

[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML

[ https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693123#comment-17693123 ] Stefan Seifert commented on SLING-11785: yes, completing SLING-11421 would be good. the ancient

[jira] [Assigned] (SLING-11421) Use DocView serialisation classes from FileVault

[ https://issues.apache.org/jira/browse/SLING-11421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-11421: --- Assignee: (was: Konrad Windszus) > Use DocView serialisation classes from

[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML

[ https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693121#comment-17693121 ] Konrad Windszus commented on SLING-11785: - I agree this should be removed and instead

[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML

[ https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693118#comment-17693118 ] Julian Reschke commented on SLING-11785: FWIW, I don't see no escaping there at all. Would need

[jira] [Commented] (SLING-11775) Update the Sling Resource Merger to parent pom version 49

[ https://issues.apache.org/jira/browse/SLING-11775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693114#comment-17693114 ] Radu Cotescu commented on SLING-11775: -- Fixed in

[jira] [Resolved] (SLING-11775) Update the Sling Resource Merger to parent pom version 49

[ https://issues.apache.org/jira/browse/SLING-11775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-11775. -- Resolution: Fixed > Update the Sling Resource Merger to parent pom version 49 >

[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML

[ https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693112#comment-17693112 ] Stefan Seifert commented on SLING-11785: [~reschke] [~kwin] in my pov the code in

[jira] [Created] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML

Stefan Seifert created SLING-11785: -- Summary: cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML Key: SLING-11785 URL: https://issues.apache.org/jira/browse/SLING-11785

[jira] [Updated] (SLING-11616) Build and test with Windows

[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-11616: --- Fix Version/s: Content-Package to Feature Model Converter 1.3.2 > Build and test with

[jira] [Commented] (SLING-11616) Build and test with Windows

[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693093#comment-17693093 ] Stefan Seifert commented on SLING-11616: i ignored the test case

[GitHub] [sling-org-apache-sling-feature-cpconverter] stefanseifert commented on pull request #159: SLING-11616 Fix build and unit tests with Windows

stefanseifert commented on PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#issuecomment-1443300889 @kwin can you have a look? all tests pass on windows and linux. and if i run aemanalyser with this snapshot with the test project from

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #159: SLING-11616 Fix build and unit tests with Windows

sonarcloud[bot] commented on PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#issuecomment-1443286267 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #160: fix header markup (bad WS?)

sonarcloud[bot] commented on PR #160: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/160#issuecomment-1443271815 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Commented] (SLING-11616) Build and test with Windows

[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693086#comment-17693086 ] Stefan Seifert commented on SLING-11616: bq. java.nio.file.InvalidPathException: Illegal char

[jira] [Comment Edited] (SLING-11616) Build and test with Windows

[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693081#comment-17693081 ] Julian Reschke edited comment on SLING-11616 at 2/24/23 8:57 AM: - bq.

[jira] [Commented] (SLING-11616) Build and test with Windows

[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693083#comment-17693083 ] Konrad Windszus commented on SLING-11616: - This has been added in

[jira] [Commented] (SLING-11616) Build and test with Windows

[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693081#comment-17693081 ] Julian Reschke commented on SLING-11616: bq. this is obivously not a valid file name on windows

[jira] [Commented] (SLING-11616) Build and test with Windows

[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693074#comment-17693074 ] Stefan Seifert commented on SLING-11616: [~kwin] the test