[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #3: SLING-11382: Sling update to 47
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1444833856 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jms=3) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-caconfig-integration-tests] sonarcloud[bot] commented on pull request #1: SLING-11114 update SLING API to 2.21.0
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1444806781 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-caconfig-integration-tests=1=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11421) Use DocView serialisation classes from FileVault
[
https://issues.apache.org/jira/browse/SLING-11421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693186#comment-17693186
]
Stefan Seifert commented on SLING-11421:
SLING-11785 describes one escaping problem which exists because the filevault
serialization is hand-made - it's not unlikely there are more issues yet
uncovered.
> Use DocView serialisation classes from FileVault
>
>
> Key: SLING-11421
> URL: https://issues.apache.org/jira/browse/SLING-11421
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> Instead of doing another implementation on enhanced DocView serialisation (in
> {{XMLNode}} and {{XMLNodeToXMLFileWriter}}), one should rather reuse the
> functionality provided by FileVault in
> https://github.com/apache/jackrabbit-filevault/blob/master/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewNode2.java.
> That would also allow to get rid of the ancient {{staxutils}} dependency
> (https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/c95e677562c114bca877abdde8fa789b87f69e0d/pom.xml#L260-L265).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11421) Use DocView serialisation classes from FileVault
[
https://issues.apache.org/jira/browse/SLING-11421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-11421:
---
Fix Version/s: Content-Package to Feature Model Converter 1.3.2
> Use DocView serialisation classes from FileVault
>
>
> Key: SLING-11421
> URL: https://issues.apache.org/jira/browse/SLING-11421
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> Instead of doing another implementation on enhanced DocView serialisation (in
> {{XMLNode}} and {{XMLNodeToXMLFileWriter}}), one should rather reuse the
> functionality provided by FileVault in
> https://github.com/apache/jackrabbit-filevault/blob/master/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewNode2.java.
> That would also allow to get rid of the ancient {{staxutils}} dependency
> (https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/c95e677562c114bca877abdde8fa789b87f69e0d/pom.xml#L260-L265).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-11616) Fix Sling-Initial-Content Handling on Windows, Fix Unit Tests on Windows
[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-11616. Resolution: Fixed > Fix Sling-Initial-Content Handling on Windows, Fix Unit Tests on Windows > > > Key: SLING-11616 > URL: https://issues.apache.org/jira/browse/SLING-11616 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.0 >Reporter: Konrad Windszus >Assignee: Stefan Seifert >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > The ASF Jenkins should build and test on Windows as well to prevent issues > like SLING-11615. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-11616) Fix Sling-Initial-Content Handling on Windows, Fix Unit Tests on Windows
[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-11616: --- Summary: Fix Sling-Initial-Content Handling on Windows, Fix Unit Tests on Windows (was: Build and test with Windows) fixed with https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commits/master not only the unit tests were affected, the whole Sling-Initial-Content handling did not work properly when executing on windows. this is fixed. > Fix Sling-Initial-Content Handling on Windows, Fix Unit Tests on Windows > > > Key: SLING-11616 > URL: https://issues.apache.org/jira/browse/SLING-11616 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.0 >Reporter: Konrad Windszus >Assignee: Stefan Seifert >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > The ASF Jenkins should build and test on Windows as well to prevent issues > like SLING-11615. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] stefanseifert merged pull request #159: SLING-11616 Fix build and unit tests with Windows
stefanseifert merged PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin closed pull request #147: Build on ASF Jenkins with Windows
kwin closed pull request #147: Build on ASF Jenkins with Windows URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on pull request #147: Build on ASF Jenkins with Windows
kwin commented on PR #147: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/147#issuecomment-1443594241 Superseded by #159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] stefanseifert commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows
stefanseifert commented on code in PR #159:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116878148
##
src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java:
##
@@ -145,7 +147,7 @@ private void write(JsonGenerator json, DocViewNode2 index,
String parentPath) th
json.writeStartObject(JcrConstants.JCR_CONTENT);
String blobAsString = new String(binary.get(),
StandardCharsets.UTF_8);
write(json, JcrConstants.JCR_PRIMARYTYPE,
Collections.singletonList(JcrConstants.NT_RESOURCE), s ->
Json.createValue("nam:" + s ));
-write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(nodePath))),
Json::createValue );
+write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(FilenameUtils.getName(nodePath,
Json::createValue );
Review Comment:
i've applied PlatformNameFormat.getPlatformName
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] sonarcloud[bot] commented on pull request #43: SLING-11748 - Improve logging output of HTTP retries in testing clients
sonarcloud[bot] commented on PR #43: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/43#issuecomment-1443560621 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-clients=43) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=43=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=43=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=43=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=43=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=43=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=43=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients=43=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients=43=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-clients=43=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=43=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=43=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-clients=43=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=43=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=43=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=43=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-clients=43=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #159: SLING-11616 Fix build and unit tests with Windows
sonarcloud[bot] commented on PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#issuecomment-1443557738 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=159) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=159=new_coverage=list) [83.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=159=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=159=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=159=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-clients] marcpf opened a new pull request, #43: SLING-11748 - Improve logging output of HTTP retries in testing clients
marcpf opened a new pull request, #43: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/43 https://issues.apache.org/jira/browse/SLING-11748 This is a follow up of #42. I came to conclude that logging the request headers is a security risk and propose to not log the request headers at all in this context. @dulvac , @joerghoh: Can I please ask for a second look? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SLING-11781) Update to commons fileupload 1.5
[ https://issues.apache.org/jira/browse/SLING-11781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-11781. > Update to commons fileupload 1.5 > > > Key: SLING-11781 > URL: https://issues.apache.org/jira/browse/SLING-11781 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.14.0 > > > We should update to the latest commons fileupload 1.5 and set the max file > count by default to 50 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11740) DefaultErrorHandler should not catch Error
[ https://issues.apache.org/jira/browse/SLING-11740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-11740. > DefaultErrorHandler should not catch Error > -- > > Key: SLING-11740 > URL: https://issues.apache.org/jira/browse/SLING-11740 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.13.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.14.0 > > > The DefaultErrorHandler is catching Error when it forwards to a delegate > error handler. As Error should not be caught by applications in general, we > should probably rather remove those two catch statements -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11722) The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher API
[
https://issues.apache.org/jira/browse/SLING-11722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler closed SLING-11722.
> The SlingRequestDispatcher doesn't correctly implement the RequestDispatcher
> API
>
>
> Key: SLING-11722
> URL: https://issues.apache.org/jira/browse/SLING-11722
> Project: Sling
> Issue Type: Bug
> Components: Engine
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Engine 2.14.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The {{include}} method [0] has the following important sentence in its
> documentation:
> {quote}
> The ServletResponse object has its path elements and parameters remain
> unchanged from the caller's. The included servlet cannot change the response
> status code or set headers; any attempt to make a change is ignored.
> {quote}
> However, the {{SlingRequestDispatcher}} [1] doesn't enforce this in any way.
> [0] -
> https://docs.oracle.com/javaee/7/api/javax/servlet/RequestDispatcher.html#include-javax.servlet.ServletRequest-javax.servlet.ServletResponse-
> [1] -
> https://github.com/apache/sling-org-apache-sling-engine/blob/bbc6acca70e7a27386f47fa9733af3740985f375/src/main/java/org/apache/sling/engine/impl/request/SlingRequestDispatcher.java#L177
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-11766) Revert parts of SLING-11702 and invoke error handlers on include again
[ https://issues.apache.org/jira/browse/SLING-11766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-11766. > Revert parts of SLING-11702 and invoke error handlers on include again > -- > > Key: SLING-11766 > URL: https://issues.apache.org/jira/browse/SLING-11766 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.13.0 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.14.0 > > > It seems that part of SLING-11702, particularly not invoking error handlers > on include anymore, is causing regressions. Therefore we should need to > revert this bit -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE RESULT] Release Apache Sling Engine 2.14.0
The vote passed with five binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe cziege...@apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows
kwin commented on code in PR #159:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116837763
##
src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java:
##
@@ -145,7 +147,7 @@ private void write(JsonGenerator json, DocViewNode2 index,
String parentPath) th
json.writeStartObject(JcrConstants.JCR_CONTENT);
String blobAsString = new String(binary.get(),
StandardCharsets.UTF_8);
write(json, JcrConstants.JCR_PRIMARYTYPE,
Collections.singletonList(JcrConstants.NT_RESOURCE), s ->
Json.createValue("nam:" + s ));
-write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(nodePath))),
Json::createValue );
+write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(FilenameUtils.getName(nodePath,
Json::createValue );
Review Comment:
still nodeName != fileName due to the escaping rules of FileVault.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] stefanseifert commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows
stefanseifert commented on code in PR #159:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116832196
##
src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java:
##
@@ -145,7 +147,7 @@ private void write(JsonGenerator json, DocViewNode2 index,
String parentPath) th
json.writeStartObject(JcrConstants.JCR_CONTENT);
String blobAsString = new String(binary.get(),
StandardCharsets.UTF_8);
write(json, JcrConstants.JCR_PRIMARYTYPE,
Collections.singletonList(JcrConstants.NT_RESOURCE), s ->
Json.createValue("nam:" + s ));
-write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(nodePath))),
Json::createValue );
+write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(FilenameUtils.getName(nodePath,
Json::createValue );
Review Comment:
i've seen the nodePath is constructed a few lines above, using directly
nodeName instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] stefanseifert commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows
stefanseifert commented on code in PR #159:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116832196
##
src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java:
##
@@ -145,7 +147,7 @@ private void write(JsonGenerator json, DocViewNode2 index,
String parentPath) th
json.writeStartObject(JcrConstants.JCR_CONTENT);
String blobAsString = new String(binary.get(),
StandardCharsets.UTF_8);
write(json, JcrConstants.JCR_PRIMARYTYPE,
Collections.singletonList(JcrConstants.NT_RESOURCE), s ->
Json.createValue("nam:" + s ));
-write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(nodePath))),
Json::createValue );
+write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(FilenameUtils.getName(nodePath,
Json::createValue );
Review Comment:
i've seend the nodePath is constructed a few lines above, using directly
nodeName instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows
kwin commented on code in PR #159:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116814303
##
src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java:
##
@@ -145,7 +147,7 @@ private void write(JsonGenerator json, DocViewNode2 index,
String parentPath) th
json.writeStartObject(JcrConstants.JCR_CONTENT);
String blobAsString = new String(binary.get(),
StandardCharsets.UTF_8);
write(json, JcrConstants.JCR_PRIMARYTYPE,
Collections.singletonList(JcrConstants.NT_RESOURCE), s ->
Json.createValue("nam:" + s ));
-write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(nodePath))),
Json::createValue );
+write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(FilenameUtils.getName(nodePath,
Json::createValue );
Review Comment:
Maybe also the variable naming is just confusing because FS path !=
repository path. Not sure what node path is supposed to contain here. To
convert from one to the other use
https://github.com/apache/jackrabbit-filevault/blob/master/vault-core/src/main/java/org/apache/jackrabbit/vault/util/PlatformNameFormat.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows
kwin commented on code in PR #159:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116814303
##
src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java:
##
@@ -145,7 +147,7 @@ private void write(JsonGenerator json, DocViewNode2 index,
String parentPath) th
json.writeStartObject(JcrConstants.JCR_CONTENT);
String blobAsString = new String(binary.get(),
StandardCharsets.UTF_8);
write(json, JcrConstants.JCR_PRIMARYTYPE,
Collections.singletonList(JcrConstants.NT_RESOURCE), s ->
Json.createValue("nam:" + s ));
-write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(nodePath))),
Json::createValue );
+write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(FilenameUtils.getName(nodePath,
Json::createValue );
Review Comment:
Maybe also the variable naming is just confusing because FS path !=
repository path. Not sure what node path is supposed to contain here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows
kwin commented on code in PR #159:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116814303
##
src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java:
##
@@ -145,7 +147,7 @@ private void write(JsonGenerator json, DocViewNode2 index,
String parentPath) th
json.writeStartObject(JcrConstants.JCR_CONTENT);
String blobAsString = new String(binary.get(),
StandardCharsets.UTF_8);
write(json, JcrConstants.JCR_PRIMARYTYPE,
Collections.singletonList(JcrConstants.NT_RESOURCE), s ->
Json.createValue("nam:" + s ));
-write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(nodePath))),
Json::createValue );
+write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(FilenameUtils.getName(nodePath,
Json::createValue );
Review Comment:
Maybe also the variable naming is just confusing because FS path name !=
repository path name. Not sure what node path is supposed to contain here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] reschke merged pull request #160: fix header markup (bad WS?)
reschke merged PR #160: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #159: SLING-11616 Fix build and unit tests with Windows
kwin commented on code in PR #159:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#discussion_r1116806497
##
src/main/java/org/apache/sling/feature/cpconverter/index/IndexDefinitionsJsonWriter.java:
##
@@ -145,7 +147,7 @@ private void write(JsonGenerator json, DocViewNode2 index,
String parentPath) th
json.writeStartObject(JcrConstants.JCR_CONTENT);
String blobAsString = new String(binary.get(),
StandardCharsets.UTF_8);
write(json, JcrConstants.JCR_PRIMARYTYPE,
Collections.singletonList(JcrConstants.NT_RESOURCE), s ->
Json.createValue("nam:" + s ));
-write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(nodePath))),
Json::createValue );
+write(json,
JcrConstants.JCR_MIMETYPE,Collections.singletonList(Files.probeContentType(Paths.get(FilenameUtils.getName(nodePath,
Json::createValue );
Review Comment:
For JCR Paths I would rather use
https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/util/Text.java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML
[
https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693123#comment-17693123
]
Stefan Seifert commented on SLING-11785:
yes, completing SLING-11421 would be good. the ancient staxutils are also part
of the trouble in SLING-11616.
> cpconverter: Sling-Initial-Content String values are not properly escaped in
> DocView XML
>
>
> Key: SLING-11785
> URL: https://issues.apache.org/jira/browse/SLING-11785
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.0
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> it seems the cpconverter is not properly escaping string values read from
> Sling-Initial-Content JSON files and then converting to DocView XML.
> in this sample project:
> https://github.com/stefanseifert/aem-cloud-service-deployment-issues/tree/feature/archetype-40-DRND-202-escaping
> i've introduces in [this
> commit|https://github.com/stefanseifert/aem-cloud-service-deployment-issues/commit/866fab64b6280c213e93dbbe5c9791f1a9877f5b]
> a JSON file in Sling-Initial-Content containing two strings with regexp
> containing "\". those strings are transferred 1:1 to the DocView XML in the
> content package, which is wrong. the "\" has to be escaped to be re-read
> properly via JCR API.
> it seems the escaping rules applied by
> {{org.apache.jackrabbit.vault.util.DocViewProperty#format}} are missing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-11421) Use DocView serialisation classes from FileVault
[
https://issues.apache.org/jira/browse/SLING-11421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-11421:
---
Assignee: (was: Konrad Windszus)
> Use DocView serialisation classes from FileVault
>
>
> Key: SLING-11421
> URL: https://issues.apache.org/jira/browse/SLING-11421
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Konrad Windszus
>Priority: Major
>
> Instead of doing another implementation on enhanced DocView serialisation (in
> {{XMLNode}} and {{XMLNodeToXMLFileWriter}}), one should rather reuse the
> functionality provided by FileVault in
> https://github.com/apache/jackrabbit-filevault/blob/master/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewNode2.java.
> That would also allow to get rid of the ancient {{staxutils}} dependency
> (https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/c95e677562c114bca877abdde8fa789b87f69e0d/pom.xml#L260-L265).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML
[
https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693121#comment-17693121
]
Konrad Windszus commented on SLING-11785:
-
I agree this should be removed and instead
https://github.com/apache/jackrabbit-filevault/blob/master/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewNode2.java
should be used. But I think this is already tracked in SLING-11421.
> cpconverter: Sling-Initial-Content String values are not properly escaped in
> DocView XML
>
>
> Key: SLING-11785
> URL: https://issues.apache.org/jira/browse/SLING-11785
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.0
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> it seems the cpconverter is not properly escaping string values read from
> Sling-Initial-Content JSON files and then converting to DocView XML.
> in this sample project:
> https://github.com/stefanseifert/aem-cloud-service-deployment-issues/tree/feature/archetype-40-DRND-202-escaping
> i've introduces in [this
> commit|https://github.com/stefanseifert/aem-cloud-service-deployment-issues/commit/866fab64b6280c213e93dbbe5c9791f1a9877f5b]
> a JSON file in Sling-Initial-Content containing two strings with regexp
> containing "\". those strings are transferred 1:1 to the DocView XML in the
> content package, which is wrong. the "\" has to be escaped to be re-read
> properly via JCR API.
> it seems the escaping rules applied by
> {{org.apache.jackrabbit.vault.util.DocViewProperty#format}} are missing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML
[
https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693118#comment-17693118
]
Julian Reschke commented on SLING-11785:
FWIW, I don't see no escaping there at all. Would need to read some more code
to understand who's responsible for what...
> cpconverter: Sling-Initial-Content String values are not properly escaped in
> DocView XML
>
>
> Key: SLING-11785
> URL: https://issues.apache.org/jira/browse/SLING-11785
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.0
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> it seems the cpconverter is not properly escaping string values read from
> Sling-Initial-Content JSON files and then converting to DocView XML.
> in this sample project:
> https://github.com/stefanseifert/aem-cloud-service-deployment-issues/tree/feature/archetype-40-DRND-202-escaping
> i've introduces in [this
> commit|https://github.com/stefanseifert/aem-cloud-service-deployment-issues/commit/866fab64b6280c213e93dbbe5c9791f1a9877f5b]
> a JSON file in Sling-Initial-Content containing two strings with regexp
> containing "\". those strings are transferred 1:1 to the DocView XML in the
> content package, which is wrong. the "\" has to be escaped to be re-read
> properly via JCR API.
> it seems the escaping rules applied by
> {{org.apache.jackrabbit.vault.util.DocViewProperty#format}} are missing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11775) Update the Sling Resource Merger to parent pom version 49
[ https://issues.apache.org/jira/browse/SLING-11775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693114#comment-17693114 ] Radu Cotescu commented on SLING-11775: -- Fixed in https://github.com/apache/sling-org-apache-sling-resourcemerger/commit/622f3b3fae9cacb8a846a027a661fab6a4e673d7. > Update the Sling Resource Merger to parent pom version 49 > - > > Key: SLING-11775 > URL: https://issues.apache.org/jira/browse/SLING-11775 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Resource Merger 1.4.2 > > > The Sling Resource Merger should use the latest available parent pom. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11775) Update the Sling Resource Merger to parent pom version 49
[ https://issues.apache.org/jira/browse/SLING-11775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-11775. -- Resolution: Fixed > Update the Sling Resource Merger to parent pom version 49 > - > > Key: SLING-11775 > URL: https://issues.apache.org/jira/browse/SLING-11775 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: Resource Merger 1.4.2 > > > The Sling Resource Merger should use the latest available parent pom. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML
[
https://issues.apache.org/jira/browse/SLING-11785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693112#comment-17693112
]
Stefan Seifert commented on SLING-11785:
[~reschke] [~kwin] in my pov the code in
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/f01d77a60949595f9d266fcc06a72e243078902d/src/main/java/org/apache/sling/feature/cpconverter/handlers/slinginitialcontent/xmlbuffer/XMLNode.java
has be refactored to use the jackrabbit vault API to encode the values,
instead of doing it manually (incomplete) with string operations.
WDYT?
> cpconverter: Sling-Initial-Content String values are not properly escaped in
> DocView XML
>
>
> Key: SLING-11785
> URL: https://issues.apache.org/jira/browse/SLING-11785
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.0
>Reporter: Stefan Seifert
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.3.2
>
>
> it seems the cpconverter is not properly escaping string values read from
> Sling-Initial-Content JSON files and then converting to DocView XML.
> in this sample project:
> https://github.com/stefanseifert/aem-cloud-service-deployment-issues/tree/feature/archetype-40-DRND-202-escaping
> i've introduces in [this
> commit|https://github.com/stefanseifert/aem-cloud-service-deployment-issues/commit/866fab64b6280c213e93dbbe5c9791f1a9877f5b]
> a JSON file in Sling-Initial-Content containing two strings with regexp
> containing "\". those strings are transferred 1:1 to the DocView XML in the
> content package, which is wrong. the "\" has to be escaped to be re-read
> properly via JCR API.
> it seems the escaping rules applied by
> {{org.apache.jackrabbit.vault.util.DocViewProperty#format}} are missing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11785) cpconverter: Sling-Initial-Content String values are not properly escaped in DocView XML
Stefan Seifert created SLING-11785:
--
Summary: cpconverter: Sling-Initial-Content String values are not
properly escaped in DocView XML
Key: SLING-11785
URL: https://issues.apache.org/jira/browse/SLING-11785
Project: Sling
Issue Type: Bug
Components: Content-Package to Feature Model Converter
Affects Versions: Content-Package to Feature Model Converter 1.3.0
Reporter: Stefan Seifert
Fix For: Content-Package to Feature Model Converter 1.3.2
it seems the cpconverter is not properly escaping string values read from
Sling-Initial-Content JSON files and then converting to DocView XML.
in this sample project:
https://github.com/stefanseifert/aem-cloud-service-deployment-issues/tree/feature/archetype-40-DRND-202-escaping
i've introduces in [this
commit|https://github.com/stefanseifert/aem-cloud-service-deployment-issues/commit/866fab64b6280c213e93dbbe5c9791f1a9877f5b]
a JSON file in Sling-Initial-Content containing two strings with regexp
containing "\". those strings are transferred 1:1 to the DocView XML in the
content package, which is wrong. the "\" has to be escaped to be re-read
properly via JCR API.
it seems the escaping rules applied by
{{org.apache.jackrabbit.vault.util.DocViewProperty#format}} are missing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11616) Build and test with Windows
[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-11616: --- Fix Version/s: Content-Package to Feature Model Converter 1.3.2 > Build and test with Windows > --- > > Key: SLING-11616 > URL: https://issues.apache.org/jira/browse/SLING-11616 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.0 >Reporter: Konrad Windszus >Assignee: Stefan Seifert >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.3.2 > > > The ASF Jenkins should build and test on Windows as well to prevent issues > like SLING-11615. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11616) Build and test with Windows
[
https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693093#comment-17693093
]
Stefan Seifert commented on SLING-11616:
i ignored the test case {{testSlingInitialContentWithSpecialCharacters}} on
windows, please have a look at the PR
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159
if we can merge it.
> Build and test with Windows
> ---
>
> Key: SLING-11616
> URL: https://issues.apache.org/jira/browse/SLING-11616
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.0
>Reporter: Konrad Windszus
>Assignee: Stefan Seifert
>Priority: Major
>
> The ASF Jenkins should build and test on Windows as well to prevent issues
> like SLING-11615.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-feature-cpconverter] stefanseifert commented on pull request #159: SLING-11616 Fix build and unit tests with Windows
stefanseifert commented on PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#issuecomment-1443300889 @kwin can you have a look? all tests pass on windows and linux. and if i run aemanalyser with this snapshot with the test project from https://github.com/wcm-io/io.wcm.caconfig.editor/issues/10, is can see the expected warnings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #159: SLING-11616 Fix build and unit tests with Windows
sonarcloud[bot] commented on PR #159: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/159#issuecomment-1443286267 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=159) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=159=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=159=new_coverage=list) [83.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=159=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=159=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=159=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #160: fix header markup (bad WS?)
sonarcloud[bot] commented on PR #160: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/160#issuecomment-1443271815 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-cpconverter=160) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=160=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=160=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=160=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-11616) Build and test with Windows
[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693086#comment-17693086 ] Stefan Seifert commented on SLING-11616: bq. java.nio.file.InvalidPathException: Illegal char <:> at index 4: /oak:index/lucene/tika/config.xml no, this one i have alredy fixed. the related code did not use the full path at all, but only the file name to detect the content type - i've reduced the code to only check the filename. > Build and test with Windows > --- > > Key: SLING-11616 > URL: https://issues.apache.org/jira/browse/SLING-11616 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.0 >Reporter: Konrad Windszus >Assignee: Stefan Seifert >Priority: Major > > The ASF Jenkins should build and test on Windows as well to prevent issues > like SLING-11615. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (SLING-11616) Build and test with Windows
[
https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693081#comment-17693081
]
Julian Reschke edited comment on SLING-11616 at 2/24/23 8:57 AM:
-
bq. this is obivously not a valid file name on windows
Well, the FS supports that (I can roundtrip between Cygwin and WSL just fine).
It's just that the Windows command shell and Explorer are confused. I believe
these should be fine.
EDIT:
so it's
{noformat}
java.nio.file.InvalidPathException: Illegal char <:> at index 4:
/oak:index/lucene/tika/config.xml
at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182)
at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153)
at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
at sun.nio.fs.WindowsPath.parse(WindowsPath.java:94)
at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:255)
at java.nio.file.Paths.get(Paths.java:84)
{noformat}
So it is Java on Windows which is extra-picky, not Windows itself.
So maybe modify the test to leave out ":".
was (Author: reschke):
bq. this is obivously not a valid file name on windows
Well, the FS supports that (I can roundtrip between Cygwin and WSL just fine).
It's just that the Windows command shell and Explorer are confused. I believe
these should be fine.
> Build and test with Windows
> ---
>
> Key: SLING-11616
> URL: https://issues.apache.org/jira/browse/SLING-11616
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.0
>Reporter: Konrad Windszus
>Assignee: Stefan Seifert
>Priority: Major
>
> The ASF Jenkins should build and test on Windows as well to prevent issues
> like SLING-11615.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11616) Build and test with Windows
[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693083#comment-17693083 ] Konrad Windszus commented on SLING-11616: - This has been added in https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/f01d77a60949595f9d266fcc06a72e243078902d by [~Sc0rpic0m] in SLING-10931. He should tell if this is relevant. Otherwise we can just execute that test on *nix. > Build and test with Windows > --- > > Key: SLING-11616 > URL: https://issues.apache.org/jira/browse/SLING-11616 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.0 >Reporter: Konrad Windszus >Assignee: Stefan Seifert >Priority: Major > > The ASF Jenkins should build and test on Windows as well to prevent issues > like SLING-11615. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11616) Build and test with Windows
[ https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693081#comment-17693081 ] Julian Reschke commented on SLING-11616: bq. this is obivously not a valid file name on windows Well, the FS supports that (I can roundtrip between Cygwin and WSL just fine). It's just that the Windows command shell and Explorer are confused. I believe these should be fine. > Build and test with Windows > --- > > Key: SLING-11616 > URL: https://issues.apache.org/jira/browse/SLING-11616 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.3.0 >Reporter: Konrad Windszus >Assignee: Stefan Seifert >Priority: Major > > The ASF Jenkins should build and test on Windows as well to prevent issues > like SLING-11615. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11616) Build and test with Windows
[
https://issues.apache.org/jira/browse/SLING-11616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693074#comment-17693074
]
Stefan Seifert commented on SLING-11616:
[~kwin] the test {{testSlingInitialContentWithSpecialCharacters}} and the used
{{mysite.core-1.0.0-SNAPSHOT-specialchars-json-inputstream.jar}} contains a
JSON file with name:
{noformat}
<"&>.json
{noformat}
this is obivously not a valid file name on windows - and i'm wondering if it's
worth to implement a special handling for such an exotic filename - very
unlikely anyone is using a file name like this. we could add a validation to
fail early with an exception (on both linux and windows) if i filename with
certain not allowed characters is used.
i think this is the only remaining issue.
> Build and test with Windows
> ---
>
> Key: SLING-11616
> URL: https://issues.apache.org/jira/browse/SLING-11616
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.3.0
>Reporter: Konrad Windszus
>Assignee: Stefan Seifert
>Priority: Major
>
> The ASF Jenkins should build and test on Windows as well to prevent issues
> like SLING-11615.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
