[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #163: [draft] remove toobig check

2023-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #163: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/163#issuecomment-1523834272 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #166: SLING-11837 - Align index definition generation logic with the one from Oak

2023-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #166: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/166#issuecomment-1523832209 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #137: Bump gson from 2.8.6 to 2.8.9

2023-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #137: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/137#issuecomment-1523831641 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-starter] enapps-enorman commented on pull request #155: SLING-11836 - Add Jakarta JSON support to the Sling Starter

2023-04-26 Thread via GitHub
enapps-enorman commented on PR #155: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/155#issuecomment-1523764136 > @enapps-enorman - I did try using the SPIFly bundle locally, but I think I did not do it properly. There is some discussion about it at

[GitHub] [sling-org-apache-sling-testing-sling-mock] raducotescu merged pull request #21: SLING-11852 - Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal

2023-04-26 Thread via GitHub
raducotescu merged PR #21: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (SLING-11849) Create osgiContext#unregisterService() for easy unregistering of services

2023-04-26 Thread Stefan Seifert (Jira)
[ https://issues.apache.org/jira/browse/SLING-11849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716762#comment-17716762 ] Stefan Seifert commented on SLING-11849: the usual way in OSGi to unregister a service is to

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2023-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-1523404500 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #31: SLING-11558 part1: remove the LocationIterator

2023-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/31#issuecomment-1523402641 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [VOTE] Release Apache Sling Servlet Helpers 1.4.6, Testing JCR Mock 1.6.8, Testing Sling Mock 3.4.6

2023-04-26 Thread Radu Cotescu
+1 > On 24 Apr 2023, at 02:28, Eric Norman wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...

[GitHub] [sling-org-apache-sling-testing-sling-mock] sonarcloud[bot] commented on pull request #21: SLING-11852 - Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal

2023-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #21: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/21#issuecomment-1523341428 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-testing-sling-mock] raducotescu commented on pull request #21: SLING-11852 - Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal

2023-04-26 Thread via GitHub
raducotescu commented on PR #21: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/21#issuecomment-1523334748 @stefanseifert, could you please tell me if you're ok with this tiny change? It was the least invasive way to fix my test setup. -- This is an

[jira] [Assigned] (SLING-11852) Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal

2023-04-26 Thread Radu Cotescu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu reassigned SLING-11852: Assignee: Radu Cotescu > Make the ThreadsafeMockAdapterManagerWrapper use an

[jira] [Created] (SLING-11852) Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal

2023-04-26 Thread Radu Cotescu (Jira)
Radu Cotescu created SLING-11852: Summary: Make the ThreadsafeMockAdapterManagerWrapper use an InheritableThreadLocal Key: SLING-11852 URL: https://issues.apache.org/jira/browse/SLING-11852 Project:

[jira] [Comment Edited] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-04-26 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716652#comment-17716652 ] Konrad Windszus edited comment on SLING-11843 at 4/26/23 11:14 AM: ---

[jira] [Comment Edited] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-04-26 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716654#comment-17716654 ] Konrad Windszus edited comment on SLING-11843 at 4/26/23 10:25 AM: ---

[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-04-26 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716654#comment-17716654 ] Konrad Windszus commented on SLING-11843: - bq. One concern that I have with Java 17 is that

[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-04-26 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716652#comment-17716652 ] Konrad Windszus commented on SLING-11843: - For me the ultimate goal of this issue to ease and

[GitHub] [sling-tooling-jenkins] kwin commented on pull request #16: SLING-11843 build on JDK11/17 with Windows and Linux by default

2023-04-26 Thread via GitHub
kwin commented on PR #16: URL: https://github.com/apache/sling-tooling-jenkins/pull/16#issuecomment-1523170026 Checking out the parent version is not that easy (IMHO the Jenkins library should not parse the pom.xml). Also I consider all modules still on parent 35 or older basically

Re: [VOTE] Release Apache Sling Rewriter version 1.3.6

2023-04-26 Thread Robert Munteanu
On Mon, 2023-04-24 at 09:29 -0500, Daniel Klco wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-04-26 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716611#comment-17716611 ] Robert Munteanu commented on SLING-11843: - One concern that I have with Java 17 is that projects

[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #155: SLING-11836 - Add Jakarta JSON support to the Sling Starter

2023-04-26 Thread via GitHub
rombert commented on PR #155: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/155#issuecomment-1523029559 @enapps-enorman - I did try using the SPIFly bundle locally, but I think I did not do it properly. There is some discussion about it at

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2023-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-1523021917 SonarCloud Quality Gate failed. [![Quality Gate

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #31: SLING-11558 part1: remove the LocationIterator

2023-04-26 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/31#issuecomment-1523019001 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Unix/Windows

2023-04-26 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716604#comment-17716604 ] Robert Munteanu commented on SLING-11843: - [~kwin] - it would help by giving maintainers a

[jira] [Resolved] (SLING-11838) Unexpected runmode inheritance behavior

2023-04-26 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11838. - Resolution: Fixed PR merged, thanks for the contribution [~dsuess]! > Unexpected

[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert merged pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-26 Thread via GitHub
rombert merged PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,