[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #23: SLING-11972 add support for java 17 build
sonarcloud[bot] commented on PR #23: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/23#issuecomment-1640792725 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-servlets-post=23) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=23=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=23=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=23=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=23=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=23=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=23=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post=23=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=23=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=23=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post=23=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=23=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=23=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=23=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post=23=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
RE: [VOTE] Apache Sling Parent & Bundle Parent 52
+1 stefan
[jira] [Commented] (SLING-11972) Make Sling Post Servlets build with Java 17
[ https://issues.apache.org/jira/browse/SLING-11972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744309#comment-17744309 ] Joerg Hoh commented on SLING-11972: --- PR https://github.com/apache/sling-org-apache-sling-servlets-post/pull/23 > Make Sling Post Servlets build with Java 17 > --- > > Key: SLING-11972 > URL: https://issues.apache.org/jira/browse/SLING-11972 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets POST 2.5.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets POST 2.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-servlets-post] joerghoh opened a new pull request, #23: SLING-11972 add support for java 17 build
joerghoh opened a new pull request, #23: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/23 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11972) Make Sling Post Servlets build with Java 17
Joerg Hoh created SLING-11972: - Summary: Make Sling Post Servlets build with Java 17 Key: SLING-11972 URL: https://issues.apache.org/jira/browse/SLING-11972 Project: Sling Issue Type: Task Components: Servlets Affects Versions: Servlets POST 2.5.0 Reporter: Joerg Hoh Fix For: Servlets POST 2.5.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11972) Make Sling Post Servlets build with Java 17
[ https://issues.apache.org/jira/browse/SLING-11972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-11972: - Assignee: Joerg Hoh > Make Sling Post Servlets build with Java 17 > --- > > Key: SLING-11972 > URL: https://issues.apache.org/jira/browse/SLING-11972 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets POST 2.5.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets POST 2.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (SLING-11971) Log duration of each PostProcessor
[ https://issues.apache.org/jira/browse/SLING-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744304#comment-17744304 ] Joerg Hoh edited comment on SLING-11971 at 7/18/23 5:32 PM: PR at https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22 was (Author: joerghoh): PR at https://github.com/apache/sling-org-apache-sling-servlets-post/pull/21 > Log duration of each PostProcessor > -- > > Key: SLING-11971 > URL: https://issues.apache.org/jira/browse/SLING-11971 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets POST 2.5.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets POST 2.5.2 > > > The Sling Post Servlet should log the duration of each postprocessor into the > RequestProgressTracker, which allows to debug potential performance issues > easier. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-servlets-post] joerghoh closed pull request #21: SLING-11971 log duration of each postprocessor
joerghoh closed pull request #21: SLING-11971 log duration of each postprocessor URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-post] pat-lego opened a new pull request, #22: Adding additional logging for sling post processors
pat-lego opened a new pull request, #22: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/22 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11971) Log duration of each PostProcessor
[ https://issues.apache.org/jira/browse/SLING-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11971: -- Fix Version/s: Servlets POST 2.5.2 > Log duration of each PostProcessor > -- > > Key: SLING-11971 > URL: https://issues.apache.org/jira/browse/SLING-11971 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets POST 2.5.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Servlets POST 2.5.2 > > > The Sling Post Servlet should log the duration of each postprocessor into the > RequestProgressTracker, which allows to debug potential performance issues > easier. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11971) Log duration of each PostProcessor
[ https://issues.apache.org/jira/browse/SLING-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744304#comment-17744304 ] Joerg Hoh commented on SLING-11971: --- PR at https://github.com/apache/sling-org-apache-sling-servlets-post/pull/21 > Log duration of each PostProcessor > -- > > Key: SLING-11971 > URL: https://issues.apache.org/jira/browse/SLING-11971 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets POST 2.5.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > The Sling Post Servlet should log the duration of each postprocessor into the > RequestProgressTracker, which allows to debug potential performance issues > easier. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-servlets-post] joerghoh opened a new pull request, #21: SLING-11971 log duration of each postprocessor
joerghoh opened a new pull request, #21: URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/21 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-11971) Log duration of each PostProcessor
[ https://issues.apache.org/jira/browse/SLING-11971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-11971: - Assignee: Joerg Hoh > Log duration of each PostProcessor > -- > > Key: SLING-11971 > URL: https://issues.apache.org/jira/browse/SLING-11971 > Project: Sling > Issue Type: Task > Components: Servlets >Affects Versions: Servlets POST 2.5.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > The Sling Post Servlet should log the duration of each postprocessor into the > RequestProgressTracker, which allows to debug potential performance issues > easier. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11971) Log duration of each PostProcessor
Joerg Hoh created SLING-11971: - Summary: Log duration of each PostProcessor Key: SLING-11971 URL: https://issues.apache.org/jira/browse/SLING-11971 Project: Sling Issue Type: Task Components: Servlets Affects Versions: Servlets POST 2.5.0 Reporter: Joerg Hoh The Sling Post Servlet should log the duration of each postprocessor into the RequestProgressTracker, which allows to debug potential performance issues easier. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-starter] renovate-bot opened a new pull request, #192: chore(deps): update dependency org.apache.sling:org.apache.sling.models.jacksonexporter to v1.1.4
renovate-bot opened a new pull request, #192: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/192 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.sling:org.apache.sling.models.jacksonexporter](https://sling.apache.org) ([source](https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-models-jacksonexporter.git)) | `1.1.2` -> `1.1.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apache/sling-org-apache-sling-starter). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11968) Use renovate to keep plug-in versions updated
[ https://issues.apache.org/jira/browse/SLING-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11968: Description: A lot of the work on the parent git repository is about keeping versions of maven plug-ins and other toos like bnd updated. This sounds like an opportunity to automate the version updates with renovate. However, we need to add some integration tests first to make sure we don't break anything. was: A lot of the work on the parent git repository is about keeping versions of maven plug-ins and other toos like bnd updated. This sounds like an opportunity to automate the version updates with renovate. > Use renovate to keep plug-in versions updated > - > > Key: SLING-11968 > URL: https://issues.apache.org/jira/browse/SLING-11968 > Project: Sling > Issue Type: Improvement > Components: Build and Source Control >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Parent 53 > > > A lot of the work on the parent git repository is about keeping versions of > maven plug-ins and other toos like bnd updated. > This sounds like an opportunity to automate the version updates with > renovate. However, we need to add some integration tests first to make sure > we don't break anything. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11968) Use renovate to keep plug-in versions updated
[ https://issues.apache.org/jira/browse/SLING-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11968: --- Assignee: (was: Robert Munteanu) > Use renovate to keep plug-in versions updated > - > > Key: SLING-11968 > URL: https://issues.apache.org/jira/browse/SLING-11968 > Project: Sling > Issue Type: Improvement > Components: Build and Source Control >Reporter: Robert Munteanu >Priority: Major > Fix For: Parent 53 > > > A lot of the work on the parent git repository is about keeping versions of > maven plug-ins and other toos like bnd updated. > This sounds like an opportunity to automate the version updates with > renovate. However, we need to add some integration tests first to make sure > we don't break anything. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11968) Use renovate to keep plug-in versions updated
[ https://issues.apache.org/jira/browse/SLING-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744280#comment-17744280 ] Robert Munteanu commented on SLING-11968: - Ack, makes sense. > Use renovate to keep plug-in versions updated > - > > Key: SLING-11968 > URL: https://issues.apache.org/jira/browse/SLING-11968 > Project: Sling > Issue Type: Improvement > Components: Build and Source Control >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Parent 53 > > > A lot of the work on the parent git repository is about keeping versions of > maven plug-ins and other toos like bnd updated. > This sounds like an opportunity to automate the version updates with renovate. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11923) Sling Events does not Build on Java 17
[
https://issues.apache.org/jira/browse/SLING-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744276#comment-17744276
]
Stefan Egli commented on SLING-11923:
-
FYI: merged https://github.com/apache/sling-org-apache-sling-event/pull/32
> Sling Events does not Build on Java 17
> --
>
> Key: SLING-11923
> URL: https://issues.apache.org/jira/browse/SLING-11923
> Project: Sling
> Issue Type: Bug
> Components: Event
>Affects Versions: Event 4.3.12
>Reporter: Dan Klco
>Assignee: Rishabh Daim
>Priority: Major
> Fix For: Event 4.3.14
>
>
> Attempting to build Sling Events with Java 17 fails with:
> {code:java}
> [main] INFO org.apache.jackrabbit.oak.plugins.index.IndexUpdate - Reindexing
> completed
> [ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.935
> s <<< FAILURE! - in org.apache.sling.event.impl.jobs.queues.TestTopicHalting
> [ERROR]
> org.apache.sling.event.impl.jobs.queues.TestTopicHalting.testUnhalting Time
> elapsed: 1.506 s <<< ERROR!
> java.lang.NoClassDefFoundError: java/security/acl/Group
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
> at
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
>
> {code}
> This class is deprecated for removal in Java 11:
> https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/security/acl/Group.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-event] stefan-egli merged pull request #32: SLING-11923 : fixed IT failures for JDK 17
stefan-egli merged PR #32: URL: https://github.com/apache/sling-org-apache-sling-event/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] commented on pull request #32: SLING-11923 : fixed IT failures for JDK 17
sonarcloud[bot] commented on PR #32: URL: https://github.com/apache/sling-org-apache-sling-event/pull/32#issuecomment-1640456579 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event=32) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=32=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=32=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=32=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=32=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=32=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=32=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] commented on pull request #32: SLING-11923 : fixed IT failures for JDK 17
sonarcloud[bot] commented on PR #32: URL: https://github.com/apache/sling-org-apache-sling-event/pull/32#issuecomment-1640453165 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event=32) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=32=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=32=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=32=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=32=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=32=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=32=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] sonarcloud[bot] commented on pull request #32: SLING-11923 : fixed IT failures for JDK 17
sonarcloud[bot] commented on PR #32: URL: https://github.com/apache/sling-org-apache-sling-event/pull/32#issuecomment-1640436748 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event=32) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=32=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=32=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event=32=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event=32=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=32=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=32=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event=32=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-engine] sonarcloud[bot] commented on pull request #38: SLING-11970 : Avoid restarting of components on configuration change
sonarcloud[bot] commented on PR #38: URL: https://github.com/apache/sling-org-apache-sling-engine/pull/38#issuecomment-1640401329 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-engine=38) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [6 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-engine=38=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-engine=38=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-engine=38=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-event] rishabhdaim commented on pull request #32: SLING-11923 : fixed IT failures for JDK 17
rishabhdaim commented on PR #32: URL: https://github.com/apache/sling-org-apache-sling-event/pull/32#issuecomment-1640397237 @stefan-egli - I have updated the `sleep(5000)` to `sleep(1)` in my fork. - `.java-version`: was added accidentally, will remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-11970) Avoid restarting of services on configuration change
Carsten Ziegeler created SLING-11970: Summary: Avoid restarting of services on configuration change Key: SLING-11970 URL: https://issues.apache.org/jira/browse/SLING-11970 Project: Sling Issue Type: Improvement Components: Engine Affects Versions: Engine 2.15.2 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Engine 2.15.4 When the configuration for the Engine changes, the components consuming this configuration all implement "modified" - so these components itself do not restart. However, components depending (referencing) the above might restart as they have a static reference. We could avoid restarting on configuration change by using dynamic (required) references -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11968) Use renovate to keep plug-in versions updated
[ https://issues.apache.org/jira/browse/SLING-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744237#comment-17744237 ] Konrad Windszus commented on SLING-11968: - This requires some ITs being added first. > Use renovate to keep plug-in versions updated > - > > Key: SLING-11968 > URL: https://issues.apache.org/jira/browse/SLING-11968 > Project: Sling > Issue Type: Improvement > Components: Build and Source Control >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Parent 53 > > > A lot of the work on the parent git repository is about keeping versions of > maven plug-ins and other toos like bnd updated. > This sounds like an opportunity to automate the version updates with renovate. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: CI Build issue for GraphQL Core
I tried to upgrade a few dependencies but eventually I am running into the issue on Java 17 that the pax-exam is not able to find the Sling service (in time). Upgrading the pax-exam to 4.3.15 lead to an issue where it is not able to find org.sl4j.LoggerFactory: java.rmi.ServerError: Error occurred in server thread; nested exception is: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory at org.ops4j.pax.exam.forked.ForkedTestContainer.start(ForkedTestContainer.java:168) … Caused by: java.rmi.ServerError: Error occurred in server thread; nested exception is: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory … Caused by: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory at org.ops4j.pax.swissbox.tracker.ServiceLookup.(ServiceLookup.java:41) ... Caused by: java.lang.ClassNotFoundException: org.slf4j.LoggerFactory … Any idea on how to fix that? - Andy > On Jul 18, 2023, at 10:46 AM, Andreas Schaefer > wrote: > > Hi Robert > > My problem is not there yet but I updated the wiki page with the issue and my > discovery so far. > > When I upgrade to Mockito-Inline 5.2.0 the compilation issue goes away but > the pax-exam IT tests are time out when looking up Sling services. > > In the past when I tried to upgrade Pax-Exam I ran into other issues so I > don’t think upgrading would work but I don’t know. > > - Andy > >> On Jul 18, 2023, at 9:59 AM, Robert Munteanu wrote: >> >> Hi Andy, >> >> On Tue, 2023-07-18 at 09:47 +0200, Andreas Schaefer wrote: >>> Hi >>> >>> For my latest PR for Sling GraphQL Core I am running into CI build >>> issues on Java 17: >>> >>> https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/3/pipeline >>> >>> Any idea on how to resolve this? >> >> [1] gathers the problem patterns we saw when migrating builds to Java >> 11/17, maybe your problem is already listed? >> >> Thanks, >> Robert >> >> [1]: >> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690 >
[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #32: SLING-11923 : fixed IT failures for JDK 17
stefan-egli commented on PR #32: URL: https://github.com/apache/sling-org-apache-sling-event/pull/32#issuecomment-1640246129 @rishabhdaim , looks like it might not be a flaky test so much anymore - but maybe it's just a very slow piece of hardware used - could you please increase the `sleep(5000)` [here in your fork](https://github.com/rishabhdaim/sling-org-apache-sling-event/blob/SLING-11923/src/test/java/org/apache/sling/event/impl/discovery/InitDelayingTopologyEventListenerTest.java#L307) to eg `sleep(1)` - just to check? thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11969) Improve the ConfigurableSerializationModuleProvider
[ https://issues.apache.org/jira/browse/SLING-11969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-11969: -- Fix Version/s: Models Jackson Exporter 1.1.6 > Improve the ConfigurableSerializationModuleProvider > --- > > Key: SLING-11969 > URL: https://issues.apache.org/jira/browse/SLING-11969 > Project: Sling > Issue Type: Task > Components: Sling Models >Reporter: Joerg Hoh >Priority: Major > Fix For: Models Jackson Exporter 1.1.6 > > > (Feedback taken over from SLING-11924) > * > https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/7/files > contains several commented out lines of code and TODO tags, would be good to > get rid of all those in the final code base > * the comments in the OSGi config definition should explicitly state that > currently only org.apache.sling.api.resource.ResourceResolver is supported. > unlike the OSGi config definition itself we can change the comments at any > time if we want to support more classes. > * and if a different class name is given for any of those parameters, a > warning should be logged that it has no effect. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-11924) ModelExporter should not serialize a ResourceResolver
[
https://issues.apache.org/jira/browse/SLING-11924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh closed SLING-11924.
-
> ModelExporter should not serialize a ResourceResolver
> -
>
> Key: SLING-11924
> URL: https://issues.apache.org/jira/browse/SLING-11924
> Project: Sling
> Issue Type: Task
> Components: Sling Models
>Affects Versions: Sling Models Jackson Exporter 1.0.2
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Models Jackson Exporter 1.1.4
>
>
> With the addition of {{ResourceResolver.getPropertyMap()}} (SLING-10895) I
> found that the serialization of a ResourceResolver can fail like this:
> {noformat}
> org.apache.sling.models.factory.ExportException:
> com.fasterxml.jackson.databind.exc.InvalidDefinitionException: No serializer
> found for class com.day.cq.wcm.core.impl.policies.ContentPolicyManagerImpl
> and no properties discovered to create BeanSerializer (to avoid exception,
> disable SerializationFeature.FAIL_ON_EMPTY_BEANS) (through reference chain:
> com.myapp.PageImpl[":items"]> [...] > com.myapp.MyModel["resolver"]
> >org.apache.sling.resourceresolver.impl.ResourceResolverImpl["propertyMap"]
> >java.util.HashMap["com.day.cq.wcm.core.impl.policies.ContentPolicyAdapterFactory.ContentPolicy"])
> at
> org.apache.sling.models.jacksonexporter.impl.JacksonExporter.export(JacksonExporter.java:138)
> [org.apache.sling.models.jacksonexporter:1.1.2]
> at
> org.apache.sling.models.impl.ModelAdapterFactory.exportModel(ModelAdapterFactory.java:1333)
> [org.apache.sling.models.impl:1.5.4]
> {noformat}
> This is caused by the fact, that a Sling Model class serializes a
> ResourceResolver, which is problematic for these 2 reasons:
> * It can fail for the above mentioned reason in an unpredictable way (for
> example, some code adds items via {{getPropertyMap().put(x,y)}} and the
> serialization fails at a totally different place.
> * The serialization of the RR discloses implementation details (e.g.
> searchpaths, or other things which might be stored in the propertyMap).
> I am not aware of any reason, why a ResourceResolver should be serialized,
> instead more specialized types should be used instead.
> For these reasons we should have a way to disable the serialization of the
> ResourceResolver. For backwards compatibility we can keep the existing
> behavior as a default, but I also see reasons why it the serialization of the
> RR should be turned off by default.
> See also the discussion on sling-dev:
> https://lists.apache.org/thread/8xl4lgfl5omv3md4drgyqqz3vmfllsom
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[RESULT][VOTE] Release Apache Sling Models Jackson Exporter 1.1.4
Hi, The vote has passed with the following result : +1 (binding): Jörg Hoh, Robert Munteanu, Daniel Klco, Stefan Seifert +1 (non binding): - I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Am Do., 13. Juli 2023 um 11:48 Uhr schrieb Jörg Hoh : > Hi, > > We solved 2 issues in this > release:https://issues.apache.org/jira/projects/SLING/versions/12351062 > > Staging > repository:https://repository.apache.org/content/repositories/orgapachesling-2767/ > > You can use this UNIX script to download the release and verify the > signatures:https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > Usage: > sh check_staged_release.sh 2767 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > > > -- > Cheers, > Jörg Hoh, > > https://cqdump.joerghoh.de > Twitter: @joerghoh > -- Cheers, Jörg Hoh, https://cqdump.joerghoh.de Twitter: @joerghoh
[jira] [Commented] (SLING-11924) ModelExporter should not serialize a ResourceResolver
[
https://issues.apache.org/jira/browse/SLING-11924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744203#comment-17744203
]
Joerg Hoh commented on SLING-11924:
---
Thanks [~sseifert], I created SLING-11969 for it.
> ModelExporter should not serialize a ResourceResolver
> -
>
> Key: SLING-11924
> URL: https://issues.apache.org/jira/browse/SLING-11924
> Project: Sling
> Issue Type: Task
> Components: Sling Models
>Affects Versions: Sling Models Jackson Exporter 1.0.2
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Models Jackson Exporter 1.1.4
>
>
> With the addition of {{ResourceResolver.getPropertyMap()}} (SLING-10895) I
> found that the serialization of a ResourceResolver can fail like this:
> {noformat}
> org.apache.sling.models.factory.ExportException:
> com.fasterxml.jackson.databind.exc.InvalidDefinitionException: No serializer
> found for class com.day.cq.wcm.core.impl.policies.ContentPolicyManagerImpl
> and no properties discovered to create BeanSerializer (to avoid exception,
> disable SerializationFeature.FAIL_ON_EMPTY_BEANS) (through reference chain:
> com.myapp.PageImpl[":items"]> [...] > com.myapp.MyModel["resolver"]
> >org.apache.sling.resourceresolver.impl.ResourceResolverImpl["propertyMap"]
> >java.util.HashMap["com.day.cq.wcm.core.impl.policies.ContentPolicyAdapterFactory.ContentPolicy"])
> at
> org.apache.sling.models.jacksonexporter.impl.JacksonExporter.export(JacksonExporter.java:138)
> [org.apache.sling.models.jacksonexporter:1.1.2]
> at
> org.apache.sling.models.impl.ModelAdapterFactory.exportModel(ModelAdapterFactory.java:1333)
> [org.apache.sling.models.impl:1.5.4]
> {noformat}
> This is caused by the fact, that a Sling Model class serializes a
> ResourceResolver, which is problematic for these 2 reasons:
> * It can fail for the above mentioned reason in an unpredictable way (for
> example, some code adds items via {{getPropertyMap().put(x,y)}} and the
> serialization fails at a totally different place.
> * The serialization of the RR discloses implementation details (e.g.
> searchpaths, or other things which might be stored in the propertyMap).
> I am not aware of any reason, why a ResourceResolver should be serialized,
> instead more specialized types should be used instead.
> For these reasons we should have a way to disable the serialization of the
> ResourceResolver. For backwards compatibility we can keep the existing
> behavior as a default, but I also see reasons why it the serialization of the
> RR should be turned off by default.
> See also the discussion on sling-dev:
> https://lists.apache.org/thread/8xl4lgfl5omv3md4drgyqqz3vmfllsom
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-11969) Improve the ConfigurableSerializationModuleProvider
Joerg Hoh created SLING-11969: - Summary: Improve the ConfigurableSerializationModuleProvider Key: SLING-11969 URL: https://issues.apache.org/jira/browse/SLING-11969 Project: Sling Issue Type: Task Components: Sling Models Reporter: Joerg Hoh (Feedback taken over from SLING-11924) * https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/7/files contains several commented out lines of code and TODO tags, would be good to get rid of all those in the final code base * the comments in the OSGi config definition should explicitly state that currently only org.apache.sling.api.resource.ResourceResolver is supported. unlike the OSGi config definition itself we can change the comments at any time if we want to support more classes. * and if a different class name is given for any of those parameters, a warning should be logged that it has no effect. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11968) Use renovate to keep plug-in versions updated
[ https://issues.apache.org/jira/browse/SLING-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744201#comment-17744201 ] Robert Munteanu commented on SLING-11968: - [~kwin] - you made most of these 'version bump' changes recently, what are your thoughts on using renovate to keep the versions up-to-date? > Use renovate to keep plug-in versions updated > - > > Key: SLING-11968 > URL: https://issues.apache.org/jira/browse/SLING-11968 > Project: Sling > Issue Type: Improvement > Components: Build and Source Control >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Parent 53 > > > A lot of the work on the parent git repository is about keeping versions of > maven plug-ins and other toos like bnd updated. > This sounds like an opportunity to automate the version updates with renovate. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11968) Use renovate to keep plug-in versions updated
Robert Munteanu created SLING-11968: --- Summary: Use renovate to keep plug-in versions updated Key: SLING-11968 URL: https://issues.apache.org/jira/browse/SLING-11968 Project: Sling Issue Type: Improvement Components: Build and Source Control Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Parent 53 A lot of the work on the parent git repository is about keeping versions of maven plug-ins and other toos like bnd updated. This sounds like an opportunity to automate the version updates with renovate. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE] Apache Sling Parent & Bundle Parent 52
Hi, We solved 2 issues in these releases: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353412=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2769/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2769 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because … This majority vote is open for at least 72 hours. Thanks in advance for voting, Konrad
[jira] [Updated] (SLING-11842) Drop Java 8 support from Parent
[ https://issues.apache.org/jira/browse/SLING-11842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11842: Fix Version/s: Parent 53 (was: Parent 52) > Drop Java 8 support from Parent > --- > > Key: SLING-11842 > URL: https://issues.apache.org/jira/browse/SLING-11842 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Priority: Major > Fix For: Parent 53 > > > Given that Java 8 is EOL since quite some time, and soon Java 21 will be the > default LTS release we should drop support for Java 8 (that allows to get rid > of some profiles and plugins like > https://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-sling-mock] sonarcloud[bot] commented on pull request #25: SLING-10391 Make use of real org.apache.sling.xss.impl.XSSAPIImpl implementation, introduce MockXSSF
sonarcloud[bot] commented on PR #25: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/25#issuecomment-1640106534 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock=25) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=25=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=25=new_coverage=list) [63.6% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=25=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=25=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=25=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-sling-mock] stefanseifert commented on pull request #24: SLING-10391 Implement encoding methods
stefanseifert commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/24#issuecomment-1640091924 thanks for the PR! i've an alternative proposal: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10391) Improve MockXSSAPIImpl
[ https://issues.apache.org/jira/browse/SLING-10391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744191#comment-17744191 ] Stefan Seifert commented on SLING-10391: looking at the implementation of the real XSSAPIImpl i'm wondering why we mock it at all - in https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/25 i've a different proposal that uses the real implementation, and introduces a mock for the rather complex implementation of XSSFilter instead. WDYT? > Improve MockXSSAPIImpl > -- > > Key: SLING-10391 > URL: https://issues.apache.org/jira/browse/SLING-10391 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: Testing Sling Mock 3.0.2 >Reporter: Henry Kuijpers >Priority: Major > > MockXSSAPIImpl only has a few very simplistic method implementations (i.e. > for encodeForHTML it returns the input as-is). > I think we can make some improvements to it, by: > * Use StringEscapeUtils.escapeHtml4() to do HTML escaping (so that we can at > least see a difference in the output) > * Use StringEscapeUtils.escapeXml() to do XML escaping > etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-testing-sling-mock] stefanseifert opened a new pull request, #25: SLING-10391 Make use of real org.apache.sling.xss.impl.XSSAPIImpl implementation, introduce MockXSSFi
stefanseifert opened a new pull request, #25: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/25 https://issues.apache.org/jira/browse/SLING-10391 alternative approach for https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-sling-mock] sonarcloud[bot] commented on pull request #24: SLING-10391 Implement encoding methods
sonarcloud[bot] commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/24#issuecomment-1640049000 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock=24) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock=24=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=24=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=24=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=24=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock=24=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
RE: [VOTE] Release Apache Sling Models Jackson Exporter 1.1.4
+1 stefan p.s. some remarks for cleanup in https://issues.apache.org/jira/browse/SLING-11924?focusedCommentId=17744179#comment-17744179
[jira] [Commented] (SLING-11924) ModelExporter should not serialize a ResourceResolver
[
https://issues.apache.org/jira/browse/SLING-11924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744179#comment-17744179
]
Stefan Seifert commented on SLING-11924:
sorry, i did not have time to look the PR for some days, it's merged and in
release process.
some partially cosmetic remarks probably for a follow-up ticket in the next
release:
*
https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/pull/7/files
contains several commented out lines of code and TODO tags, would be good to
get rid of all those in the final code base
* the comments in the OSGi config definition should explicitly state that
currently only {{org.apache.sling.api.resource.ResourceResolver}} is supported.
unlike the OSGi config definition itself we can change the comments at any time
if we want to support more classes.
* and if a different class name is given for any of those parameters, a warning
should be logged that it has no effect.
> ModelExporter should not serialize a ResourceResolver
> -
>
> Key: SLING-11924
> URL: https://issues.apache.org/jira/browse/SLING-11924
> Project: Sling
> Issue Type: Task
> Components: Sling Models
>Affects Versions: Sling Models Jackson Exporter 1.0.2
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Models Jackson Exporter 1.1.4
>
>
> With the addition of {{ResourceResolver.getPropertyMap()}} (SLING-10895) I
> found that the serialization of a ResourceResolver can fail like this:
> {noformat}
> org.apache.sling.models.factory.ExportException:
> com.fasterxml.jackson.databind.exc.InvalidDefinitionException: No serializer
> found for class com.day.cq.wcm.core.impl.policies.ContentPolicyManagerImpl
> and no properties discovered to create BeanSerializer (to avoid exception,
> disable SerializationFeature.FAIL_ON_EMPTY_BEANS) (through reference chain:
> com.myapp.PageImpl[":items"]> [...] > com.myapp.MyModel["resolver"]
> >org.apache.sling.resourceresolver.impl.ResourceResolverImpl["propertyMap"]
> >java.util.HashMap["com.day.cq.wcm.core.impl.policies.ContentPolicyAdapterFactory.ContentPolicy"])
> at
> org.apache.sling.models.jacksonexporter.impl.JacksonExporter.export(JacksonExporter.java:138)
> [org.apache.sling.models.jacksonexporter:1.1.2]
> at
> org.apache.sling.models.impl.ModelAdapterFactory.exportModel(ModelAdapterFactory.java:1333)
> [org.apache.sling.models.impl:1.5.4]
> {noformat}
> This is caused by the fact, that a Sling Model class serializes a
> ResourceResolver, which is problematic for these 2 reasons:
> * It can fail for the above mentioned reason in an unpredictable way (for
> example, some code adds items via {{getPropertyMap().put(x,y)}} and the
> serialization fails at a totally different place.
> * The serialization of the RR discloses implementation details (e.g.
> searchpaths, or other things which might be stored in the propertyMap).
> I am not aware of any reason, why a ResourceResolver should be serialized,
> instead more specialized types should be used instead.
> For these reasons we should have a way to disable the serialization of the
> ResourceResolver. For backwards compatibility we can keep the existing
> behavior as a default, but I also see reasons why it the serialization of the
> RR should be turned off by default.
> See also the discussion on sling-dev:
> https://lists.apache.org/thread/8xl4lgfl5omv3md4drgyqqz3vmfllsom
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-event] stefan-egli commented on pull request #32: SLING-11923 : fixed IT failures for JDK 17
stefan-egli commented on PR #32: URL: https://github.com/apache/sling-org-apache-sling-event/pull/32#issuecomment-1639963865 @rishabhdaim * good point about updating the wiki. Something along the lines of "paxexam 4.0 is required for Java 17" ? * `.java-version` : noticed you added this file, do we need this? ``` SLING-11923 : removed jacoco while using pax exam 4 ``` I'll ignore the test failures prior to [run 6](https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-event/job/PR-32/6/) then. Run 6 itself had a test fialure with `InitDelayingTopologyEventListenerTest.testProperties`, so perhaps that's an actual flaky test. I'd like to do some more test rounds to get a better understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: CI Build issue for GraphQL Core
Hi Robert My problem is not there yet but I updated the wiki page with the issue and my discovery so far. When I upgrade to Mockito-Inline 5.2.0 the compilation issue goes away but the pax-exam IT tests are time out when looking up Sling services. In the past when I tried to upgrade Pax-Exam I ran into other issues so I don’t think upgrading would work but I don’t know. - Andy > On Jul 18, 2023, at 9:59 AM, Robert Munteanu wrote: > > Hi Andy, > > On Tue, 2023-07-18 at 09:47 +0200, Andreas Schaefer wrote: >> Hi >> >> For my latest PR for Sling GraphQL Core I am running into CI build >> issues on Java 17: >> >> https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/3/pipeline >> >> Any idea on how to resolve this? > > [1] gathers the problem patterns we saw when migrating builds to Java > 11/17, maybe your problem is already listed? > > Thanks, > Robert > > [1]: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690
[jira] [Commented] (SLING-11967) Onboard JCR Presence to SonarCloud
[
https://issues.apache.org/jira/browse/SLING-11967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744097#comment-17744097
]
Fabrice Bellingard commented on SLING-11967:
Done =>
https://sonarcloud.io/project/overview?id=apache_sling-org-apache-sling-jcr-presence
> Onboard JCR Presence to SonarCloud
> --
>
> Key: SLING-11967
> URL: https://issues.apache.org/jira/browse/SLING-11967
> Project: Sling
> Issue Type: Task
> Components: JCR
>Reporter: Oliver Lietz
>Assignee: Fabrice Bellingard
>Priority: Major
> Fix For: JCR Presence 1.0.0
>
>
> {{sling-org-apache-sling-jcr-presence}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: CI Build issue for GraphQL Core
Hi Andy, On Tue, 2023-07-18 at 09:47 +0200, Andreas Schaefer wrote: > Hi > > For my latest PR for Sling GraphQL Core I am running into CI build > issues on Java 17: > > https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/3/pipeline > > Any idea on how to resolve this? [1] gathers the problem patterns we saw when migrating builds to Java 11/17, maybe your problem is already listed? Thanks, Robert [1]: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=255071690
CI Build issue for GraphQL Core
Hi For my latest PR for Sling GraphQL Core I am running into CI build issues on Java 17: https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-graphql-core/detail/PR-36/3/pipeline Any idea on how to resolve this? Cheers - Andy
