[jira] [Commented] (SLING-12015) Add more metrics to sling.event
[ https://issues.apache.org/jira/browse/SLING-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761086#comment-17761086 ] Robert Munteanu commented on SLING-12015: - More details would not hurt :-) > Add more metrics to sling.event > --- > > Key: SLING-12015 > URL: https://issues.apache.org/jira/browse/SLING-12015 > Project: Sling > Issue Type: New Feature >Reporter: José Andrés Cordero Benítez >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #37: SLING-12014 - GraphQL Core needs to support additional fields from GraphQL Java
sonarcloud[bot] commented on PR #37: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/37#issuecomment-1701513088 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=37) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=37=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=37=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=37=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=37=new_coverage=list) [43.9% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=37=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=37=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=37=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] schaefa commented on pull request #37: SLING-12014 - GraphQL Core needs to support additional fields from GraphQL Java
schaefa commented on PR #37: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/37#issuecomment-1701509811 I added the JCR-305 to all fields, methods and parameters. Right now all of them are Nullable that come from Graphql-java because they do not provide any indication there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #37: SLING-12014 - GraphQL Core needs to support additional fields from GraphQL Java
sonarcloud[bot] commented on PR #37: URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/37#issuecomment-1701493949 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-graphql-core=37) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=37=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=37=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=37=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=37=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=37=new_coverage=list) [41.9% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=37=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=37=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=37=new_duplicated_lines_density=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] schaefa commented on a diff in pull request #37: SLING-12014 - GraphQL Core needs to support additional fields from GraphQL Java
schaefa commented on code in PR #37:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/37#discussion_r1311971949
##
src/main/java/org/apache/sling/graphql/core/engine/SelectedFieldWrapper.java:
##
@@ -74,18 +94,53 @@ public String getName() {
}
@Override
+public @Nullable String getQualifiedName() {
+return qualifiedName;
+}
+
+@Override
+public String getFullyQualifiedName() {
+return fullyQualifiedName;
+}
+
+@Override
+public boolean isConditional() {
+return conditional;
+}
+
+@Override
+public int getLevel() {
+return 0;
+}
+
+@Override
+public String getAlias() {
+return null;
+}
+
+@Override
+public String getResultKey() {
+return null;
+}
Review Comment:
I missed that - DONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] schaefa commented on a diff in pull request #37: SLING-12014 - GraphQL Core needs to support additional fields from GraphQL Java
schaefa commented on code in PR #37:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/37#discussion_r1311971673
##
src/main/java/org/apache/sling/graphql/api/SelectedField.java:
##
@@ -39,6 +39,34 @@ public interface SelectedField {
@Nullable
String getName();
+/** @return the simple qualified name of the selected field **/
+@Nullable
+String getQualifiedName();
+
+/**
+ * @return the fully qualified name of the item
+ */
+@Nullable
+String getFullyQualifiedName();
+
+/** @return level of the selected field within the query **/
+int getLevel();
+
+/** @return whether the field is conditionally present **/
+boolean isConditional();
+
+/**
+ * @return the alias of the selected field or null if not alias was used
+ */
+String getAlias();
+
+/**
+ * The result key is either the field query alias OR the field name in
that preference order
+ *
+ * @return the result key of the selected field
+ */
+String getResultKey();
+
Review Comment:
No, I cannot because the source of the values does not provide any
annotations or any other indication of the expectation. I will mark the all
Nullable for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Comment Edited] (SLING-11799) use keyset pagination for sling:alias query
[ https://issues.apache.org/jira/browse/SLING-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760936#comment-17760936 ] Julian Reschke edited comment on SLING-11799 at 8/31/23 1:46 PM: - Turns out that the number of distinct names is not *that* interesting. What would be needed is the (first) alias that has the most occurrences. Assuming that aliases do not change that much, finding these during startup, logging interesting findings, and throwing away the data structure should be good enough. was (Author: reschke): Turns around that the number of distinct names is not *that* interesting. What would be needed is the (first) alias that has the most occurrences. Assuming that aliases do not change that much, finding these during startup, logging interesting findings, and throwing away the data structure should be good enough. > use keyset pagination for sling:alias query > --- > > Key: SLING-11799 > URL: https://issues.apache.org/jira/browse/SLING-11799 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > > Similar to what was done for vanity paths (SLING-11581), we should use keyset > pagination for queries for sling:alias. > This would work the same in principle, however we should keep in mind that - > due to the different type of data - we may have way more duplicates, so in > edge cases the pages might be bigger than expected. However, every size > reduction of "results of a single query" should help. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11799) use keyset pagination for sling:alias query
[ https://issues.apache.org/jira/browse/SLING-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760936#comment-17760936 ] Julian Reschke commented on SLING-11799: Turns around that the number of distinct names is not *that* interesting. What would be needed is the (first) alias that has the most occurrences. Assuming that aliases do not change that much, finding these during startup, logging interesting findings, and throwing away the data structure should be good enough. > use keyset pagination for sling:alias query > --- > > Key: SLING-11799 > URL: https://issues.apache.org/jira/browse/SLING-11799 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > > Similar to what was done for vanity paths (SLING-11581), we should use keyset > pagination for queries for sling:alias. > This would work the same in principle, however we should keep in mind that - > due to the different type of data - we may have way more duplicates, so in > edge cases the pages might be bigger than expected. However, every size > reduction of "results of a single query" should help. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11799) use keyset pagination for sling:alias query
[ https://issues.apache.org/jira/browse/SLING-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17760896#comment-17760896 ] Julian Reschke commented on SLING-11799: I wonder whether it would be good to count the distinct alias names (or even the distinct first names in the alias array), and to report them as metrics. Or would it be sufficient to log that? > use keyset pagination for sling:alias query > --- > > Key: SLING-11799 > URL: https://issues.apache.org/jira/browse/SLING-11799 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > > Similar to what was done for vanity paths (SLING-11581), we should use keyset > pagination for queries for sling:alias. > This would work the same in principle, however we should keep in mind that - > due to the different type of data - we may have way more duplicates, so in > edge cases the pages might be bigger than expected. However, every size > reduction of "results of a single query" should help. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-aggregator] rombert opened a new pull request, #10: generate-project-badges: access collection size in the right way
rombert opened a new pull request, #10: URL: https://github.com/apache/sling-aggregator/pull/10 Use size() instead of size for the collection; this might've worked by accident but is not guaranteed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-12016) Activate Sling Commons Metrics Prometheus on SonarCloud
[ https://issues.apache.org/jira/browse/SLING-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12016: --- Assignee: Fabrice Bellingard [~bellingard] - can you please help onboard the project mentioned in this issue? > Activate Sling Commons Metrics Prometheus on SonarCloud > --- > > Key: SLING-12016 > URL: https://issues.apache.org/jira/browse/SLING-12016 > Project: Sling > Issue Type: Task > Components: Build and Source Control >Reporter: Robert Munteanu >Assignee: Fabrice Bellingard >Priority: Major > > We have a new project that needs onboarding - > https://github.com/apache/sling-org-apache-sling-commons-metrics-prometheus . -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12016) Activate Sling Commons Metrics Prometheus on SonarCloud
[
https://issues.apache.org/jira/browse/SLING-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12016:
Description: We have a new project that needs onboarding -
https://github.com/apache/sling-org-apache-sling-commons-metrics-prometheus .
(was: Jenkins Jobs have been created (thanks!) for the Journal based Sling
Content Distribution projects. The repositories are listed below
*
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
*
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
*
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
*
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
Those Jenkins jobs fail currently with an error similar to
{code:java}
[ERROR] Failed to execute goal
org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar (default-cli)
on project org.apache.sling.distribution.journal.messages: You're not
authorized to run analysis. Please contact the project administrator. -> [Help
1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
{code}
which seems related to a missing integration with Sonar.)
> Activate Sling Commons Metrics Prometheus on SonarCloud
> ---
>
> Key: SLING-12016
> URL: https://issues.apache.org/jira/browse/SLING-12016
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Reporter: Robert Munteanu
>Priority: Major
>
> We have a new project that needs onboarding -
> https://github.com/apache/sling-org-apache-sling-commons-metrics-prometheus .
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12016) Activate Sling Commons Metrics Prometheus on SonarCloud
[
https://issues.apache.org/jira/browse/SLING-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12016:
Reporter: Robert Munteanu (was: Timothee Maret)
> Activate Sling Commons Metrics Prometheus on SonarCloud
> ---
>
> Key: SLING-12016
> URL: https://issues.apache.org/jira/browse/SLING-12016
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0, Content
> Distribution Journal Kafka 0.1.0, Content Distribution Journal ITs 0.1.0,
> Content Distribution Journal Messages 0.1.0
>
>
> Jenkins Jobs have been created (thanks!) for the Journal based Sling Content
> Distribution projects. The repositories are listed below
> *
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
> *
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
> *
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
> *
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
>
> Those Jenkins jobs fail currently with an error similar to
> {code:java}
> [ERROR] Failed to execute goal
> org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar
> (default-cli) on project org.apache.sling.distribution.journal.messages:
> You're not authorized to run analysis. Please contact the project
> administrator. -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> which seems related to a missing integration with Sonar.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12016) Activate Sling Commons Metrics Prometheus on SonarCloud
Robert Munteanu created SLING-12016:
---
Summary: Activate Sling Commons Metrics Prometheus on SonarCloud
Key: SLING-12016
URL: https://issues.apache.org/jira/browse/SLING-12016
Project: Sling
Issue Type: Task
Components: Content Distribution
Reporter: Timothee Maret
Fix For: Content Distribution Journal Core 0.1.0, Content
Distribution Journal Kafka 0.1.0, Content Distribution Journal ITs 0.1.0,
Content Distribution Journal Messages 0.1.0
Jenkins Jobs have been created (thanks!) for the Journal based Sling Content
Distribution projects. The repositories are listed below
*
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
*
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
*
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
*
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
Those Jenkins jobs fail currently with an error similar to
{code:java}
[ERROR] Failed to execute goal
org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar (default-cli)
on project org.apache.sling.distribution.journal.messages: You're not
authorized to run analysis. Please contact the project administrator. -> [Help
1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
{code}
which seems related to a missing integration with Sonar.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12016) Activate Sling Commons Metrics Prometheus on SonarCloud
[ https://issues.apache.org/jira/browse/SLING-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12016: Component/s: Build and Source Control (was: Content Distribution) > Activate Sling Commons Metrics Prometheus on SonarCloud > --- > > Key: SLING-12016 > URL: https://issues.apache.org/jira/browse/SLING-12016 > Project: Sling > Issue Type: Task > Components: Build and Source Control >Reporter: Robert Munteanu >Priority: Major > > We have a new project that needs onboarding - > https://github.com/apache/sling-org-apache-sling-commons-metrics-prometheus . -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12016) Activate Sling Commons Metrics Prometheus on SonarCloud
[
https://issues.apache.org/jira/browse/SLING-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-12016:
Fix Version/s: (was: Content Distribution Journal Core 0.1.0)
(was: Content Distribution Journal Kafka 0.1.0)
(was: Content Distribution Journal ITs 0.1.0)
(was: Content Distribution Journal Messages 0.1.0)
> Activate Sling Commons Metrics Prometheus on SonarCloud
> ---
>
> Key: SLING-12016
> URL: https://issues.apache.org/jira/browse/SLING-12016
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Reporter: Robert Munteanu
>Priority: Major
>
> Jenkins Jobs have been created (thanks!) for the Journal based Sling Content
> Distribution projects. The repositories are listed below
> *
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
> *
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
> *
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
> *
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
>
> Those Jenkins jobs fail currently with an error similar to
> {code:java}
> [ERROR] Failed to execute goal
> org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar
> (default-cli) on project org.apache.sling.distribution.journal.messages:
> You're not authorized to run analysis. Please contact the project
> administrator. -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> which seems related to a missing integration with Sonar.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12015) Add more metrics to sling.event
José Andrés Cordero Benítez created SLING-12015: --- Summary: Add more metrics to sling.event Key: SLING-12015 URL: https://issues.apache.org/jira/browse/SLING-12015 Project: Sling Issue Type: New Feature Reporter: José Andrés Cordero Benítez -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-graphql-core] kwin commented on a diff in pull request #37: SLING-12014 - GraphQL Core needs to support additional fields from GraphQL Java
kwin commented on code in PR #37:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/37#discussion_r1311333882
##
src/main/java/org/apache/sling/graphql/api/SelectedField.java:
##
@@ -39,6 +39,34 @@ public interface SelectedField {
@Nullable
String getName();
+/** @return the simple qualified name of the selected field **/
+@Nullable
+String getQualifiedName();
+
+/**
+ * @return the fully qualified name of the item
+ */
+@Nullable
+String getFullyQualifiedName();
+
+/** @return level of the selected field within the query **/
+int getLevel();
+
+/** @return whether the field is conditionally present **/
+boolean isConditional();
+
+/**
+ * @return the alias of the selected field or null if not alias was used
+ */
+String getAlias();
+
+/**
+ * The result key is either the field query alias OR the field name in
that preference order
+ *
+ * @return the result key of the selected field
+ */
+String getResultKey();
+
Review Comment:
It is Jetbrains null annotations nowadays
(https://sling.apache.org/documentation/development/null-analysis.html) :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on a diff in pull request #37: SLING-12014 - GraphQL Core needs to support additional fields from GraphQL Java
raducotescu commented on code in PR #37:
URL:
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/37#discussion_r1311259577
##
src/main/java/org/apache/sling/graphql/api/SelectedField.java:
##
@@ -39,6 +39,34 @@ public interface SelectedField {
@Nullable
String getName();
+/** @return the simple qualified name of the selected field **/
+@Nullable
+String getQualifiedName();
+
+/**
+ * @return the fully qualified name of the item
+ */
+@Nullable
+String getFullyQualifiedName();
+
+/** @return level of the selected field within the query **/
+int getLevel();
+
+/** @return whether the field is conditionally present **/
+boolean isConditional();
+
+/**
+ * @return the alias of the selected field or null if not alias was used
+ */
+String getAlias();
+
+/**
+ * The result key is either the field query alias OR the field name in
that preference order
+ *
+ * @return the result key of the selected field
+ */
+String getResultKey();
+
Review Comment:
Can you please add the JSR-305 annotations to all the methods? (return
values and parameters)
##
src/main/java/org/apache/sling/graphql/core/engine/SelectedFieldWrapper.java:
##
@@ -74,18 +94,53 @@ public String getName() {
}
@Override
+public @Nullable String getQualifiedName() {
+return qualifiedName;
+}
+
+@Override
+public String getFullyQualifiedName() {
+return fullyQualifiedName;
+}
+
+@Override
+public boolean isConditional() {
+return conditional;
+}
+
+@Override
+public int getLevel() {
+return 0;
+}
+
+@Override
+public String getAlias() {
+return null;
+}
+
+@Override
+public String getResultKey() {
+return null;
+}
Review Comment:
Why don't you return the actual values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (SLING-12014) GraphQL Core needs to support additional fields from GraphQL Java
[ https://issues.apache.org/jira/browse/SLING-12014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-12014: - Summary: GraphQL Core needs to support additional fields from GraphQL Java (was: GraphQL Core needs to Support Addition Fields from GraphQL Java) > GraphQL Core needs to support additional fields from GraphQL Java > - > > Key: SLING-12014 > URL: https://issues.apache.org/jira/browse/SLING-12014 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > > There is a need to have additional fields from the GraphQL Java's Selected > Field. For example there is a need to separate fields with the same name but > different parent through the Fully Qualified Name. -- This message was sent by Atlassian Jira (v8.20.10#820010)
