[GitHub] [sling-org-apache-sling-jms] sonarcloud[bot] commented on pull request #3: SLING-11382: Sling update to 47
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-jms/pull/3#issuecomment-1741610635 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jms=3) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jms=3=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jms=3=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jms=3=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-11906) Migrate to slf4j 2.x
[ https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman updated SLING-11906: Description: Increasingly more libraries have been migrating to slf4j 2.x (for example logback 1.3+, tika 2.5+ and jetty 10+) To be compatible with those, the sling commons log bundle should migrate to slf4j v2.x (and logback v1.4.x or v1.3.x?) It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported packages, so it should hopefully be compatible with existing bundles that are importing the 1.x version of the slf4j packages. was: Increasingly more libraries have been migrating to slf4j 2.x (for example logback 1.3+, tika 2.5+ and jetty 10+) To be compatible with those, the sling commons log bundle should migrate to slf4j v2.0.7 (and logback v1.4.7) It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported packages, so it should hopefully be compatible with existing bundles that are importing the 1.x version of the slf4j packages. > Migrate to slf4j 2.x > > > Key: SLING-11906 > URL: https://issues.apache.org/jira/browse/SLING-11906 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Priority: Major > Fix For: Commons Log 6.0.0 > > > Increasingly more libraries have been migrating to slf4j 2.x (for example > logback 1.3+, tika 2.5+ and jetty 10+) > To be compatible with those, the sling commons log bundle should migrate to > slf4j v2.x (and logback v1.4.x or v1.3.x?) > It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported > packages, so it should hopefully be compatible with existing bundles that are > importing the 1.x version of the slf4j packages. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770594#comment-17770594 ] Eric Norman commented on SLING-12053: - Linked the related open issue regarding the migration of sling to slf4j 2.x > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer reassigned SLING-12053: Assignee: Andreas Schaefer > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10899) Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached
[ https://issues.apache.org/jira/browse/SLING-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770499#comment-17770499 ] Carsten Ziegeler commented on SLING-10899: -- Memory consumption is one thing - that can most likely be solved - but change in behaviour is risky. I'm pretty sure that there will be users of Sling which expect that two calls to getResource on the same resolver with the same path return two different objects. And I'm also sure the same is true for getting the value map. So we can't simply change that. One way out seems to be to create new methods to introduce the caching behaviour - but that obviously only works if you then change all usage to the new methods - and here again, I'm sure that there are places where you can't do this. I think the Filter use case could be solved (for example by introducing a method on the request object), but I assume that is only one out of many > Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached > -- > > Key: SLING-10899 > URL: https://issues.apache.org/jira/browse/SLING-10899 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.0.22 >Reporter: Henry Kuijpers >Priority: Major > > I was performance testing our application. There is a specific part of the > code where we have a set of ~500 resources and we sort them based on a few > properties of the resources. Multiple properties are used (which results in > multiple calls to getValueMap). The sorting is done using a comparator, so > the logic that determines the order is accessed numerous times. > We've seen quite a decrease in performance when doing this with Resources > that are of type JcrNodeResource. Turns out that the result of getValueMap > (or adaptTo((Value)Map.class)) is not cached. > As you can see in the adaptTo()-method implementation: > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java#L136 > this call bypasses the AdapterFactory framework and also bypasses any > caching that happens over there. > What's even more unfortunate, is that JcrValueMap is implementing caching via > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/6e13f4d315ddf2804d2e16c55faee18e805b618e/src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java#L49 > . That caching is not leveraged properly, because every call to getValueMap > returns a new JcrValueMap, instead of reusing a previously created one. > One change that can be done is maybe converting the logic inside the > adaptTo()-method to a dedicated AdapterFactory implementation, so that > caching is done by default? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770495#comment-17770495 ] Andreas Schaefer commented on SLING-12053: -- I suggested a version check in the garaphql-java grade.build: Import-Package: !android.os.*,!com.google.*,!org.checkerframework.*,!javax.annotation.*,!graphql.com.google.*,!org.antlr.*,!graphql.org.antlr.*,!sun.misc.*,org.slf4j;version="[1.7,3.0)",* That would allow to use SLF4J version 1.7 and newer and would allow us to keep using it. This is my discussion with graphs-java: [https://github.com/graphql-java/graphql-java/issues/3339] > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10899) Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached
[ https://issues.apache.org/jira/browse/SLING-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770465#comment-17770465 ] Henry Kuijpers commented on SLING-10899: [~joerghoh] [~cziegeler] There is no caching of the adaption, unfortunately, and it's also not possible to do this outside of all the implementations: Whenever ResourceResolver#getResource is called, a new Resource object is returned. Never an existing one(? unless I'm missing something). It would be up to ResourceResolverImpl to return the same one under certain conditions, if I have that right. This would definitely be a nice upgrade (and I agree also a complicated one), as right now, calling getResource() on the same instance of ResourceResolver, will always return a new fresh Resource (which can be any impl, of course). In the case of a JCR Resource, a JcrNodeResource is returned. This JcrNodeResource has 2 ways of obtaining a ValueMap: * getValueMap * adaptTo(ValueMap.class) The getValueMap (coming from AbstractResource) calls adaptTo(ValueMap.class). adaptTo(ValueMap.class) will *always* return a new instance of JcrValueMap, as you can see here: https://github.com/apache/sling-org-apache-sling-jcr-resource/blame/master/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java#L136 It is not possible to influence this, as we have no influence over these internal helper classes and/or any of the other impls. So, this means that: 1. The ResourceResolverImpl is returning a fresh new JcrNodeResource object for the same path *all the time* 2. The JcrNodeResource is returning a fresh new JcrValueMap for every call to getValueMap/adaptTo(ValueMap.class) *all the time* 3. The cache that resides in JcrValueMap is of almost no use, as it will most often have a cache miss. 4. It is not very easily possible to create a wrapper around such resources (because, where would we create them)? 5. Creating a wrapping that could cache the valuemap is not possible, because there are quite a few checks for "instanceof", which then isn't true anymore A few very easy improvements could be: 1. When obtaining the ValueMap for a JcrNodeResource, create the map and save it in an instance field, when calling it the next time, just return the instance field, instead of creating a new JcrValueMap - This will of course all go away when the Resource-object is garbage collected 2. Do not obtain the ValueMap in the adaptTo-method in the Resource impls, but instead, use AdapterFactory for that, but, put some kind of caching mechanism in there (basically a cache that could be similar to the Sling Models cache that is in place) 3. Let the ValueMap-cache (and vielleicht other related stored data) live together with the lifetime of the ResourceResolver, so as soon as it is closed, also remove all the caches In the improvements I don't see something so risky that it could blow the JVM and/or cause too much memory to be claimed or similar. As long as it is implemented well enough. :) About doing the adaption repeatedly: We have no choice! If I have a Filter implementation that needs to access the ValueMap of a Resource, I *need* to call getValueMap and/or adaptTo(ValueMap.class). Both will have their own code inside JcrNodeResource, that bypasses any AdapterFactory or anything else where caching can take place. And *they do not cache anything*. If the next Filter comes, and it has to access the ValueMap too, then the same logic is kicked off and yet another new JcrValueMap (with empty cache) is created, instead of reusing the previous one. It is impossible to obtain a resource only once and reuse it throughout the entire application and all the various phases. Looking at every location independently is totally fine. I know most of the locations that are interesting. But they always involve Sling/Adobe/... code, mainly filters etc etc. And also our own code, but we have no way to pass those Resource objects (and especially their JcrValueMap objects) around. The problem is really inside JcrNodeResource and JcrValueMap. Please have another look at it, based on this summary of the problem. > Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached > -- > > Key: SLING-10899 > URL: https://issues.apache.org/jira/browse/SLING-10899 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.0.22 >Reporter: Henry Kuijpers >Priority: Major > > I was performance testing our application. There is a specific part of the > code where we have a set of ~500 resources and we sort them based on a few > properties of the resources. Multiple properties are used (which results in > multiple calls to getValueMap). The sorting is done using a
[jira] [Created] (SLING-12056) Add Java 21 as additional build JDK
Konrad Windszus created SLING-12056: --- Summary: Add Java 21 as additional build JDK Key: SLING-12056 URL: https://issues.apache.org/jira/browse/SLING-12056 Project: Sling Issue Type: Improvement Components: Build and Source Control Reporter: Konrad Windszus Assignee: Konrad Windszus Currently our projects build on Java 11 and 17 by default on Jenkins. We should include Java 21 as well. This requires a Temurin release though which did not happen yet: https://github.com/adoptium/adoptium/issues/248. Compare with https://cwiki.apache.org/confluence/display/SLING/Hackathon+in+Berlin+-+September+2023 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-servlets-get] cziegeler closed pull request #4: SLING-9060 Improved handling of redirects when streaming
cziegeler closed pull request #4: SLING-9060 Improved handling of redirects when streaming URL: https://github.com/apache/sling-org-apache-sling-servlets-get/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12055) Remove dependency on Sling XSS
[ https://issues.apache.org/jira/browse/SLING-12055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-12055. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-servlets-get/commit/468daa34fc3a5b86e553f9372daef0f5ee9ea940 > Remove dependency on Sling XSS > -- > > Key: SLING-12055 > URL: https://issues.apache.org/jira/browse/SLING-12055 > Project: Sling > Issue Type: Improvement > Components: Servlets >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Servlets Get 2.1.46 > > > For XSS encoding the servlets get module has currently a dependency on the > heavy Sling XSS bundle. We can replace this with a lightweight alternative: > owasp encoders -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12055) Remove dependency on Sling XSS
Carsten Ziegeler created SLING-12055: Summary: Remove dependency on Sling XSS Key: SLING-12055 URL: https://issues.apache.org/jira/browse/SLING-12055 Project: Sling Issue Type: Improvement Components: Servlets Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Servlets Get 2.1.46 For XSS encoding the servlets get module has currently a dependency on the heavy Sling XSS bundle. We can replace this with a lightweight alternative: owasp encoders -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12049) Update the Sling downloads list using renovate
[ https://issues.apache.org/jira/browse/SLING-12049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12049. - Resolution: Fixed Renovate set up, website documentation updated. > Update the Sling downloads list using renovate > -- > > Key: SLING-12049 > URL: https://issues.apache.org/jira/browse/SLING-12049 > Project: Sling > Issue Type: Improvement > Components: Documentation >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > > We can simplify the release management process by having Renovate update the > downloads list. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-site] rombert merged pull request #134: SLING-12049 - Update the Sling downloads list using renovate
rombert merged PR #134: URL: https://github.com/apache/sling-site/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-site] rombert opened a new pull request, #134: SLING-12049 - Update the Sling downloads list using renovate
rombert opened a new pull request, #134: URL: https://github.com/apache/sling-site/pull/134 Update release management documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh commented on pull request #101: SLING-11715 in the optimized code path avoid resource resolution
joerghoh commented on PR #101: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/101#issuecomment-1740790102 @reschke @cziegeler I am pretty confident here, but can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #101: SLING-11715 in the optimized code path avoid resource resolution
sonarcloud[bot] commented on PR #101: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/101#issuecomment-1740780137 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=101) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_coverage=list) [98.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[hackathon] Changing POM URL References to GitHub
Hi, During the hackathon I proposed to change the pom.xml scm.url property from gitbox to github. Details are at [1], but this property is informational and not involved in the maven-release-plugin process. Infra is currently redirecting to GitHub anyway: $ curl --verbose 'https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-starter.git' (...) < HTTP/2 302 < date: Fri, 29 Sep 2023 12:02:38 GMT < server: Apache < location: https://github.com/apache/sling-org-apache-sling-starter (...) If anyone has any concerns please let me know. Thanks, Robert [1]: https://cwiki.apache.org/confluence/display/SLING/Hackathon+in+Berlin+-+September+2023#HackathoninBerlinSeptember2023-8)ChangingPOMURLReferencestoGitHub
[jira] [Commented] (SLING-10506) Document inappropriate Sonar rules
[
https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770400#comment-17770400
]
Robert Munteanu commented on SLING-10506:
-
[~bellingard] - we had one question regarding SonarCloud and custom quality
profiles. We have started documenting the rules which do not apply for our
projects, for various reasons.
We would like to create a custom quality profile that extends the default
'Sonar Way' for Java. The challege is that we have > 300 projects that this
should apply to. Is there a way to associate bulk associate existing 'sling'
project to a new profile, once created? I guess when we create a new one it
would not be a big issue to associate it to a custom profile.
> Document inappropriate Sonar rules
> --
>
> Key: SLING-10506
> URL: https://issues.apache.org/jira/browse/SLING-10506
> Project: Sling
> Issue Type: Task
> Components: Build and Source Control, CI
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> * {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
> * {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
> * {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
> * {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
> * {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
> * {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
> * {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
> * {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #101: SLING-11715 in the optimized code path avoid resource resolution
sonarcloud[bot] commented on PR #101: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/101#issuecomment-1740760558 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=101) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_coverage=list) [98.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #84: SLING-11352 - Fix parsing of path-only mappings
sonarcloud[bot] commented on PR #84: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1740759001 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=84) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=84=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=84=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=84=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #101: SLING-11715 in the optimized code path avoid resource resolution
sonarcloud[bot] commented on PR #101: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/101#issuecomment-1740758821 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=101) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=101=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=101=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_coverage=list) [98.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=101=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh merged pull request #106: SLING-12054 display WARNing when optimized alias resolution is not used
joerghoh merged PR #106: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12054) WARN of the non-use of optimizedAliasResolution
[ https://issues.apache.org/jira/browse/SLING-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12054: -- Description: As we found in SLING-12025, disabling the optimizedAliasResolution changes the behavior of the mapping result. This can be clearly considered a bug, but as it is part of the ResourceResolver for quite some time (although not default), we cannot fix or remove it that easily. We should write a WARN message into the log, when the optimizedAliasResolution is *NOT* used. The wording in the configuration (as shown in the OSGI Webconsole) should be adjusted too. The removal of this code path should be considered as next step, taking place in 12+ months earliest. was: As we found in SLING-12025, disabling the optimizedAliasResolution changes the behavior of the mapping result. This can be clearly considered a bug, but as it is part of the ResourceResolver for quite some time (although not default), we cannot fix or remove it that easily. We should write a WARN message into the log, when the optimizedAliasResolution is *NOT* used. The wording in the webconsole should be adjusted too. The removal of this code path should be considered as next step, taking place in 12+ months earliest. > WARN of the non-use of optimizedAliasResolution > > > Key: SLING-12054 > URL: https://issues.apache.org/jira/browse/SLING-12054 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Affects Versions: Resource Resolver 1.11.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Resource Resolver 1.11.2 > > > As we found in SLING-12025, disabling the optimizedAliasResolution changes > the behavior of the mapping result. This can be clearly considered a bug, but > as it is part of the ResourceResolver for quite some time (although not > default), we cannot fix or remove it that easily. > We should write a WARN message into the log, when the > optimizedAliasResolution is *NOT* used. The wording in the configuration (as > shown in the OSGI Webconsole) should be adjusted too. > The removal of this code path should be considered as next step, taking place > in 12+ months earliest. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12054) WARN of the non-use of optimizedAliasResolution
[ https://issues.apache.org/jira/browse/SLING-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12054: -- Description: As we found in SLING-12025, disabling the optimizedAliasResolution changes the behavior of the mapping result. This can be clearly considered a bug, but as it is part of the ResourceResolver for quite some time (although not default), we cannot fix or remove it that easily. We should write a WARN message into the log, when the optimizedAliasResolution is *NOT* used. The wording in the webconsole should be adjusted too. The removal of this code path should be considered as next step, taking place in 12+ months earliest. was: As we found in SLING-12025, disabling the optimizedAliasResolution changes the behavior of the mapping result. This can be clearly considered a bug, but as it is part of the ResourceResolver for quite some time (although not default), we cannot fix or remove it that easily. We should write a WARN message into the log, when the optimizedAliasResolution is *NOT* used. The wording in the webconsole just be adjusted too. The removal of this code path should be considered as next step, taking place in 12+ months earliest. > WARN of the non-use of optimizedAliasResolution > > > Key: SLING-12054 > URL: https://issues.apache.org/jira/browse/SLING-12054 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Affects Versions: Resource Resolver 1.11.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Resource Resolver 1.11.2 > > > As we found in SLING-12025, disabling the optimizedAliasResolution changes > the behavior of the mapping result. This can be clearly considered a bug, but > as it is part of the ResourceResolver for quite some time (although not > default), we cannot fix or remove it that easily. > We should write a WARN message into the log, when the > optimizedAliasResolution is *NOT* used. The wording in the webconsole should > be adjusted too. > The removal of this code path should be considered as next step, taking place > in 12+ months earliest. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12054) WARN of the non-use of optimizedAliasResolution
[ https://issues.apache.org/jira/browse/SLING-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12054: -- Fix Version/s: Resource Resolver 1.11.2 > WARN of the non-use of optimizedAliasResolution > > > Key: SLING-12054 > URL: https://issues.apache.org/jira/browse/SLING-12054 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Affects Versions: Resource Resolver 1.11.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Resource Resolver 1.11.2 > > > As we found in SLING-12025, disabling the optimizedAliasResolution changes > the behavior of the mapping result. This can be clearly considered a bug, but > as it is part of the ResourceResolver for quite some time (although not > default), we cannot fix or remove it that easily. > We should write a WARN message into the log, when the > optimizedAliasResolution is *NOT* used. The wording in the webconsole just be > adjusted too. > The removal of this code path should be considered as next step, taking place > in 12+ months earliest. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #106: SLING-12054 display WARNing when optimized alias resolution is not used
sonarcloud[bot] commented on PR #106: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/106#issuecomment-1740745259 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=106) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=106=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=106=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=106=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=106=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=106=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=106=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=106=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #1043 is FIXED
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/1043/ for details. No further emails will be sent until the status of the build is changed.
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #106: SLING-12054 display WARNing when optimized alias resolution is not used
sonarcloud[bot] commented on PR #106: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/106#issuecomment-1740734654 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=106) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=106=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=106=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=106=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=106=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=106=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=106=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=106=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=106=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Discussed topics from Sling Hackathon @ Berlin 2023
we had a nice day in berlin yesterday (and adaptTo() the three days before) - i've written together all the topics we have discussed with some notes about the considerations: https://cwiki.apache.org/confluence/x/Hx00Dw#HackathoninBerlinSeptember2023-DiscussedTopics for most topics we have defines someone who wants to pick up the topic and bring it to the list or make an actual proposal. stefan
[jira] [Assigned] (SLING-12054) WARN of the non-use of optimizedAliasResolution
[ https://issues.apache.org/jira/browse/SLING-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh reassigned SLING-12054: - Assignee: Joerg Hoh > WARN of the non-use of optimizedAliasResolution > > > Key: SLING-12054 > URL: https://issues.apache.org/jira/browse/SLING-12054 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Affects Versions: Resource Resolver 1.11.0 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > > As we found in SLING-12025, disabling the optimizedAliasResolution changes > the behavior of the mapping result. This can be clearly considered a bug, but > as it is part of the ResourceResolver for quite some time (although not > default), we cannot fix or remove it that easily. > We should write a WARN message into the log, when the > optimizedAliasResolution is *NOT* used. The wording in the webconsole just be > adjusted too. > The removal of this code path should be considered as next step, taking place > in 12+ months earliest. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12054) WARN of the non-use of optimizedAliasResolution
[ https://issues.apache.org/jira/browse/SLING-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770380#comment-17770380 ] Joerg Hoh commented on SLING-12054: --- PR at https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/106 > WARN of the non-use of optimizedAliasResolution > > > Key: SLING-12054 > URL: https://issues.apache.org/jira/browse/SLING-12054 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Affects Versions: Resource Resolver 1.11.0 >Reporter: Joerg Hoh >Priority: Major > > As we found in SLING-12025, disabling the optimizedAliasResolution changes > the behavior of the mapping result. This can be clearly considered a bug, but > as it is part of the ResourceResolver for quite some time (although not > default), we cannot fix or remove it that easily. > We should write a WARN message into the log, when the > optimizedAliasResolution is *NOT* used. The wording in the webconsole just be > adjusted too. > The removal of this code path should be considered as next step, taking place > in 12+ months earliest. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh opened a new pull request, #106: SLING-12054 display WARNing when optimized alias resolution is not used
joerghoh opened a new pull request, #106: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/106 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled
[
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770368#comment-17770368
]
Julian Reschke commented on SLING-12025:
bq. Actually, when checking closer, the aliasing is not working at all, if the
optimizedAliasing is not turned on...
Care to elaborate? :-)
> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
> Issue Type: Task
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Resource Resolver 1.11.2
>
>
> I found that the there is a different behavior in case the "optimized alias
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
> + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if
> it's turned off, it does not work anymore, and you can resolve that resource
> only via its name. (In that case I assume that the jcr:content resource is
> aliased.)
> I created
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to
> demonstrate this problem.
> Is my assumption about the behavior correct?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12043) Incorrect virtual include path when passing resource to data-sly-resource
[
https://issues.apache.org/jira/browse/SLING-12043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Oeyen updated SLING-12043:
--
Description:
When upgrading AEM Service Pack 11 to Service Pack 18 we noticed issues with
Sling Dynamic include. The virtual include paths contained the resourcetype as
a postfix to the path where we did not expect that.
We traced it back to the the includeTagFilter.java thinking the resource is
synthetic in the buildUrl method:
{code:java}
private String buildUrl(Configuration config, SlingHttpServletRequest
request) {
final Resource resource = request.getResource();
final boolean synthetic =
ResourceUtil.isSyntheticResource(request.getResource());
return UrlBuilder.buildUrl(config.getIncludeSelector(),
resource.getResourceType(), synthetic, config, request.getRequestPathInfo());
} {code}
We contacted Adobe Support and they reported that they did make a change in the
responsivegrid.html in Service Pack 13.
Service pack 11 responsivegrid.html
{code:java}
...
... {code}
Was changed in Service pack 13 to:
{code:java}
...
... {code}
Because Adobe is not officially supporting Sling Dynamic Includes hence i'm
creating this ticket.
-As a temporary workaroud we overlayed the reponsivegrid.html with the SP11
version to mitigate this issue.- This workaround is causing other issues so
should not be applied.
*Steps to reproduce this issue:*
1) Install AEM 6.5 with sample content
2) Create a new XF fragment
3) Add an XF component to a page and pick the previously created XF fragment
4) Install Sling Dynamic Include via the OSGI Console
5) Configure Sling Dynamic Include via OSGi Console
{code:java}
Enable = true
resource types = cq/experience-fragments/editor/components/experiencefragment
{code}
6) Confirm we get a virtual include via curl
{code:java}
curl -u admin:admin -H "Server-Agent: Communique-Dispatcher"
http://localhost:4502/content/we-retail/language-masters/en.html {code}
{code:java}
...
...
{code}
7) Do the change from child.path to child.resource via CRX/DE on
{code:java}
/libs/wcm/foundation/components/responsivegrid/responsivegrid.html line 27
{code}
8) Confirm we get a wrong virtual include path via curl
{code:java}
curl -u admin:admin -H "Server-Agent: Communique-Dispatcher"
http://localhost:4502/content/we-retail/language-masters/en.html {code}
{code:java}
...
...
{code}
was:
When upgrading AEM Service Pack 11 to Service Pack 18 we noticed issues with
Sling Dynamic include. The virtual include paths contained the resourcetype as
a postfix to the path where we did not expect that.
We traced it back to the the includeTagFilter.java thinking the resource is
synthetic in the buildUrl method:
{code:java}
private String buildUrl(Configuration config, SlingHttpServletRequest
request) {
final Resource resource = request.getResource();
final boolean synthetic =
ResourceUtil.isSyntheticResource(request.getResource());
return UrlBuilder.buildUrl(config.getIncludeSelector(),
resource.getResourceType(), synthetic, config, request.getRequestPathInfo());
} {code}
We contacted Adobe Support and they reported that they did make a change in the
responsivegrid.html in Service Pack 13.
Service pack 11 responsivegrid.html
{code:java}
...
... {code}
Was changed in Service pack 13 to:
{code:java}
...
... {code}
Because Adobe is not officially supporting Sling Dynamic Includes hence i'm
creating this ticket. As a temporary workaroud we overlayed the
reponsivegrid.html with the SP11 version to mitigate this issue.
*Steps to reproduce this issue:*
1) Install AEM 6.5 with sample content
2) Create a new XF fragment
3) Add an XF component to a page and pick the previously created XF fragment
4) Install Sling Dynamic Include via the OSGI Console
5) Configure Sling Dynamic Include via OSGi Console
{code:java}
Enable = true
resource types = cq/experience-fragments/editor/components/experiencefragment
{code}
6) Confirm we get a virtual include via curl
{code:java}
curl -u admin:admin -H "Server-Agent: Communique-Dispatcher"
http://localhost:4502/content/we-retail/language-masters/en.html {code}
{code:java}
...
...
{code}
7) Do the change from child.path to child.resource via CRX/DE on
{code:java}
/libs/wcm/foundation/components/responsivegrid/responsivegrid.html line 27
{code}
8) Confirm we get a wrong virtual include path via curl
{code:java}
curl -u admin:admin -H "Server-Agent: Communique-Dispatcher"
http://localhost:4502/content/we-retail/language-masters/en.html {code}
{code:java}
...
...
{code}
Priority: Major (was: Minor)
Temporary workaround overlaying the responsivegrid.html with the previous
version is causing other issues in our site, so it is not considered a good
workaround.
Because of this there is currently no solution to prevent major loss of
[jira] [Resolved] (SLING-11741) Provide alternative terminology for inequitable terms
[ https://issues.apache.org/jira/browse/SLING-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11741. -- Resolution: Fixed > Provide alternative terminology for inequitable terms > - > > Key: SLING-11741 > URL: https://issues.apache.org/jira/browse/SLING-11741 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Base 3.1.12 >Reporter: Cioriia Cristian >Assignee: Carsten Ziegeler >Priority: Major > Fix For: JCR Base 3.1.16 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > The Apache Sling Login Admin Whitelist has occurrences of "whitelist" and > "blacklist" e.g. "whitelist.bypass", "whitelist.bundles.regexp" which is > considered inequitable terminology and some customers are prevented to use > these terms by their git commit policies. > Therefore, some more acceptable equivalents should be provided for these > terms. The proposal is to provide the "allowedlist.bypass" and > "allowedlist.bundles.regexp" alternatives for them -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11741) Provide alternative terminology for inequitable terms
[ https://issues.apache.org/jira/browse/SLING-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-11741: Assignee: Carsten Ziegeler > Provide alternative terminology for inequitable terms > - > > Key: SLING-11741 > URL: https://issues.apache.org/jira/browse/SLING-11741 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Base 3.1.12 >Reporter: Cioriia Cristian >Assignee: Carsten Ziegeler >Priority: Major > Fix For: JCR Base 3.1.16 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > The Apache Sling Login Admin Whitelist has occurrences of "whitelist" and > "blacklist" e.g. "whitelist.bypass", "whitelist.bundles.regexp" which is > considered inequitable terminology and some customers are prevented to use > these terms by their git commit policies. > Therefore, some more acceptable equivalents should be provided for these > terms. The proposal is to provide the "allowedlist.bypass" and > "allowedlist.bundles.regexp" alternatives for them -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10899) Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached
[ https://issues.apache.org/jira/browse/SLING-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770344#comment-17770344 ] Carsten Ziegeler commented on SLING-10899: -- Re-reading the ticket, I think it will be dangerous to introduce a change in behaviour. This is better handled on the client side. The risk of breaking existing clients is imho too high > Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached > -- > > Key: SLING-10899 > URL: https://issues.apache.org/jira/browse/SLING-10899 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.0.22 >Reporter: Henry Kuijpers >Priority: Major > > I was performance testing our application. There is a specific part of the > code where we have a set of ~500 resources and we sort them based on a few > properties of the resources. Multiple properties are used (which results in > multiple calls to getValueMap). The sorting is done using a comparator, so > the logic that determines the order is accessed numerous times. > We've seen quite a decrease in performance when doing this with Resources > that are of type JcrNodeResource. Turns out that the result of getValueMap > (or adaptTo((Value)Map.class)) is not cached. > As you can see in the adaptTo()-method implementation: > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java#L136 > this call bypasses the AdapterFactory framework and also bypasses any > caching that happens over there. > What's even more unfortunate, is that JcrValueMap is implementing caching via > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/6e13f4d315ddf2804d2e16c55faee18e805b618e/src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java#L49 > . That caching is not leveraged properly, because every call to getValueMap > returns a new JcrValueMap, instead of reusing a previously created one. > One change that can be done is maybe converting the logic inside the > adaptTo()-method to a dedicated AdapterFactory implementation, so that > caching is done by default? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12054) WARN of the non-use of optimizedAliasResolution
[ https://issues.apache.org/jira/browse/SLING-12054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joerg Hoh updated SLING-12054: -- Summary: WARN of the non-use of optimizedAliasResolution (was: Deprecate the non-use of optimizedAliasResolution ) > WARN of the non-use of optimizedAliasResolution > > > Key: SLING-12054 > URL: https://issues.apache.org/jira/browse/SLING-12054 > Project: Sling > Issue Type: Task > Components: ResourceResolver >Affects Versions: Resource Resolver 1.11.0 >Reporter: Joerg Hoh >Priority: Major > > As we found in SLING-12025, disabling the optimizedAliasResolution changes > the behavior of the mapping result. This can be clearly considered a bug, but > as it is part of the ResourceResolver for quite some time (although not > default), we cannot fix or remove it that easily. > We should write a WARN message into the log, when the > optimizedAliasResolution is *NOT* used. The wording in the webconsole just be > adjusted too. > The removal of this code path should be considered as next step, taking place > in 12+ months earliest. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12054) Deprecate the non-use of optimizedAliasResolution
Joerg Hoh created SLING-12054: - Summary: Deprecate the non-use of optimizedAliasResolution Key: SLING-12054 URL: https://issues.apache.org/jira/browse/SLING-12054 Project: Sling Issue Type: Task Components: ResourceResolver Affects Versions: Resource Resolver 1.11.0 Reporter: Joerg Hoh As we found in SLING-12025, disabling the optimizedAliasResolution changes the behavior of the mapping result. This can be clearly considered a bug, but as it is part of the ResourceResolver for quite some time (although not default), we cannot fix or remove it that easily. We should write a WARN message into the log, when the optimizedAliasResolution is *NOT* used. The wording in the webconsole just be adjusted too. The removal of this code path should be considered as next step, taking place in 12+ months earliest. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled
[
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh reassigned SLING-12025:
-
Assignee: Joerg Hoh
> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
> Issue Type: Task
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Resource Resolver 1.11.2
>
>
> I found that the there is a different behavior in case the "optimized alias
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
> + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if
> it's turned off, it does not work anymore, and you can resolve that resource
> only via its name. (In that case I assume that the jcr:content resource is
> aliased.)
> I created
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to
> demonstrate this problem.
> Is my assumption about the behavior correct?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled
[
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh resolved SLING-12025.
---
Resolution: Fixed
> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
> Issue Type: Task
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Assignee: Joerg Hoh
>Priority: Major
> Fix For: Resource Resolver 1.11.2
>
>
> I found that the there is a different behavior in case the "optimized alias
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
> + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if
> it's turned off, it does not work anymore, and you can resolve that resource
> only via its name. (In that case I assume that the jcr:content resource is
> aliased.)
> I created
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to
> demonstrate this problem.
> Is my assumption about the behavior correct?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled
[
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-12025:
--
Fix Version/s: Resource Resolver 1.11.2
> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
> Issue Type: Task
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Priority: Major
> Fix For: Resource Resolver 1.11.2
>
>
> I found that the there is a different behavior in case the "optimized alias
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
> + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if
> it's turned off, it does not work anymore, and you can resolve that resource
> only via its name. (In that case I assume that the jcr:content resource is
> aliased.)
> I created
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to
> demonstrate this problem.
> Is my assumption about the behavior correct?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-resourceresolver] joerghoh merged pull request #105: SLING-12025: Incorrect aliasing when optimzed alias resolution is off
joerghoh merged PR #105: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-site] bdelacretaz commented on pull request #133: SLING-12052: add Pagefind for site search
bdelacretaz commented on PR #133: URL: https://github.com/apache/sling-site/pull/133#issuecomment-1740533365 I think this is good enough to commit as a first version, planning to merge this PR early next week unless someone objects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10899) Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached
[ https://issues.apache.org/jira/browse/SLING-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770335#comment-17770335 ] Joerg Hoh commented on SLING-10899: --- [~Henry Kuijpers] I see the problem with the caching of the results of this adaption, as the cache must be limited in size (e.g 100 elements or 500k) , otherwise it can easily blow the JVM. This naturally limits the effectiveness, because depending on the access patterns and the cache eviction strategy you benefit from it only when you access a few resources constantly. Or if your code access only a small amount of resources at a time. I would say that in both cases you as the consumer of the API are in a much better position to decide if you want to do that adaption repeatedly and if it makes sense to cache the resulting ValueMaps in an application-layer cache and thus avoid them. And yes, this definitely makes it much harder to optimize performance, because you need to look at each location independently, and there is no immediate performance boost for each functionality doing such an adaption. But in my opinion the effectiveness of such a cache is not guaranteed, and the memory usage can be significant. > Result of JcrNodeResource#adaptTo(ValueMap.class) should be cached > -- > > Key: SLING-10899 > URL: https://issues.apache.org/jira/browse/SLING-10899 > Project: Sling > Issue Type: Improvement > Components: JCR >Affects Versions: JCR Resource 3.0.22 >Reporter: Henry Kuijpers >Priority: Major > > I was performance testing our application. There is a specific part of the > code where we have a set of ~500 resources and we sort them based on a few > properties of the resources. Multiple properties are used (which results in > multiple calls to getValueMap). The sorting is done using a comparator, so > the logic that determines the order is accessed numerous times. > We've seen quite a decrease in performance when doing this with Resources > that are of type JcrNodeResource. Turns out that the result of getValueMap > (or adaptTo((Value)Map.class)) is not cached. > As you can see in the adaptTo()-method implementation: > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/src/main/java/org/apache/sling/jcr/resource/internal/helper/jcr/JcrNodeResource.java#L136 > this call bypasses the AdapterFactory framework and also bypasses any > caching that happens over there. > What's even more unfortunate, is that JcrValueMap is implementing caching via > https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/6e13f4d315ddf2804d2e16c55faee18e805b618e/src/main/java/org/apache/sling/jcr/resource/internal/JcrValueMap.java#L49 > . That caching is not leveraged properly, because every call to getValueMap > returns a new JcrValueMap, instead of reusing a previously created one. > One change that can be done is maybe converting the logic inside the > adaptTo()-method to a dedicated AdapterFactory implementation, so that > caching is done by default? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #105: SLING-12025: Incorrect aliasing when optimzed alias resolution is off
sonarcloud[bot] commented on PR #105: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105#issuecomment-1740519672 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=105) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=105=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=105=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=105=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=105=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=105=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=105=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #105: SLING-12025: Incorrect aliasing when optimzed alias resolution is off
sonarcloud[bot] commented on PR #105: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105#issuecomment-1740512961 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-resourceresolver=105) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=105=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=105=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver=105=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=105=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=105=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=105=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=105=new_duplicated_lines_density=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12025) ResourceResolver: different mapping when optimizedAliasResolution enabled
[
https://issues.apache.org/jira/browse/SLING-12025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770327#comment-17770327
]
Joerg Hoh commented on SLING-12025:
---
Actually, when checking closer, the aliasing is not working at all, if the
optimizedAliasing is not turned on...
I adjusted the test and made it pass in all cases, to document this behavior.
> ResourceResolver: different mapping when optimizedAliasResolution enabled
> -
>
> Key: SLING-12025
> URL: https://issues.apache.org/jira/browse/SLING-12025
> Project: Sling
> Issue Type: Task
> Components: ResourceResolver
>Affects Versions: Resource Resolver 1.10.0
>Reporter: Joerg Hoh
>Priority: Major
>
> I found that the there is a different behavior in case the "optimized alias
> resolution is enabled.
> Setup:
> {noformat}
> * /content/jcr:content
> + sling:alias=foobar
> {noformat}
> In my opinion the expected behavior is that the {{content}} resource is
> aliased and can be resolved via both {{/content}} and {{/foobar}}. You cannot
> alias the {{jcr:content}} node. Unfortunately there are no unit tests for
> that, and I just came across that behavior when I tried to write one.
> This works with the "optimized alias resolution" feature turned on, but if
> it's turned off, it does not work anymore, and you can resolve that resource
> only via its name. (In that case I assume that the jcr:content resource is
> aliased.)
> I created
> https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/105 to
> demonstrate this problem.
> Is my assumption about the behavior correct?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [sling-org-apache-sling-jcr-base] cziegeler merged pull request #11: Issues/sling 11741
cziegeler merged PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: Automatically updating the downloads list for out website
Hi Robert I think it's an excellent idea! Thanks for making the release process simpler. Regards Julian On Wed, Sep 27, 2023 at 11:33 PM Robert Munteanu wrote: > > On Fri, 2023-09-22 at 11:35 +0200, Robert Munteanu wrote: > > Hi, > > > > I did a quick experiment on automatically updating the download list > > for the sling web site with renovate. > > > > You can see how it would look like at [1]. We would still need to > > manually merge PRs but I think it's better than manually updating the > > downloads list after a release. > > > > It already shows 12 missed updates and a typo. > > > > We need to ask infra to install the 'forking-renovate' app, just like > > they did for the Sling Starter, so I would like to make sure there > > are > > no objections before I do that. > > I heard no objections, created > https://issues.apache.org/jira/browse/SLING-12049 to track the work. > > Thanks, > Robert > > > > > I plan to ask infra on Tuesday, please voice concerns before that. > > > > Thanks, > > Robert > > > > > > [1]: https://github.com/rombert/sling-site/pull/1 >
[GitHub] [sling-org-apache-sling-jcr-base] jsedding commented on pull request #11: Issues/sling 11741
jsedding commented on PR #11: URL: https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#issuecomment-1740452497 @cziegeler if you're happy with the current state, feel free to merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-base] jsedding commented on a diff in pull request #11: Issues/sling 11741
jsedding commented on code in PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-base/pull/11#discussion_r1341023515
##
src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java:
##
@@ -133,24 +124,47 @@ public boolean allowLoginAdministrative(Bundle b) {
}
// encapsulate configuration state for atomic configuration updates
-private static class ConfigurationState {
+static class ConfigurationState {
+
+public final boolean bypassAllowList;
-private final boolean bypassAllowList;
+public final Pattern allowListRegexp;
-private final Pattern allowListRegexp;
+ConfigurationState(final LoginAdminAllowListConfiguration config,
final Map properties) {
+// first check for legacy properties
+boolean bypass = config.allowlist_bypass();
+final Object legacyBypassObject =
properties.get(LEGACY_BYPASS_PROPERTY);
+if (legacyBypassObject != null) {
+LOG.warn("Using deprecated configuration property '{}' from
configuration '{}'. " +
+"Update your configuration to use configuration '{}' and
property '{}' instead.",
+LEGACY_BYPASS_PROPERTY, LEGACY_PID, PID,
"allowlist.bypass");
+bypass =
Converters.standardConverter().convert(legacyBypassObject).defaultValue(false).to(Boolean.class);
+}
+String legacyRegexp = null;
+final Object legacyBundlesObject =
properties.get(LEGACY_BUNDLES_PROPERTY);
+if (legacyBypassObject != null) {
+LOG.warn("Using deprecated configuration property '{}' from
configuration '{}'. " +
+"Update your configuration to use configuration '{}' and
property '{}' instead.",
+LEGACY_BUNDLES_PROPERTY, LEGACY_PID, PID,
"allowlist.bundles.regexp");
+legacyRegexp =
Converters.standardConverter().convert(legacyBundlesObject).to(String.class);
+}
-private ConfigurationState(final LoginAdminAllowListConfiguration
config) {
final String regexp = config.allowlist_bundles_regexp();
-if(regexp.trim().length() > 0) {
-allowListRegexp = Pattern.compile(regexp);
-LOG.warn("A 'allowlist.bundles.regexp' is configured, this is
NOT RECOMMENDED for production: {}",
-allowListRegexp);
+if (regexp.trim().length() > 0) {
+if (legacyRegexp != null) {
+LOG.warn("Both deprecated configuration property '{}' and
configuration property '{}' are set. " +
+"The deprecated property '{}' is ignored.",
+LEGACY_BUNDLES_PROPERTY, "allowlist.bundles.regexp",
LEGACY_BUNDLES_PROPERTY);
+}
+this.allowListRegexp = Pattern.compile(regexp);
} else {
-allowListRegexp = null;
+this.allowListRegexp = legacyRegexp != null ?
Pattern.compile(legacyRegexp) : null;
}
-
-bypassAllowList = config.allowlist_bypass();
-if(bypassAllowList) {
+if (this.allowListRegexp != null) {
+LOG.warn("A 'allowlist.bundles.regexp' is configured, this is
NOT RECOMMENDED for production: {}", allowListRegexp);
Review Comment:
Fine with me.
##
src/main/java/org/apache/sling/jcr/base/internal/LoginAdminAllowList.java:
##
@@ -133,24 +124,47 @@ public boolean allowLoginAdministrative(Bundle b) {
}
// encapsulate configuration state for atomic configuration updates
-private static class ConfigurationState {
+static class ConfigurationState {
+
+public final boolean bypassAllowList;
-private final boolean bypassAllowList;
+public final Pattern allowListRegexp;
-private final Pattern allowListRegexp;
+ConfigurationState(final LoginAdminAllowListConfiguration config,
final Map properties) {
+// first check for legacy properties
+boolean bypass = config.allowlist_bypass();
+final Object legacyBypassObject =
properties.get(LEGACY_BYPASS_PROPERTY);
+if (legacyBypassObject != null) {
+LOG.warn("Using deprecated configuration property '{}' from
configuration '{}'. " +
+"Update your configuration to use configuration '{}' and
property '{}' instead.",
+LEGACY_BYPASS_PROPERTY, LEGACY_PID, PID,
"allowlist.bypass");
+bypass =
Converters.standardConverter().convert(legacyBypassObject).defaultValue(false).to(Boolean.class);
+}
+String legacyRegexp = null;
+final Object legacyBundlesObject =
properties.get(LEGACY_BUNDLES_PROPERTY);
+if (legacyBypassObject != null) {
+LOG.warn("Using deprecated configuration property '{}'
