Re: [PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]
kwin commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5#issuecomment-2050026016 What makes you think this is not supported with Parent 60? Compare with https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=284790344. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]
rombert commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5#issuecomment-2050022625 Because we still need to target Java 8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]
kwin commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5#issuecomment-2049995107 Why not 60? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-12291) Broken backwards compatibility for duplicated keys
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12291: --- Assignee: Remo Liechti > Broken backwards compatibility for duplicated keys > -- > > Key: SLING-12291 > URL: https://issues.apache.org/jira/browse/SLING-12291 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.24 >Reporter: Remo Liechti >Assignee: Remo Liechti >Priority: Major > Fix For: Commons JSON 2.0.24 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > duplicated keys in a json. > New behaviour: throws an exception on duplicated keys > Old behaviour: ignores the fact and is able to process json with duplicated > keys. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12276 - Update to java-html-sanitizer 20240325.1 [sling-org-apache-sling-xss]
rombert commented on PR #42: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/42#issuecomment-2049992800 @raducotescu - any comments? I plan to merge tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12291) Broken backwards compatibility for duplicated keys
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12291: Fix Version/s: Commons JSON 2.0.24 > Broken backwards compatibility for duplicated keys > -- > > Key: SLING-12291 > URL: https://issues.apache.org/jira/browse/SLING-12291 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.24 >Reporter: Remo Liechti >Priority: Major > Fix For: Commons JSON 2.0.24 > > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > duplicated keys in a json. > New behaviour: throws an exception on duplicated keys > Old behaviour: ignores the fact and is able to process json with duplicated > keys. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-10506) Document inappropriate Sonar rules
[
https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oliver Lietz updated SLING-10506:
-
Description:
* {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
* {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
* {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
* {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
* {{java:S1948}} (https://rules.sonarsource.com/java/RSPEC-1948)
* {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
* {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
* {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
* {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)
was:
* {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
* {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
* {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
* {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
* {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
* {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
* {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
* {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)
> Document inappropriate Sonar rules
> --
>
> Key: SLING-10506
> URL: https://issues.apache.org/jira/browse/SLING-10506
> Project: Sling
> Issue Type: Task
> Components: Build and Source Control, CI
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> * {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
> * {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
> * {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
> * {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
> * {{java:S1948}} (https://rules.sonarsource.com/java/RSPEC-1948)
> * {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
> * {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
> * {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
> * {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12291) Broken backwards compatibility for duplicated keys
Remo Liechti created SLING-12291: Summary: Broken backwards compatibility for duplicated keys Key: SLING-12291 URL: https://issues.apache.org/jira/browse/SLING-12291 Project: Sling Issue Type: Bug Reporter: Remo Liechti The fix of CVE-2022-47937 introduced an invalid backwards compatibility for duplicated keys in a json. New behaviour: throws an exception on duplicated keys Old behaviour: ignores the fact and is able to process json with duplicated keys. To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12291) Broken backwards compatibility for duplicated keys
[ https://issues.apache.org/jira/browse/SLING-12291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remo Liechti updated SLING-12291: - Affects Version/s: Commons JSON 2.0.24 > Broken backwards compatibility for duplicated keys > -- > > Key: SLING-12291 > URL: https://issues.apache.org/jira/browse/SLING-12291 > Project: Sling > Issue Type: Bug >Affects Versions: Commons JSON 2.0.24 >Reporter: Remo Liechti >Priority: Major > > The fix of CVE-2022-47937 introduced an invalid backwards compatibility for > duplicated keys in a json. > New behaviour: throws an exception on duplicated keys > Old behaviour: ignores the fact and is able to process json with duplicated > keys. > To no break existing users of the library, reestablish the old behaviour. -- This message was sent by Atlassian Jira (v8.20.10#820010)
RE: [VOTE] Release Apache Sling Tenant 1.1.8
+1 stefan
Re: [PR] SLING-11633 - Compile with Java 11 [sling-org-apache-sling-junit-teleporter]
rombert commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-junit-teleporter/pull/7#issuecomment-2049712912 @sufyanharoon - I agree that it can be used as a plain jar, but if you build it you will see that it's an OSGi bundle - https://github.com/apache/sling-org-apache-sling-junit-teleporter/blob/3de6bd052bcb1c7b59bcf6c7a660bc2be5ead532/pom.xml#L24 ``` $ cat target/classes/META-INF/MANIFEST.MF | grep 'Bundle-SymbolicName' Bundle-SymbolicName: org.apache.sling.junit.teleporter ``` Won't your scenario be fixed if you add the two extra jars to the classpath? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Apache Sling Tenant 1.1.8
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354544=Text Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2845/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2845 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Resolved] (SLING-12290) Update tenant module to use parent pom 52
[ https://issues.apache.org/jira/browse/SLING-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12290. - Resolution: Fixed > Update tenant module to use parent pom 52 > - > > Key: SLING-12290 > URL: https://issues.apache.org/jira/browse/SLING-12290 > Project: Sling > Issue Type: Task > Components: Extensions >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Tenant 1.1.8 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]
rombert merged PR #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5#issuecomment-2049662623 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-tenant=5) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tenant=5=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tenant=5=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tenant=5=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tenant=5=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-tenant=5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12283 : changed the config Pid to separate factoryPID & PID wit… [sling-org-apache-sling-installer-factory-configuration]
sonarcloud[bot] commented on PR #13: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/13#issuecomment-2049658267 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-installer-factory-configuration=13) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration=13=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-factory-configuration=13=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-installer-factory-configuration=13=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-factory-configuration=13=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-factory-configuration=13=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-installer-factory-configuration=13) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] SLING-12290 - Update tenant module to use parent pom 52 [sling-org-apache-sling-tenant]
rombert opened a new pull request, #5: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/5 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12290) Update tenant module to use parent pom 52
Robert Munteanu created SLING-12290: --- Summary: Update tenant module to use parent pom 52 Key: SLING-12290 URL: https://issues.apache.org/jira/browse/SLING-12290 Project: Sling Issue Type: Task Components: Extensions Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Tenant 1.1.8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10506) Document inappropriate Sonar rules
[
https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836157#comment-17836157
]
Oliver Lietz commented on SLING-10506:
--
[~kwin], Makes totally sense to add (I've suppressed the warnings myself in the
past, example:
[ClamEventsServlet|https://github.com/apache/sling-org-apache-sling-clam/blob/master/src/main/java/org/apache/sling/clam/http/internal/ClamEventsServlet.java])
and *communicate* as developers are already "fixing" the issue.
No chance to follow up on this topic currently as all spare time goes into Pax
Exam.
> Document inappropriate Sonar rules
> --
>
> Key: SLING-10506
> URL: https://issues.apache.org/jira/browse/SLING-10506
> Project: Sling
> Issue Type: Task
> Components: Build and Source Control, CI
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> * {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
> * {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
> * {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
> * {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
> * {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
> * {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
> * {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
> * {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-12266. Fix Version/s: Testing Sling Mock Oak 3.2.0-1.44.0 Testing Sling Mock 3.5.0 Resolution: Fixed * [https://github.com/apache/sling-org-apache-sling-testing-sling-mock/commit/0fb97232b98a91bdca3b5accaa3d499175e4685b] * [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/7a8c92c3f6995c54d38aebecd8225d2fa3a2f5ee] * > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > Fix For: Testing Sling Mock Oak 3.2.0-1.44.0, Testing Sling Mock > 3.5.0 > > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]
stefanseifert merged PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]
sonarcloud[bot] commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#issuecomment-2049560447 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12=false=true)  [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-sling-mock-oak=12) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]
stefanseifert commented on code in PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560922574 ## pom.xml: ## @@ -45,7 +45,7 @@ 1.44.0 Review Comment: i've created [SLING-12287](https://issues.apache.org/jira/browse/SLING-12287) for the oak version discussion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] SLING-12266 - Add support for repo snapshots [sling-org-apache-sling-testing-sling-mock]
stefanseifert merged PR #39: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12288) Allow configuration of SubscriberReady forceIdleMillies
[ https://issues.apache.org/jira/browse/SLING-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-12288: Fix Version/s: Content Distribution Journal Core 0.3.0 > Allow configuration of SubscriberReady forceIdleMillies > --- > > Key: SLING-12288 > URL: https://issues.apache.org/jira/browse/SLING-12288 > Project: Sling > Issue Type: Improvement >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Journal Core 0.3.0 > > > Currently we set this to SubscriberReady.DEFAULT_FORCE_IDLE_MILLIS. > For some cases we need a longer timeout though. So this should also be > configurable via the config map. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12289) PackageStatusWatcher should ignore additional status for the same package
Christian Schneider created SLING-12289: --- Summary: PackageStatusWatcher should ignore additional status for the same package Key: SLING-12289 URL: https://issues.apache.org/jira/browse/SLING-12289 Project: Sling Issue Type: Improvement Reporter: Christian Schneider Assignee: Christian Schneider Fix For: Content Distribution Journal Core 0.3.0 If a second status message arrives when we already have a status stored locally we should ignore the new status message. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12288) Allow configuration of SubscriberReady forceIdleMillies
Christian Schneider created SLING-12288: --- Summary: Allow configuration of SubscriberReady forceIdleMillies Key: SLING-12288 URL: https://issues.apache.org/jira/browse/SLING-12288 Project: Sling Issue Type: Improvement Reporter: Christian Schneider Assignee: Christian Schneider Currently we set this to SubscriberReady.DEFAULT_FORCE_IDLE_MILLIS. For some cases we need a longer timeout though. So this should also be configurable via the config map. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836117#comment-17836117 ] Csaba Varga commented on SLING-12266: - [~sseifert] : Removed the "more aggressive" commit as requested. While there, I also rebased my code on the latest master. (I accidentally started from an outdated commit originally.) > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12285. - Resolution: Fixed > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Gagan Malpani >Assignee: Gagan Malpani >Priority: Major > Fix For: Tenant 1.1.8 > > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]
rombert merged PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-12285: --- Assignee: Gagan Malpani > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Bug > Components: General >Reporter: Gagan Malpani >Assignee: Gagan Malpani >Priority: Major > Fix For: Tenant 1.1.8 > > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12285: Component/s: Extensions (was: General) > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Gagan Malpani >Assignee: Gagan Malpani >Priority: Major > Fix For: Tenant 1.1.8 > > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12285: Issue Type: Bug (was: Improvement) > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Bug > Components: General >Reporter: Gagan Malpani >Priority: Major > Fix For: Tenant 1.1.8 > > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]
rombert commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2049255899 Thanks for the PR and explanation in the Jira issue @gagan031992 , I've merged the fix and will create a release this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-12286) Tenant build fails with Java 17 or newer
[ https://issues.apache.org/jira/browse/SLING-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12286. - Resolution: Fixed > Tenant build fails with Java 17 or newer > > > Key: SLING-12286 > URL: https://issues.apache.org/jira/browse/SLING-12286 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Tenant 1.1.8 > > > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 > s <<< FAILURE! - in org.apache.sling.tenant.internal.TenantProviderImplTest > [ERROR] > org.apache.sling.tenant.internal.TenantProviderImplTest.testListTenantsWithoutTenantRoot > Time elapsed: 0.036 s <<< ERROR! > java.lang.ExceptionInInitializerError > at > org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12285 adding bind & unbind methods mapping [sling-org-apache-sling-tenant]
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/3#issuecomment-2049247224 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-tenant=3) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tenant=3=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tenant=3=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tenant=3=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tenant=3=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-tenant=3) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12287) sling-mock-oak: Use latest Oak Version and add ITs to ensure compatiblity with 1.22.x
Stefan Seifert created SLING-12287: -- Summary: sling-mock-oak: Use latest Oak Version and add ITs to ensure compatiblity with 1.22.x Key: SLING-12287 URL: https://issues.apache.org/jira/browse/SLING-12287 Project: Sling Issue Type: Improvement Components: Testing Reporter: Stefan Seifert Assignee: Stefan Seifert Fix For: Testing Sling Mock Oak 3.2.0-1.44.0 following the discussion with [~reschke] in SLING-12266 we should move away from oak 1.44 which is quite outdated. however, we need to ensure to keep compatibility with the old 1.22.x version range to support all sorts of projects using the mocks. a solution might be to switch to a recent version of oak in the POM, and create dedicated ITs to test against this and older 1.22.x versions to ensure compatibility. the benefit is, that all projects that are "just using" sling-mock-oak without thinking about the dependency management (e.g. not using something like [https://wcm.io/tooling/maven/aem-dependencies.html)] will get the latest version which is better supported. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12286 - Tenant build fails with Java 17 or newer [sling-org-apache-sling-tenant]
rombert merged PR #4: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836072#comment-17836072 ] Julian Reschke commented on SLING-12266: bq. there was some need form other sling modules to have a slightly newer version from oak in sling-mock-oak than 1.22 Would be interesting to dig out why; might be a confusion about how versioning is handled over in Oak. > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12286 - Tenant build fails with Java 17 or newer [sling-org-apache-sling-tenant]
sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/4#issuecomment-2049232427 ## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-tenant=4) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-tenant=4=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tenant=4=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-tenant=4=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-tenant=4=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-tenant=4) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-12286) Tenant build fails with Java 17 or newer
[ https://issues.apache.org/jira/browse/SLING-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12286: Summary: Tenant build fails with Java 17 or newer (was: Tenat build fails with Java 17 or newer) > Tenant build fails with Java 17 or newer > > > Key: SLING-12286 > URL: https://issues.apache.org/jira/browse/SLING-12286 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Tenant 1.1.8 > > > [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 > s <<< FAILURE! - in org.apache.sling.tenant.internal.TenantProviderImplTest > [ERROR] > org.apache.sling.tenant.internal.TenantProviderImplTest.testListTenantsWithoutTenantRoot > Time elapsed: 0.036 s <<< ERROR! > java.lang.ExceptionInInitializerError > at > org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836068#comment-17836068 ] Stefan Seifert commented on SLING-12266: ah, ok. there was some need form other sling modules to have a slightly newer version from oak in sling-mock-oak than 1.22, so we are currently between chairs of supporting the "old and the new world". usually, the actual version that is used in the unit tests should be controlled by the project environment e.g. when using [https://wcm.io/tooling/maven/aem-dependencies.html] for either AEMaaCS or AEM 6.5, so this is a bit of an academic discussion. of course, there may be projects that to not care about that dependency management and end up with 1.44. we might think about a way to ensure compatibility with different old and new versions in CI and use a newer version in the POM. however, this is off-topic for this ticket. [~Csaba Varga] it would be great if you can remove the makeJcr optimization then we can merge the PRs. > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] SLING-12286 - Tenat build fails with Java 17 or newer [sling-org-apache-sling-tenant]
rombert opened a new pull request, #4: URL: https://github.com/apache/sling-org-apache-sling-tenant/pull/4 Update to Mockito 4.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-12286) Tenat build fails with Java 17 or newer
Robert Munteanu created SLING-12286: --- Summary: Tenat build fails with Java 17 or newer Key: SLING-12286 URL: https://issues.apache.org/jira/browse/SLING-12286 Project: Sling Issue Type: Bug Components: Extensions Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Tenant 1.1.8 [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.038 s <<< FAILURE! - in org.apache.sling.tenant.internal.TenantProviderImplTest [ERROR] org.apache.sling.tenant.internal.TenantProviderImplTest.testListTenantsWithoutTenantRoot Time elapsed: 0.036 s <<< ERROR! java.lang.ExceptionInInitializerError at org.mockito.cglib.core.KeyFactory$Generator.generateClass(KeyFactory.java:167) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12285) adding bind & unbind methods mapping in reference annotation
[ https://issues.apache.org/jira/browse/SLING-12285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-12285: Fix Version/s: Tenant 1.1.8 > adding bind & unbind methods mapping in reference annotation > > > Key: SLING-12285 > URL: https://issues.apache.org/jira/browse/SLING-12285 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Gagan Malpani >Priority: Major > Fix For: Tenant 1.1.8 > > > adding bind & unbind methods mapping in reference annotation for > tenantproviderimpl -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836061#comment-17836061 ] Julian Reschke commented on SLING-12266: Yep - that's an unsupported version. Either use a recent version from the maintenance branch (1.22.x), or the "latest & greatest". > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836059#comment-17836059 ] Stefan Seifert commented on SLING-12266: yes - and we should be using that oak 1.22.x version in all sling mocks, sling-mock-oak is using 1.44 > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836055#comment-17836055 ] Julian Reschke commented on SLING-12266: AEM 6.5 should be on Oak 1.22.18 with the latest SP. If you really need to support older SPs, there are matching Oak versions for each. AEM pre 6.5 is EOL and does not receive any fixes anymore. > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12266) Cache initial repository state to improve JCR_OAK performance
[ https://issues.apache.org/jira/browse/SLING-12266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836054#comment-17836054 ] Stefan Seifert commented on SLING-12266: i tested both PRs locally with the unit tests from aem-mock (which runs all tests on all resource resolver types), and it again was a considerable improvement in run time (from 45s to 32s on my machine). i did not see any difference with and without [https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12/commits/11de72022bf969e7253c6f6725b528963d3638db,] so i recommend to remove this optimization again - it seems oak is smart enough to not re-register the CND files again or it does not make a difference. concerning the latest jackrabbit/oak versions: we have an eye on this, but as described in SLING-12208 we have to maintain a wide range of compatibility for project contexts these mocks are used. esp. if used in AEM 6.x context, a very old oak version is still in use, and we have to support this. that's why we cannot always update to latest and greatest in the mocks here. > Cache initial repository state to improve JCR_OAK performance > - > > Key: SLING-12266 > URL: https://issues.apache.org/jira/browse/SLING-12266 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock 3.4.18 >Reporter: Csaba Varga >Assignee: Stefan Seifert >Priority: Minor > > A lot of effort goes into preparing an Oak Mock repository from scratch: node > types need to be registered, indexes need to be created, and all this happens > over several commits. None of this work depends on the test case itself, so > it will always result in the exact same repository state. We could take the > root NodeState from the first repository we build, then build subsequent > repositories on top of it, avoiding most of the redundant work. Commits can > be relatively expensive even in memory, so each one we avoid can save a lot > of time in the long term. > > This would require extending the contract between Testing Sling Mock and the > ResourceResolverTypeAdapters, to add optional "make snapshot" and "build repo > from snapshot" operations. For adapters that don't support them, we would > keep rebuilding things from scratch. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] SLING-12266 - Support snapshotting mock Oak repositories [sling-org-apache-sling-testing-sling-mock-oak]
csaboka commented on code in PR #12: URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#discussion_r1560500748 ## pom.xml: ## @@ -45,7 +45,7 @@ 1.44.0 Review Comment: I think this change would be better done in a separate PR, with a related Jira ticket since it's unrelated to the goal of this ticket and PR. I would rather someone else did it, someone who understands the implications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sling.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
