Re: [VOTE] Release Apache Sling Commons Mime 2.3.0
+1 regards, Karl On Wed, Dec 6, 2023 at 8:40 PM Carsten Ziegeler wrote: > > Hi, > > We solved 1 issue in this release > https://issues.apache.org/jira/browse/SLING-12183 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2818/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2818 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Commons Johnzon 2.0.0
+1 regards, Karl On Wed, Dec 6, 2023 at 8:39 PM Carsten Ziegeler wrote: > > Hi, > > We solved 1 issue in this release > https://issues.apache.org/jira/browse/SLING-12182 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2819/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2819 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
[jira] [Created] (SLING-12179) Make i18n optional
Karl Pauls created SLING-12179: -- Summary: Make i18n optional Key: SLING-12179 URL: https://issues.apache.org/jira/browse/SLING-12179 Project: Sling Issue Type: Improvement Components: Scripting Affects Versions: Scripting HTL Engine 1.4.22-1.4.0 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Scripting HTL Engine 1.4.24-1.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12178) Make commons metrics optional in xss bundle
[ https://issues.apache.org/jira/browse/SLING-12178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-12178. Resolution: Fixed Done in https://github.com/apache/sling-org-apache-sling-xss/pull/41 > Make commons metrics optional in xss bundle > --- > > Key: SLING-12178 > URL: https://issues.apache.org/jira/browse/SLING-12178 > Project: Sling > Issue Type: Improvement > Components: XSS Protection API >Affects Versions: XSS Protection API 2.4.0 > Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: XSS Protection API 2.4.2 > > > Following the pattern we use in the other bundles, it would be good if the > sling metrics would be optional for the xss bundle. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12178) Make commons metrics optional in xss bundle
Karl Pauls created SLING-12178: -- Summary: Make commons metrics optional in xss bundle Key: SLING-12178 URL: https://issues.apache.org/jira/browse/SLING-12178 Project: Sling Issue Type: Improvement Components: XSS Protection API Affects Versions: XSS Protection API 2.4.0 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: XSS Protection API 2.4.2 Following the pattern we use in the other bundles, it would be good if the sling metrics would be optional for the xss bundle. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12057) Replace commons.threads with Executor
[ https://issues.apache.org/jira/browse/SLING-12057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-12057. Resolution: Fixed > Replace commons.threads with Executor > - > > Key: SLING-12057 > URL: https://issues.apache.org/jira/browse/SLING-12057 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting Core 2.4.8 >Reporter: Carsten Ziegeler >Assignee: Karl Pauls >Priority: Major > Fix For: Scripting Core 2.4.10 > > > In order to minimize dependencies for core Sling, we could replace usage of > the commons.threads (which is not used in any other core bundle) with > Executor api > [~radu] WDYT? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12057) Replace commons.threads with Executor
[ https://issues.apache.org/jira/browse/SLING-12057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned SLING-12057: -- Assignee: Karl Pauls > Replace commons.threads with Executor > - > > Key: SLING-12057 > URL: https://issues.apache.org/jira/browse/SLING-12057 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Scripting Core 2.4.8 >Reporter: Carsten Ziegeler >Assignee: Karl Pauls >Priority: Major > Fix For: Scripting Core 2.4.10 > > > In order to minimize dependencies for core Sling, we could replace usage of > the commons.threads (which is not used in any other core bundle) with > Executor api > [~radu] WDYT? -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling Testing JCR Mock 1.6.2
+1 regards, Karl On Thursday, February 23, 2023, Carsten Ziegeler wrote: > +1 > > Carsten > > On 22.02.2023 10:52, Radu Cotescu wrote: > >> Hi, >> >> We solved 1 issue in this release: >> https://issues.apache.org/jira/browse/SLING/fixforversion/12351708 >> >> Staging repository: >> https://repository.apache.org/content/repositories/orgapachesling-2720/ >> >> You can use this UNIX script to download the release and verify the >> signatures: >> https://gitbox.apache.org/repos/asf?p=sling-tooling-release. >> git;a=blob;f=check_staged_release.sh;hb=HEAD >> >> Usage: >> sh check_staged_release.sh 2720 /tmp/sling-staging >> >> Please vote to approve this release: >> >>[ ] +1 Approve the release >>[ ] 0 Don't care >>[ ] -1 Don't release, because ... >> >> This majority vote is open for at least 72 hours. >> >> Regards, >> Radu Cotescu >> > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Engine 2.14.0
+1 regards, Karl On Tuesday, February 21, 2023, Nicolas Peltier wrote: > +1 > > Nicolas > > Le mar. 21 févr. 2023 à 16:23, Angela Schreiber > > a écrit : > > > +1 > > > > kind regards > > angela > > > > > > From: Carsten Ziegeler > > Sent: Tuesday, February 21, 2023 14:36 > > To: dev@sling.apache.org > > Subject: [VOTE] Release Apache Sling Engine 2.14.0 > > > > Hi, > > > > We solved 4 issues in this release > > https://issues.apache.org/jira/projects/SLING/versions/12352612 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2719 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling- > release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2719 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling JCR Base 3.1.12
+1 regards, Karl On Thu, Feb 9, 2023 at 11:42 AM Robert Munteanu wrote: > On Thu, 2023-02-09 at 08:36 +0100, ang...@apache.org wrote: > > Please vote to approve this release: > > +1 > Robert > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Scripting JSP 2.6.2
+1 regards, Karl On Fri, Dec 9, 2022 at 12:06 PM Angela Schreiber wrote: > +1 > angela > > From: Radu Cotescu > Sent: Friday, December 9, 2022 11:15 > To: Sling Developers List > Subject: [VOTE] Release Apache Sling Scripting JSP 2.6.2 > > EXTERNAL: Use caution when clicking on links or opening attachments. > > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352657 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2706/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2706 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Engine 2.13.2
+1 regards, Karl On Fri, Dec 9, 2022 at 12:07 PM Angela Schreiber wrote: > +1 > angela > > > From: Radu Cotescu > Sent: Friday, December 9, 2022 11:15 > To: Sling Developers List > Subject: [VOTE] Release Apache Sling Engine 2.13.2 > > > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12352612 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2705/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2705 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Radu Cotescu > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Webconsole Securityprovider 1.2.8
+1 regards, Karl On Tue, Dec 6, 2022 at 5:32 PM Daniel Klco wrote: > +1 > > On Tue, Dec 6, 2022 at 11:23 AM Carsten Ziegeler > wrote: > > > +1 > > > > Carsten > > > > Am 06.12.2022 um 15:15 schrieb Carsten Ziegeler: > > > Hi, > > > > > > We solved 1 issue in this release > > > https://issues.apache.org/jira/browse/SLING-11620 > > > > > > > > > Staging repository: > > > https://repository.apache.org/content/repositories/orgapachesling-2704 > > > > > > You can use this UNIX script to download the release and verify the > > > signatures: > > > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: > > > sh check_staged_release.sh 2704 /tmp/sling-staging > > > > > > Please vote to approve this release: > > > > > >[ ] +1 Approve the release > > >[ ] 0 Don't care > > >[ ] -1 Don't release, because ... > > > > > > This majority vote is open for at least 72 hours. > > > > > > Regards > > > Carsten > > > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Feature Launcher 1.2.2 and Feature Extensions Apiregions 1.6.4
+1 regards, Karl On Tuesday, December 6, 2022, Angela Schreiber wrote: > [x] +1 Approve the release > > kind regards > angela > > > From: Carsten Ziegeler > Sent: Tuesday, December 6, 2022 06:33 > To: dev@sling.apache.org > Subject: [VOTE] Release Apache Sling Feature Launcher 1.2.2 and Feature > Extensions Apiregions 1.6.4 > > > Hi, > > we solved 11 issues for the launcher > https://issues.apache.org/jira/projects/SLING/versions/12351353 > > and 2 issues for the apiregions extension > https://issues.apache.org/jira/projects/SLING/versions/12352068 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2703 > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling- > release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2703 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Servlets Resolver 2.9.10
+1 regards, Karl On Wed, Nov 30, 2022 at 8:33 PM Eric Norman wrote: > +1 > > On Mon, Nov 28, 2022 at 10:26 PM Carsten Ziegeler > wrote: > > > Hi, > > > > We solved 1 issue in this release > > https://issues.apache.org/jira/projects/SLING/versions/12352599 > > > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2699 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2699 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Engine 2.13.0
+1 regards, Karl On Wed, Nov 30, 2022 at 8:32 PM Eric Norman wrote: > Hi Carsten, > > Thanks for the follow up. I'm satisfied with the explanation and > solutions. The tests are all working now for me. > > +1 for me. > > Regards, > Eric > > On Wed, Nov 30, 2022 at 3:57 AM Carsten Ziegeler > wrote: > > > Thanks Eric, > > > > the errors are caused by two things: > > a) wrongly written error handlers as part of the tests. As we document > > an error handler needs to set the status code (if different from 200). > > The test ones didn't do that. I fixed the error handlers. > > b) the other failing tests are actually testing what is now fixed in the > > engine. when a response can't be reset, an error handler must not output > > anything. However, some tests are checking this. Increasing the response > > buffer (which I did in the starter now for the tests), fixes that > problem. > > > > So I think, there is no problem with the new engine release. > > > > Regards > > Carsten > > > > Am 29.11.2022 um 20:12 schrieb Eric Norman: > > > -1 for me. > > > > > > Switching to this artifact introduces 7 new failures in the starter > > > integration tests that need to be remedied or explained. > > > > > > Most of the failures appear to be related to the wrong status code > > arriving > > > with the error pages. > > > > > > Regards, > > > Eric > > > > > > On Mon, Nov 28, 2022 at 10:25 PM Carsten Ziegeler < > cziege...@apache.org> > > > wrote: > > > > > >> Hi, > > >> > > >> We solved 1 issue in this release > > >> https://issues.apache.org/jira/projects/SLING/versions/12352598 > > >> > > >> > > >> Staging repository: > > >> > https://repository.apache.org/content/repositories/orgapachesling-2698 > > >> > > >> You can use this UNIX script to download the release and verify the > > >> signatures: > > >> > > >> > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > >> > > >> Usage: > > >> sh check_staged_release.sh 2698 /tmp/sling-staging > > >> > > >> Please vote to approve this release: > > >> > > >> [ ] +1 Approve the release > > >> [ ] 0 Don't care > > >> [ ] -1 Don't release, because ... > > >> > > >> This majority vote is open for at least 72 hours. > > >> > > >> Regards > > >> Carsten > > >> -- > > >> Carsten Ziegeler > > >> Adobe > > >> cziege...@apache.org > > >> > > > > > > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.24
+1 Regards, Karl On Fri, Nov 18, 2022 at 3:25 PM wrote: > +1 > > David > > On Fri, 18 Nov 2022 at 12:39, Carsten Ziegeler > wrote: > > > +1 > > > > Carsten > > > > Am 17.11.2022 um 10:44 schrieb ang...@apache.org: > > > Hi, > > > > > > We solved 2 issues in this release: > > > https://issues.apache.org/jira/projects/SLING/versions/12352474 > > > > > > Staging repository: > > > https://repository.apache.org/content/repositories/orgapachesling-2693 > > > > > > You can use this UNIX script to download the release and verify the > > > signatures: > > > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: > > > sh check_staged_release.sh 2693 /tmp/sling-staging > > > > > > Please vote to approve this release: > > > > > >[ ] +1 Approve the release > > >[ ] 0 Don't care > > >[ ] -1 Don't release, because ... > > > > > > This majority vote is open for at least 72 hours. > > > > > > Kind regards > > > Angela > > > > -- > > Carsten Ziegeler > > Adobe > > cziege...@apache.org > > > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Engine 2.12.2
+1 regards, Karl On Fri, Nov 11, 2022 at 1:05 PM Robert Munteanu wrote: > On Fri, 2022-11-11 at 07:35 +0100, Carsten Ziegeler wrote: > > Please vote to approve this release: > > +1 > Robert > -- Karl Pauls karlpa...@gmail.com
[jira] [Resolved] (SLING-11630) Feature model IOUtils should not use caches for jar files from jar url connection
[ https://issues.apache.org/jira/browse/SLING-11630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-11630. Resolution: Fixed Done in https://github.com/apache/sling-org-apache-sling-feature/pull/31 > Feature model IOUtils should not use caches for jar files from jar url > connection > - > > Key: SLING-11630 > URL: https://issues.apache.org/jira/browse/SLING-11630 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model 1.2.30 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Feature Model 1.3.0 > > > The JarUrlConnection is set to use caches for JarFiles by default. That is a > problem because if there is more than one connection for the same JarFile and > the connection is going away, it will close the JarFile - potentially causing > the users of the JarFile from the other (still open) connection with a closed > JarFile. > To work around this problem, the IOUtils should set use caches to false on > the connections it creates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-11630) Feature model IOUtils should not use caches for jar files from jar url connection
Karl Pauls created SLING-11630: -- Summary: Feature model IOUtils should not use caches for jar files from jar url connection Key: SLING-11630 URL: https://issues.apache.org/jira/browse/SLING-11630 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: Feature Model 1.2.30 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Feature Model 1.3.0 The JarUrlConnection is set to use caches for JarFiles by default. That is a problem because if there is more than one connection for the same JarFile and the connection is going away, it will close the JarFile - potentially causing the users of the JarFile from the other (still open) connection with a closed JarFile. To work around this problem, the IOUtils should set use caches to false on the connections it creates. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [VOTE] Release Apache Sling XSS Protection API 2.3.0
+1 regards, Karl On Fri, Sep 30, 2022 at 3:48 PM Stefan Seifert wrote: > +1 > > stefan > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling GraphQL Core 0.0.14
+1 regards, Karl On Tue, Aug 30, 2022 at 6:26 PM Radu Cotescu wrote: > +1 > > > On 30 Aug 2022, at 18:24, Radu Cotescu wrote: > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Resource Resolver 1.10.0, Apache Sling Scripting HTL JS Use Provider 1.2.8, Apache Sling Scripting HTL Engine 1.4.20-1.4.0, Apache Sling Servlets Resolver 2.9.8, Apache
+1 regards, Karl On Mon, Aug 8, 2022 at 6:54 PM Carsten Ziegeler wrote: > > +1 > > Carsten > > Am 08.08.2022 um 18:09 schrieb Radu Cotescu: > > Hi, > > > > We solved 18 issues in these releases: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12351841 > > https://issues.apache.org/jira/browse/SLING/fixforversion/12352164 > > https://issues.apache.org/jira/browse/SLING/fixforversion/12352163 > > https://issues.apache.org/jira/browse/SLING/fixforversion/12351808 > > https://issues.apache.org/jira/browse/SLING/fixforversion/12351863 > > https://issues.apache.org/jira/browse/SLING/fixforversion/12352083 > > https://issues.apache.org/jira/browse/SLING/fixforversion/12350470 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2662/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2662 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards, > > Radu Cotescu > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
[jira] [Resolved] (SLING-11373) The MergingServletResourceProvider does not wrap resources correctly
[
https://issues.apache.org/jira/browse/SLING-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls resolved SLING-11373.
Resolution: Fixed
> The MergingServletResourceProvider does not wrap resources correctly
>
>
> Key: SLING-11373
> URL: https://issues.apache.org/jira/browse/SLING-11373
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Affects Versions: Servlets Resolver 2.7.0
>Reporter: Radu Cotescu
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Servlets Resolver 2.9.8
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The {{MergingServletResourceProvider}} does not wrap resources correctly,
> forcing script engines that need to solve dependencies via this provider to
> call {{ResourceResolver#resolve(String)}}. Unfortunately, there is a case
> when the call to {{resolve}} fails:
> {noformat}
> /apps/components/a/
> a.html
> helper.something.html
> helper/ [backed by JCR]
> partial.html
> /apps/components/b [sling:resourceSuperType=components/a]
> b.html -> tries to resolve helper.something.html
> {noformat}
> In the case above, {{b.html}} will get the {{helper}} folder when trying to
> resolve {{helper.something.html}}.
> If the {{MergingServletResourceProvider}} would correctly wrap resources (and
> decorate them accordingly), the script engines could switch to using
> {{ResourceResolver#getResource(String)}}, which would not exhibit the same
> behaviour.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11373) The MergingServletResourceProvider does not wrap resources correctly
[
https://issues.apache.org/jira/browse/SLING-11373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566744#comment-17566744
]
Karl Pauls commented on SLING-11373:
With the new passthrough mode from [~cziegeler] (many thanks), it seems like
the best option to just use that one.
I added a {{mountPathProviders}} option in [0] which overrides the
{{mountProviders}} option if enabled. That should fix the issue the right way
and we can eventually deprecated the {{mountProviders}} option altogether.
[0] https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/30
> The MergingServletResourceProvider does not wrap resources correctly
>
>
> Key: SLING-11373
> URL: https://issues.apache.org/jira/browse/SLING-11373
> Project: Sling
> Issue Type: Bug
> Components: Servlets
>Affects Versions: Servlets Resolver 2.7.0
>Reporter: Radu Cotescu
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Servlets Resolver 2.9.8
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The {{MergingServletResourceProvider}} does not wrap resources correctly,
> forcing script engines that need to solve dependencies via this provider to
> call {{ResourceResolver#resolve(String)}}. Unfortunately, there is a case
> when the call to {{resolve}} fails:
> {noformat}
> /apps/components/a/
> a.html
> helper.something.html
> helper/ [backed by JCR]
> partial.html
> /apps/components/b [sling:resourceSuperType=components/a]
> b.html -> tries to resolve helper.something.html
> {noformat}
> In the case above, {{b.html}} will get the {{helper}} folder when trying to
> resolve {{helper.something.html}}.
> If the {{MergingServletResourceProvider}} would correctly wrap resources (and
> decorate them accordingly), the script engines could switch to using
> {{ResourceResolver#getResource(String)}}, which would not exhibit the same
> behaviour.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-11438) Resource path consisting of %7D with multiple dots leads to path traversal
[ https://issues.apache.org/jira/browse/SLING-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-11438: --- Fix Version/s: Engine 2.9.2 > Resource path consisting of %7D with multiple dots leads to path traversal > -- > > Key: SLING-11438 > URL: https://issues.apache.org/jira/browse/SLING-11438 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.9.0 >Reporter: Sagar Miglani >Assignee: Karl Pauls >Priority: Major > Fix For: Engine 2.9.2 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > With changes of SLING-10225, sling-engine started considering requests > consisting of resource path with %5B ([) and multiple dots as "Invalid", as > it could lead to path traversal and exposure of repository content. > But same could happen with %7D (}) with multiple dots in the request resource > path. > e.g: > http://:/content/we-retail/us/en/experience.html/.%7D./.%7D./.1.json > would lead to exposure of repository content stored at /content/we-retail/us -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-11438) Resource path consisting of %7D with multiple dots leads to path traversal
[ https://issues.apache.org/jira/browse/SLING-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls reassigned SLING-11438: -- Assignee: Karl Pauls > Resource path consisting of %7D with multiple dots leads to path traversal > -- > > Key: SLING-11438 > URL: https://issues.apache.org/jira/browse/SLING-11438 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.9.0 >Reporter: Sagar Miglani >Assignee: Karl Pauls >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > With changes of SLING-10225, sling-engine started considering requests > consisting of resource path with %5B ([) and multiple dots as "Invalid", as > it could lead to path traversal and exposure of repository content. > But same could happen with %7D (}) with multiple dots in the request resource > path. > e.g: > http://:/content/we-retail/us/en/experience.html/.%7D./.%7D./.1.json > would lead to exposure of repository content stored at /content/we-retail/us -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-11438) Resource path consisting of %7D with multiple dots leads to path traversal
[ https://issues.apache.org/jira/browse/SLING-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-11438. Resolution: Fixed Thanks a lot [~sagarmiglani], I merged your PR. > Resource path consisting of %7D with multiple dots leads to path traversal > -- > > Key: SLING-11438 > URL: https://issues.apache.org/jira/browse/SLING-11438 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.9.0 >Reporter: Sagar Miglani >Assignee: Karl Pauls >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > With changes of SLING-10225, sling-engine started considering requests > consisting of resource path with %5B ([) and multiple dots as "Invalid", as > it could lead to path traversal and exposure of repository content. > But same could happen with %7D (}) with multiple dots in the request resource > path. > e.g: > http://:/content/we-retail/us/en/experience.html/.%7D./.%7D./.1.json > would lead to exposure of repository content stored at /content/we-retail/us -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Feature Launcher used as OSGi bundle
Right, I guess I can see the argument to have valid package metadata. I'm just not sure it would work to actually use it as a bundle and at least I don't have the bandwidth to look into it. Personally, I feel like we are better off to remove it again if we don't want to support that use case atm but if somebody wanted to maintain it / make it work I wouldn't be against it. regards, Karl On Fri, Jul 1, 2022 at 9:12 AM Konrad Windszus wrote: > > Ping, anyone? > > > On 23. Jun 2022, at 09:28, Konrad Windszus wrote: > > > > Hi, > > In the context of https://issues.apache.org/jira/browse/SLING-10211 OSGi > > metadata has been added to the Sling Feature Launcher. Some concerns were > > raised in the PR at > > https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/19#pullrequestreview-611745073 > > but never answered. > > Can someone shed some light why OSGi metadata are useful in the context? If > > it should be an OSGi bundle, we should definitely switch to inheriting from > > Bundle-Parent > > (https://github.com/apache/sling-org-apache-sling-feature-launcher/blob/ffc1cf2b79bc7b88f0906b9d1af76fbcdd290fff/pom.xml#L18). > > > > Thanks, > > Konrad > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Feature Model Extension Api Region 1.6.2
+1 regards, Karl On Mon, Jun 13, 2022 at 9:07 AM Dirk Rudolph wrote: > > +1 > > Anyone else? We need another binding vote. > > Dirk > > On Wed, 8 Jun 2022 at 16:19, wrote: > > > > +1 > > > > David > > > > On Wed, 8 Jun 2022 at 13:33, Carsten Ziegeler wrote: > > > > > +1 > > > > > > Carsten > > > > > > Am 08.06.2022 um 14:21 schrieb Dirk Rudolph: > > > > Hi, > > > > > > > > we solved 1 issue in this release: > > > > https://issues.apache.org/jira/projects/SLING/versions/12351830 > > > > > > > > Staging repository: > > > > https://repository.apache.org/content/repositories/orgapachesling-2644/ > > > > > > > > You can use this UNIX script to download the release and verify the > > > > signatures: > > > > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > > > Usage: > > > > sh check_staged_release.sh 2644 /tmp/sling-staging > > > > > > > > Please vote to approve this release: > > > > > > > > [ ] +1 Approve the release > > > > [ ] 0 Don't care > > > > [ ] -1 Don't release, because ... > > > > > > > > This majority vote is open for at least 72 hours. > > > > > > > > Regards > > > > Dirk > > > > > > -- > > > Carsten Ziegeler > > > Adobe > > > cziege...@apache.org > > > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling XSS Protection API 2.2.20
+1 regards, Karl On Friday, May 20, 2022, Carsten Ziegeler wrote: > +1 > > Carsten > > Am 20.05.2022 um 13:43 schrieb Robert Munteanu: > >> Hi, >> >> We solved 4 issues in this release: >> https://issues.apache.org/jira/browse/SLING/fixforversion/12351228 >> >> Staging repository: >> https://repository.apache.org/content/repositories/orgapachesling-2640/ >> >> You can use this UNIX script to download the release and verify the >> signatures: >> https://gitbox.apache.org/repos/asf?p=sling-tooling-release. >> git;a=blob;f=check_staged_release.sh;hb=HEAD >> >> Usage: >> sh check_staged_release.sh 2640 /tmp/sling-staging >> >> Please vote to approve this release: >> >>[ ] +1 Approve the release >>[ ] 0 Don't care >>[ ] -1 Don't release, because ... >> >> This majority vote is open for at least 72 hours. >> >> Regards, >> Robert Munteanu >> > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.16
+1 regards, Karl On Tuesday, May 17, 2022, Carsten Ziegeler wrote: > Hi, > > we solved 8 issues in this release > https://issues.apache.org/jira/projects/SLING/versions/12351486 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2638/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release. > git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2638 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Feature Model Extension Api Region 1.6.0
+1 regards, Karl On Thursday, May 12, 2022, Carsten Ziegeler wrote: > +1 > > Carsten > > Am 11.05.2022 um 16:58 schrieb Carsten Ziegeler: > >> Hi, >> >> we solved 4 issues in this release: >> https://issues.apache.org/jira/projects/SLING/versions/12351355 >> >> Staging repository: >> https://repository.apache.org/content/repositories/orgapachesling-2635/ >> >> You can use this UNIX script to download the release and verify the >> signatures: >> https://gitbox.apache.org/repos/asf?p=sling-tooling-release. >> git;a=blob;f=check_staged_release.sh;hb=HEAD >> >> Usage: >> sh check_staged_release.sh 2635 /tmp/sling-staging >> >> Please vote to approve this release: >> >>[ ] +1 Approve the release >>[ ] 0 Don't care >>[ ] -1 Don't release, because ... >> >> This majority vote is open for at least 72 hours. >> >> Regards >> Carsten >> > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Apache Sling Scripting JSP 2.6.0, Scripting Core 2.4.8 and Servlets Resolver 2.9.6
+1 regards, Karl On Tue, May 10, 2022 at 5:24 PM Carsten Ziegeler wrote: > > Hi, > > we solved 5 issues for scripting jsp 2.6.0 > https://issues.apache.org/jira/browse/SLING-11301?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20JSP%202.6.0%22 > > we solved one issue for servlets resolver 2.9.6 > https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Servlets%20Resolver%202.9.6%22 > > we solved two issues for scripting core 2.4.8 > https://issues.apache.org/jira/browse/SLING-11307?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Scripting%20Core%202.4.8%22 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2634/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2634/tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling JSPC Maven Plugin 2.3.4
+1 regards, Karl On Mon, Apr 11, 2022 at 4:13 PM Radu Cotescu wrote: > > +1 > > > On 8 Apr 2022, at 17:35, Radu Cotescu wrote: > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.14
+1 regards, Karl On Tue, Mar 22, 2022 at 4:27 PM Angela Schreiber wrote: > > [x] +1 Approve the release > > kind regards > angela > > From: Robert Munteanu > Sent: Tuesday, March 22, 2022 4:11 PM > To: Sling Developers List > Subject: [VOTE] Release Apache Sling Content-Package to Feature Model > Converter 1.1.14 > > Hi, > > We solved 1 issue in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12351440 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2617/ > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2617 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > Robert Munteanu -- Karl Pauls karlpa...@gmail.com
[jira] [Commented] (SLING-11158) The starter's "Start Sling" instructions don't work with feature launcher v1.1.28 or later
[
https://issues.apache.org/jira/browse/SLING-11158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508871#comment-17508871
]
Karl Pauls commented on SLING-11158:
Yeah, the additional problem is that it gets worse with more than one extension
because they might have their own dependencies. For a while, we tried to work
with embedding and shading everything but that becomes a mess so we gave up and
just have to manage the class path of the launcher - at which point it is
better if it brings its dependencies as well.
> The starter's "Start Sling" instructions don't work with feature launcher
> v1.1.28 or later
> --
>
> Key: SLING-11158
> URL: https://issues.apache.org/jira/browse/SLING-11158
> Project: Sling
> Issue Type: Bug
>Affects Versions: Feature Model Launcher 1.1.28, Feature Model Launcher
> 1.2.0
>Reporter: Eric Norman
>Priority: Major
> Fix For: Feature Launcher Maven Plugin 0.1.4, Starter 13
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> After the SLING-10956 changes, launching the Starter with the README provided
> instructions while using the v1.1.28 or later feature launcher does not work
> anymore.
> For example,
> {noformat}
> $ java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
> target/slingfeature-tmp/feature-oak_tar.json
> Error: Unable to initialize main class
> org.apache.sling.feature.launcher.impl.Main
> Caused by: java.lang.NoClassDefFoundError:
> org/apache/commons/cli/ParseException{noformat}
>
> Also, the start goal of the feature-launcher-maven-plugin fails with the same
> exception when paired with a featureLauncherVersion of 1.1.28 or later.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
Re: [VOTE] Release Apache Sling Feature Model Analyser version 1.6.2, slingfeature-maven-plugin version 1.6.2
+1 regards, Karl On Tue, Mar 15, 2022 at 4:48 PM Carsten Ziegeler wrote: > > +1 > > Carsten > > Am 15.03.2022 um 15:42 schrieb ang...@apache.org: > > Hi, > > > > We solved the following issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12351361 > > https://issues.apache.org/jira/projects/SLING/versions/12351364 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2615/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: > > sh check_staged_release.sh 2615 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Kind regards > > Angela > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
[jira] [Closed] (SLING-10858) Incorrect API Regions generated in features
[
https://issues.apache.org/jira/browse/SLING-10858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls closed SLING-10858.
--
> Incorrect API Regions generated in features
> ---
>
> Key: SLING-10858
> URL: https://issues.apache.org/jira/browse/SLING-10858
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.6
>Reporter: A. J. David Bosschaert
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> In some cases the cpconverter generates an {{api-regions}} section with
> {{global}} exports for packages, where the bundles providing those packages
> are not actually listed in the feature. I have seen features with _no_
> bundles (just some configuration) and an {{api-regions}} section with lots of
> exports, which clearly couldn't be satisfied by the feature as it did not
> have any bundles at all.
> I believe that this might be caused by the fact that the
> DefaultFeaturesManager has the an apiRegionsExports field
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java#L101
> which is not cleared between features being processed, and as such the
> api-regions exports are bleeding between generated features.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-10921) Converter creates dependencies for extracted content that are wrong when the provider is around in more than one run mode
[ https://issues.apache.org/jira/browse/SLING-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10921. -- > Converter creates dependencies for extracted content that are wrong when the > provider is around in more than one run mode > - > > Key: SLING-10921 > URL: https://issues.apache.org/jira/browse/SLING-10921 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > When the converter extracts content from bundles it does that again every > time it hits the bundle (assuming it is present in different > locations/runmodes/packages). That is a problem as this way, only the last > location will be added as a dependency to the package - causing it to fail to > install if it was used from one of the other locations. > We should just not generate a dependency, like we do with contain packages. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10920) Converter doesn't reset the aclManager after first pass and rejects too much after resets
[ https://issues.apache.org/jira/browse/SLING-10920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10920. -- > Converter doesn't reset the aclManager after first pass and rejects too much > after resets > - > > Key: SLING-10920 > URL: https://issues.apache.org/jira/browse/SLING-10920 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > The converter doesn't reset the acl manager after the first pass. That makes > it so that the service users are collected and put into the all feature. > Furthermore, if it resets, it is loosing the acls that have matching service > users but that come too later in the contenpackage. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10929) CPConverter - error messages can be obfuscated
[ https://issues.apache.org/jira/browse/SLING-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10929. -- > CPConverter - error messages can be obfuscated > -- > > Key: SLING-10929 > URL: https://issues.apache.org/jira/browse/SLING-10929 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > Currently, when performing a CPConversion, if the customer has wrong code, > sometimes the exception can be very obfuscated. > This gives the customer no chance to fix their error easily: > In this example a xml file is empty: > [ERROR] Unable to convert content-package > [/tmp/packages/???.ui.content-1.28.0-SNAPSHOT.zip, > /tmp/packages/???.ui.apps-1.28.0-SNAPSHOT.zip]: Premature end of file. > We would like a path to be provided in the exception so the customer can take > a look there. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10933) Content package converter should use QUOTE_TICK option when parsing json
[ https://issues.apache.org/jira/browse/SLING-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10933. -- > Content package converter should use QUOTE_TICK option when parsing json > > > Key: SLING-10933 > URL: https://issues.apache.org/jira/browse/SLING-10933 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 > Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > The converter should use the QUOTE_TICK options when parsing json to force > UTF-8 charset and allow for slightly malformed json files (where quote ticks > are used instead of string quotes). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11152) Use official OSGi Converter Implementation
[ https://issues.apache.org/jira/browse/SLING-11152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11152. -- > Use official OSGi Converter Implementation > -- > > Key: SLING-11152 > URL: https://issues.apache.org/jira/browse/SLING-11152 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content Distribution Journal Core 0.1.24, Feature Model > Converter 1.0.16, Slingstart Maven Plugin 1.9.14, Settings 1.4.2, > Content-Package to Feature Model Converter 1.1.12, Models Implementation > 1.5.2, Feature Model Launcher 1.2.2, Feature Model Analyser 1.6.2, Adapter > 2.2.2, Feature Model 1.3.0, slingfeature-maven-plugin 1.6.2 > > > The Apache Felix implementation of the OSGi Converter has been retired in > favour of the one provided by OSGi. We should update to the latest version -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11058) CPConverter - sling initial content - check illegal xml chars
[ https://issues.apache.org/jira/browse/SLING-11058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11058. -- > CPConverter - sling initial content - check illegal xml chars > - > > Key: SLING-11058 > URL: https://issues.apache.org/jira/browse/SLING-11058 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > We have to make sure that in the case of XML illegal characters being used in > JSON descriptor files for sling initial contrent, such as <, >, " and ', > these do not break the build in the cpconverter. > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11059) CPConverter - sling initial content - XSLT support
[ https://issues.apache.org/jira/browse/SLING-11059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11059. -- > CPConverter - sling initial content - XSLT support > -- > > Key: SLING-11059 > URL: https://issues.apache.org/jira/browse/SLING-11059 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > In the sling initial content specs, XLST is supported: > [https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html#using-a-custom-xml-format] > Currently in the CPConverter, this is not supported yet, so we need to > implement this. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10822) Avoid duplicate parsing of configuration pid
[ https://issues.apache.org/jira/browse/SLING-10822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10822. -- > Avoid duplicate parsing of configuration pid > > > Key: SLING-10822 > URL: https://issues.apache.org/jira/browse/SLING-10822 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > There is some duplicated logic to detect whether a configuration pid is a > factory pid. This can be reduced to a single place -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10823) Pass in repoinit as a single text
[ https://issues.apache.org/jira/browse/SLING-10823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10823. -- > Pass in repoinit as a single text > - > > Key: SLING-10823 > URL: https://issues.apache.org/jira/browse/SLING-10823 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > When an OSGi configuration contains repoinit, each value of the scripts array > is handled separated. However sometimes a whole script is not passed in as a > single value in the array but as an array of strings. > So it is better to first append all values from the string array and handle > them as a single script -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10917) Exclude filters in converted content packages can have a trailing slash
[ https://issues.apache.org/jira/browse/SLING-10917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10917. -- > Exclude filters in converted content packages can have a trailing slash > --- > > Key: SLING-10917 > URL: https://issues.apache.org/jira/browse/SLING-10917 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 > Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > The filter excludes we generate can have an extra slash at the end that is > not correct. This is effectively just and off by one in case a content.xml > has been removed and should be excluded. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11191) Update repo-init parser dependency to 1.6.14
[ https://issues.apache.org/jira/browse/SLING-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11191. -- > Update repo-init parser dependency to 1.6.14 > > > Key: SLING-11191 > URL: https://issues.apache.org/jira/browse/SLING-11191 > Project: Sling > Issue Type: Task > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Angela Schreiber >Assignee: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > [~kpauls], as discussed we also need to update the cp-2-fm-converter to use > the latest repoinit parser 1.6.14. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-11075) Maven id for bundles that don't have a GAV can end up not being well formed
[ https://issues.apache.org/jira/browse/SLING-11075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11075. -- > Maven id for bundles that don't have a GAV can end up not being well formed > --- > > Key: SLING-11075 > URL: https://issues.apache.org/jira/browse/SLING-11075 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.1.10 > Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > When the converter finds a bundle, it tries to determine the maven > coordinates for it by looking at the embedded maven info. If there is none, > it tries to guess it from the maven info path. If that fails, it takes the > bsn and derives the info from it. > That works, however, in the case of a bsn, it doesn't strip attributes which > can cause an invalid mvn id in the end (e.g., if the bsn has a > ;singelton:=true) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10770) JcrNamespaceRegistry.registerCnd throws NPE
[
https://issues.apache.org/jira/browse/SLING-10770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls closed SLING-10770.
--
> JcrNamespaceRegistry.registerCnd throws NPE
> ---
>
> Key: SLING-10770
> URL: https://issues.apache.org/jira/browse/SLING-10770
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Niek Raaijmakers
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> [~karlpauls], while trying to fix some sonar findings in the converter I came
> across a warning about a null {{NodeTypeManager}} being passed to
> {{CndImporter.registerNodeTypes}} in the following new method introduced with
> SLING-10243:
> {code}
> public void registerCnd(Reader reader, String systemId) throws
> ParseException, RepositoryException, IOException {
> NodeTypeManager ntManager = null;
> ValueFactory valueFactory = null;
> CndImporter.registerNodeTypes(reader, systemId, ntManager, this,
> valueFactory, false);
> registeredCndSystemIds.add(systemId);
> }
> {code}
> a simple test shows that the method always fails with NPE.
> so, unless i am missing something that code calling this method doesn't work
> at all. according to
> https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=uncovered_conditions=apache_sling-org-apache-sling-feature-cpconverter%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Ffeature%2Fcpconverter%2Fvltpkg%2FJcrNamespaceRegistry.java=list
> the method isn't covered with any tests either so that might explain why
> it has not been spotted before.
> what would be the best approach to get this fixed? should we revert changes
> made with SLING-10243? There is most probably no instance of JCR
> {{NodeTypeManager}} available if there is no JCR repository available at the
> stage the converter is being executed and I don't think mocking it at this
> stage is sensible.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (SLING-11072) Introduce command line argument for CPConverter to toggle the use of source package type for package type calculation.
[ https://issues.apache.org/jira/browse/SLING-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-11072. -- > Introduce command line argument for CPConverter to toggle the use of source > package type for package type calculation. > -- > > Key: SLING-11072 > URL: https://issues.apache.org/jira/browse/SLING-11072 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > We need to introduce a command line argument in the CPConverter. > The toggle should enables us to use the source package type when determining > package types of generated content packages. It should be on by default. > > We can then disable / overrule this by passing in false from the command line. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10931) CPConverter - Sling initial content - json files should be converted to folders with a content xml in any case to avoid conflicts
[ https://issues.apache.org/jira/browse/SLING-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10931. -- > CPConverter - Sling initial content - json files should be converted to > folders with a content xml in any case to avoid conflicts > - > > Key: SLING-10931 > URL: https://issues.apache.org/jira/browse/SLING-10931 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > In case of converting sling initial content containing JSON files over to > xml, currently the cpconverter simply creates a xml file in the same level. > The problem is when there are other files in a directory with the same name > to go along the resourceType. > For example we have: > > * page.json > * page/body.html > * page/footer.html > > The result will be: > * page.xml > * page/body.html > * page/footer.html > > Vault doesn't like this approach so much, resulting in stuff like: > * page.dir > * page.xml > * page/.content.xml (with resourceType nt:folder) > * page/body.html > * page/footer.html > The solution lies in simply redirecting the output to .content.xml in a new > folder: > * page/.content.xml > * page/body.html > * page/footer.html > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10818) Add origin information to repoinit
[ https://issues.apache.org/jira/browse/SLING-10818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-10818. -- > Add origin information to repoinit > -- > > Key: SLING-10818 > URL: https://issues.apache.org/jira/browse/SLING-10818 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > OSGi configurations are converted to repoinit instructions, resulting in a > single long repoinit text - if there is any error in those instructions like > a syntax error, later on it is hard to find the origin of that faulty > repoinit. > The converter could add a comment above every repoinit it appends containing > the origin information (package id and config id) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SLING-10859) runmode.mapping file does not contain all needed values
[
https://issues.apache.org/jira/browse/SLING-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls closed SLING-10859.
--
> runmode.mapping file does not contain all needed values
> ---
>
> Key: SLING-10859
> URL: https://issues.apache.org/jira/browse/SLING-10859
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.6
>Reporter: A. J. David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.12
>
>
> In some cases the {{runmode.mapping}} file generated by the cpconverter does
> not contain all the required file (feature model) references.
> This can happen when certain filenames that need to be referenced are a
> substring of other file names.
> It centers around this code:
> https://github.com/apache/sling-org-apache-sling-feature-cpconverter/blob/master/src/main/java/org/apache/sling/feature/cpconverter/features/RunmodeMapper.java#L63-L67
> Assume that {{properties}} contains an entry
> {{(default)=>my-webapp-all.json}}. Then next a feature file named
> {{all.json}} is processed. As the name of it is a substring of the
> pre-existing value it will not append. In fact it will replace the previous
> value with the new value and as such remove it.
> The logic there should be fixed to not use substrings, but rather compare
> entire names. Possibly a better idea would be to keep a Set
> internally and convert that to a comma-separated list only once the
> Properties are persisted in the {{save(()}} call.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
Re: [RESULT][VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.12
Time to call the vote on the Content-Package to Feature Model Converter 1.1.12 release. * +1 votes from David Bosschaert, Robert Munteanu, Carsten Ziegeler, and Karl Pauls. * No other votes. The vote is successful. I will make the artifacts available as soon as possible.
Re: [VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.12
+1 regards, Karl On Sun, Mar 13, 2022 at 9:22 AM Carsten Ziegeler wrote: > > +1 > > > Carsten > > Am 10.03.2022 um 22:26 schrieb Karl Pauls: > > I'd like to call the release on the following component: > > > > Content-Package to Feature Model Converter 1.1.12: > > https://issues.apache.org/jira/projects/SLING/versions/12350576 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2613 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2613 /tmp/sling-staging > > > > Please vote to approve these releases: > > > >[ ] +1 Approve the releases > > [ ] 0 Don't care > >[ ] -1 Don't release, because ... > > -- > Carsten Ziegeler > Adobe > cziege...@apache.org -- Karl Pauls karlpa...@gmail.com
[VOTE] Release Apache Sling Content-Package to Feature Model Converter 1.1.12
I'd like to call the release on the following component: Content-Package to Feature Model Converter 1.1.12: https://issues.apache.org/jira/projects/SLING/versions/12350576 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2613 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2613 /tmp/sling-staging Please vote to approve these releases: [ ] +1 Approve the releases [ ] 0 Don't care [ ] -1 Don't release, because ...
[jira] [Updated] (SLING-11134) Extract Oak index definitions and package them as an additional file
[ https://issues.apache.org/jira/browse/SLING-11134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-11134: --- Fix Version/s: Content-Package to Feature Model Converter 1.1.14 Content-Package to Feature Model Converter 1.1.14 (was: Content-Package to Feature Model Converter 1.1.12) > Extract Oak index definitions and package them as an additional file > > > Key: SLING-11134 > URL: https://issues.apache.org/jira/browse/SLING-11134 > Project: Sling > Issue Type: New Feature > Components: Content-Package to Feature Model Converter >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.14 > > > It is sometimes useful to read the Oak index definitions from the content > package and package them as an additional file ( in JSON format? ) so they > can be more easily consumed by downstream tools that need to know the index > definitions. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10774) Fix sonar findings in content-package to feature model converter
[ https://issues.apache.org/jira/browse/SLING-10774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-10774: --- Fix Version/s: Content-Package to Feature Model Converter 1.1.14 Content-Package to Feature Model Converter 1.1.14 (was: Content-Package to Feature Model Converter 1.1.12) > Fix sonar findings in content-package to feature model converter > > > Key: SLING-10774 > URL: https://issues.apache.org/jira/browse/SLING-10774 > Project: Sling > Issue Type: Improvement > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.14 > > > sonar reports quite some findings for the content-package to feature model > converter bundle that are easy to fix preventing broken window syndrome i > would suggest to keep fixing as much as possible. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10861) Subpackages are missing dependency on their container
[ https://issues.apache.org/jira/browse/SLING-10861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-10861: --- Fix Version/s: Content-Package to Feature Model Converter 1.1.14 Content-Package to Feature Model Converter 1.1.14 (was: Content-Package to Feature Model Converter 1.1.12) > Subpackages are missing dependency on their container > - > > Key: SLING-10861 > URL: https://issues.apache.org/jira/browse/SLING-10861 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 > Reporter: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.14 > > > When the converter is extracting sub packages it is not adding a dependency > to their containing package to them. It does for embedded packages but not > for subpackages. It should add a dependency in both cases. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10779) ContentPackage2FeatureModelConverter.getAclManager should never return null
[
https://issues.apache.org/jira/browse/SLING-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-10779:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
Content-Package to Feature Model Converter 1.1.14
(was: Content-Package to Feature Model Converter 1.1.12)
> ContentPackage2FeatureModelConverter.getAclManager should never return null
> ---
>
> Key: SLING-10779
> URL: https://issues.apache.org/jira/browse/SLING-10779
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> {{ContentPackage2FeatureModelConverter.getAclManager}} is used across the
> converter code base and always expected to be not-null. so, instead of
> defining it as 'nullable' we should find ways to make sure it is always
> present on the converter. this would allow to get rid of
> Objects.requireNotNull and the warnings about potential NPE where the check
> is missing.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10571) Hardcoded application paths in VaultPackageUtils.detectPackageType
[
https://issues.apache.org/jira/browse/SLING-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-10571:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
Content-Package to Feature Model Converter 1.1.14
(was: Content-Package to Feature Model Converter 1.1.12)
> Hardcoded application paths in VaultPackageUtils.detectPackageType
> --
>
> Key: SLING-10571
> URL: https://issues.apache.org/jira/browse/SLING-10571
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
> Labels: technical_debt
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> while investigating SLING-10467 i noticed hardcoded paths for what should be
> considered application content in {{VaultPackageUtils.detectPackageType}}.
> the method looks as follows:
> {code}
> public static @NotNull PackageType detectPackageType(String path) {
> if ("/apps".equals(path)
> || path.startsWith("/apps/")
> || "/libs".equals(path)
> || path.startsWith("/libs/")) {
> return PackageType.APPLICATION;
> } else {
> return PackageType.CONTENT;
> }
> }
> {code}
> instead of hardcoding /apps and /libs which are details of Adobe AEM, these
> paths should be configured with the converter-launcher. in particular since
> the list looks a bit arbitrary as there are other paths that IMHO should be
> considered application content like nodetype registry, namespace registry,
> privilege registry, service users etc.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10768) AbstractJcrNodeParser and subclasses ignore namespace mappings
[
https://issues.apache.org/jira/browse/SLING-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-10768:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
Content-Package to Feature Model Converter 1.1.14
(was: Content-Package to Feature Model Converter 1.1.12)
> AbstractJcrNodeParser and subclasses ignore namespace mappings
> --
>
> Key: SLING-10768
> URL: https://issues.apache.org/jira/browse/SLING-10768
> Project: Sling
> Issue Type: Improvement
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> The {{AbstractJcrNodeParser}} has a constant defined for "jcr:root". It would
> be better if it (and subclasses) would not rely on the default namespace
> mappings.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10784) BundleEntryHandler - sonar findings
[ https://issues.apache.org/jira/browse/SLING-10784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-10784: --- Fix Version/s: Content-Package to Feature Model Converter 1.1.14 Content-Package to Feature Model Converter 1.1.14 (was: Content-Package to Feature Model Converter 1.1.12) > BundleEntryHandler - sonar findings > --- > > Key: SLING-10784 > URL: https://issues.apache.org/jira/browse/SLING-10784 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.14 > > > https://sonarcloud.io/code?id=apache_sling-org-apache-sling-feature-cpconverter=apache_sling-org-apache-sling-feature-cpconverter%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Ffeature%2Fcpconverter%2Fhandlers%2FBundleEntryHandler.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-11060) CPConverter - sling initial content - ACL support
[
https://issues.apache.org/jira/browse/SLING-11060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-11060:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
Content-Package to Feature Model Converter 1.1.14
(was: Content-Package to Feature Model Converter 1.1.12)
> CPConverter - sling initial content - ACL support
> -
>
> Key: SLING-11060
> URL: https://issues.apache.org/jira/browse/SLING-11060
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Affects Versions: Content-Package to Feature Model Converter 1.1.10
>Reporter: Niek Raaijmakers
>Assignee: Niek Raaijmakers
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> Currently, we do not implement the ACL support for Sling Initial Content as
> specified :
> [https://sling.apache.org/documentation/bundles/repository-initialization.html]
> We need the following methods
> (org.apache.sling.feature.cpconverter.handlers.slinginitialcontent.VaultContentXMLContentCreator)
> implemented or another workaround found:
>
> {code:java}
> @Override
> public boolean switchCurrentNode(String subPath, String newNodeType) throws
> RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createUser(String name, String password, Map
> extraProperties) throws RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createGroup(String name, String[] members, Map
> extraProperties) throws RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createAce(String principal, String[] grantedPrivileges, String[]
> deniedPrivileges, String order) throws RepositoryException {
> throw new UnsupportedOperationException();
> }
> @Override
> public void createAce(String principalId, String[] grantedPrivilegeNames,
> String[] deniedPrivilegeNames,
> String order, Map restrictions, Map
> mvRestrictions,
> Set removedRestrictionNames) throws RepositoryException {
> throw new UnsupportedOperationException();
> }{code}
>
> Stashed code is on branch: SLING-10931
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10790) BundleEntryHandler.extractArtifactId may use wrong GAV
[
https://issues.apache.org/jira/browse/SLING-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-10790:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
Content-Package to Feature Model Converter 1.1.14
(was: Content-Package to Feature Model Converter 1.1.12)
> BundleEntryHandler.extractArtifactId may use wrong GAV
> --
>
> Key: SLING-10790
> URL: https://issues.apache.org/jira/browse/SLING-10790
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Minor
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> [~kpauls], if my reading of {{BundleEntryHandler.extractArtifactId}} is
> correct it the method might be ending up using the wrong
> groupId/artifactId/version.
> the code will loop over jar-entries and stop if the extracted GAV matches the
> bundle name. however, groupId/artifactId/version are not reset to {{null}} in
> case they were successfully extracted but didn't end up matching the bundle
> name i.e. {quote}it was the pom.properties we were looking for{quote}.
> i can't tell how big of an issue that is (and how likely). but given the fact
> that there is some extra effort to verify that the parsed pom is actually the
> right one, it might actually be relevant. the relies on a compliant content
> package that does contain a matching pom, which may or may not be the case...
> logging a warning or throwing a ConverterException in case of violation might
> help spotting troublesome content packages instead of getting some sort of
> side effect if another pom was spotted.
> a heavily simplified copy of the method:
> {code}
> String artifactId = null;
> String version = null;
> String groupId = null;
> String classifier = null;
> for (Enumeration e = jarFile.entries();
> e.hasMoreElements();) {
> [...]
> // extract groupId/artifactId/version
> [...]
>
> if (groupId != null && artifactId != null && version != null) {
> // bundleName is now the bare name without extension
> String synthesized = artifactId + "-" + version;
> // it was the pom.properties we were looking for
> if (bundleName.startsWith(synthesized) ||
> bundleName.equals(artifactId)) {
> [...]
>
> // no need to iterate further
> break;
> }
> }
> }
>
> if (groupId == null) {
> [...]
> }
> return new ArtifactId(groupId, artifactId, version, classifier,
> JAR_TYPE);
> {code}
> feel free to resolve as not a problem in case my reading of the code is all
> wrong.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10781) ContentPackage2FeatureModelConverterLauncher - sonar findings
[ https://issues.apache.org/jira/browse/SLING-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-10781: --- Fix Version/s: Content-Package to Feature Model Converter 1.1.14 Content-Package to Feature Model Converter 1.1.14 (was: Content-Package to Feature Model Converter 1.1.12) > ContentPackage2FeatureModelConverterLauncher - sonar findings > - > > Key: SLING-10781 > URL: https://issues.apache.org/jira/browse/SLING-10781 > Project: Sling > Issue Type: Sub-task > Components: Content-Package to Feature Model Converter >Reporter: Angela Schreiber >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.14 > > > see > https://sonarcloud.io/code?id=apache_sling-org-apache-sling-feature-cpconverter=apache_sling-org-apache-sling-feature-cpconverter%3Asrc%2Fmain%2Fjava%2Forg%2Fapache%2Fsling%2Ffeature%2Fcpconverter%2Fcli%2FContentPackage2FeatureModelConverterLauncher.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10787) BundleEntryHandler.extractArtifactId prone to IllegalArgumentException
[
https://issues.apache.org/jira/browse/SLING-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-10787:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
Content-Package to Feature Model Converter 1.1.14
(was: Content-Package to Feature Model Converter 1.1.12)
> BundleEntryHandler.extractArtifactId prone to IllegalArgumentException
> --
>
> Key: SLING-10787
> URL: https://issues.apache.org/jira/browse/SLING-10787
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
>
> trying to address sonar findings for {{BundleEntryHandler}} (see SLING-10784)
> i noticed that there is no guarantee that 'artifactId' and 'version' are not
> left null after all the processing completed. if any of the two is null
> constructing a new {{ArtifactId}} object from the given strings will fail
> will {{IllegalArgumentException}}.
> it might be as simple as extracting the following statements out of the
> previous block that handles the {{groupId == null}} case:
> {code}
> if (artifactId == null || artifactId.isEmpty()) {
> artifactId = groupId;
> }
>
> if (version == null) {
> Version osgiVersion =
> Version.parseVersion(getCheckedProperty(jarFile.getManifest(),
> Constants.BUNDLE_VERSION));
> version = osgiVersion.getMajor() + "." + osgiVersion.getMinor() +
> "." + osgiVersion.getMicro() + (osgiVersion.getQualifier().isEmpty() ? "" :
> "-" + osgiVersion.getQualifier());
> }
> {code}
> but i am not totally sure there is a reason the method
> {{BundleEntryHandler.extractArtifactId}} gets called out by sonar :)
> note: on line 472 of the same method {{IllegalArgumentException}} is
> caught so i assume the code doesn't expect this method to fail upon
> building the {{ArtifactId}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-10914) CpConverter - package type calculation should take filters into account
[ https://issues.apache.org/jira/browse/SLING-10914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-10914: --- Fix Version/s: Content-Package to Feature Model Converter 1.1.14 Content-Package to Feature Model Converter 1.1.14 (was: Content-Package to Feature Model Converter 1.1.12) > CpConverter - package type calculation should take filters into account > --- > > Key: SLING-10914 > URL: https://issues.apache.org/jira/browse/SLING-10914 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Minor > Fix For: Content-Package to Feature Model Converter 1.1.14 > > > The converter does attempt to (re-)calculate the package type (application, > content, mixed) as part of creating the converted packages. However, it > doesn't take the targets of the filters into account when determining the > type. As such, it is possible that e.g. a package containing a filter > targeting apps would end up being classified as being of type content. > Furthermore, it when looking into the content, it doesn't take into account > if the content is covered by filters - ie., it doesn't really check if the > content would be ignored by vault. > Given that it is hard to know what vault will install or not, it might not be > possible to fix the second issue - however, it should be possible to at least > look at the filters and take their targets into account (as pathes) when > (re-)calculating the package type. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SLING-10760) Converter ignores access control content and users/groups in .content.xml files
[
https://issues.apache.org/jira/browse/SLING-10760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-10760:
---
Fix Version/s: Content-Package to Feature Model Converter 1.1.14
(was: Content-Package to Feature Model Converter 1.1.12)
> Converter ignores access control content and users/groups in .content.xml
> files
> ---
>
> Key: SLING-10760
> URL: https://issues.apache.org/jira/browse/SLING-10760
> Project: Sling
> Issue Type: Bug
> Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Critical
> Fix For: Content-Package to Feature Model Converter 1.1.14
>
> Attachments: subtree_in_contentxml_policy.png,
> subtree_in_contentxml_sibling.png
>
>
> [~kpauls], while trying to find more edge cases that could cause SLING-10754,
> i noticed that not only sibling nodes but also access control content (like
> e.g. _rep:policy_ nodes) contained in a _.content.xml_ get installed by
> Jackrabbit Filevault even if those nodes are not covered by the corresponding
> {{WorkspaceFilter}}.
> It also seems that these package 'entries' are not spotted by the converter
> and thus the dedicated {{EntryHandler}} implementations that are intended to
> analyze and convert special content like e.g. access control (but probably
> not limited to that) are not triggered.
> In other words: content hidden in _.content.xml_ will not be properly
> converted but will be installed even if not covered by _filter.xml_
> associated with the content package. I don't know if that actually intended
> behavior of Jackrabbit FileVault (the documentation clearly stating that
> everything should be covered by filter rules [0], section 'Usage for
> Import/Installation'), but if it is correct it might in the worse case
> require the converter to parse all _.content.xml_ files and delegate to the
> proper handler implementations.
> [~kwin], I would appreciate your input on the FileVault related question of
> this ticket. In particular: is it correct and intended that subnodes defined
> in _.content.xml_ get installed even if not covered by any filter rule?
> [0] https://jackrabbit.apache.org/filevault/filter.html
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
Re: [VOTE] Release Apache Sling Scripting Core 2.4.6
+1 regards, Karl On Thu, Mar 10, 2022 at 5:08 PM Stefan Seifert wrote: > > +1 > > stefan -- Karl Pauls karlpa...@gmail.com
[jira] [Resolved] (SLING-10921) Converter creates dependencies for extracted content that are wrong when the provider is around in more than one run mode
[ https://issues.apache.org/jira/browse/SLING-10921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-10921. Resolution: Fixed > Converter creates dependencies for extracted content that are wrong when the > provider is around in more than one run mode > - > > Key: SLING-10921 > URL: https://issues.apache.org/jira/browse/SLING-10921 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > When the converter extracts content from bundles it does that again every > time it hits the bundle (assuming it is present in different > locations/runmodes/packages). That is a problem as this way, only the last > location will be added as a dependency to the package - causing it to fail to > install if it was used from one of the other locations. > We should just not generate a dependency, like we do with contain packages. -- This message was sent by Atlassian Jira (v8.20.1#820001)
Re: [VOTE] Release Apache Sling Repoinit Parser 1.6.14, Apache Sling Repoinit JCR 1.1.38
+1 regards, Karl On Thu, Mar 3, 2022 at 2:45 PM ang...@apache.org wrote: > > [x] +1 Approve the release > > NOTE: the usage instruction below did not contain the right id. > > should obviously be > > > sh check_staged_release.sh 2605 /tmp/sling-staging > > kind regards > angela > > > On 03.03.22 10:56, ang...@apache.org wrote: > > Hi, > > > > We solved the following issues in this release: > > > > https://issues.apache.org/jira/projects/SLING/versions/12351292 > > https://issues.apache.org/jira/projects/SLING/versions/12350313 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2605 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: > > sh check_staged_release.sh 2601 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Kind regards > > Angela -- Karl Pauls karlpa...@gmail.com
[jira] [Commented] (SLING-9624) Get rid of custom "org.osgi.framework.system.packages"
[ https://issues.apache.org/jira/browse/SLING-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500733#comment-17500733 ] Karl Pauls commented on SLING-9624: --- right, but the versions are the versions sling had since a long time. I don't know why they where like they where. > Get rid of custom "org.osgi.framework.system.packages" > -- > > Key: SLING-9624 > URL: https://issues.apache.org/jira/browse/SLING-9624 > Project: Sling > Issue Type: Improvement > Components: Starter >Reporter: Konrad Windszus >Priority: Major > Fix For: Starter 13 > > Time Spent: 10m > Remaining Estimate: 0h > > Instead of using a Sling specific "org.osgi.framework.system.packages" > property > (https://github.com/apache/sling-org-apache-sling-starter/blob/5f44b7f6c6b75e4cfd5574fb701c3e7eca8405ef/src/main/provisioning/launchpad.txt#L26) > we should just rely on the Felix default > (https://github.com/apache/felix-dev/blob/master/framework/src/main/resources/default.properties) > to not miss to export all relevant packages for the different JREs > compare with > https://lists.apache.org/thread.html/r0aa3c02c38b5026e24684a00de3c6c8506e166334e77892ac2ee0ab3%40%3Cdev.sling.apache.org%3E. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-11173) Wrong version of org.osgi.framework exported (OSGi R7 instead of OSGi R8)
[ https://issues.apache.org/jira/browse/SLING-11173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500715#comment-17500715 ] Karl Pauls commented on SLING-11173: [~kwin], I guess you just have to adjust the exports to match, no? Unless you wanted to go with SLING-9624 - the problem there is that if you want to use the modules/classpath then we have bundles that assume that the versions are different. The correct list for the current felix osgi exports is here: https://github.com/apache/felix-dev/blob/master/framework/src/main/resources/default.properties#L108 > Wrong version of org.osgi.framework exported (OSGi R7 instead of OSGi R8) > - > > Key: SLING-11173 > URL: https://issues.apache.org/jira/browse/SLING-11173 > Project: Sling > Issue Type: Bug > Components: Starter >Reporter: Konrad Windszus >Priority: Blocker > Fix For: Starter 12 > > > Although Felix was updated in SLING-10409 to Felix 7 (OSGi R8 compliant) the > package exports are still only for OSGi R7 in > https://github.com/apache/sling-org-apache-sling-starter/blob/150e60df97a6d8911e938b76903f64d54f1201df/src/main/features/boot.json#L151. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-9624) Get rid of custom "org.osgi.framework.system.packages"
[ https://issues.apache.org/jira/browse/SLING-9624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500713#comment-17500713 ] Karl Pauls commented on SLING-9624: --- Right, that was the issue - we had bundles that have imports with version ranges that assume the old package versioning sling did. Thats why I did massage the exports of the system bundle to work with that and still pick up the modules from the jvm where possible. > Get rid of custom "org.osgi.framework.system.packages" > -- > > Key: SLING-9624 > URL: https://issues.apache.org/jira/browse/SLING-9624 > Project: Sling > Issue Type: Improvement > Components: Starter >Reporter: Konrad Windszus >Priority: Major > Fix For: Starter 13 > > > Instead of using a Sling specific "org.osgi.framework.system.packages" > property > (https://github.com/apache/sling-org-apache-sling-starter/blob/5f44b7f6c6b75e4cfd5574fb701c3e7eca8405ef/src/main/provisioning/launchpad.txt#L26) > we should just rely on the Felix default > (https://github.com/apache/felix-dev/blob/master/framework/src/main/resources/default.properties) > to not miss to export all relevant packages for the different JREs > compare with > https://lists.apache.org/thread.html/r0aa3c02c38b5026e24684a00de3c6c8506e166334e77892ac2ee0ab3%40%3Cdev.sling.apache.org%3E. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11166) Launcher bootstrap should have a way to run it without doing a System.exit on error
[ https://issues.apache.org/jira/browse/SLING-11166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-11166. Resolution: Fixed > Launcher bootstrap should have a way to run it without doing a System.exit on > error > --- > > Key: SLING-11166 > URL: https://issues.apache.org/jira/browse/SLING-11166 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model Launcher 1.2.0 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Feature Model Launcher 1.2.2 > > > The Bootstrap in the launcher is there to make it easy to use it in different > use-cases - however, the run method currently does System.exit on errors > which might not be what one expects in different use-cases. We should add > another method that doesn't System.exit. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11166) Launcher bootstrap should have a way to run it without doing a System.exit on error
Karl Pauls created SLING-11166: -- Summary: Launcher bootstrap should have a way to run it without doing a System.exit on error Key: SLING-11166 URL: https://issues.apache.org/jira/browse/SLING-11166 Project: Sling Issue Type: Improvement Components: Feature Model Affects Versions: Feature Model Launcher 1.2.0 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Feature Model Launcher 1.2.2 The Bootstrap in the launcher is there to make it easy to use it in different use-cases - however, the run method currently does System.exit on errors which might not be what one expects in different use-cases. We should add another method that doesn't System.exit. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11164) Configuration API feature to region cache can lose mappings on feature merge
[ https://issues.apache.org/jira/browse/SLING-11164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-11164. Resolution: Fixed > Configuration API feature to region cache can lose mappings on feature merge > > > Key: SLING-11164 > URL: https://issues.apache.org/jira/browse/SLING-11164 > Project: Sling > Issue Type: Bug > Components: Feature Model Analyser >Affects Versions: Feature Model API Regions Extension 1.5.0 > Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Feature Model API Regions Extension 1.5.2 > > > When merging two features which both have entries in the feature to region > cache of their api region, one of them will be lost. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11164) Configuration API feature to region cache can lose mappings on feature merge
Karl Pauls created SLING-11164: -- Summary: Configuration API feature to region cache can lose mappings on feature merge Key: SLING-11164 URL: https://issues.apache.org/jira/browse/SLING-11164 Project: Sling Issue Type: Bug Components: Feature Model Analyser Affects Versions: Feature Model API Regions Extension 1.5.0 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Feature Model API Regions Extension 1.5.2 When merging two features which both have entries in the feature to region cache of their api region, one of them will be lost. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11155) Bundled scripts should be registered by path for the main script when overriding
[ https://issues.apache.org/jira/browse/SLING-11155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-11155. Resolution: Fixed > Bundled scripts should be registered by path for the main script when > overriding > > > Key: SLING-11155 > URL: https://issues.apache.org/jira/browse/SLING-11155 > Project: Sling > Issue Type: Bug > Components: Scripting, Servlets >Affects Versions: Servlets Resolver 2.9.2 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Servlets Resolver 2.9.4 > > Time Spent: 20m > Remaining Estimate: 0h > > When a bundled script is provided without a real script but a resource super > type, it gets a capability for the resource type and will be registered for > that resource type (with the resource super type set). That is done to proxy > the resource super type. > The problem is that the resolver will register a GET/HEAD servlet > automatically for resource types that have no other properties set. > Consequently, this setup ends up handling all GET requests while it should > only handle requests for the default extension (i.e. it overrides requests > for .json which would normally be handled by the default GET servlet). > The fix is for the resolver to not register these proxies as resource types > servlets but bind them by path instead. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11155) Bundled scripts should be registered by path for the main script when overriding
Karl Pauls created SLING-11155: -- Summary: Bundled scripts should be registered by path for the main script when overriding Key: SLING-11155 URL: https://issues.apache.org/jira/browse/SLING-11155 Project: Sling Issue Type: Bug Components: Scripting, Servlets Affects Versions: Servlets Resolver 2.9.2 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Servlets Resolver 2.9.4 When a bundled script is provided without a real script but a resource super type, it gets a capability for the resource type and will be registered for that resource type (with the resource super type set). That is done to proxy the resource super type. The problem is that the resolver will register a GET/HEAD servlet automatically for resource types that have no other properties set. Consequently, this setup ends up handling all GET requests while it should only handle requests for the default extension (i.e. it overrides requests for .json which would normally be handled by the default GET servlet). The fix is for the resolver to not register these proxies as resource types servlets but bind them by path instead. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11148) Feature launcher should look up configadmin service with all service lookup
[ https://issues.apache.org/jira/browse/SLING-11148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-11148. Resolution: Fixed Done in https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/38 > Feature launcher should look up configadmin service with all service lookup > --- > > Key: SLING-11148 > URL: https://issues.apache.org/jira/browse/SLING-11148 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model Launcher 1.2.0 > Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Feature Model Launcher 1.2.2 > > > The feature model launcher looks up config admins inside the launched > features using a service tracker without setting the all services boolean to > true. That can cause it to miss config admins if the config admin interface > is available on the outside. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11148) Feature launcher should look up configadmin service with all service lookup
Karl Pauls created SLING-11148: -- Summary: Feature launcher should look up configadmin service with all service lookup Key: SLING-11148 URL: https://issues.apache.org/jira/browse/SLING-11148 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: Feature Model Launcher 1.2.0 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Feature Model Launcher 1.2.2 The feature model launcher looks up config admins inside the launched features using a service tracker without setting the all services boolean to true. That can cause it to miss config admins if the config admin interface is available on the outside. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11144) Compiler does not create classfiles if compilation of unrelated compilation unit fails
[ https://issues.apache.org/jira/browse/SLING-11144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-11144. Resolution: Fixed > Compiler does not create classfiles if compilation of unrelated compilation > unit fails > -- > > Key: SLING-11144 > URL: https://issues.apache.org/jira/browse/SLING-11144 > Project: Sling > Issue Type: Bug > Components: Commons >Affects Versions: Commons Compiler 2.4.0 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Commons Compiler 2.5.0 > > Time Spent: 20m > Remaining Estimate: 0h > > SLING-7111 made it so that we (correctly) don't write out classfiles > resulting from failing compilations - however, it was too aggressive in that > it just stops to write classfiles altogether. That is fine if there was only > a single compilation unit to begin with. Otherwise, it is a mistake as now, > assuming multiple compilation units, it depends on when the failing > compilation unit gets processed. > We should only not write the classfiles for the compilation unit that failed > and proceed for the other compilation units. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11144) Compiler does not create classfiles if compilation of unrelated compilation unit fails
Karl Pauls created SLING-11144: -- Summary: Compiler does not create classfiles if compilation of unrelated compilation unit fails Key: SLING-11144 URL: https://issues.apache.org/jira/browse/SLING-11144 Project: Sling Issue Type: Bug Components: Commons Affects Versions: Commons Compiler 2.4.0 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Commons Compiler 2.5.0 SLING-7111 made it so that we (correctly) don't write out classfiles resulting from failing compilations - however, it was too aggressive in that it just stops to write classfiles altogether. That is fine if there was only a single compilation unit to begin with. Otherwise, it is a mistake as now, assuming multiple compilation units, it depends on when the failing compilation unit gets processed. We should only not write the classfiles for the compilation unit that failed and proceed for the other compilation units. -- This message was sent by Atlassian Jira (v8.20.1#820001)
Re: [VOTE] Release Apache Sling Security version 1.1.24
+1 regards, Karl On Tue, Feb 15, 2022 at 9:59 AM ang...@apache.org wrote: > > [x] +1 Approve the release > > kind regards > angela > > On 15.02.22 08:58, ang...@apache.org wrote: > > Hi, > > > > We solved 3 issues in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12351306 > > > > There are no outstanding issues. > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2601 > > > > You can use this UNIX script to download the release and verify the > > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: > > sh check_staged_release.sh 2601 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Kind regards > > Angela -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Feature Model Unpack Extension 0.3.0
+1 regards, Karl On Fri, Feb 11, 2022 at 11:26 AM Stefan Seifert wrote: > > +1 -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Scripting Core 2.4.4
+1 regards, Karl On Fri, Feb 11, 2022 at 11:30 AM Stefan Seifert wrote: > > +1 -- Karl Pauls karlpa...@gmail.com
[jira] [Resolved] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls resolved SLING-11099.
Resolution: Fixed
Done in https://github.com/apache/sling-jspc-maven-plugin/pull/7
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JSPC Maven Plugin 2.3.4
>
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls updated SLING-11099:
---
Fix Version/s: JSPC Maven Plugin 2.2.4
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JSPC Maven Plugin 2.2.4
>
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483984#comment-17483984
]
Karl Pauls commented on SLING-11099:
Yeah, looks like a bug. I guess I missed that adding an artifactid as a
property makes it need the classes even so it is not configured. I'll fix it.
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Assignee: Karl Pauls
>Priority: Major
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Assigned] (SLING-11099) JSPC plugin missing critical dependencies by default
[
https://issues.apache.org/jira/browse/SLING-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Pauls reassigned SLING-11099:
--
Assignee: Karl Pauls
> JSPC plugin missing critical dependencies by default
>
>
> Key: SLING-11099
> URL: https://issues.apache.org/jira/browse/SLING-11099
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins and Archetypes
>Affects Versions: JSPC Maven Plugin 2.3.2
>Reporter: Donal Fellows
>Assignee: Karl Pauls
>Priority: Major
>
> The JSPC Maven Plugin, version 2.3.2, fails to work when used as an ordinary
> Maven plugin. The first two lines of relevance (there's a _lot_ more stack
> trace, but it is really not very informative) from the build logs are:
> {{{}[WARNING] Error injecting: org.apache.sling.maven.jspc.JspcMojo
> {}}}{{{}java.lang.NoClassDefFoundError:
> org/apache/sling/feature/ArtifactId{}}}
> The problem appears to be that the _{{org.apache.sling.feature}}_ dependency
> (and, by transitive closure, the _{{org.osgi.framework}}_ dependency as well)
> is marked as {_}provided{_}. Adding the following two as explicit plugin
> dependencies is a workaround (and allows at least my builds to work).
> However, I do not believe that ordinary Maven users should have to do such a
> workaround.
> {{ }}
> {{ org.apache.sling}}
> {{ org.apache.sling.feature}}
> {{ 1.2.30}}
> {{ }}
> {{ }}
> {{ org.osgi}}
> {{ org.osgi.framework}}
> {{ 1.10.0}}
> {{ }}
> Note that 2.3.0 worked correctly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (SLING-11093) Bundled scripts should only be registered for the absolute resource type if the relative resource type is the same
[ https://issues.apache.org/jira/browse/SLING-11093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-11093. Resolution: Fixed Done in the linked PR > Bundled scripts should only be registered for the absolute resource type if > the relative resource type is the same > -- > > Key: SLING-11093 > URL: https://issues.apache.org/jira/browse/SLING-11093 > Project: Sling > Issue Type: Improvement > Components: Scripting, Servlets >Affects Versions: Servlets Resolver 2.9.2 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Servlets Resolver 2.9.2 > > Time Spent: 0.5h > Remaining Estimate: 0h > > The capabilities for bundled scripts typically contain the same resource type > as an absolute and a relative version. Right now, we end up registering both, > which is not needed if we have an absolute resource type anyways. > Furthermore, this can cause problems if the servlet root index is configured > because, in that case, one has to take into account the bundle scripts as > their relative resource types will depend on that as well. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11093) Bundled scripts should only be registered for the absolute resource type if the relative resource type is the same
Karl Pauls created SLING-11093: -- Summary: Bundled scripts should only be registered for the absolute resource type if the relative resource type is the same Key: SLING-11093 URL: https://issues.apache.org/jira/browse/SLING-11093 Project: Sling Issue Type: Improvement Components: Scripting, Servlets Affects Versions: Servlets Resolver 2.9.2 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Servlets Resolver 2.9.2 The capabilities for bundled scripts typically contain the same resource type as an absolute and a relative version. Right now, we end up registering both, which is not needed if we have an absolute resource type anyways. Furthermore, this can make cause problems if the servlet root index is configured because in that case, one has to take into account the bundle scripts as their relative resource types will depend on that as well. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-11075) Maven id for bundles that don't have a GAV can end up not being well formed
[ https://issues.apache.org/jira/browse/SLING-11075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-11075. Resolution: Fixed > Maven id for bundles that don't have a GAV can end up not being well formed > --- > > Key: SLING-11075 > URL: https://issues.apache.org/jira/browse/SLING-11075 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Content-Package to Feature Model Converter 1.1.10 > Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > When the converter finds a bundle, it tries to determine the maven > coordinates for it by looking at the embedded maven info. If there is none, > it tries to guess it from the maven info path. If that fails, it takes the > bsn and derives the info from it. > That works, however, in the case of a bsn, it doesn't strip attributes which > can cause an invalid mvn id in the end (e.g., if the bsn has a > ;singelton:=true) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (SLING-11075) Maven id for bundles that don't have a GAV can end up not being well formed
Karl Pauls created SLING-11075: -- Summary: Maven id for bundles that don't have a GAV can end up not being well formed Key: SLING-11075 URL: https://issues.apache.org/jira/browse/SLING-11075 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: Content-Package to Feature Model Converter 1.1.10 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Content-Package to Feature Model Converter 1.1.12 When the converter finds a bundle, it tries to determine the maven coordinates for it by looking at the embedded maven info. If there is none, it tries to guess it from the maven info path. If that fails, it takes the bsn and derives the info from it. That works, however, in the case of a bsn, it doesn't strip attributes which can cause an invalid mvn id in the end (e.g., if the bsn has a ;singelton:=true) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (SLING-10931) CPConverter - Sling initial content - json files should be converted to folders with a content xml in any case to avoid conflicts
[ https://issues.apache.org/jira/browse/SLING-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-10931. Resolution: Fixed Done in https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/125 > CPConverter - Sling initial content - json files should be converted to > folders with a content xml in any case to avoid conflicts > - > > Key: SLING-10931 > URL: https://issues.apache.org/jira/browse/SLING-10931 > Project: Sling > Issue Type: Bug > Components: Content-Package to Feature Model Converter >Affects Versions: Content-Package to Feature Model Converter 1.1.10 >Reporter: Niek Raaijmakers >Assignee: Niek Raaijmakers >Priority: Major > Fix For: Content-Package to Feature Model Converter 1.1.12 > > > In case of converting sling initial content containing JSON files over to > xml, currently the cpconverter simply creates a xml file in the same level. > The problem is when there are other files in a directory with the same name > to go along the resourceType. > For example we have: > > * page.json > * page/body.html > * page/footer.html > > The result will be: > * page.xml > * page/body.html > * page/footer.html > > Vault doesn't like this approach so much, resulting in stuff like: > * page.dir > * page.xml > * page/.content.xml (with resourceType nt:folder) > * page/body.html > * page/footer.html > The solution lies in simply redirecting the output to .content.xml in a new > folder: > * page/.content.xml > * page/body.html > * page/footer.html > -- This message was sent by Atlassian Jira (v8.20.1#820001)
