Re: [VOTE] Release Apache Sling Content Parser JSON 2.1.0
+1 Konrad > On 9. Apr 2024, at 12:15, Stefan Seifert > wrote: > > Hi, > > We solved 4 issues in this release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353724=Text=12310710 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2844/ > > You can use this UNIX script to download the release and verify the > signatures: > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2844 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan
[jira] [Commented] (SLING-10506) Document inappropriate Sonar rules
[
https://issues.apache.org/jira/browse/SLING-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835176#comment-17835176
]
Konrad Windszus commented on SLING-10506:
-
I would like to add https://rules.sonarsource.com/java/RSPEC-1948/ to the list
because AFAIK none of the OSGi runtimes ever serialize something to disk
(except if explicitly forced via API call). This particularly affects
HttpServletRequest derived classes...
[~olli] Any chance of following up on this?
> Document inappropriate Sonar rules
> --
>
> Key: SLING-10506
> URL: https://issues.apache.org/jira/browse/SLING-10506
> Project: Sling
> Issue Type: Task
> Components: Build and Source Control, CI
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> * {{java:S100}} (https://rules.sonarsource.com/java/RSPEC-100)
> * {{java:S112}} (https://rules.sonarsource.com/java/RSPEC-112)
> * {{java:S1117}} (https://rules.sonarsource.com/java/RSPEC-1117)
> * {{java:S1149}} (https://rules.sonarsource.com/java/RSPEC-1149)
> * {{java:S1989}} (https://rules.sonarsource.com/java/RSPEC-1989)
> * {{java:S2226}} (https://rules.sonarsource.com/java/RSPEC-2226)
> * {{java:S3077}} (https://rules.sonarsource.com/java/RSPEC-3077)
> * {{java:S6212}} (https://rules.sonarsource.com/java/RSPEC-6212)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: Sling Jobs & Eventing Web Console
Hi Stefan, Thanks, that was helpful already. Regards, Konrad > On 3. Apr 2024, at 10:40, Stefan Egli wrote: > > Hi Konrad, > > Suspend stops processing of new jobs but finishes already started jobs (note > that the default implementation suspends for 60min, then resumes the queue). > This has no influence on enqueuing, so jobs can still be enqueued. > > I'm not aware of any helper that goes through the stack trace to find which > code added a job. There is (debug) logging though, so that might be of some > help. > > Cheers, > Stefan > > On 02.04.24 18:04, Konrad Windszus wrote: >> Hi >> I currently face an issue with jobs which get constantly queued (unclear by >> whom yet). >> In order to bring back back the server to a stable state I want to leverage >> the web console at /system/console/slingevent which offers 4 actions per >> each active job queue: >> >> Reset Stats >> Resume/Suspend >> Test >> Drop Alll >> >> (https://github.com/apache/sling-org-apache-sling-event/blob/71c6d4b3219adb640fa5628fb31cad84d31eff2b/src/main/java/org/apache/sling/event/impl/jobs/console/WebConsolePlugin.java#L297-L304) >> >> What happens exactly if I suspend a queue? Do jobs still get enqueued on the >> suspended queue? Is there any helper available to figure out which code is >> responsible for adding jobs? >> Thanks in advance >> >> Konrad >> >> >> >> >>
Sling Jobs & Eventing Web Console
Hi I currently face an issue with jobs which get constantly queued (unclear by whom yet). In order to bring back back the server to a stable state I want to leverage the web console at /system/console/slingevent which offers 4 actions per each active job queue: Reset Stats Resume/Suspend Test Drop Alll (https://github.com/apache/sling-org-apache-sling-event/blob/71c6d4b3219adb640fa5628fb31cad84d31eff2b/src/main/java/org/apache/sling/event/impl/jobs/console/WebConsolePlugin.java#L297-L304) What happens exactly if I suspend a queue? Do jobs still get enqueued on the suspended queue? Is there any helper available to figure out which code is responsible for adding jobs? Thanks in advance Konrad
[jira] [Assigned] (SLING-12278) Improve handling of late initialized context in SlingContextExtension/OsgiContextExtension
[
https://issues.apache.org/jira/browse/SLING-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-12278:
---
Assignee: (was: Konrad Windszus)
> Improve handling of late initialized context in
> SlingContextExtension/OsgiContextExtension
> --
>
> Key: SLING-12278
> URL: https://issues.apache.org/jira/browse/SLING-12278
> Project: Sling
> Issue Type: Improvement
> Reporter: Konrad Windszus
>Priority: Major
>
> Currently neither in
> https://sling.apache.org/documentation/development/osgi-mock.html#junit-5-osgi-context-junit-extension
> nor in
> https://sling.apache.org/documentation/development/sling-mock.html#junit-5-sling-context-junit-extension
> it is mentioned that the context must not be initialized in {{@BeforeAll}}
> or {{@BeforeEach}} as at that point in time the extension has already
> initialized another context. Those two context may lead to subtle issues (for
> example if resources are only added in the second context). For a concrete
> example look at https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/37.
> In the best case the JUnit5 extension never creates a context (but only uses
> the existing instance) or at least creation should be deferred until the
> Before methods have been executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12278) Improve handling of late instantiated context in SlingContextExtension/OsgiContextExtension
[
https://issues.apache.org/jira/browse/SLING-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12278:
Summary: Improve handling of late instantiated context in
SlingContextExtension/OsgiContextExtension (was: Improve handling of late
initialized context in SlingContextExtension/OsgiContextExtension)
> Improve handling of late instantiated context in
> SlingContextExtension/OsgiContextExtension
> ---
>
> Key: SLING-12278
> URL: https://issues.apache.org/jira/browse/SLING-12278
> Project: Sling
> Issue Type: Improvement
> Reporter: Konrad Windszus
>Priority: Major
>
> Currently neither in
> https://sling.apache.org/documentation/development/osgi-mock.html#junit-5-osgi-context-junit-extension
> nor in
> https://sling.apache.org/documentation/development/sling-mock.html#junit-5-sling-context-junit-extension
> it is mentioned that the context must not be initialized in {{@BeforeAll}}
> or {{@BeforeEach}} as at that point in time the extension has already
> initialized another context. Those two context may lead to subtle issues (for
> example if resources are only added in the second context). For a concrete
> example look at https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/37.
> In the best case the JUnit5 extension never creates a context (but only uses
> the existing instance) or at least creation should be deferred until the
> Before methods have been executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12278) Improve handling of late instantiated context in SlingContextExtension/OsgiContextExtension
[
https://issues.apache.org/jira/browse/SLING-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12278:
Description:
Currently neither in
https://sling.apache.org/documentation/development/osgi-mock.html#junit-5-osgi-context-junit-extension
nor in
https://sling.apache.org/documentation/development/sling-mock.html#junit-5-sling-context-junit-extension
it is mentioned that the context must not be instantiated in {{@BeforeAll}} or
{{@BeforeEach}} as at that point in time the extension has already instantiated
another context. Those two contexts may lead to subtle issues (for example if
resources are only added in the second context). For a concrete example look at
https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/37.
In the best case the JUnit5 extension never creates a context (but only uses
the existing instance) or at least creation should be deferred until the Before
methods have been executed.
was:
Currently neither in
https://sling.apache.org/documentation/development/osgi-mock.html#junit-5-osgi-context-junit-extension
nor in
https://sling.apache.org/documentation/development/sling-mock.html#junit-5-sling-context-junit-extension
it is mentioned that the context must not be initialized in {{@BeforeAll}} or
{{@BeforeEach}} as at that point in time the extension has already initialized
another context. Those two context may lead to subtle issues (for example if
resources are only added in the second context). For a concrete example look at
https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/37.
In the best case the JUnit5 extension never creates a context (but only uses
the existing instance) or at least creation should be deferred until the Before
methods have been executed.
> Improve handling of late instantiated context in
> SlingContextExtension/OsgiContextExtension
> ---
>
> Key: SLING-12278
> URL: https://issues.apache.org/jira/browse/SLING-12278
> Project: Sling
> Issue Type: Improvement
> Reporter: Konrad Windszus
>Priority: Major
>
> Currently neither in
> https://sling.apache.org/documentation/development/osgi-mock.html#junit-5-osgi-context-junit-extension
> nor in
> https://sling.apache.org/documentation/development/sling-mock.html#junit-5-sling-context-junit-extension
> it is mentioned that the context must not be instantiated in {{@BeforeAll}}
> or {{@BeforeEach}} as at that point in time the extension has already
> instantiated another context. Those two contexts may lead to subtle issues
> (for example if resources are only added in the second context). For a
> concrete example look at
> https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/37.
> In the best case the JUnit5 extension never creates a context (but only uses
> the existing instance) or at least creation should be deferred until the
> Before methods have been executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-12278) Improve handling of late initialized context in SlingContextExtension/OsgiContextExtension
[
https://issues.apache.org/jira/browse/SLING-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-12278:
---
Assignee: Konrad Windszus
> Improve handling of late initialized context in
> SlingContextExtension/OsgiContextExtension
> --
>
> Key: SLING-12278
> URL: https://issues.apache.org/jira/browse/SLING-12278
> Project: Sling
> Issue Type: Improvement
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
>Priority: Major
>
> Currently neither in
> https://sling.apache.org/documentation/development/osgi-mock.html#junit-5-osgi-context-junit-extension
> nor in
> https://sling.apache.org/documentation/development/sling-mock.html#junit-5-sling-context-junit-extension
> it is mentioned that the context must not be initialized in {{@BeforeAll}}
> or {{@BeforeEach}} as at that point in time the extension has already
> initialized another context. Those two context may lead to subtle issues (for
> example if resources are only added in the second context). For a concrete
> example look at https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/37.
> In the best case the JUnit5 extension never creates a context (but only uses
> the existing instance) or at least creation should be deferred until the
> Before methods have been executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12278) Improve handling of late initialized context in SlingContextExtension/OsgiContextExtension
[
https://issues.apache.org/jira/browse/SLING-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831923#comment-17831923
]
Konrad Windszus commented on SLING-12278:
-
I think
https://junit.org/junit5/docs/current/user-guide/#extensions-registration-programmatic
is the better pattern for parameterizing JUnit extensions.
> Improve handling of late initialized context in
> SlingContextExtension/OsgiContextExtension
> --
>
> Key: SLING-12278
> URL: https://issues.apache.org/jira/browse/SLING-12278
> Project: Sling
> Issue Type: Improvement
> Reporter: Konrad Windszus
>Priority: Major
>
> Currently neither in
> https://sling.apache.org/documentation/development/osgi-mock.html#junit-5-osgi-context-junit-extension
> nor in
> https://sling.apache.org/documentation/development/sling-mock.html#junit-5-sling-context-junit-extension
> it is mentioned that the context must not be initialized in {{@BeforeAll}}
> or {{@BeforeEach}} as at that point in time the extension has already
> initialized another context. Those two context may lead to subtle issues (for
> example if resources are only added in the second context). For a concrete
> example look at https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/37.
> In the best case the JUnit5 extension never creates a context (but only uses
> the existing instance) or at least creation should be deferred until the
> Before methods have been executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12278) Improve handling of late initialized context in SlingContextExtension/OsgiContextExtension
[
https://issues.apache.org/jira/browse/SLING-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831922#comment-17831922
]
Konrad Windszus commented on SLING-12278:
-
[~sseifert] I would appreciate your input here as for me there is way too much
magic inside
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/blob/41c4a554333a2fc8c32f9bd233290132b638de4b/junit5/src/main/java/org/apache/sling/testing/mock/sling/junit5/SlingContextExtension.java#L41-L62.
> Improve handling of late initialized context in
> SlingContextExtension/OsgiContextExtension
> --
>
> Key: SLING-12278
> URL: https://issues.apache.org/jira/browse/SLING-12278
> Project: Sling
> Issue Type: Improvement
> Reporter: Konrad Windszus
>Priority: Major
>
> Currently neither in
> https://sling.apache.org/documentation/development/osgi-mock.html#junit-5-osgi-context-junit-extension
> nor in
> https://sling.apache.org/documentation/development/sling-mock.html#junit-5-sling-context-junit-extension
> it is mentioned that the context must not be initialized in {{@BeforeAll}}
> or {{@BeforeEach}} as at that point in time the extension has already
> initialized another context. Those two context may lead to subtle issues (for
> example if resources are only added in the second context). For a concrete
> example look at https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/37.
> In the best case the JUnit5 extension never creates a context (but only uses
> the existing instance) or at least creation should be deferred until the
> Before methods have been executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12278) Improve handling of late initialized context in SlingContextExtension/OsgiContextExtension
Konrad Windszus created SLING-12278:
---
Summary: Improve handling of late initialized context in
SlingContextExtension/OsgiContextExtension
Key: SLING-12278
URL: https://issues.apache.org/jira/browse/SLING-12278
Project: Sling
Issue Type: Improvement
Reporter: Konrad Windszus
Currently neither in
https://sling.apache.org/documentation/development/osgi-mock.html#junit-5-osgi-context-junit-extension
nor in
https://sling.apache.org/documentation/development/sling-mock.html#junit-5-sling-context-junit-extension
it is mentioned that the context must not be initialized in {{@BeforeAll}} or
{{@BeforeEach}} as at that point in time the extension has already initialized
another context. Those two context may lead to subtle issues (for example if
resources are only added in the second context). For a concrete example look at
https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/37.
In the best case the JUnit5 extension never creates a context (but only uses
the existing instance) or at least creation should be deferred until the Before
methods have been executed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12277) Improve logging during AbstractSlingRepositoryManager.executeRepositoryInitializers()
Konrad Windszus created SLING-12277:
---
Summary: Improve logging during
AbstractSlingRepositoryManager.executeRepositoryInitializers()
Key: SLING-12277
URL: https://issues.apache.org/jira/browse/SLING-12277
Project: Sling
Issue Type: Improvement
Components: JCR
Affects Versions: JCR Base 3.2.0
Reporter: Konrad Windszus
As long running {{SlingRepositoryInitializer}} services can defer the startup
quite a lot, it would be helpful to emit regular log messages (with INFO level)
while looping through
https://github.com/apache/sling-org-apache-sling-jcr-base/blob/c8a53dff4ec163e19a014c470126eb4450f78cde/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepositoryManager.java#L625.
The log messages should include:
- Time since repo start,
- Currently running initializer (class name)
- Index of current initializer and total number of initializers
That should allow to predict by looking at the log, if there is any progress in
starting the repo and how long it will probably still take.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12275) Undeprecate optional element for injector specific annotations
[
https://issues.apache.org/jira/browse/SLING-12275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-12275.
-
Resolution: Invalid
Sorry, too early for me. There is already the replacement {{injectionStrategy}}
on the injector specific annotation.
> Undeprecate optional element for injector specific annotations
> --
>
> Key: SLING-12275
> URL: https://issues.apache.org/jira/browse/SLING-12275
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
>Priority: Major
>
> In the context of SLING-4155 the {{optional}} element has been deprecated.
> It is still necessary though in cases where different element have different
> injection strategies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12275) Undeprecate optional element for injector specific annotations
Konrad Windszus created SLING-12275:
---
Summary: Undeprecate optional element for injector specific
annotations
Key: SLING-12275
URL: https://issues.apache.org/jira/browse/SLING-12275
Project: Sling
Issue Type: Improvement
Components: Sling Models
Reporter: Konrad Windszus
Assignee: Konrad Windszus
In the context of SLING-4155 the {{optional}} element has been deprecated.
It is still necessary though in cases where different element have different
injection strategies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12271) Supported source version 'RELEASE_8' from annotation processor 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less than -source '11'
[
https://issues.apache.org/jira/browse/SLING-12271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-12271.
-
Fix Version/s: Models API 1.5.2
Resolution: Fixed
> Supported source version 'RELEASE_8' from annotation processor
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
> than -source '11'
> -
>
> Key: SLING-12271
> URL: https://issues.apache.org/jira/browse/SLING-12271
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Affects Versions: Models API 1.5.0
> Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Models API 1.5.2
>
>
> The annotation processor introduced with SLING-11507 only supports Java 8
> source code version according to the annotation
> https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.
> This leads to the following warning during compilation when using javac's
> {{source}} or {{release}} option with any other value than 1.8/8.
> {code}
> [WARNING] Supported source version 'RELEASE_8' from annotation processor
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
> than -source '11'
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12271) Supported source version 'RELEASE_8' from annotation processor 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less than -source '11'
[
https://issues.apache.org/jira/browse/SLING-12271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829942#comment-17829942
]
Konrad Windszus commented on SLING-12271:
-
Fixed in
https://github.com/apache/sling-org-apache-sling-models-api/commit/6d6b5609fe11ad1f4a5014ce2b9254ba1c836147.
> Supported source version 'RELEASE_8' from annotation processor
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
> than -source '11'
> -
>
> Key: SLING-12271
> URL: https://issues.apache.org/jira/browse/SLING-12271
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Affects Versions: Models API 1.5.0
> Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> The annotation processor introduced with SLING-11507 only supports Java 8
> source code version according to the annotation
> https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.
> This leads to the following warning during compilation when using javac's
> {{source}} or {{release}} option with any other value than 1.8/8.
> {code}
> [WARNING] Supported source version 'RELEASE_8' from annotation processor
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
> than -source '11'
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12263) Separate real OSGi bundles from simple JARs in Downloads page
[ https://issues.apache.org/jira/browse/SLING-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-12263. - Resolution: Fixed > Separate real OSGi bundles from simple JARs in Downloads page > - > > Key: SLING-12263 > URL: https://issues.apache.org/jira/browse/SLING-12263 > Project: Sling > Issue Type: Improvement > Components: Site > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > > Currently the page https://sling.apache.org/downloads.cgi#sling-components > has a section "Sling Components" which contains most of the Sling modules. > However not all in that list are bundles. > Therefore I propose to rename "Sling Components" to "Sling Bundles" (and only > list real OSGi bundles there) and add an additional section named "Sling > Helpers" and list all JARs there which do not fit in any other category > (maven plugins, bnd plugins, IDE or Sling Application). > Those are primarily all annotation modules like > - https://github.com/apache/sling-adapter-annotations > - https://github.com/apache/sling-org-apache-sling-adapter-annotations > but also > - > https://github.com/apache/sling-org-apache-sling-installer-provider-installhook > ... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12273) Build breaks on Java 21
[
https://issues.apache.org/jira/browse/SLING-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-12273.
-
Resolution: Fixed
Fixed by updating to sling-bundle-parent 60 in
https://github.com/apache/sling-org-apache-sling-models-api/commit/fbfb295c90b08336e75cfb2d59ebbcd09a329da9
and the two subsequent commits.
> Build breaks on Java 21
> ---
>
> Key: SLING-12273
> URL: https://issues.apache.org/jira/browse/SLING-12273
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Affects Versions: Models API 1.5.0
> Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Models API 1.5.2
>
>
> The following error is emitted in during building with Maven
> (https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-models-api/detail/master/212/pipeline/)
> {code}
> [INFO] --- invoker:3.3.0:run (integration-test) @ org.apache.sling.models.api
> ---
> [INFO] Building: validating-annotation-processor/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO] BUG! exception in phase 'semantic analysis' in source unit
> 'Script1.groovy' Unsupported class file major version 65
> [INFO] validating-annotation-processor/pom.xml .. FAILED
> (15.5 s)
> [INFO] -
> [INFO] Build Summary:
> [INFO] Passed: 0, Failed: 1, Errors: 0, Skipped: 0
> [INFO] -
> [ERROR] The following builds failed:
> [ERROR] * validating-annotation-processor/pom.xml
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 51.891 s
> [INFO] Finished at: 2024-03-15T23:26:49Z
> [INFO]
>
> [INFO] [jenkins-event-spy] Generated
> /home/jenkins/workspace/g-apache-sling-models-api_master/jdk_21_latest@tmp/withMaven74374c80/maven-spy-20240315-232556-91012999432982760308630.log
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run (integration-test) on
> project org.apache.sling.models.api: 1 build failed. See console output above
> for details. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run
> (integration-test) on project org.apache.sling.models.api: 1 build failed.
> See console output above for details.
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.DirectMethodHandleAccessor.invoke
> (DirectMethodHandleAccessor.java:103)
> at java.lang.reflect.Method.invoke (Method.java:580)
> at org.
[jira] [Updated] (SLING-12273) Build breaks on Java 21
[
https://issues.apache.org/jira/browse/SLING-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12273:
Fix Version/s: Models API 1.5.2
> Build breaks on Java 21
> ---
>
> Key: SLING-12273
> URL: https://issues.apache.org/jira/browse/SLING-12273
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Affects Versions: Models API 1.5.0
> Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Models API 1.5.2
>
>
> The following error is emitted in during building with Maven
> (https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-models-api/detail/master/212/pipeline/)
> {code}
> [INFO] --- invoker:3.3.0:run (integration-test) @ org.apache.sling.models.api
> ---
> [INFO] Building: validating-annotation-processor/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO] BUG! exception in phase 'semantic analysis' in source unit
> 'Script1.groovy' Unsupported class file major version 65
> [INFO] validating-annotation-processor/pom.xml .. FAILED
> (15.5 s)
> [INFO] -
> [INFO] Build Summary:
> [INFO] Passed: 0, Failed: 1, Errors: 0, Skipped: 0
> [INFO] -
> [ERROR] The following builds failed:
> [ERROR] * validating-annotation-processor/pom.xml
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 51.891 s
> [INFO] Finished at: 2024-03-15T23:26:49Z
> [INFO]
>
> [INFO] [jenkins-event-spy] Generated
> /home/jenkins/workspace/g-apache-sling-models-api_master/jdk_21_latest@tmp/withMaven74374c80/maven-spy-20240315-232556-91012999432982760308630.log
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run (integration-test) on
> project org.apache.sling.models.api: 1 build failed. See console output above
> for details. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run
> (integration-test) on project org.apache.sling.models.api: 1 build failed.
> See console output above for details.
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.DirectMethodHandleAccessor.invoke
> (DirectMethodHandleAccessor.java:103)
> at java.lang.reflect.Method.invoke (Method.java:580)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codeh
[jira] [Assigned] (SLING-12273) Build breaks on Java 21
[
https://issues.apache.org/jira/browse/SLING-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-12273:
---
Assignee: Konrad Windszus
> Build breaks on Java 21
> ---
>
> Key: SLING-12273
> URL: https://issues.apache.org/jira/browse/SLING-12273
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Affects Versions: Models API 1.5.0
> Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> The following error is emitted in during building with Maven
> (https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-models-api/detail/master/212/pipeline/)
> {code}
> [INFO] --- invoker:3.3.0:run (integration-test) @ org.apache.sling.models.api
> ---
> [INFO] Building: validating-annotation-processor/pom.xml
> [INFO] run post-build script verify.groovy
> [INFO] BUG! exception in phase 'semantic analysis' in source unit
> 'Script1.groovy' Unsupported class file major version 65
> [INFO] validating-annotation-processor/pom.xml .. FAILED
> (15.5 s)
> [INFO] -
> [INFO] Build Summary:
> [INFO] Passed: 0, Failed: 1, Errors: 0, Skipped: 0
> [INFO] -
> [ERROR] The following builds failed:
> [ERROR] * validating-annotation-processor/pom.xml
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 51.891 s
> [INFO] Finished at: 2024-03-15T23:26:49Z
> [INFO]
>
> [INFO] [jenkins-event-spy] Generated
> /home/jenkins/workspace/g-apache-sling-models-api_master/jdk_21_latest@tmp/withMaven74374c80/maven-spy-20240315-232556-91012999432982760308630.log
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run (integration-test) on
> project org.apache.sling.models.api: 1 build failed. See console output above
> for details. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run
> (integration-test) on project org.apache.sling.models.api: 1 build failed.
> See console output above for details.
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.DirectMethodHandleAccessor.invoke
> (DirectMethodHandleAccessor.java:103)
> at java.lang.reflect.Method.invoke (Method.java:580)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codehaus.pl
[jira] [Created] (SLING-12273) Build breaks on Java 21
Konrad Windszus created SLING-12273:
---
Summary: Build breaks on Java 21
Key: SLING-12273
URL: https://issues.apache.org/jira/browse/SLING-12273
Project: Sling
Issue Type: Improvement
Components: Sling Models
Affects Versions: Models API 1.5.0
Reporter: Konrad Windszus
The following error is emitted in during building with Maven
(https://ci-builds.apache.org/blue/organizations/jenkins/Sling%2Fmodules%2Fsling-org-apache-sling-models-api/detail/master/212/pipeline/)
{code}
[INFO] --- invoker:3.3.0:run (integration-test) @ org.apache.sling.models.api
---
[INFO] Building: validating-annotation-processor/pom.xml
[INFO] run post-build script verify.groovy
[INFO] BUG! exception in phase 'semantic analysis' in source unit
'Script1.groovy' Unsupported class file major version 65
[INFO] validating-annotation-processor/pom.xml .. FAILED
(15.5 s)
[INFO] -
[INFO] Build Summary:
[INFO] Passed: 0, Failed: 1, Errors: 0, Skipped: 0
[INFO] -
[ERROR] The following builds failed:
[ERROR] * validating-annotation-processor/pom.xml
[INFO] -
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 51.891 s
[INFO] Finished at: 2024-03-15T23:26:49Z
[INFO]
[INFO] [jenkins-event-spy] Generated
/home/jenkins/workspace/g-apache-sling-models-api_master/jdk_21_latest@tmp/withMaven74374c80/maven-spy-20240315-232556-91012999432982760308630.log
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run (integration-test) on
project org.apache.sling.models.api: 1 build failed. See console output above
for details. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-invoker-plugin:3.3.0:run (integration-test) on
project org.apache.sling.models.api: 1 build failed. See console output above
for details.
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:333)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
(MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
(MojoExecutor.java:162)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
(DefaultMojosExecutionStrategy.java:39)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:159)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:105)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:73)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:53)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
at jdk.internal.reflect.DirectMethodHandleAccessor.invoke
(DirectMethodHandleAccessor.java:103)
at java.lang.reflect.Method.invoke (Method.java:580)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:283)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:226)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:407)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:348)
Caused by: org.apache.maven.plugin.MojoFailureException: 1 build failed. See
console output above for details.
at org.apache.maven.plugins.invoker.InvokerSession.handleFailures
(InvokerSession.java:285)
at org.apache.maven.plugins.invoker.InvokerMojo.processResults
(InvokerMojo.java:81)
at org.apache.maven.plugins.invoker.AbstractInvokerMojo.execute
(AbstractInvokerMojo.java:876)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:
[jira] [Resolved] (SLING-10137) SlingModelAdapterFactory.createModel() returns null
[
https://issues.apache.org/jira/browse/SLING-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-10137.
-
Resolution: Duplicate
> SlingModelAdapterFactory.createModel() returns null
> ---
>
> Key: SLING-10137
> URL: https://issues.apache.org/jira/browse/SLING-10137
> Project: Sling
> Issue Type: Bug
> Components: Sling Models
>Affects Versions: Models Implementation 1.4.16
>Reporter: René Grob
>Priority: Major
>
> According to the documentation
> ([https://sling.apache.org/documentation/bundles/models.html#modelfactory-since-120])
> null checks are not necessary. However if a {{@PostConstruct}} method
> returns false,
> {{org.apache.sling.models.impl.ModelAdapterFactory.invokePostConstruct()}}
> will return {{null}}. This will cause
> {{org.apache.sling.models.impl.ModelAdapterFactory.createModel()}} to fail
> because {{result.getThrowable()}} returns {{null}} which will result in
> {{throw null}}.
> In order to fix this {{internalCreateModel()}} needs to return a valid
> throwable to indicate that the {{@PostConstruct}} method returned {{false}}
> and therefore no model was created.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12271) Supported source version 'RELEASE_8' from annotation processor 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less than -source '11'
[
https://issues.apache.org/jira/browse/SLING-12271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12271:
Description:
The annotation processor introduced with SLING-11507 only supports Java 8
source code version according to the annotation
https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.
This leads to the following warning during compilation when using javac's
{{source}} or {{release}} option with any other value than 1.8/8.
{code}
[WARNING] Supported source version 'RELEASE_8' from annotation processor
'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
than -source '11'
{code}
was:
The annotation processor introduced with SLING-11507 only supports Java 8
bytecode according to the annotation
https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.
This leads to the following warning during compilation when targetting e.g.
Java 11 bytecode
{code}
[WARNING] Supported source version 'RELEASE_8' from annotation processor
'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
than -source '11'
{code}
> Supported source version 'RELEASE_8' from annotation processor
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
> than -source '11'
> -
>
> Key: SLING-12271
> URL: https://issues.apache.org/jira/browse/SLING-12271
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Affects Versions: Models API 1.5.0
> Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> The annotation processor introduced with SLING-11507 only supports Java 8
> source code version according to the annotation
> https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.
> This leads to the following warning during compilation when using javac's
> {{source}} or {{release}} option with any other value than 1.8/8.
> {code}
> [WARNING] Supported source version 'RELEASE_8' from annotation processor
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
> than -source '11'
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12272) Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
[
https://issues.apache.org/jira/browse/SLING-12272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829523#comment-17829523
]
Konrad Windszus commented on SLING-12272:
-
[~rombert] or [~diru] Can any of you take this up?
> Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
> --
>
> Key: SLING-12272
> URL: https://issues.apache.org/jira/browse/SLING-12272
> Project: Sling
> Issue Type: Improvement
> Reporter: Konrad Windszus
>Priority: Major
>
> With JDK 22 annotation processors will no longer be automatically executed by
> javac (https://bugs.openjdk.org/browse/JDK-8306819). Instead they need to be
> explicitly enabled with
> {code}
> -processor
> {code}
> (https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-processor)
> That and a minimum description of what it does should be added to
> https://sling.apache.org/documentation/bundles/models.html.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12272) Document org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
Konrad Windszus created SLING-12272:
---
Summary: Document
org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor
Key: SLING-12272
URL: https://issues.apache.org/jira/browse/SLING-12272
Project: Sling
Issue Type: Improvement
Reporter: Konrad Windszus
With JDK 22 annotation processors will no longer be automatically executed by
javac (https://bugs.openjdk.org/browse/JDK-8306819). Instead they need to be
explicitly enabled with
{code}
-processor
{code}
(https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-processor)
That and a minimum description of what it does should be added to
https://sling.apache.org/documentation/bundles/models.html.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-12271) Supported source version 'RELEASE_8' from annotation processor 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less than -source '11'
[
https://issues.apache.org/jira/browse/SLING-12271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-12271:
---
Assignee: Konrad Windszus
> Supported source version 'RELEASE_8' from annotation processor
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
> than -source '11'
> -
>
> Key: SLING-12271
> URL: https://issues.apache.org/jira/browse/SLING-12271
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Affects Versions: Models API 1.5.0
> Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> The annotation processor introduced with SLING-11507 only supports Java 8
> bytecode according to the annotation
> https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.
> This leads to the following warning during compilation when targetting e.g.
> Java 11 bytecode
> {code}
> [WARNING] Supported source version 'RELEASE_8' from annotation processor
> 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
> than -source '11'
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12271) Supported source version 'RELEASE_8' from annotation processor 'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less than -source '11'
Konrad Windszus created SLING-12271:
---
Summary: Supported source version 'RELEASE_8' from annotation
processor
'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
than -source '11'
Key: SLING-12271
URL: https://issues.apache.org/jira/browse/SLING-12271
Project: Sling
Issue Type: Improvement
Components: Sling Models
Affects Versions: Models API 1.5.0
Reporter: Konrad Windszus
The annotation processor introduced with SLING-11507 only supports Java 8
bytecode according to the annotation
https://github.com/apache/sling-org-apache-sling-models-api/blob/3a2bfd7882ef0ef453261aff4f58adeee171c4c7/src/main/java/org/apache/sling/models/annotations/apt/ValidatingAnnotationProcessor.java#L41.
This leads to the following warning during compilation when targetting e.g.
Java 11 bytecode
{code}
[WARNING] Supported source version 'RELEASE_8' from annotation processor
'org.apache.sling.models.annotations.apt.ValidatingAnnotationProcessor' less
than -source '11'
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-12263) Separate real OSGi bundles from simple JARs in Downloads page
[ https://issues.apache.org/jira/browse/SLING-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-12263: --- Assignee: Konrad Windszus > Separate real OSGi bundles from simple JARs in Downloads page > - > > Key: SLING-12263 > URL: https://issues.apache.org/jira/browse/SLING-12263 > Project: Sling > Issue Type: Improvement > Components: Site > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > > Currently the page https://sling.apache.org/downloads.cgi#sling-components > has a section "Sling Components" which contains most of the Sling modules. > However not all in that list are bundles. > Therefore I propose to rename "Sling Components" to "Sling Bundles" (and only > list real OSGi bundles there) and add an additional section named "Sling > Helpers" and list all JARs there which do not fit in any other category > (maven plugins, bnd plugins, IDE or Sling Application). > Those are primarily all annotation modules like > - https://github.com/apache/sling-adapter-annotations > - https://github.com/apache/sling-org-apache-sling-adapter-annotations > but also > - > https://github.com/apache/sling-org-apache-sling-installer-provider-installhook > ... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12263) Separate real OSGi bundles from simple JARs in Downloads page
[ https://issues.apache.org/jira/browse/SLING-12263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12263: Summary: Separate real OSGi bundles from simple JARs in Downloads page (was: Separate real OSGi bundles from simple JARs) > Separate real OSGi bundles from simple JARs in Downloads page > - > > Key: SLING-12263 > URL: https://issues.apache.org/jira/browse/SLING-12263 > Project: Sling > Issue Type: Improvement > Components: Site > Reporter: Konrad Windszus >Priority: Major > > Currently the page https://sling.apache.org/downloads.cgi#sling-components > has a section "Sling Components" which contains most of the Sling modules. > However not all in that list are bundles. > Therefore I propose to rename "Sling Components" to "Sling Bundles" (and only > list real OSGi bundles there) and add an additional section named "Sling > Helpers" and list all JARs there which do not fit in any other category > (maven plugins, bnd plugins, IDE or Sling Application). > Those are primarily all annotation modules like > - https://github.com/apache/sling-adapter-annotations > - https://github.com/apache/sling-org-apache-sling-adapter-annotations > but also > - > https://github.com/apache/sling-org-apache-sling-installer-provider-installhook > ... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12263) Separate real OSGi bundles from simple JARs
Konrad Windszus created SLING-12263: --- Summary: Separate real OSGi bundles from simple JARs Key: SLING-12263 URL: https://issues.apache.org/jira/browse/SLING-12263 Project: Sling Issue Type: Improvement Components: Site Reporter: Konrad Windszus Currently the page https://sling.apache.org/downloads.cgi#sling-components has a section "Sling Components" which contains most of the Sling modules. However not all in that list are bundles. Therefore I propose to rename "Sling Components" to "Sling Bundles" (and only list real OSGi bundles there) and add an additional section named "Sling Helpers" and list all JARs there which do not fit in any other category (maven plugins, bnd plugins, IDE or Sling Application). Those are primarily all annotation modules like - https://github.com/apache/sling-adapter-annotations - https://github.com/apache/sling-org-apache-sling-adapter-annotations but also - https://github.com/apache/sling-org-apache-sling-installer-provider-installhook ... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT][VOTE] Release Apache Sling Resource Observation Annotations 1.0.0
Hi, The vote has passed with the following result : +1 (binding): Robert, Radu, Jörg I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad > On 1. Mar 2024, at 13:19, Konrad Windszus wrote: > > Hi, > > We solved 1 issues in this release: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354378=Text > > The source code is located in the new repository at > https://github.com/apache/sling-org-apache-sling-resource-observation-annotations. > > Its usage is described in https://github.com/apache/sling-site/pull/157 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2841/ > > You can use this UNIX script to download the release and verify the > signatures: > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2841 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Thanks in advance for voting, > Konrad
[jira] [Closed] (SLING-12247) Provide component property type for (External)ResourceChangeListener
[ https://issues.apache.org/jira/browse/SLING-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-12247. --- > Provide component property type for (External)ResourceChangeListener > > > Key: SLING-12247 > URL: https://issues.apache.org/jira/browse/SLING-12247 > Project: Sling > Issue Type: Improvement > Components: Resource Observation Annotations > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Observation Annotations 1.0.0 > > > In order to ease registration of Sling ResourceChangeListeners a [component > property type > |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types] > should be provided with elements for all supported properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12261) Sling Event: Update to sling-bundle-parent 60
[ https://issues.apache.org/jira/browse/SLING-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12261: Affects Version/s: Event 4.3.14 > Sling Event: Update to sling-bundle-parent 60 > - > > Key: SLING-12261 > URL: https://issues.apache.org/jira/browse/SLING-12261 > Project: Sling > Issue Type: Improvement > Components: Event >Affects Versions: Event 4.3.14 > Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12261) Sling Event: Update to sling-bundle-parent 60
[ https://issues.apache.org/jira/browse/SLING-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12261: Component/s: Event > Sling Event: Update to sling-bundle-parent 60 > - > > Key: SLING-12261 > URL: https://issues.apache.org/jira/browse/SLING-12261 > Project: Sling > Issue Type: Improvement > Components: Event > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12261) Sling Event: Update to sling-bundle-parent 60
Konrad Windszus created SLING-12261: --- Summary: Sling Event: Update to sling-bundle-parent 60 Key: SLING-12261 URL: https://issues.apache.org/jira/browse/SLING-12261 Project: Sling Issue Type: Improvement Reporter: Konrad Windszus Assignee: Konrad Windszus -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12260) Sling Events does not build on Java 21
[
https://issues.apache.org/jira/browse/SLING-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12260:
Summary: Sling Events does not build on Java 21 (was: Sling Events does
not Build on Java 21)
> Sling Events does not build on Java 21
> --
>
> Key: SLING-12260
> URL: https://issues.apache.org/jira/browse/SLING-12260
> Project: Sling
> Issue Type: Bug
> Components: Event
>Affects Versions: Event 4.3.14
> Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Attempting to build Sling Events with Java 21 fails with:
> {code:java}
> [ERROR]
> org.apache.sling.event.impl.discovery.InitDelayingTopologyEventListenerTest.testChanging0
> Time elapsed: 0.002 s <<< ERROR!
> java.lang.IllegalStateException: Could not initialize plugin: interface
> org.mockito.plugins.MockMaker (alternate: null)
> at
> org.mockito.internal.configuration.plugins.PluginLoader$1.invoke(PluginLoader.java:84)
> at jdk.proxy2/jdk.proxy2.$Proxy21.isTypeMockable(Unknown Source)
> at
> org.mockito.internal.util.MockUtil.typeMockabilityOf(MockUtil.java:33)
> at
> org.mockito.internal.util.MockCreationValidator.validateType(MockCreationValidator.java:22)
> at
> org.mockito.internal.creation.MockSettingsImpl.validatedSettings(MockSettingsImpl.java:250)
> at
> org.mockito.internal.creation.MockSettingsImpl.build(MockSettingsImpl.java:232)
> at org.mockito.internal.MockitoCore.mock(MockitoCore.java:83)
> at org.mockito.Mockito.mock(Mockito.java:1954)
> at org.mockito.Mockito.mock(Mockito.java:1865)
> at
> org.apache.sling.event.impl.discovery.InitDelayingTopologyEventListenerTest.createView(InitDelayingTopologyEventListenerTest.java:158)
> at
> org.apache.sling.event.impl.discovery.InitDelayingTopologyEventListenerTest.createEvent(InitDelayingTopologyEventListenerTest.java:176)
> at
> org.apache.sling.event.impl.discovery.InitDelayingTopologyEventListenerTest.testChanging0(InitDelayingTopologyEventListenerTest.java:258)
> at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)
> Caused by: java.lang.IllegalStateException: Internal problem occurred, please
> report it. Mockito is unable
[jira] [Updated] (SLING-12260) Sling Events does not Build on Java 21
[
https://issues.apache.org/jira/browse/SLING-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12260:
Description:
Attempting to build Sling Events with Java 21 fails with:
{code:java}
[ERROR]
org.apache.sling.event.impl.discovery.InitDelayingTopologyEventListenerTest.testChanging0
Time elapsed: 0.002 s <<< ERROR!
java.lang.IllegalStateException: Could not initialize plugin: interface
org.mockito.plugins.MockMaker (alternate: null)
at
org.mockito.internal.configuration.plugins.PluginLoader$1.invoke(PluginLoader.java:84)
at jdk.proxy2/jdk.proxy2.$Proxy21.isTypeMockable(Unknown Source)
at
org.mockito.internal.util.MockUtil.typeMockabilityOf(MockUtil.java:33)
at
org.mockito.internal.util.MockCreationValidator.validateType(MockCreationValidator.java:22)
at
org.mockito.internal.creation.MockSettingsImpl.validatedSettings(MockSettingsImpl.java:250)
at
org.mockito.internal.creation.MockSettingsImpl.build(MockSettingsImpl.java:232)
at org.mockito.internal.MockitoCore.mock(MockitoCore.java:83)
at org.mockito.Mockito.mock(Mockito.java:1954)
at org.mockito.Mockito.mock(Mockito.java:1865)
at
org.apache.sling.event.impl.discovery.InitDelayingTopologyEventListenerTest.createView(InitDelayingTopologyEventListenerTest.java:158)
at
org.apache.sling.event.impl.discovery.InitDelayingTopologyEventListenerTest.createEvent(InitDelayingTopologyEventListenerTest.java:176)
at
org.apache.sling.event.impl.discovery.InitDelayingTopologyEventListenerTest.testChanging0(InitDelayingTopologyEventListenerTest.java:258)
at
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:364)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:272)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:237)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:158)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
at
org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
at
org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
at
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)
Caused by: java.lang.IllegalStateException: Internal problem occurred, please
report it. Mockito is unable to load the default implementation of class that
is a part of Mockito distribution. Failed to load interface
org.mockito.plugins.MockMaker
at
org.mockito.internal.configuration.plugins.DefaultMockitoPlugins.create(DefaultMockitoPlugins.java:91)
at
org.mockito.internal.configuration.plugins.DefaultMockitoPlugins.getDefaultPlugin(DefaultMockitoPlugins.java:64)
at
org.mockito.internal.configuration.plugins.PluginLoader.loadPlugin(PluginLoader.java:75)
at
org.mockito.internal.configuration.plugins.PluginLoader.loadPlugin(PluginLoader.java:50)
at
org.mockito.internal.configuration.plugins.PluginRegistry.(PluginRegistry.java:26)
at
org.mockito.internal.configuration.plugins.Plugins.(Plugins.java:20)
at org.mockito.junit.MockitoJUnit.rule(MockitoJUnit.java:35)
at
org.apache.sling.event.impl.jobs.tasks.Cl
[jira] [Assigned] (SLING-12260) Sling Events does not Build on Java 21
[
https://issues.apache.org/jira/browse/SLING-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-12260:
---
Assignee: Konrad Windszus (was: Rishabh Daim)
> Sling Events does not Build on Java 21
> --
>
> Key: SLING-12260
> URL: https://issues.apache.org/jira/browse/SLING-12260
> Project: Sling
> Issue Type: Bug
> Components: Event
>Affects Versions: Event 4.3.12
> Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Event 4.3.14
>
>
> Attempting to build Sling Events with Java 17 fails with:
> {code:java}
> [main] INFO org.apache.jackrabbit.oak.plugins.index.IndexUpdate - Reindexing
> completed
> [ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.935
> s <<< FAILURE! - in org.apache.sling.event.impl.jobs.queues.TestTopicHalting
> [ERROR]
> org.apache.sling.event.impl.jobs.queues.TestTopicHalting.testUnhalting Time
> elapsed: 1.506 s <<< ERROR!
> java.lang.NoClassDefFoundError: java/security/acl/Group
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
> at
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
>
> {code}
> This class is deprecated for removal in Java 11:
> https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/security/acl/Group.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12260) Sling Events does not Build on Java 21
[
https://issues.apache.org/jira/browse/SLING-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12260:
Fix Version/s: (was: Event 4.3.14)
> Sling Events does not Build on Java 21
> --
>
> Key: SLING-12260
> URL: https://issues.apache.org/jira/browse/SLING-12260
> Project: Sling
> Issue Type: Bug
> Components: Event
>Affects Versions: Event 4.3.14
> Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Attempting to build Sling Events with Java 17 fails with:
> {code:java}
> [main] INFO org.apache.jackrabbit.oak.plugins.index.IndexUpdate - Reindexing
> completed
> [ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.935
> s <<< FAILURE! - in org.apache.sling.event.impl.jobs.queues.TestTopicHalting
> [ERROR]
> org.apache.sling.event.impl.jobs.queues.TestTopicHalting.testUnhalting Time
> elapsed: 1.506 s <<< ERROR!
> java.lang.NoClassDefFoundError: java/security/acl/Group
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
> at
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
>
> {code}
> This class is deprecated for removal in Java 11:
> https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/security/acl/Group.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12260) Sling Events does not Build on Java 21
[
https://issues.apache.org/jira/browse/SLING-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12260:
Reporter: Konrad Windszus (was: Dan Klco)
> Sling Events does not Build on Java 21
> --
>
> Key: SLING-12260
> URL: https://issues.apache.org/jira/browse/SLING-12260
> Project: Sling
> Issue Type: Bug
> Components: Event
>Affects Versions: Event 4.3.12
> Reporter: Konrad Windszus
>Assignee: Rishabh Daim
>Priority: Major
> Fix For: Event 4.3.14
>
>
> Attempting to build Sling Events with Java 17 fails with:
> {code:java}
> [main] INFO org.apache.jackrabbit.oak.plugins.index.IndexUpdate - Reindexing
> completed
> [ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.935
> s <<< FAILURE! - in org.apache.sling.event.impl.jobs.queues.TestTopicHalting
> [ERROR]
> org.apache.sling.event.impl.jobs.queues.TestTopicHalting.testUnhalting Time
> elapsed: 1.506 s <<< ERROR!
> java.lang.NoClassDefFoundError: java/security/acl/Group
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
> at
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
>
> {code}
> This class is deprecated for removal in Java 11:
> https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/security/acl/Group.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12260) Sling Events does not Build on Java 21
[
https://issues.apache.org/jira/browse/SLING-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12260:
Affects Version/s: Event 4.3.14
(was: Event 4.3.12)
> Sling Events does not Build on Java 21
> --
>
> Key: SLING-12260
> URL: https://issues.apache.org/jira/browse/SLING-12260
> Project: Sling
> Issue Type: Bug
> Components: Event
>Affects Versions: Event 4.3.14
> Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Event 4.3.14
>
>
> Attempting to build Sling Events with Java 17 fails with:
> {code:java}
> [main] INFO org.apache.jackrabbit.oak.plugins.index.IndexUpdate - Reindexing
> completed
> [ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.935
> s <<< FAILURE! - in org.apache.sling.event.impl.jobs.queues.TestTopicHalting
> [ERROR]
> org.apache.sling.event.impl.jobs.queues.TestTopicHalting.testUnhalting Time
> elapsed: 1.506 s <<< ERROR!
> java.lang.NoClassDefFoundError: java/security/acl/Group
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
> at
> java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
>
> {code}
> This class is deprecated for removal in Java 11:
> https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/security/acl/Group.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12260) Sling Events does not Build on Java 21
Konrad Windszus created SLING-12260:
---
Summary: Sling Events does not Build on Java 21
Key: SLING-12260
URL: https://issues.apache.org/jira/browse/SLING-12260
Project: Sling
Issue Type: Bug
Components: Event
Affects Versions: Event 4.3.12
Reporter: Dan Klco
Assignee: Rishabh Daim
Fix For: Event 4.3.14
Attempting to build Sling Events with Java 17 fails with:
{code:java}
[main] INFO org.apache.jackrabbit.oak.plugins.index.IndexUpdate - Reindexing
completed
[ERROR] Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1.935 s
<<< FAILURE! - in org.apache.sling.event.impl.jobs.queues.TestTopicHalting
[ERROR] org.apache.sling.event.impl.jobs.queues.TestTopicHalting.testUnhalting
Time elapsed: 1.506 s <<< ERROR!
java.lang.NoClassDefFoundError: java/security/acl/Group
at java.base/java.lang.ClassLoader.defineClass1(Native Method)
at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
at
java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
at
java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:862)
at
java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:760)
at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:681)
at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:639)
{code}
This class is deprecated for removal in Java 11:
https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/security/acl/Group.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-8702) Investigate automatically onboarding Sling projects to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-8702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822539#comment-17822539 ] Konrad Windszus commented on SLING-8702: I see there is https://sonarcloud.io/web_api/api/projects/create?deprecated=false=params. Can this be used with a token that ASF Infra owns [~bellingard]? > Investigate automatically onboarding Sling projects to SonarCloud > - > > Key: SLING-8702 > URL: https://issues.apache.org/jira/browse/SLING-8702 > Project: Sling > Issue Type: Task > Components: Build and Source Control >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > > [~bellingard] - at our last Hackathon we discussed the option of > automatically onboarding projects to SonarCloud as they are created. Is > there an API that we could use for this? Alternatively, can we somehow mark > the repositories in the ASF GitHub org for inclusion? We now have control of > the repository tags, for instance. > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12247) Provide component property type for (External)ResourceChangeListener
[ https://issues.apache.org/jira/browse/SLING-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822538#comment-17822538 ] Konrad Windszus commented on SLING-12247: - [~bellingard] Can you please onboard https://github.com/apache/sling-org-apache-sling-resource-observation-annotations to Sonarcloud? Thanks. > Provide component property type for (External)ResourceChangeListener > > > Key: SLING-12247 > URL: https://issues.apache.org/jira/browse/SLING-12247 > Project: Sling > Issue Type: Improvement > Components: Resource Observation Annotations > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Observation Annotations 1.0.0 > > > In order to ease registration of Sling ResourceChangeListeners a [component > property type > |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types] > should be provided with elements for all supported properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[VOTE] Release Apache Sling Resource Observation Annotations 1.0.0
Hi, We solved 1 issues in this release: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12354378=Text The source code is located in the new repository at https://github.com/apache/sling-org-apache-sling-resource-observation-annotations. Its usage is described in https://github.com/apache/sling-site/pull/157 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2841/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2841 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Thanks in advance for voting, Konrad
[jira] [Resolved] (SLING-12247) Provide component property type for (External)ResourceChangeListener
[ https://issues.apache.org/jira/browse/SLING-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-12247. - Fix Version/s: Resource Observation Annotations 1.0.0 Resolution: Fixed > Provide component property type for (External)ResourceChangeListener > > > Key: SLING-12247 > URL: https://issues.apache.org/jira/browse/SLING-12247 > Project: Sling > Issue Type: Improvement > Components: Resource Observation Annotations > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > Fix For: Resource Observation Annotations 1.0.0 > > > In order to ease registration of Sling ResourceChangeListeners a [component > property type > |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types] > should be provided with elements for all supported properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
ResourceChangeListener behaviour for MOVE operations
Hi, For an edge case outlined at SLING-12245 [0] the resource change listeners are not implemented correctly. Although fixing each change listener would be possible with expensive traversal operations for each “ADDED” event I would rather aim for a solution on a higher level (i.e. on https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java or https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/observation/BasicObservationReporter.java. I would appreciate your input on this as it seems that Carsten was rather in favour of fixing this for every resource change listener individually. I fear that not only the Sling internal resource change listeners are affected but probably almost all downstream consumers as well… Having said that I would also appreciate input on which level to implement the fix: a) Oak level b) Resource Resolver level c) JCR Resource level d) Each ResourceChangeListener individually Thanks in advance, Konrad [0] - https://issues.apache.org/jira/browse/SLING-12245
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822513#comment-17822513
]
Konrad Windszus commented on SLING-12246:
-
I added some more tests in
https://github.com/apache/sling-org-apache-sling-jcr-resource/commit/7660582019bc8b4b0fdda73bdddbde77262159e6
(without modifying the behaviour) to verify which events are currently sent
for the different move operations (including the edge case outlined at
SLING-12245). Since there is no functional change needed in the context of this
ticket closing this as "invalid".
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-12246.
-
Resolution: Invalid
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
> Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (SLING-12252) Remove maven-plugin-annotations from dependencyManagement
[ https://issues.apache.org/jira/browse/SLING-12252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-12252. - Resolution: Fixed [~sjaranowski] Thanks for the PR. I just applied it. Fixed in https://github.com/apache/sling-parent/commit/0bf3676a221c6beea001bea876ca9e50156f5858. > Remove maven-plugin-annotations from dependencyManagement > - > > Key: SLING-12252 > URL: https://issues.apache.org/jira/browse/SLING-12252 > Project: Sling > Issue Type: Task >Reporter: Slawomir Jaranowski > Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 61 > > > dependencyManagement for maven-plugin-annotations is defined in ASF parent > from version 25 - MPOM-288 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12252) Remove maven-plugin-annotations from dependencyManagement
[ https://issues.apache.org/jira/browse/SLING-12252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-12252: --- Assignee: Konrad Windszus > Remove maven-plugin-annotations from dependencyManagement > - > > Key: SLING-12252 > URL: https://issues.apache.org/jira/browse/SLING-12252 > Project: Sling > Issue Type: Task >Reporter: Slawomir Jaranowski > Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 61 > > > dependencyManagement for maven-plugin-annotations is defined in ASF parent > from version 25 - MPOM-288 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12249) Clarify "ADDED" resource changes for ancestor nodes of path
[ https://issues.apache.org/jira/browse/SLING-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-12249. - Fix Version/s: API 2.27.4 Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-api/commit/0b81078c6977afe27d1f3d069456329a34459134. > Clarify "ADDED" resource changes for ancestor nodes of path > --- > > Key: SLING-12249 > URL: https://issues.apache.org/jira/browse/SLING-12249 > Project: Sling > Issue Type: Improvement > Components: API >Affects Versions: API 2.15.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: API 2.27.4 > > > Similar to what was clarified in SLING-6066, events for ancestors of the > registered path may not only be received for "REMOVED" resource changes but > also for "ADDED" resource changes. > This happens e.g. for moving resources with the JCR Resource Provider which > uses internally the semantics from > https://issues.apache.org/jira/browse/OAK-1459?focusedCommentId=13911484=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13911484 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12249) Clarify "ADDED" resource changes for ancestor nodes of path
[ https://issues.apache.org/jira/browse/SLING-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815995#comment-17815995 ] Konrad Windszus commented on SLING-12249: - [~cziegeler] I would appreciate a review on the linked PR. > Clarify "ADDED" resource changes for ancestor nodes of path > --- > > Key: SLING-12249 > URL: https://issues.apache.org/jira/browse/SLING-12249 > Project: Sling > Issue Type: Improvement > Components: API >Affects Versions: API 2.15.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Similar to what was clarified in SLING-6066, events for ancestors of the > registered path may not only be received for "REMOVED" resource changes but > also for "ADDED" resource changes. > This happens e.g. for moving resources with the JCR Resource Provider which > uses internally the semantics from > https://issues.apache.org/jira/browse/OAK-1459?focusedCommentId=13911484=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13911484 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SLING-12237) Extend exception message for RepositoryInitializerFactory with config PID and affected script/reference
[
https://issues.apache.org/jira/browse/SLING-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-12237.
-
Resolution: Fixed
Fixed in
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/7dcdfa8c6ef967ed579703d8f75286357e6debcc.
> Extend exception message for RepositoryInitializerFactory with config PID and
> affected script/reference
> ---
>
> Key: SLING-12237
> URL: https://issues.apache.org/jira/browse/SLING-12237
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.46
>Reporter: Konrad Windszus
> Assignee: Konrad Windszus
>Priority: Major
> Fix For: Repoinit JCR 1.1.48
>
>
> Currently an error in any of the repoinit scripts or reference just lead to
> an exception which does not expose the configuration PID triggering the
> exception, e.g.
> {code}
> javax.jcr.RepositoryException: Applying repoinit operation failed despite
> retry; set loglevel to DEBUG to see all exceptions. Last exception message
> was: Session.save failed: javax.jcr.nodetype.ConstraintViolationException:
> OakConstraint0001: /var/groovyconsole[[nt:folder]]: No matching definition
> found for child node audit with effective type [nt:unstructured]
> at
> org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.applyOperations(RepositoryInitializerFactory.java:176)
> [org.apache.sling.jcr.repoinit:1.1.38]
> {code}
> As repo init scripts are contributed from many different source locations the
> underlying configuration PID should be contained in the exception message as
> well. In addition the index of the according script or the according
> reference URL should be included.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815614#comment-17815614
]
Konrad Windszus edited comment on SLING-12245 at 2/8/24 10:42 AM:
--
This issue affects every ResourceChangeListener! I wouldn't want to implement
such a logic in every implementation.
Some examples:
#
https://github.com/apache/sling-org-apache-sling-i18n/blob/262951b8a778757df0af8495ae71f3f264b8df30/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java#L222
#
https://github.com/apache/sling-org-apache-sling-xss/blob/16bb365c0116374c2a17340242189afb8ad38cd4/src/main/java/org/apache/sling/xss/impl/XSSFilterImpl.java#L372
#
https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/690a818692bd08c3f6a49e842ea530cc3e60e3ad/src/main/java/org/apache/sling/scripting/sightly/impl/engine/ResourceBackedPojoChangeMonitor.java#L75
#
https://github.com/apache/sling-org-apache-sling-event/blob/94680f155e8a88ea6b8f937656bdfd9c9c6a3cea/src/main/java/org/apache/sling/event/impl/jobs/scheduling/JobSchedulerImpl.java#L564
...
was (Author: kwin):
This issue affects every ResourceChangeListener! I wouldn't want to implement
such a logic in every implementation.
Some examples:
#
https://github.com/apache/sling-org-apache-sling-i18n/blob/262951b8a778757df0af8495ae71f3f264b8df30/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java#L222
#
https://github.com/apache/sling-org-apache-sling-xss/blob/16bb365c0116374c2a17340242189afb8ad38cd4/src/main/java/org/apache/sling/xss/impl/XSSFilterImpl.java#L372
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
> Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815612#comment-17815612
]
Konrad Windszus edited comment on SLING-12245 at 2/8/24 10:18 AM:
--
The receiver does not know if it is ADDED event due to a move operation or a
regular ADDED event. Only in the former case a traversal is necessary. If you
do it for every ADDED event outside the path there is a high chance that you
treat the same configuration twice (e.g. when adding a configuration via
content package) which will first trigger an ADDED event on the ancestor as
well followed by the ADDED event on the actual configuration resource. It gets
worse the more levels the ADDED event is away from the actually relevant
resources (traversing each time adds a considerable load in the system and
deduplication will be impossible)
was (Author: kwin):
The receiver does not know if it is ADDED event due to a move operation or a
regular ADDED event. Only in the former case a traversal is necessary. If you
do it for every ADDED event outside the path there is a high chance that you
treat the same configuration twice (e.g. when adding a configuration via
content package) which will first trigger an ADDED event on the ancestor as
well followed by the ADDED event on the actual configuration resource.
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
> Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815612#comment-17815612
]
Konrad Windszus commented on SLING-12245:
-
The receiver does not know if it is ADDED event due to a move operation or a
regular ADDED event. Only in the former case a traversal is necessary. If you
do it for every ADDED event outside the path there is a high chance that you
treat the same configuration twice (e.g. when adding a configuration via
content package) which will first trigger an ADDED event on the ancestor as
well followed by the ADDED event on the actual configuration resource.
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
> Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815608#comment-17815608
]
Konrad Windszus commented on SLING-12245:
-
bq. So isn't the fix to not ignore the event?
This will be hard, as the receiver only receives an ADDED for an ancestor node.
It doesn't know about potentially other following ADDED events. One would need
to traverse the full child nodes (which can be huge e.g. for renamed level 1
nodes) to see if that contains a relevant resource name.
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
> Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12248) Sling IDE Tools 1.2.2 looking for non-existent class, org.eclipse.m2e.core.internal.index.IndexListener
[
https://issues.apache.org/jira/browse/SLING-12248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815589#comment-17815589
]
Konrad Windszus commented on SLING-12248:
-
I think this was fixed in the context of SLING-11590. Please try the latest
nightly
(https://sling.apache.org/documentation/development/ide-tooling.html#update-site-installation).
> Sling IDE Tools 1.2.2 looking for non-existent class,
> org.eclipse.m2e.core.internal.index.IndexListener
> ---
>
> Key: SLING-12248
> URL: https://issues.apache.org/jira/browse/SLING-12248
> Project: Sling
> Issue Type: Bug
> Components: Tooling
>Affects Versions: Sling Eclipse IDE 1.2.2
> Environment: Eclipse 2023-12, Maven 3.8.1, Java 11, AEM 1.3.0, Sling
> IDE Tools 1.2.2
>Reporter: Dat Huynh
>Priority: Blocker
>
> AEM (Adobe Experience Manager) Developer Tool latest version with latest
> Sling IDE tool depends on a non-existent Java class of M2E,
> org.eclipse.m2e.core.internal.index.IndexListener.
> {code:java}
> java.lang.NoClassDefFoundError:
> org/eclipse/m2e/core/internal/index/IndexListener
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027)
> at
> org.eclipse.osgi.internal.loader.ModuleClassLoader.defineClass(ModuleClassLoader.java:283)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.defineClass(ClasspathManager.java:716)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findClassImpl(ClasspathManager.java:639)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClassImpl(ClasspathManager.java:607)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClassImpl(ClasspathManager.java:587)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClass(ClasspathManager.java:566)
> at
> org.eclipse.osgi.internal.loader.ModuleClassLoader.findLocalClass(ModuleClassLoader.java:335)
> at
> org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:397)
> at
> org.eclipse.osgi.internal.loader.BundleLoader.findClass0(BundleLoader.java:500)
> at
> org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:416)
> at
> org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:168)
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewMavenBasedSlingApplicationWizard.addPages(AbstractNewMavenBasedSlingApplicationWizard.java:72)
> at
> org.eclipse.jface.wizard.WizardSelectionPage.getNextPage(WizardSelectionPage.java:119)
> at
> org.eclipse.ui.internal.dialogs.WorkbenchWizardSelectionPage.getNextPage(WorkbenchWizardSelectionPage.java:98)
> at
> org.eclipse.ui.internal.dialogs.NewWizardSelectionPage.advanceToNextPageOrFinish(NewWizardSelectionPage.java:73)
> at
> org.eclipse.ui.internal.dialogs.NewWizardNewPage.lambda$0(NewWizardNewPage.java:342)
> at
> org.eclipse.jface.viewers.StructuredViewer$1.run(StructuredViewer.java:780)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
> at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:174)
> at
> org.eclipse.jface.viewers.StructuredViewer.fireDoubleClick(StructuredViewer.java:777)
> at
> org.eclipse.jface.viewers.AbstractTreeViewer.handleDoubleSelect(AbstractTreeViewer.java:1559)
> at
> org.eclipse.jface.viewers.StructuredViewer$4.widgetDefaultSelected(StructuredViewer.java:1210)
> at
> org.eclipse.jface.util.OpenStrategy.fireDefaultSelectionEvent(OpenStrategy.java:272)
> at
> org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:329)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4273)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1066)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4071)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3659)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:823)
> at org.eclipse.jface.window.Window.open(Window.java:799)
> at org.eclipse.ui.actions.NewProjectAction.run(NewProjectAction.java:119)
> at org.eclipse.jface.action.Action.runWithEvent(Action.java:474)
> at
> org.eclipse.jface.action.ActionCon
[jira] [Updated] (SLING-12248) Sling IDE Tools 1.2.2 looking for non-existent class, org.eclipse.m2e.core.internal.index.IndexListener
[
https://issues.apache.org/jira/browse/SLING-12248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12248:
Affects Version/s: Sling Eclipse IDE 1.2.2
(was: OSGi Feature Maven Plugin 1.8.0)
> Sling IDE Tools 1.2.2 looking for non-existent class,
> org.eclipse.m2e.core.internal.index.IndexListener
> ---
>
> Key: SLING-12248
> URL: https://issues.apache.org/jira/browse/SLING-12248
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Sling Eclipse IDE 1.2.2
> Environment: Eclipse 2023-12, Maven 3.8.1, Java 11, AEM 1.3.0, Sling
> IDE Tools 1.2.2
>Reporter: Dat Huynh
>Priority: Blocker
>
> AEM (Adobe Experience Manager) Developer Tool latest version with latest
> Sling IDE tool depends on a non-existent Java class of M2E,
> org.eclipse.m2e.core.internal.index.IndexListener.
> {code:java}
> java.lang.NoClassDefFoundError:
> org/eclipse/m2e/core/internal/index/IndexListener
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027)
> at
> org.eclipse.osgi.internal.loader.ModuleClassLoader.defineClass(ModuleClassLoader.java:283)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.defineClass(ClasspathManager.java:716)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findClassImpl(ClasspathManager.java:639)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClassImpl(ClasspathManager.java:607)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClassImpl(ClasspathManager.java:587)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClass(ClasspathManager.java:566)
> at
> org.eclipse.osgi.internal.loader.ModuleClassLoader.findLocalClass(ModuleClassLoader.java:335)
> at
> org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:397)
> at
> org.eclipse.osgi.internal.loader.BundleLoader.findClass0(BundleLoader.java:500)
> at
> org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:416)
> at
> org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:168)
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewMavenBasedSlingApplicationWizard.addPages(AbstractNewMavenBasedSlingApplicationWizard.java:72)
> at
> org.eclipse.jface.wizard.WizardSelectionPage.getNextPage(WizardSelectionPage.java:119)
> at
> org.eclipse.ui.internal.dialogs.WorkbenchWizardSelectionPage.getNextPage(WorkbenchWizardSelectionPage.java:98)
> at
> org.eclipse.ui.internal.dialogs.NewWizardSelectionPage.advanceToNextPageOrFinish(NewWizardSelectionPage.java:73)
> at
> org.eclipse.ui.internal.dialogs.NewWizardNewPage.lambda$0(NewWizardNewPage.java:342)
> at
> org.eclipse.jface.viewers.StructuredViewer$1.run(StructuredViewer.java:780)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
> at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:174)
> at
> org.eclipse.jface.viewers.StructuredViewer.fireDoubleClick(StructuredViewer.java:777)
> at
> org.eclipse.jface.viewers.AbstractTreeViewer.handleDoubleSelect(AbstractTreeViewer.java:1559)
> at
> org.eclipse.jface.viewers.StructuredViewer$4.widgetDefaultSelected(StructuredViewer.java:1210)
> at
> org.eclipse.jface.util.OpenStrategy.fireDefaultSelectionEvent(OpenStrategy.java:272)
> at
> org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:329)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4273)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1066)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4071)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3659)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:823)
> at org.eclipse.jface.window.Window.open(Window.java:799)
> at org.eclipse.ui.actions.NewProjectAction.run(NewProjectAction.java:119)
> at org.eclipse.jface.action.Action.runWithEvent(Action.java:474)
> at
> org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:580)
&
[jira] [Updated] (SLING-12248) Sling IDE Tools 1.2.2 looking for non-existent class, org.eclipse.m2e.core.internal.index.IndexListener
[
https://issues.apache.org/jira/browse/SLING-12248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12248:
Component/s: Tooling
(was: Extensions)
> Sling IDE Tools 1.2.2 looking for non-existent class,
> org.eclipse.m2e.core.internal.index.IndexListener
> ---
>
> Key: SLING-12248
> URL: https://issues.apache.org/jira/browse/SLING-12248
> Project: Sling
> Issue Type: Bug
> Components: Tooling
>Affects Versions: Sling Eclipse IDE 1.2.2
> Environment: Eclipse 2023-12, Maven 3.8.1, Java 11, AEM 1.3.0, Sling
> IDE Tools 1.2.2
>Reporter: Dat Huynh
>Priority: Blocker
>
> AEM (Adobe Experience Manager) Developer Tool latest version with latest
> Sling IDE tool depends on a non-existent Java class of M2E,
> org.eclipse.m2e.core.internal.index.IndexListener.
> {code:java}
> java.lang.NoClassDefFoundError:
> org/eclipse/m2e/core/internal/index/IndexListener
> at java.base/java.lang.ClassLoader.defineClass1(Native Method)
> at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027)
> at
> org.eclipse.osgi.internal.loader.ModuleClassLoader.defineClass(ModuleClassLoader.java:283)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.defineClass(ClasspathManager.java:716)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findClassImpl(ClasspathManager.java:639)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClassImpl(ClasspathManager.java:607)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClassImpl(ClasspathManager.java:587)
> at
> org.eclipse.osgi.internal.loader.classpath.ClasspathManager.findLocalClass(ClasspathManager.java:566)
> at
> org.eclipse.osgi.internal.loader.ModuleClassLoader.findLocalClass(ModuleClassLoader.java:335)
> at
> org.eclipse.osgi.internal.loader.BundleLoader.findLocalClass(BundleLoader.java:397)
> at
> org.eclipse.osgi.internal.loader.BundleLoader.findClass0(BundleLoader.java:500)
> at
> org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:416)
> at
> org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:168)
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
> at
> org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewMavenBasedSlingApplicationWizard.addPages(AbstractNewMavenBasedSlingApplicationWizard.java:72)
> at
> org.eclipse.jface.wizard.WizardSelectionPage.getNextPage(WizardSelectionPage.java:119)
> at
> org.eclipse.ui.internal.dialogs.WorkbenchWizardSelectionPage.getNextPage(WorkbenchWizardSelectionPage.java:98)
> at
> org.eclipse.ui.internal.dialogs.NewWizardSelectionPage.advanceToNextPageOrFinish(NewWizardSelectionPage.java:73)
> at
> org.eclipse.ui.internal.dialogs.NewWizardNewPage.lambda$0(NewWizardNewPage.java:342)
> at
> org.eclipse.jface.viewers.StructuredViewer$1.run(StructuredViewer.java:780)
> at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:47)
> at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:174)
> at
> org.eclipse.jface.viewers.StructuredViewer.fireDoubleClick(StructuredViewer.java:777)
> at
> org.eclipse.jface.viewers.AbstractTreeViewer.handleDoubleSelect(AbstractTreeViewer.java:1559)
> at
> org.eclipse.jface.viewers.StructuredViewer$4.widgetDefaultSelected(StructuredViewer.java:1210)
> at
> org.eclipse.jface.util.OpenStrategy.fireDefaultSelectionEvent(OpenStrategy.java:272)
> at
> org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:329)
> at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
> at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4273)
> at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1066)
> at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4071)
> at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3659)
> at org.eclipse.jface.window.Window.runEventLoop(Window.java:823)
> at org.eclipse.jface.window.Window.open(Window.java:799)
> at org.eclipse.ui.actions.NewProjectAction.run(NewProjectAction.java:119)
> at org.eclipse.jface.action.Action.runWithEvent(Action.java:474)
> at
> org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:580)
> at
> org.eclipse.jface.action.ActionContributionItem.lam
[jira] [Comment Edited] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815578#comment-17815578
]
Konrad Windszus edited comment on SLING-12245 at 2/8/24 8:50 AM:
-
Just to clarify: The ResourceChangeListener in
https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L134
is notified both about REMOVED and ADDED *outside* the path (i.e. for the
ancestor node) as the filter method in
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/6cfe4c3cb3a532ebfcabe13ae0028b71fb20996e/src/main/java/org/apache/sling/resourceresolver/impl/observation/BasicObservationReporter.java#L205C39-L205C52
doesn't consider the path restriction at all!
The only difference is that for REMOVED it is also notified about sub resources.
I don't think there is a reasonable fix inside the Sling Rewriter, but rather
this requires a better approach in
https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java
or
https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/src/main/java/org/apache/sling/jcr/resource/internal/JcrListenerBaseConfig.java
to tackle node moves. Any other idea for fixing this except for another flag
for Oak to also emit "NODE_ADDED" events for all moved child nodes?
was (Author: kwin):
Just to clarify: The ResourceChangeListener in
https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L134
is notified both about REMOVED and ADDED *outside* the path (i.e. for the
ancestor node) as the filter method in
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/6cfe4c3cb3a532ebfcabe13ae0028b71fb20996e/src/main/java/org/apache/sling/resourceresolver/impl/observation/BasicObservationReporter.java#L205C39-L205C52
doesn't consider the path restriction at all!
The only difference is that for REMOVED it is also notified about sub resources.
I don't think there is a reasonable fix inside the Sling Rewriter, but rather
this requires a better approach in
https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java
to tackle node moves. Any other idea for fixing this except for another flag
for Oak to also emit "NODE_ADDED" events for all moved child nodes?
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
>Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815578#comment-17815578
]
Konrad Windszus commented on SLING-12245:
-
Just to clarify: The ResourceChangeListener in
https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L134
is notified both about REMOVED and ADDED *outside* the path (i.e. for the
ancestor node) as the filter method in
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/6cfe4c3cb3a532ebfcabe13ae0028b71fb20996e/src/main/java/org/apache/sling/resourceresolver/impl/observation/BasicObservationReporter.java#L205C39-L205C52
doesn't consider the path restriction at all!
The only difference is that for REMOVED it is also notified about sub resources.
I don't think there is a reasonable fix inside the Sling Rewriter, but rather
this requires a better approach in
https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/master/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java
to tackle node moves. Any other idea for fixing this except for another flag
for Oak to also emit "NODE_ADDED" events for all moved child nodes?
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
>Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12249) Clarify "ADDED" resource changes for ancestor nodes of path
[ https://issues.apache.org/jira/browse/SLING-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12249: Description: Similar to what was clarified in SLING-6066, events for ancestors of the registered path may not only be received for "REMOVED" resource changes but also for "ADDED" resource changes. This happens e.g. for moving resources with the JCR Resource Provider which uses internally the semantics from https://issues.apache.org/jira/browse/OAK-1459?focusedCommentId=13911484=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13911484 was: Similar to what was clarified in SLING-6066, events outside the path may not only be received for "REMOVED" resource changes but also for "ADDED" resource changes. This happens e.g. for moving resources with the JCR Resource Provider which uses internally the semantics from https://issues.apache.org/jira/browse/OAK-1459?focusedCommentId=13911484=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13911484 > Clarify "ADDED" resource changes for ancestor nodes of path > --- > > Key: SLING-12249 > URL: https://issues.apache.org/jira/browse/SLING-12249 > Project: Sling > Issue Type: Improvement > Components: API >Affects Versions: API 2.15.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Similar to what was clarified in SLING-6066, events for ancestors of the > registered path may not only be received for "REMOVED" resource changes but > also for "ADDED" resource changes. > This happens e.g. for moving resources with the JCR Resource Provider which > uses internally the semantics from > https://issues.apache.org/jira/browse/OAK-1459?focusedCommentId=13911484=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13911484 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SLING-12249) Clarify "ADDED" resource changes for ancestor nodes of path
Konrad Windszus created SLING-12249: --- Summary: Clarify "ADDED" resource changes for ancestor nodes of path Key: SLING-12249 URL: https://issues.apache.org/jira/browse/SLING-12249 Project: Sling Issue Type: Improvement Components: API Affects Versions: API 2.15.0 Reporter: Konrad Windszus Assignee: Konrad Windszus Similar to what was clarified in SLING-6066, events outside the path may not only be received for "REMOVED" resource changes but also for "ADDED" resource changes. This happens e.g. for moving resources with the JCR Resource Provider which uses internally the semantics from https://issues.apache.org/jira/browse/OAK-1459?focusedCommentId=13911484=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13911484 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815401#comment-17815401
]
Konrad Windszus commented on SLING-12245:
-
[~cziegeler] Do we need another flag in Oak named {{withIncludeAncestorsAdd()}}
similar to {{withIncludeAncestorsRemove}} introduced with OAK-5020? What was
the original reason why only remove was considered in that flag in the first
place?
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
> Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815393#comment-17815393
]
Konrad Windszus edited comment on SLING-12245 at 2/7/24 6:33 PM:
-
Debugging revealed the following:
When renaming a working rewriter pipeline config from
{{/apps/system/config/rewriter2}} to {{/apps/system/config/rewriter}} the
following {{ResourceChange}} is received:
{code}
ResourceChange[type=ADDED, path=/apps/system/config/rewriter, external=false]
{code}
which is ignored in {{ProcessorManagerImpl.onChange(...)}}
However when renaming a working rewriter pipeline config from
{{/apps/system/config/rewriter}} to {{/apps/system/config/rewriter2}} the
following {{ResourceChanges}} are received:
{code}
ResourceChange[type=REMOVED, path=/apps/system/config/rewriter, external=false]
ResourceChange[type=REMOVED, path=/apps/system/config/rewriter/custom,
external=false]
{code}
which leads to removing the config at {{/apps/system/config/rewriter}} in
{{ProcessorManagerImpl.onChange(...)}} (in case it was previously registered).
This is due to the fact how the JCR Event Listener is being registered in
https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrListenerBaseConfig.java#L104.
Looks like the OakEventFilter does not behave synchronously here, i.e. in case
of renames only notifies about each removal of a subtree, but not for the
addition for each addition of a subtree.
was (Author: kwin):
Debugging revealed the following:
When renaming a working rewriter pipeline config from
{{/apps/system/config/rewriter2}} to {{/apps/system/config/rewriter}} the
following {{ResourceChange}} is received:
{code}
ResourceChange[type=ADDED, path=/apps/system/config/rewriter, external=false]
{code}
which is ignored in {{ProcessorManagerImpl.onChange(...)}}
However when renaming a working rewriter pipeline config from
{{/apps/system/config/rewriter}} to {{/apps/system/config/rewriter2}} the
following {{ResourceChanges}} are received:
{code}
ResourceChange[type=REMOVED, path=/apps/system/config/rewriter, external=false]
ResourceChange[type=REMOVED, path=/apps/system/config/rewriter/custom,
external=false]
{code}
which leads to removing the config at {{/apps/system/config/rewriter}} in
{{ProcessorManagerImpl.onChange(...)}} (in case it was previously registered).
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
> Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815393#comment-17815393
]
Konrad Windszus commented on SLING-12245:
-
Debugging revealed the following:
When renaming a working rewriter pipeline config from
{{/apps/system/config/rewriter2}} to {{/apps/system/config/rewriter}} the
following {{ResourceChange}} is received:
{code}
ResourceChange[type=ADDED, path=/apps/system/config/rewriter, external=false]
{code}
which is ignored in {{ProcessorManagerImpl.onChange(...)}}
However when renaming a working rewriter pipeline config from
{{/apps/system/config/rewriter}} to {{/apps/system/config/rewriter2}} the
following {{ResourceChanges}} are received:
{code}
ResourceChange[type=REMOVED, path=/apps/system/config/rewriter, external=false]
ResourceChange[type=REMOVED, path=/apps/system/config/rewriter/custom,
external=false]
{code}
which leads to removing the config at {{/apps/system/config/rewriter}} in
{{ProcessorManagerImpl.onChange(...)}} (in case it was previously registered).
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
> Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12247) Provide component property type for (External)ResourceChangeListener
[ https://issues.apache.org/jira/browse/SLING-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-12247: Component/s: Resource Observation Annotations > Provide component property type for (External)ResourceChangeListener > > > Key: SLING-12247 > URL: https://issues.apache.org/jira/browse/SLING-12247 > Project: Sling > Issue Type: Improvement > Components: Resource Observation Annotations > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > > In order to ease registration of Sling ResourceChangeListeners a [component > property type > |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types] > should be provided with elements for all supported properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815320#comment-17815320
]
Konrad Windszus commented on SLING-12246:
-
Indeed {{Session.move()}} always emits "NODE_DELETE" and "NODE_ADDED" for the
root paths in Oak. There is no event currently emitted for
{{Node.orderBefore(...)}} (only a "NODE_MOVED") is sent for that operation).
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12247) Provide component property type for (External)ResourceChangeListener
[ https://issues.apache.org/jira/browse/SLING-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815248#comment-17815248 ] Konrad Windszus commented on SLING-12247: - I created the new repo https://github.com/apache/sling-org-apache-sling-resource-observation-annotations for it. > Provide component property type for (External)ResourceChangeListener > > > Key: SLING-12247 > URL: https://issues.apache.org/jira/browse/SLING-12247 > Project: Sling > Issue Type: Improvement > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > > In order to ease registration of Sling ResourceChangeListeners a [component > property type > |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types] > should be provided with elements for all supported properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12247) Provide component property type for (External)ResourceChangeListener
[ https://issues.apache.org/jira/browse/SLING-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814800#comment-17814800 ] Konrad Windszus commented on SLING-12247: - I added an initial proposal to https://github.com/apache/sling-whiteboard/tree/feature/resourcechangelistener-annotations. [~cziegeler] Can you have a look? > Provide component property type for (External)ResourceChangeListener > > > Key: SLING-12247 > URL: https://issues.apache.org/jira/browse/SLING-12247 > Project: Sling > Issue Type: Improvement > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > > In order to ease registration of Sling ResourceChangeListeners a [component > property type > |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types] > should be provided with elements for all supported properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SLING-12247) Provide component property type for (External)ResourceChangeListener
[ https://issues.apache.org/jira/browse/SLING-12247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus reassigned SLING-12247: --- Assignee: Konrad Windszus > Provide component property type for (External)ResourceChangeListener > > > Key: SLING-12247 > URL: https://issues.apache.org/jira/browse/SLING-12247 > Project: Sling > Issue Type: Improvement > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > > In order to ease registration of Sling ResourceChangeListeners a [component > property type > |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types] > should be provided with elements for all supported properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814718#comment-17814718
]
Konrad Windszus commented on SLING-12246:
-
Let me verify with an IT, but I think at least rename operations (i.e. moves
not changing the level nor parent node) do not emit NODE_ADDED and NODE_REMOVED.
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
> Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814716#comment-17814716
]
Konrad Windszus commented on SLING-12246:
-
bq. event as a add/remove events were sent in addition anyway.
That contradicts the description in
https://jackrabbit.apache.org/oak/docs/differences.html#observation and also I
have at least one use case which was not working correctly: SLING-12245.
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
> Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12247) Provide component property type for (External)ResourceChangeListener
Konrad Windszus created SLING-12247: --- Summary: Provide component property type for (External)ResourceChangeListener Key: SLING-12247 URL: https://issues.apache.org/jira/browse/SLING-12247 Project: Sling Issue Type: Improvement Reporter: Konrad Windszus In order to ease registration of Sling ResourceChangeListeners a [component property type |https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-component.property.types] should be provided with elements for all supported properties. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12246:
Description:
Currently the event type NODE_MOVED
(https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
is not supported in {{JcrResourceListener}}
(https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
Although the support in Oak is limited
(https://jackrabbit.apache.org/oak/docs/differences.html#observation) the even
type is still used.
IMHO it should be translated into two {{ResourceChange}} events:
# one change on the source path
# one change on the destination path
The path handling for
https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
must be the same as for remove events (i.e. changed parent paths will also
trigger it)
was:
Currently the event type NODE_MOVED
(https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
is not supported in {{JcrResourceListener}}
(https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
Although the support in Oak is limited
(https://jackrabbit.apache.org/oak/docs/differences.html#observation) the even
type is still used.
IMHO it should be translated into two {{ResourceChange}} events:
# one change on the source path
# one change on the destination path
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
> Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
> The path handling for
> https://sling.apache.org/apidocs/sling12/org/apache/sling/api/resource/observation/ResourceChangeListener.html#PATHS
> must be the same as for remove events (i.e. changed parent paths will also
> trigger it)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12246:
Description:
Currently the event type NODE_MOVED
(https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
is not supported in {{JcrResourceListener}}
(https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
Although the support in Oak is limited
(https://jackrabbit.apache.org/oak/docs/differences.html#observation) the even
type is still used.
IMHO it should be translated into two {{ResourceChange}} events:
# one change on the source path
# one change on the destination path
was:
Currently the event type NODE_MOVED
(https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
is not supported in {{JcrResourceListener}}
(https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
Although the support in Oak is limited
(https://jackrabbit.apache.org/oak/docs/differences.html#observation) the even
type is still used.
IMHO it should be translated into two ResourceChanged events:
# one change on the source path
# one change on the destination path
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
> Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two {{ResourceChange}} events:
> # one change on the source path
> # one change on the destination path
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
[
https://issues.apache.org/jira/browse/SLING-12246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12246:
Description:
Currently the event type NODE_MOVED
(https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
is not supported in {{JcrResourceListener}}
(https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
Although the support in Oak is limited
(https://jackrabbit.apache.org/oak/docs/differences.html#observation) the even
type is still used.
IMHO it should be translated into two ResourceChanged events:
# one change on the source path
# one change on the destination path
was:
Currently the event type NODE_MOVED
(https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
is not supported in {{JcrResourceListener}}
(https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
Although the support in Oak is limited
(https://jackrabbit.apache.org/oak/docs/differences.html#observation) the even
type is still used.
> Support Event.NODE_MOVED in JcrResourceListener
> ---
>
> Key: SLING-12246
> URL: https://issues.apache.org/jira/browse/SLING-12246
> Project: Sling
> Issue Type: Improvement
> Components: JCR
>Affects Versions: JCR Resource 3.2.4
> Reporter: Konrad Windszus
>Priority: Major
>
> Currently the event type NODE_MOVED
> (https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
> is not supported in {{JcrResourceListener}}
> (https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
> Although the support in Oak is limited
> (https://jackrabbit.apache.org/oak/docs/differences.html#observation) the
> even type is still used.
> IMHO it should be translated into two ResourceChanged events:
> # one change on the source path
> # one change on the destination path
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12246) Support Event.NODE_MOVED in JcrResourceListener
Konrad Windszus created SLING-12246:
---
Summary: Support Event.NODE_MOVED in JcrResourceListener
Key: SLING-12246
URL: https://issues.apache.org/jira/browse/SLING-12246
Project: Sling
Issue Type: Improvement
Components: JCR
Affects Versions: JCR Resource 3.2.4
Reporter: Konrad Windszus
Currently the event type NODE_MOVED
(https://developer.adobe.com/experience-manager/reference-materials/spec/jcr/2.0/12_Observation.html#12.3.3%20Event%20Information%20on%20Move%20and%20Order)
is not supported in {{JcrResourceListener}}
(https://github.com/apache/sling-org-apache-sling-jcr-resource/blob/8fb5a3d44de01f05964028debcf24531f2f65747/src/main/java/org/apache/sling/jcr/resource/internal/JcrResourceListener.java#L117).
Although the support in Oak is limited
(https://jackrabbit.apache.org/oak/docs/differences.html#observation) the even
type is still used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
[
https://issues.apache.org/jira/browse/SLING-12245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12245:
Affects Version/s: Rewriter 1.3.10
> Sling Rewriter does not detect configuration changes coming in via move
> ---
>
> Key: SLING-12245
> URL: https://issues.apache.org/jira/browse/SLING-12245
> Project: Sling
> Issue Type: Improvement
>Affects Versions: Rewriter 1.3.10
> Reporter: Konrad Windszus
>Priority: Major
>
> If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
> {{/apps/my/config/rewriter}} the new rewriter configuration is not being
> detected by the {{ProcessorManagerImpl}} due to the
> {{ResourceChangeListener}} only being configured to listen for changes below
> the {{rewriter}} resource
> (https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SLING-12245) Sling Rewriter does not detect configuration changes coming in via move
Konrad Windszus created SLING-12245:
---
Summary: Sling Rewriter does not detect configuration changes
coming in via move
Key: SLING-12245
URL: https://issues.apache.org/jira/browse/SLING-12245
Project: Sling
Issue Type: Improvement
Reporter: Konrad Windszus
If one renames/moves a JCR node from {{/apps/my/config/invalid-rewriter}} to
{{/apps/my/config/rewriter}} the new rewriter configuration is not being
detected by the {{ProcessorManagerImpl}} due to the {{ResourceChangeListener}}
only being configured to listen for changes below the {{rewriter}} resource
(https://github.com/apache/sling-org-apache-sling-rewriter/blob/4d1952648e35e7001236f282040a78479f7726d4/src/main/java/org/apache/sling/rewriter/impl/ProcessorManagerImpl.java#L69).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12163) Update ASF Parent to 31
[ https://issues.apache.org/jira/browse/SLING-12163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-12163. --- > Update ASF Parent to 31 > --- > > Key: SLING-12163 > URL: https://issues.apache.org/jira/browse/SLING-12163 > Project: Sling > Issue Type: Improvement > Components: General > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 60 (Java 11) > > > https://github.com/apache/maven-apache-parent/releases/tag/apache-31 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12186) Automatic code formatting with spotless-maven-plugin
[
https://issues.apache.org/jira/browse/SLING-12186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus closed SLING-12186.
---
> Automatic code formatting with spotless-maven-plugin
>
>
> Key: SLING-12186
> URL: https://issues.apache.org/jira/browse/SLING-12186
> Project: Sling
> Issue Type: Improvement
> Components: General
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 60 (Java 11)
>
>
> As discussed in
> https://lists.apache.org/thread/t32o425mttoftfr622wkvp4s5br4wzt1 we should
> introduce
> [spotless-maven-plugin|https://github.com/diffplug/spotless/tree/main/plugin-maven]
> to enforce a common code formatting similar to what was done for Maven in
> https://issues.apache.org/jira/browse/MPOM-349.
> With each reformatting a {{.git-blame-ignore-revs}} should be added/enriched
> which is considered by git blame in GitHub
> (https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)
> and optionally with Git CLI
> (https://git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt).
>
> I propose to reuse the following configuration files from Apache Maven Shared
> Resources
> *
> https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/maven-eclipse-importorder.txt
> *
> https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/maven-header-plain.txt
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12080) Update to Bnd 7.0 and require at least Java 17 for build
[ https://issues.apache.org/jira/browse/SLING-12080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-12080. --- > Update to Bnd 7.0 and require at least Java 17 for build > > > Key: SLING-12080 > URL: https://issues.apache.org/jira/browse/SLING-12080 > Project: Sling > Issue Type: Improvement > Components: General > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > Fix For: Bundle Parent 60 (Java 17) > > > Bnd 7.0 (https://github.com/bndtools/bnd/wiki/Changes-in-7.0.0) is out and > requires Java 17 for build. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12207) Use adjusted inheritance rules for URLs
[
https://issues.apache.org/jira/browse/SLING-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus closed SLING-12207.
---
> Use adjusted inheritance rules for URLs
> ---
>
> Key: SLING-12207
> URL: https://issues.apache.org/jira/browse/SLING-12207
> Project: Sling
> Issue Type: Bug
> Components: General
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 60 (Java 11)
>
>
> For Sling projects the default inheritance rules for URLs are not applicable:
> https://maven.apache.org/ref/3.8.4/maven-model-builder/index.html#Inheritance_Assembly.
> Therefore the dedicated attribute {{@child.project.url.inherit.append.path}}
> should be set to {{false}} (requires Maven 3.6.1 or newer,
> https://issues.apache.org/jira/browse/MNG-6059).
> Also the SCM element and children should be moved to the profile only active
> when the parent pom is built (as they are never applicable as is to derived
> modules).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SLING-12170) Update Jacoco to 0.8.11
[ https://issues.apache.org/jira/browse/SLING-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-12170. --- > Update Jacoco to 0.8.11 > --- > > Key: SLING-12170 > URL: https://issues.apache.org/jira/browse/SLING-12170 > Project: Sling > Issue Type: Improvement > Components: General > Reporter: Konrad Windszus > Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 60 (Java 11) > > > https://www.eclemma.org/jacoco/trunk/doc/changes.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SLING-12131) Update sling-parent pom.xml to include JUnit5 dependencies
[ https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus closed SLING-12131. --- > Update sling-parent pom.xml to include JUnit5 dependencies > -- > > Key: SLING-12131 > URL: https://issues.apache.org/jira/browse/SLING-12131 > Project: Sling > Issue Type: Task >Reporter: Rob McDougall >Assignee: Rob McDougall >Priority: Major > Fix For: Parent 60 (Java 11) > > > JUnit4 is in maintenance mode (no updates in the last 2 years and then only > security fixes). I think updating projects to JUnit5 should be encouraged. > I am thinking this should be a relatively easy change of adding the > junit-jupiter and junit-vintage-engine into the Dependency Management section > of the sling-parent. > Once this is done, individual projects could switch to the vintage-engine (at > the very least) or move to jupiter by switching the dependency in their > project pom. > Some day down the road, the JUnit 4 dependencies could be removed. Projects > that have not updated to JUnit5 (vintage or jupiter) by that time are likely > no longer maintained. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[RESULT] [VOTE] Release Apache Sling Parent and Bundle Parent version 60
Hi, The vote has passed with the following result : +1 (binding): Stefan, Robert and Jörg. I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Thanks for voting, Konrad > On 30. Jan 2024, at 14:27, Konrad Windszus wrote: > > Hi, > > We solved some issues in this release: > > Sling Parent 60: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353433=Text > > Sling Bundle Parent 60: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353434=Text > > > Some important hints to consider when upgrading to that version are available > at https://cwiki.apache.org/confluence/x/SI75E. > These releases increase the minimum Java build version to 11/17 and introduce > automated code formatting with spotless-maven-plugin. > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2836/ > > You can use this UNIX script to download the release and verify the > signatures: > https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh > > Usage: sh check_staged_release.sh 2836 /tmp/sling-staging > > Please vote to approve this release: > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because … > > This majority vote is open for at least 72 hours. > > Thanks, > Konrad
[VOTE] Release Apache Sling Parent and Bundle Parent version 60
Hi, We solved some issues in this release: Sling Parent 60: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353433=Text Sling Bundle Parent 60: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12353434=Text Some important hints to consider when upgrading to that version are available at https://cwiki.apache.org/confluence/x/SI75E. These releases increase the minimum Java build version to 11/17 and introduce automated code formatting with spotless-maven-plugin. Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2836/ You can use this UNIX script to download the release and verify the signatures: https://raw.githubusercontent.com/apache/sling-tooling-release/master/check_staged_release.sh Usage: sh check_staged_release.sh 2836 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because … This majority vote is open for at least 72 hours. Thanks, Konrad
[jira] [Updated] (SLING-11968) Use renovate to keep plug-in versions updated
[ https://issues.apache.org/jira/browse/SLING-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-11968: Fix Version/s: Parent 61 (was: Parent 60 (Java 11)) > Use renovate to keep plug-in versions updated > - > > Key: SLING-11968 > URL: https://issues.apache.org/jira/browse/SLING-11968 > Project: Sling > Issue Type: Improvement > Components: Build and Source Control >Reporter: Robert Munteanu >Priority: Major > Fix For: Parent 61 > > > A lot of the work on the parent git repository is about keeping versions of > maven plug-ins and other toos like bnd updated. > This sounds like an opportunity to automate the version updates with > renovate. However, we need to add some integration tests first to make sure > we don't break anything. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Sling Model Caching & GC problems
Sorry, yes, I see it now. Seems that Gmail has some issues and delivers some mails very delayed only (I only saw Carsten’s mail). Will check next time in the archives. Konrad > On 30. Jan 2024, at 10:45, Stefan Seifert > wrote: > >> @Joerg: Pauls mail never hit the mailing list. Can you forward it? > > must be a problem on you side - it's in the archives: > https://lists.apache.org/thread/xj6qosnjtgxvdf1lh58zs1bv5lh0y0q6 > > stefan
Re: Sling Model Caching & GC problems
@Joerg: Pauls mail never hit the mailing list. Can you forward it? > On 30. Jan 2024, at 10:28, Jörg Hoh wrote: > > Paul, > > thanks for your mail. I agree to your observation what's going on. I also > think that cache at the ResourceResolver level makes more sense, and it's > easier to control and remove cached models, which cannot be used any more. > > @Carsten: Regarding the size, we can still use a WeakHashMap as a container > for these Sling Models (and store the WeakHashMap in the PropertyMap of the > ResourceResolver), and that should prevent the worst, even in case of a > long-running ResourceResolver or many adaptions. > > Jörg > > > Am Di., 30. Jan. 2024 um 07:16 Uhr schrieb Carsten Ziegeler < > cziege...@apache.org>: > >> I don't know much about sling models caching, but it seems storing the >> cache into the resource resolver and therefore binding it to that >> lifecycle sounds very reasonable to me. And due to the mentioned support >> for Closeable, the cache gets discarded automatically with the resolver >> being closed. No extra handling required, no soft references etc. needed. >> >> Obviously, that sounds problematic with long or forever running resource >> resolvers as the cache would never be released. However, I guess thats >> not worse than what we have today. And long running resource resolvers >> are an anti-pattern anyway. >> >> Regards >> Carsten >> >> On 23.01.2024 17:23, Paul Bjorkstrand wrote: >>> Hi Jörg, >>> >>> My guess is that you are running up against the problem where the Model >> is >>> referencing its adaptable, directly or indirectly. In that situation, the >>> model would not be collectable because it is referenced more strongly >> than >>> by weak reference. The reference path of these might look like this: >>> >>> Model Cache Holder (the Model Adapter Factory >>> (strong reference) >>> Model Cache >>> (soft reference) >>> Model >>> (strong reference) >>> Resource Resolver >>> (strong reference, maybe indirectly) >>> Resource [the adaptable] >>> >>> >>> The resource is strongly or softly referenced, possibly indirectly, >> making >>> it ineligible for collection on normal GC cycles. The resource & >> resolver, >>> will not be collected until after the model is collected. Since the model >>> is not collected until there is memory pressure, that would explain why >> you >>> are seeing this (expensive) GC behavior. >>> >>> When memory pressure occurs, first the models (soft references) are >>> collected prior to the OOM, which releases both resolver (no longer >>> referenced via field in the model) and resource. >>> >>> The quickest fix is to release the resource resolver at the end of the >>> model’s constructor or @PostConstruct [2]. Alternatively, you can >> eliminate >>> the cache=true, provided it does not negatively impact your application >>> performance. >>> Another option, though more involved, is that the entire caching impl >> could >>> be changed to better handle these kinds of reference loops, by putting >> the >>> cache in the adaptable itself (Resolver, Resource, Request, etc). >> Possible >>> good candidates of these are [4] or request attributes. [4] seems to be >> the >>> overall best candidate, especially since you can hook into it using >>> Closeable ([5]) improving the cache eviction even more. >>> >>> As long as the object holding the cache is not referenced strongly >> outside >>> that reference loop (cache holder > cache > model > ... > cache holder), >>> then the loop's objects would be eligible for GC as soon as the cache >>> holder is eligible. >>> >>> [1]: >>> >> https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/ref/SoftReference.html >>> [2]: >>> >> https://sling.apache.org/documentation/bundles/models.html#a-note-about-cache-true-and-using-the-self-injector >>> [3]: >> https://github.com/apache/sling-org-apache-sling-models-impl/pull/18 >>> [4]: >>> >> https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L888 >>> [5]: >>> >> https://github.com/apache/sling-org-apache-sling-api/blob/master/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L610 >>> >>> // Paul >>> >>> >>> On Tue, Jan 23, 2024 at 6:48 AM Jörg Hoh > .invalid> >>> wrote: >>> Hi Sling community, I want to share a recent experience I had with Sling Models, Sling Model caching and Garbage Collection problems. I had a case, where an AEM instance had massive garbage collection problems, but no memory problems. We saw the regular sawtooth pattern in the heap consumption, but heavy GC activity (in a stop-the-world manner) almost constantly. But no OutOfMemory situation, there it's not a memory leak. I manually captured a heapdump and found a lot of Sling models being referenced by the Sling ModelAdapterFactory cache, and rechecking these model classes in detail I found
[jira] [Commented] (SLING-11906) Migrate to slf4j 2.x
[
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810474#comment-17810474
]
Konrad Windszus commented on SLING-11906:
-
The fix in SLF4J 2.0.11 only exports {{org.slf4j.helpers}} in a backwards
compatible way. I think we should get rid of imports towards {{org.sl4j.event}}
as that was IMHO never devised as stable API (but only supposed to be used
internally).
> Migrate to slf4j 2.x
>
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
> Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported
> packages, so it should hopefully be compatible with existing bundles that are
> importing the 1.x version of the slf4j packages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (SLING-11906) Migrate to slf4j 2.x
[
https://issues.apache.org/jira/browse/SLING-11906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810474#comment-17810474
]
Konrad Windszus edited comment on SLING-11906 at 1/24/24 3:57 PM:
--
The fix in SLF4J 2.0.11 only exports {{org.slf4j.helpers}} in a backwards
compatible way
(https://github.com/qos-ch/slf4j/commit/02b36a269a9b13dac435699839f3200529dd0e10).
I think we should get rid of imports towards {{org.sl4j.event}} as that was
IMHO never devised as stable API (but only supposed to be used internally).
was (Author: kwin):
The fix in SLF4J 2.0.11 only exports {{org.slf4j.helpers}} in a backwards
compatible way. I think we should get rid of imports towards {{org.sl4j.event}}
as that was IMHO never devised as stable API (but only supposed to be used
internally).
> Migrate to slf4j 2.x
>
>
> Key: SLING-11906
> URL: https://issues.apache.org/jira/browse/SLING-11906
> Project: Sling
> Issue Type: Improvement
>Reporter: Eric Norman
>Priority: Major
> Fix For: Commons Log 6.0.0
>
>
> Increasingly more libraries have been migrating to slf4j 2.x (for example
> logback 1.3+, tika 2.5+ and jetty 10+)
> To be compatible with those, the sling commons log bundle should migrate to
> slf4j v2.x (and logback v1.4.x or v1.3.x?)
> It looks like slf4j 2.x exports both 2.x and 1.7.36 versions of the exported
> packages, so it should hopefully be compatible with existing bundles that are
> importing the 1.x version of the slf4j packages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [RESULT] [VOTE] Release Apache Resource Resolver 1.11.6
Done, please update the site accordingly. Thanks, Konrad > On 23. Jan 2024, at 11:23, Julian Reschke wrote: > > On 22.01.2024 17:25, Julian Reschke wrote: >> On 22.01.2024 10:20, Julian Reschke wrote: >>> On 17.01.2024 07:51, Julian Reschke wrote: >>>> ... >>> >>> Hi, >>> >>> The vote has passed with the following result : >>> >>> +1 (binding): Bertrand Delacretaz , Julian >>> Reschke , Konrad Windszus , >>> Robert Munteanu >>> >>> I will copy this release to the Sling dist directory and >>> promote the artifacts to the central Maven repository. >>> >>> Best regards, Julian >> >> OK, I will need help with promoting the release (I'm committer but not >> PMC member, thus have no write access to the SVN repo). >> >> Best regards, Julian > > Hi, > > FYI: Konrad has volunteered to do the release promotion; thanks for that. > > Best regards, Julian
[jira] [Updated] (SLING-12237) Extend exception message for RepositoryInitializerFactory with config PID and affected script/reference
[
https://issues.apache.org/jira/browse/SLING-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12237:
Description:
Currently an error in any of the repoinit scripts or reference just lead to an
exception which does not expose the configuration PID triggering the exception,
e.g.
{code}
javax.jcr.RepositoryException: Applying repoinit operation failed despite
retry; set loglevel to DEBUG to see all exceptions. Last exception message was:
Session.save failed: javax.jcr.nodetype.ConstraintViolationException:
OakConstraint0001: /var/groovyconsole[[nt:folder]]: No matching definition
found for child node audit with effective type [nt:unstructured]
at
org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.applyOperations(RepositoryInitializerFactory.java:176)
[org.apache.sling.jcr.repoinit:1.1.38]
{code}
As repo init scripts are contributed from many different source locations the
underlying configuration PID should be contained in the exception message as
well. In addition the index of the according script or the according reference
URL should be included.
was:
Currently an error in any of the repoinit scripts or reference just lead to an
exception which does not expose the configuration PID triggering the exception,
e.g.
{code}
javax.jcr.RepositoryException: Applying repoinit operation failed despite
retry; set loglevel to DEBUG to see all exceptions. Last exception message was:
Session.save failed: javax.jcr.nodetype.ConstraintViolationException:
OakConstraint0001: /var/groovyconsole[[nt:folder]]: No matching definition
found for child node audit with effective type [nt:unstructured]
at
org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.applyOperations(RepositoryInitializerFactory.java:176)
[org.apache.sling.jcr.repoinit:1.1.38]
{code}
As repo init scripts are contributed by many different suppliers the underlying
configuration PID should be contained in the exception message as well. In
addition the index of the according script or the according reference URL
should be included.
> Extend exception message for RepositoryInitializerFactory with config PID and
> affected script/reference
> ---
>
> Key: SLING-12237
> URL: https://issues.apache.org/jira/browse/SLING-12237
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.46
>Reporter: Konrad Windszus
> Assignee: Konrad Windszus
>Priority: Major
> Fix For: Repoinit JCR 1.1.48
>
>
> Currently an error in any of the repoinit scripts or reference just lead to
> an exception which does not expose the configuration PID triggering the
> exception, e.g.
> {code}
> javax.jcr.RepositoryException: Applying repoinit operation failed despite
> retry; set loglevel to DEBUG to see all exceptions. Last exception message
> was: Session.save failed: javax.jcr.nodetype.ConstraintViolationException:
> OakConstraint0001: /var/groovyconsole[[nt:folder]]: No matching definition
> found for child node audit with effective type [nt:unstructured]
> at
> org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.applyOperations(RepositoryInitializerFactory.java:176)
> [org.apache.sling.jcr.repoinit:1.1.38]
> {code}
> As repo init scripts are contributed from many different source locations the
> underlying configuration PID should be contained in the exception message as
> well. In addition the index of the according script or the according
> reference URL should be included.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (SLING-12237) Extend exception message for RepositoryInitializerFactory with config PID and affected script/reference
[
https://issues.apache.org/jira/browse/SLING-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-12237:
---
Assignee: Konrad Windszus
> Extend exception message for RepositoryInitializerFactory with config PID and
> affected script/reference
> ---
>
> Key: SLING-12237
> URL: https://issues.apache.org/jira/browse/SLING-12237
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.46
>Reporter: Konrad Windszus
> Assignee: Konrad Windszus
>Priority: Major
> Fix For: Repoinit JCR 1.1.48
>
>
> Currently an error in any of the repoinit scripts or reference just lead to
> an exception which does not expose the configuration PID triggering the
> exception, e.g.
> {code}
> javax.jcr.RepositoryException: Applying repoinit operation failed despite
> retry; set loglevel to DEBUG to see all exceptions. Last exception message
> was: Session.save failed: javax.jcr.nodetype.ConstraintViolationException:
> OakConstraint0001: /var/groovyconsole[[nt:folder]]: No matching definition
> found for child node audit with effective type [nt:unstructured]
> at
> org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.applyOperations(RepositoryInitializerFactory.java:176)
> [org.apache.sling.jcr.repoinit:1.1.38]
> {code}
> As repo init scripts are contributed by many different suppliers the
> underlying configuration PID should be contained in the exception message as
> well. In addition the index of the according script or the according
> reference URL should be included.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12237) Extend exception message for RepositoryInitializerFactory with config PID and affected script/reference
[
https://issues.apache.org/jira/browse/SLING-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12237:
Description:
Currently an error in any of the repoinit scripts or reference just lead to an
exception which does not expose the configuration PID triggering the exception,
e.g.
{code}
javax.jcr.RepositoryException: Applying repoinit operation failed despite
retry; set loglevel to DEBUG to see all exceptions. Last exception message was:
Session.save failed: javax.jcr.nodetype.ConstraintViolationException:
OakConstraint0001: /var/groovyconsole[[nt:folder]]: No matching definition
found for child node audit with effective type [nt:unstructured]
at
org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.applyOperations(RepositoryInitializerFactory.java:176)
[org.apache.sling.jcr.repoinit:1.1.38]
{code}
As repo init scripts are contributed by many different suppliers the underlying
configuration PID should be contained in the exception message as well. In
addition the index of the according script or the according reference URL
should be included.
was:
Currently an error in any of the repoinit scripts or reference just lead to an
exception which does not expose the configuration PID triggering the exception,
e.g.
{code}
javax.jcr.RepositoryException: Applying repoinit operation failed despite
retry; set loglevel to DEBUG to see all exceptions. Last exception message was:
Session.save failed: javax.jcr.nodetype.ConstraintViolationException:
OakConstraint0001: /var/groovyconsole[[nt:folder]]: No matching definition
found for child node audit with effective type [nt:unstructured]
at
org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.applyOperations(RepositoryInitializerFactory.java:176)
[org.apache.sling.jcr.repoinit:1.1.38]
{code}
As repo init scripts are contributed by many different suppliers the underlying
configuration PID should be contained in the exception message as well.
> Extend exception message for RepositoryInitializerFactory with config PID and
> affected script/reference
> ---
>
> Key: SLING-12237
> URL: https://issues.apache.org/jira/browse/SLING-12237
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.46
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Repoinit JCR 1.1.48
>
>
> Currently an error in any of the repoinit scripts or reference just lead to
> an exception which does not expose the configuration PID triggering the
> exception, e.g.
> {code}
> javax.jcr.RepositoryException: Applying repoinit operation failed despite
> retry; set loglevel to DEBUG to see all exceptions. Last exception message
> was: Session.save failed: javax.jcr.nodetype.ConstraintViolationException:
> OakConstraint0001: /var/groovyconsole[[nt:folder]]: No matching definition
> found for child node audit with effective type [nt:unstructured]
> at
> org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.applyOperations(RepositoryInitializerFactory.java:176)
> [org.apache.sling.jcr.repoinit:1.1.38]
> {code}
> As repo init scripts are contributed by many different suppliers the
> underlying configuration PID should be contained in the exception message as
> well. In addition the index of the according script or the according
> reference URL should be included.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SLING-12237) Extend exception message for RepositoryInitializerFactory with config PID and script/reference
[
https://issues.apache.org/jira/browse/SLING-12237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-12237:
Summary: Extend exception message for RepositoryInitializerFactory with
config PID and script/reference (was: Extend exception message for
RepositoryInitializerFactory with config PID)
> Extend exception message for RepositoryInitializerFactory with config PID and
> script/reference
> --
>
> Key: SLING-12237
> URL: https://issues.apache.org/jira/browse/SLING-12237
> Project: Sling
> Issue Type: Improvement
> Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.46
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Repoinit JCR 1.1.48
>
>
> Currently an error in any of the repoinit scripts or reference just lead to
> an exception which does not expose the configuration PID triggering the
> exception, e.g.
> {code}
> javax.jcr.RepositoryException: Applying repoinit operation failed despite
> retry; set loglevel to DEBUG to see all exceptions. Last exception message
> was: Session.save failed: javax.jcr.nodetype.ConstraintViolationException:
> OakConstraint0001: /var/groovyconsole[[nt:folder]]: No matching definition
> found for child node audit with effective type [nt:unstructured]
> at
> org.apache.sling.jcr.repoinit.impl.RepositoryInitializerFactory.applyOperations(RepositoryInitializerFactory.java:176)
> [org.apache.sling.jcr.repoinit:1.1.38]
> {code}
> As repo init scripts are contributed by many different suppliers the
> underlying configuration PID should be contained in the exception message as
> well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
