[jira] [Commented] (SLING-11532) Remove old relocation artifact maven-sling-plugin

2022-08-12 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578980#comment-17578980
 ] 

Konrad Windszus commented on SLING-11532:
-

For me removing the relocation artifact is not a breaking change, but anyhow 
the other changes included in the next release warrant a 3.0 release for me as 
well :)

> Remove old relocation artifact maven-sling-plugin
> -
>
> Key: SLING-11532
> URL: https://issues.apache.org/jira/browse/SLING-11532
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Sling Maven Plugin 2.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 2.5.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In SLING-8204 a new artifact has been introduced with artifactId 
> {{sling-maven-plugin}} and the old artifactId {{maven-sling-plugin}} just 
> contains the relocation information.
> According to 
> https://maven.apache.org/guides/mini/guide-relocation.html#releasing-the-next-version
>  it is not necessary to always release both the relocated and the old 
> artifactId together. Just one version with the relocation information with 
> the old id is sufficient.
> bq. For the release after that, you only need to publish a Maven POM with a 
> groupId of org.bar, since users of the previous version have been informed of 
> the changed groupId.
> We already have two versions with relocation info at 
> https://search.maven.org/artifact/org.apache.sling/maven-sling-plugin/2.4.2/pom
>  and 
> https://search.maven.org/artifact/org.apache.sling/maven-sling-plugin/2.4.0/pom.
>  
> I propose to flatten the multimodule repository at 
> https://github.com/apache/sling-maven-plugin again to a single module one and 
> no longer release anything with old artifactId {{maven-sling-plugin}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-11532) Remove old relocation artifact maven-sling-plugin

2022-08-12 Thread Stefan Seifert (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578948#comment-17578948
 ] 

Stefan Seifert commented on SLING-11532:


i think that's fine 3 years after the renaming.
i would propose to release the next version of sling-maven-plugin with version 
3.0.0 to signal this breaking change.

> Remove old relocation artifact maven-sling-plugin
> -
>
> Key: SLING-11532
> URL: https://issues.apache.org/jira/browse/SLING-11532
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Sling Maven Plugin 2.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 2.5.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> In SLING-8204 a new artifact has been introduced with artifactId 
> {{sling-maven-plugin}} and the old artifactId {{maven-sling-plugin}} just 
> contains the relocation information.
> According to 
> https://maven.apache.org/guides/mini/guide-relocation.html#releasing-the-next-version
>  it is not necessary to always release both the relocated and the old 
> artifactId together. Just one version with the relocation information with 
> the old id is sufficient.
> bq. For the release after that, you only need to publish a Maven POM with a 
> groupId of org.bar, since users of the previous version have been informed of 
> the changed groupId.
> We already have two versions with relocation info at 
> https://search.maven.org/artifact/org.apache.sling/maven-sling-plugin/2.4.2/pom
>  and 
> https://search.maven.org/artifact/org.apache.sling/maven-sling-plugin/2.4.0/pom.
>  
> I propose to flatten the multimodule repository at 
> https://github.com/apache/sling-maven-plugin again to a single module one and 
> no longer release anything with old artifactId {{maven-sling-plugin}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (SLING-11532) Remove old relocation artifact maven-sling-plugin

2022-08-11 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-11532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17578578#comment-17578578
 ] 

Konrad Windszus commented on SLING-11532:
-

[~sseifert] Since you introduced the change initially, do you have any concerns 
with removing the old artifactId traces fully from the repo now?

> Remove old relocation artifact maven-sling-plugin
> -
>
> Key: SLING-11532
> URL: https://issues.apache.org/jira/browse/SLING-11532
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Sling Maven Plugin 2.4.2
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Sling Maven Plugin 2.5.0
>
>
> In SLING-8204 a new artifact has been introduced with artifactId 
> {{sling-maven-plugin}} and the old artifactId {{maven-sling-plugin}} just 
> contains the relocation information.
> According to 
> https://maven.apache.org/guides/mini/guide-relocation.html#releasing-the-next-version
>  it is not necessary to always release both the relocated and the old 
> artifactId together. Just one version with the relocation information with 
> the old id is sufficient.
> bq. For the release after that, you only need to publish a Maven POM with a 
> groupId of org.bar, since users of the previous version have been informed of 
> the changed groupId.
> We already have two versions with relocation info at 
> https://search.maven.org/artifact/org.apache.sling/maven-sling-plugin/2.4.2/pom
>  and 
> https://search.maven.org/artifact/org.apache.sling/maven-sling-plugin/2.4.0/pom.
>  
> I propose to flatten the multimodule repository at 
> https://github.com/apache/sling-maven-plugin again to a single module one and 
> no longer release anything with old artifactId {{maven-sling-plugin}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)