[jira] [Commented] (SLING-4779) Rely on RankedServices for Sling Models
[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582029#comment-14582029
]
Stefan Seifert commented on SLING-4779:
---
we could even make it more compact and include only the one class (and inner
class) that is required, not the whole package.
i just saw such a solution in \[1\] for the ConfigurationHandler of
{{org.apache.felix.configadmin}}.
\[1\]
https://svn.apache.org/repos/asf/sling/trunk/tooling/support/provisioning-model/pom.xml
Rely on RankedServices for Sling Models
---
Key: SLING-4779
URL: https://issues.apache.org/jira/browse/SLING-4779
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Sling Models Impl 1.2.0
Attachments: SLING-4779-v1.diff
To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
and leaner we should switch to the helper class {{ServiceRanking}} from
SLING-4521.
For that we must increase the dependency towards {{commons-osgi}} to version
2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4779) Rely on RankedServices for Sling Models
[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582044#comment-14582044
]
Konrad Windszus commented on SLING-4779:
Making it even smaller is really dangerous. Because then you would depend on
other classes from the commons-osgi bundle. That would force a dependency
models-impl to the commons-osgi bundle. And then the SortingServiceTracker
might be provided through both classloaders: the commons-osgi bundle
classloader and through the embedded classloader. Since I don't want to debug
such class loading issues I guess it is just safer to completely embed the
necessary classes from commons-osgi and get rid of the import-package statement
completely! Then you don't run into any conflicts, because then the
commons-osgi classloader is not used at all.
Rely on RankedServices for Sling Models
---
Key: SLING-4779
URL: https://issues.apache.org/jira/browse/SLING-4779
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Sling Models Impl 1.2.0
Attachments: SLING-4779-v1.diff
To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
and leaner we should switch to the helper class {{ServiceRanking}} from
SLING-4521.
For that we must increase the dependency towards {{commons-osgi}} to version
2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4779) Rely on RankedServices for Sling Models
[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582050#comment-14582050
]
Stefan Seifert commented on SLING-4779:
---
ah yes, you're right - forgot about the further dependencies inside
commons.osgi.
Rely on RankedServices for Sling Models
---
Key: SLING-4779
URL: https://issues.apache.org/jira/browse/SLING-4779
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Sling Models Impl 1.2.0
Attachments: SLING-4779-v1.diff
To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
and leaner we should switch to the helper class {{ServiceRanking}} from
SLING-4521.
For that we must increase the dependency towards {{commons-osgi}} to version
2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4779) Rely on RankedServices for Sling Models
[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582081#comment-14582081
]
Stefan Seifert commented on SLING-4779:
---
as far as i known felix osgi implementation does not support this when both
bundles have the same symbolic name.
the solution chosen by konrad seems the best to me - no need to deploy
anything, just a few more kb on the jar.
Rely on RankedServices for Sling Models
---
Key: SLING-4779
URL: https://issues.apache.org/jira/browse/SLING-4779
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Sling Models Impl 1.2.0
Attachments: SLING-4779-v1.diff
To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
and leaner we should switch to the helper class {{ServiceRanking}} from
SLING-4521.
For that we must increase the dependency towards {{commons-osgi}} to version
2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4779) Rely on RankedServices for Sling Models
[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582074#comment-14582074
]
Oliver Lietz commented on SLING-4779:
-
Why not deploy {{2.2.x}} *and* {{2.3.x}} of {{org.apache.sling.commons.osgi}}
as it's just a lib? Is package {{org.apache.sling.commons.osgi.bundleversion}}
with same version in 2.2 and 2.3 a problem?
Rely on RankedServices for Sling Models
---
Key: SLING-4779
URL: https://issues.apache.org/jira/browse/SLING-4779
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: Sling Models Impl 1.2.0
Attachments: SLING-4779-v1.diff
To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
and leaner we should switch to the helper class {{ServiceRanking}} from
SLING-4521.
For that we must increase the dependency towards {{commons-osgi}} to version
2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4779) Rely on RankedServices for Sling Models
[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14580761#comment-14580761
]
Konrad Windszus commented on SLING-4779:
Applied a fixed version of the patch in rev.1684708.
Rely on RankedServices for Sling Models
---
Key: SLING-4779
URL: https://issues.apache.org/jira/browse/SLING-4779
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Attachments: SLING-4779-v1.diff
To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
and leaner we should switch to the helper class {{ServiceRanking}} from
SLING-4521.
For that we must increase the dependency towards {{commons-osgi}} to version
2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4779) Rely on RankedServices for Sling Models
[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14575785#comment-14575785
]
Julian Sedding commented on SLING-4779:
---
FWIW, Neil Bartlett describes a [nice way to embed only the required
classes|http://njbartlett.name/2014/05/26/static-linking.html].
Rely on RankedServices for Sling Models
---
Key: SLING-4779
URL: https://issues.apache.org/jira/browse/SLING-4779
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Konrad Windszus
To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
and leaner we should switch to the helper class {{ServiceRanking}} from
SLING-4521.
For that we must increase the dependency towards {{commons-osgi}} to version
2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4779) Rely on RankedServices for Sling Models
[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574453#comment-14574453
]
Konrad Windszus commented on SLING-4779:
Ok, I agree. I am gonna remove the fix version for now. But it's good to
already have a ticket for that :-)
Rely on RankedServices for Sling Models
---
Key: SLING-4779
URL: https://issues.apache.org/jira/browse/SLING-4779
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Konrad Windszus
To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
and leaner we should switch to the helper class {{ServiceRanking}} from
SLING-4521.
For that we must increase the dependency towards {{commons-osgi}} to version
2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4779) Rely on RankedServices for Sling Models
[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574438#comment-14574438
]
Stefan Seifert commented on SLING-4779:
---
i would love to - but we have to keep in mind that this inserts a strong
dependency on this very new commons osgi version that is not even available in
AEM 6.1 released some days ago.
initially one of the USPs of sling models was no deps, you can even deploy it
on instance running very old sling versions.
upgrading sling commons OSGI version i a complex sling application is no
problem - but nearly all other bundles depend on it, so it still leaves one
wondering if it is safe to do so.
so the question is if this change is worth the deployment dependency
problematics it will produce. i would recommend to delay this switch for at
least one yer.
Rely on RankedServices for Sling Models
---
Key: SLING-4779
URL: https://issues.apache.org/jira/browse/SLING-4779
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Konrad Windszus
Fix For: Sling Models Impl 1.2.0
To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
and leaner we should switch to the helper class {{ServiceRanking}} from
SLING-4521.
For that we must increase the dependency towards {{commons-osgi}} to version
2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4779) Rely on RankedServices for Sling Models
[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574690#comment-14574690
]
Stefan Seifert commented on SLING-4779:
---
yes, that would be an good option as well, esp. for a tiny bundle like
org.apache.sling.commons.osgi without any dynamic components.
Rely on RankedServices for Sling Models
---
Key: SLING-4779
URL: https://issues.apache.org/jira/browse/SLING-4779
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Konrad Windszus
To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
and leaner we should switch to the helper class {{ServiceRanking}} from
SLING-4521.
For that we must increase the dependency towards {{commons-osgi}} to version
2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4779) Rely on RankedServices for Sling Models
[
https://issues.apache.org/jira/browse/SLING-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574640#comment-14574640
]
Justin Edelson commented on SLING-4779:
---
Couldn't we just embed the class (or classes) from commons.osgi in the sling
models impl bundle? That's done a lot, especially with commons.osgi for
specifically this reason.
Rely on RankedServices for Sling Models
---
Key: SLING-4779
URL: https://issues.apache.org/jira/browse/SLING-4779
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Konrad Windszus
To prevent issues like SLING-4195 and SLING-4192 and to make the code cleaner
and leaner we should switch to the helper class {{ServiceRanking}} from
SLING-4521.
For that we must increase the dependency towards {{commons-osgi}} to version
2.3.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
