[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967468#comment-15967468 ] Karl Pauls commented on SLING-6679: --- IC, well, I agree with Carsten that it is in general better to make bundles as self-contained as possible and the Felix utils JSONWriter is much smaller so if we are talking embedding it is probably better to go with that one for the use-case he mentions (i.e., bundles that just produce json in a straight-forward way). > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967432#comment-15967432 ] Radu Cotescu commented on SLING-6679: - Well, I have no preference, but seeing the last few contradicting comments between Carsten and you I thought I should maybe suggest that code as a candidate for switching. > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967395#comment-15967395 ] Karl Pauls commented on SLING-6679: --- [~radu.cotescu], you can if you think it is better but personally, I don't think that is needed. Its already using the Felix JSONWriter and that is fine for simple usecases like this. > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[
https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967337#comment-15967337
]
Radu Cotescu commented on SLING-6679:
-
[~karlpauls], should we also change this code to use {{javax.json}}? -
https://github.com/apache/sling/blob/trunk/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/SlingBindingsVariablesListJsonServlet.java#L94
> Replace usage of org.apache.sling.commons.json.* and org.json
> -
>
> Key: SLING-6679
> URL: https://issues.apache.org/jira/browse/SLING-6679
> Project: Sling
> Issue Type: Improvement
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>
> Following the deprecation of org.apache.sling.commons.json (SLING-6536) we
> need to replace its usage everywhere else (at least if we want to be able to
> release other modules that depend on it).
> This is the umbrella issue for getting this done. The idea is to create
> sub-issues with patches for individual components, review the patches, and
> when all are done: close this issue.
> General discussions and problems should go to this issue and specific ones on
> the sub-issue in question.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950887#comment-15950887 ] Carsten Ziegeler commented on SLING-6679: - Ok, let's agree that we regard this differently. So all is fine I guess and I'll shut up > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950809#comment-15950809 ] Karl Pauls commented on SLING-6679: --- I'm not sure I agree - but regardless: I'm wondering why you think that your goal of running Sling with less bundles is somehow more achievable with the JSONWriter v.s. javax.json. Granted, the JSONWriter weighs in with about 10k v.s. about 100k for the johnzon bundle but otherwise, the current johnzon bundle has no dependencies whatsoever so you could just as well inline that one into the bundles in question no? > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950730#comment-15950730 ] Carsten Ziegeler commented on SLING-6679: - Sure, but with that argument we could also say if one bundle is using bundle Y, then let's use Y all over the place :) I would like to get a running Sling with as less bundles as possible; now I totally agree that it doesn't make sense to replace the json library in servlets.get or the importer. But for modules which just produce json to be consumed by a web console plugin I think it makes more sense. I haven't looked at all of those modules, but maybe it just applies to one or two of them; adapter being one. > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950714#comment-15950714 ] Karl Pauls commented on SLING-6679: --- [~cziegeler], hm, I'm not so sure that makes that much sense. If we need javax.json around anyways we might as well use it. What benefit do you see in embedding the JSONWriter all over the place? > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950327#comment-15950327 ] Carsten Ziegeler commented on SLING-6679: - Thanks for all the great work [~karlpauls] and everyone who helped. I think it would make sense to quickly go through the list if modules and see whether we can remove the dependency to an external json library completely. For example, the adapter module is only writing out simple json to the web console. This can easily be replaced with embedding the JSONWriter from the Apache Felix Utils module. Maybe there are other modules where we can do the same. > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946864#comment-15946864 ] Oliver Lietz commented on SLING-6679: - Are there any plans for modules in contrib, e.g. distribution? > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946834#comment-15946834 ] Robert Munteanu commented on SLING-6679: Saw the commit just now, thanks! > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946830#comment-15946830 ] Karl Pauls commented on SLING-6679: --- [~rombert], yeah - I removed one snaphot too many. Carsten just committed an update of the serviceusermapping bundle to the latest snapshot. Should work now. > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[
https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946827#comment-15946827
]
Robert Munteanu commented on SLING-6679:
[~karlpauls] - the launchpad does not start anymore after these changes, see
https://builds.apache.org/job/sling-launchpad-builder-1.8/
The relevant snippet I have found in the logs is
{noformat}29.03.2017 09:25:22.244 *INFO* [OsgiInstallerImpl]
org.apache.sling.installer.core.impl.tasks.BundleStartTask Could not start
bundle org.apache.sling.xss [145]. Reason: {}. Will retry.
org.osgi.framework.BundleException: Unable to resolve org.apache.sling.xss
[145](R 145.0): missing requirement [org.apache.sling.xss [145](R 145.0)]
osgi.wiring.package;
(&(osgi.wiring.package=org.apache.sling.serviceusermapping)(version>=1.2.0)(!(version>=2.0.0)))
[caused by: Unable to resolve org.apache.sling.serviceusermapper [139](R
139.0): missing requirement [org.apache.sling.serviceusermapper [139](R 139.0)]
osgi.wiring.package;
(&(osgi.wiring.package=org.apache.sling.commons.json)(version>=2.0.0)(!(version>=3.0.0)))]
Unresolved requirements: [[org.apache.sling.xss [145](R 145.0)]
osgi.wiring.package;
(&(osgi.wiring.package=org.apache.sling.serviceusermapping)(version>=1.2.0)(!(version>=2.0.0)))]
at
org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4111)
at org.apache.felix.framework.Felix.startBundle(Felix.java:2117)
at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998)
at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:984)
at
org.apache.sling.installer.core.impl.tasks.BundleStartTask.execute(BundleStartTask.java:97)
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:894)
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:729)
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:286)
at java.lang.Thread.run(Thread.java:745){noformat}
> Replace usage of org.apache.sling.commons.json.* and org.json
> -
>
> Key: SLING-6679
> URL: https://issues.apache.org/jira/browse/SLING-6679
> Project: Sling
> Issue Type: Improvement
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>
> Following the deprecation of org.apache.sling.commons.json (SLING-6536) we
> need to replace its usage everywhere else (at least if we want to be able to
> release other modules that depend on it).
> This is the umbrella issue for getting this done. The idea is to create
> sub-issues with patches for individual components, review the patches, and
> when all are done: close this issue.
> General discussions and problems should go to this issue and specific ones on
> the sub-issue in question.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946031#comment-15946031 ] Karl Pauls commented on SLING-6679: --- I did some more clean-up and resolved all the sub-issues. Please reopen if one needs more work. Otherwise, I'll wait a little and then start to release the affected bundles. I'll keep this issue open until we have all the bundles released. > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6679) Replace usage of org.apache.sling.commons.json.* and org.json
[ https://issues.apache.org/jira/browse/SLING-6679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945115#comment-15945115 ] Karl Pauls commented on SLING-6679: --- I just commited implementations for all the subissues (with the exception of the caconfig.impl). I still need to do some clean-up and will start resolving them when I did so. For now, I put in the SNAPSHOT versions in launchpad and replaced what needed replacement (e.g., the webconsole). With that, we have a working launchpad (the launchpad/testing works for me) without org.json (I removed the geronimo bundle) and without commons.json. When I'm done with the clean-up and we think there are no other problems anymore (might be good to wait a bit for that) I will start releasing the affected bundles and update the SNAPSHOTs in the launchpad with released versions. > Replace usage of org.apache.sling.commons.json.* and org.json > - > > Key: SLING-6679 > URL: https://issues.apache.org/jira/browse/SLING-6679 > Project: Sling > Issue Type: Improvement >Reporter: Karl Pauls >Assignee: Karl Pauls > > Following the deprecation of org.apache.sling.commons.json (SLING-6536) we > need to replace its usage everywhere else (at least if we want to be able to > release other modules that depend on it). > This is the umbrella issue for getting this done. The idea is to create > sub-issues with patches for individual components, review the patches, and > when all are done: close this issue. > General discussions and problems should go to this issue and specific ones on > the sub-issue in question. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
