[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-06-24 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144257#comment-17144257 ] Roy Teeuwen commented on SLING-7768: [~rombert] ok perfect because I also had to build a workaround

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-06-24 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144240#comment-17144240 ] Robert Munteanu commented on SLING-7768: [~royteeuwen] - I see SLING-8946 is still open and I

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-06-24 Thread Roy Teeuwen (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144104#comment-17144104 ] Roy Teeuwen commented on SLING-7768: any ETA on a release date for this? > Add String Interpolation

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-06-24 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143814#comment-17143814 ] Bertrand Delacretaz commented on SLING-7768: FWIW, as the rest of the /etc/map documentation

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-23 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022486#comment-17022486 ] Andreas Schaefer commented on SLING-7768: - [~bdelacretaz] Thanks for the tip with Jacoco. I am

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-23 Thread Bertrand Delacretaz (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17022295#comment-17022295 ] Bertrand Delacretaz commented on SLING-7768: To nitpick, I ran a Jacoco coverage report and

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-22 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021814#comment-17021814 ] Carsten Ziegeler commented on SLING-7768: - Thanks for updating [~andysch] - the PR looks

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-22 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17021803#comment-17021803 ] Andreas Schaefer commented on SLING-7768: - Pushed my changes with the Interpolation and the

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-20 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019894#comment-17019894 ] Carsten Ziegeler commented on SLING-7768: - I think we should rather go with the optional

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-20 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019665#comment-17019665 ] Andreas Schaefer commented on SLING-7768: - No, neither does ';' and even ',' can give grief. I

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-18 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018599#comment-17018599 ] Carsten Ziegeler commented on SLING-7768: - Does the colon work? Like ${env:foo} ? Right, I don't

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-17 Thread Andreas Schaefer (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018277#comment-17018277 ] Andreas Schaefer commented on SLING-7768: - So '$[]' does not work as node name so I guess we are

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-17 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018222#comment-17018222 ] Carsten Ziegeler commented on SLING-7768: - The Felix interpolation plugin is here:

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2020-01-10 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013030#comment-17013030 ] Carsten Ziegeler commented on SLING-7768: - I had a brief look at the PR. I think we don't need an

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2019-07-30 Thread Andreas Schaefer (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896307#comment-16896307 ] Andreas Schaefer commented on SLING-7768: - BTW the current implementation uses the StrSubstitutor

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2019-07-30 Thread Andreas Schaefer (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896304#comment-16896304 ] Andreas Schaefer commented on SLING-7768: - Created PR for this ticket: 

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2019-07-26 Thread Ruben Reusser (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893769#comment-16893769 ] Ruben Reusser commented on SLING-7768: -- so when this was done there was a bigger discussion about

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2019-07-26 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893430#comment-16893430 ] Carsten Ziegeler commented on SLING-7768: - I guess this makes sense, if we can get a PR for this

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2019-07-26 Thread Roy Teeuwen (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893412#comment-16893412 ] Roy Teeuwen commented on SLING-7768: Any update on ever getting this in? Would simplify the setup a

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2018-08-16 Thread Bertrand Delacretaz (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582502#comment-16582502 ] Bertrand Delacretaz commented on SLING-7768: Looking at string interpolation for another

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2018-07-30 Thread Andreas Schaefer (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16562500#comment-16562500 ] Andreas Schaefer commented on SLING-7768: - Added a unit test class for the Etc Map through Etc

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2018-07-25 Thread Andreas Schaefer (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556352#comment-16556352 ] Andreas Schaefer commented on SLING-7768: - Renamed the PlaceHolderProvider to

[jira] [Commented] (SLING-7768) Add String Interpolation support to /etc/map

2018-07-24 Thread Andreas Schaefer (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554535#comment-16554535 ] Andreas Schaefer commented on SLING-7768: - I uploaded a POC to the Sling Git Repo with branch: