Re: [API] ResourceResolver.copy/move() transient or not?

2017-06-01 Thread Alexander Klimetschek
Thanks. I created https://issues.apache.org/jira/browse/SLING-6932 for the javadoc change. Also noted that the multi-phase commit behaviour (across providers) should probably be documented as well. Cheers, Alex > On 31.05.2017, at 22:27, Carsten Ziegeler wrote: > > Hi,

Re: [API] ResourceResolver.copy/move() transient or not?

2017-05-31 Thread Carsten Ziegeler
Hi, all resource operations are transient, you always have to call commit. But I guess we need to work on the javadocs a little bit to make this clear. Sling 9 is not released yet, but we're pretty close. Once it's there the javadoc will be there as well. Carsten Alexander Klimetschek wrote >

Re: [API] ResourceResolver.copy/move() transient or not?

2017-05-31 Thread Alexander Klimetschek
BTW, there is no published javadoc for sling 9, the latest is sling 8 [3], which does not include the copy/move methods, albeit they are 2 years old [4]. [3] https://sling.apache.org/apidocs/sling8/org/apache/sling/api/resource/ResourceResolver.html [4]

[API] ResourceResolver.copy/move() transient or not?

2017-05-31 Thread Alexander Klimetschek
Hi everyone, the javadocs of ResourceResolver.copy/move() [1] aren't very clear whether these methods immediately persist the change, or if the change is transient and it's necessary to call commit(). The implementation of the JCR resource provider uses Session.move() which is transient.