Re: [DISCUSS] Switching o.a.s.starter-content to use scripts and resources?
On Fri, 2019-08-16 at 08:05 +0200, Georg Henzler wrote: > > Do you mean /content/startup/index.html here? > > > yes - sorry (copy & paste error) Perfect. So all clear, and we should be good to. Thanks, Robert
Re: [DISCUSS] Switching o.a.s.starter-content to use scripts and resources?
Do you mean /content/startup/index.html here? yes - sorry (copy & paste error)
Re: [DISCUSS] Switching o.a.s.starter-content to use scripts and resources?
On Thu, 2019-08-15 at 00:10 +0200, Georg Henzler wrote: > > Replying to myself here - the /content/startup/index.html file is > > different from the /content/starter/index.html one, so no change is > > required here. > > Sorry for the late reply - so fixed perfectly via SLING-8615. The > file > /content/startup/index.html used to be loaded from starter-startup > [1], > I only recently moved it to starter-content. Thanks for confirming, Georg. > It's a good thing to have > it closer together with the regular content, unfortunately for > /content/starter/index.html we can still not use scripts and > resources > as the Sling engine is not ready yet during early startup. Do you mean /content/startup/index.html here? Robert > -Georg > > [1] > https://github.com/apache/sling-org-apache-sling-starter-startup/blob/maintenance/src/main/resources/index.html
Re: [DISCUSS] Switching o.a.s.starter-content to use scripts and resources?
Replying to myself here - the /content/startup/index.html file is different from the /content/starter/index.html one, so no change is required here. Sorry for the late reply - so fixed perfectly via SLING-8615. The file /content/startup/index.html used to be loaded from starter-startup [1], I only recently moved it to starter-content. It's a good thing to have it closer together with the regular content, unfortunately for /content/starter/index.html we can still not use scripts and resources as the Sling engine is not ready yet during early startup. -Georg [1] https://github.com/apache/sling-org-apache-sling-starter-startup/blob/maintenance/src/main/resources/index.html
Re: [DISCUSS] Switching o.a.s.starter-content to use scripts and resources?
On Tue, 2019-08-06 at 10:41 +0300, Robert Munteanu wrote: > On Mon, 2019-08-05 at 20:49 +0300, Robert Munteanu wrote: > > A quick check in the starter application shows that there at least > > the > > Felix HC bundle expects this file to be present (config snippet > > below) > > > > PID = > > org.apache.felix.hc.core.impl.filter.ServiceUnavailableFilter~start > > up > > andshutdown > > responseTextFor503 = > > classpath:org.apache.sling.starter.content:content/content/startup/ > > in > > dex.html > > Replying to myself here - the /content/startup/index.html file is > different from the /content/starter/index.html one, so no change is > required here. Filed and fixed https://issues.apache.org/jira/browse/SLING-8615 . Robert
Re: [DISCUSS] Switching o.a.s.starter-content to use scripts and resources?
On Mon, 2019-08-05 at 20:49 +0300, Robert Munteanu wrote: > A quick check in the starter application shows that there at least > the > Felix HC bundle expects this file to be present (config snippet > below) > > PID = > org.apache.felix.hc.core.impl.filter.ServiceUnavailableFilter~startup > andshutdown > responseTextFor503 = > classpath:org.apache.sling.starter.content:content/content/startup/in > dex.html Replying to myself here - the /content/startup/index.html file is different from the /content/starter/index.html one, so no change is required here. Robert
Re: [DISCUSS] Switching o.a.s.starter-content to use scripts and resources?
+1 to switching to scripts and resources. -- Jason On Mon, Aug 5, 2019, at 1:49 PM, Robert Munteanu wrote: > Hi, > > I am currently looking at the starter-content bundle and I'm not sure > why the home page is a index.html file instead of a resource handled by > a script. This would open up the way to additional customisations of > the starter application. > > A quick check in the starter application shows that there at least the > Felix HC bundle expects this file to be present (config snippet below) > > PID = > org.apache.felix.hc.core.impl.filter.ServiceUnavailableFilter~startupandshutdown > responseTextFor503 = > classpath:org.apache.sling.starter.content:content/content/startup/index.html > > Is this something we can tweak so it does not require the starter to > ship an index.html file? > > Thanks, > > Robert > >
[DISCUSS] Switching o.a.s.starter-content to use scripts and resources?
Hi, I am currently looking at the starter-content bundle and I'm not sure why the home page is a index.html file instead of a resource handled by a script. This would open up the way to additional customisations of the starter application. A quick check in the starter application shows that there at least the Felix HC bundle expects this file to be present (config snippet below) PID = org.apache.felix.hc.core.impl.filter.ServiceUnavailableFilter~startupandshutdown responseTextFor503 = classpath:org.apache.sling.starter.content:content/content/startup/index.html Is this something we can tweak so it does not require the starter to ship an index.html file? Thanks, Robert
