stefanseifert commented on issue #2: Fix OSGi package export version URL: https://github.com/apache/sling-org-apache-sling-query/pull/2#issuecomment-386365705 the way it was before the PR the version from the package-info files got ignored, because of the explicit declaration of the maven bundle plugin: ``` <configuration> <instructions> <Export-Package>!*,org.apache.sling.query,org.apache.sling.query.api</Export-Package> </instructions> </configuration> ``` if we want to keep this notation we would need to add the package version to the export package statement here. but using package-info files is far more intuitive and used in most of the other sling modules. so it thought it's good to keep the practise if hiding the private package by the convention of adding "impl" or "internal" to the package name and let the maven bundle plugin do the rest (which is the usual pattern in the other sling modules - at least when they are not converted to the bnd-maven-plugin). anyway for a developer it's also helpful to see clearly from the package name if it's private or public class.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
