[jira] [Commented] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770594#comment-17770594 ] Eric Norman commented on SLING-12053: - Linked the related open issue regarding the migration of sling to slf4j 2.x > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770495#comment-17770495 ] Andreas Schaefer commented on SLING-12053: -- I suggested a version check in the garaphql-java grade.build: Import-Package: !android.os.*,!com.google.*,!org.checkerframework.*,!javax.annotation.*,!graphql.com.google.*,!org.antlr.*,!graphql.org.antlr.*,!sun.misc.*,org.slf4j;version="[1.7,3.0)",* That would allow to use SLF4J version 1.7 and newer and would allow us to keep using it. This is my discussion with graphs-java: [https://github.com/graphql-java/graphql-java/issues/3339] > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12053) Upgrade Sling GraphQL Core to Graphql-Java 21.x
[ https://issues.apache.org/jira/browse/SLING-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770244#comment-17770244 ] Andreas Schaefer commented on SLING-12053: -- When I took Sling GraphQL Core 0.0.25-SNAPSHOT and upgraded to graphql-java 21.1 it broke the build. There are several issues with it: * It introduced a dependency to android.os (was fixed in the meantime) * upgraded to SLF4J to 2.0.x which breaks our build (I tested it by downgrading to 1.7.25 and that still works) I will check if graphql-java can contain a dependency range of SLF4J of 1.7 to 3.0 instead of 2.0 to 3.0 to allow use to upgrade. > Upgrade Sling GraphQL Core to Graphql-Java 21.x > --- > > Key: SLING-12053 > URL: https://issues.apache.org/jira/browse/SLING-12053 > Project: Sling > Issue Type: Improvement >Reporter: Andreas Schaefer >Priority: Major > > There is an upgrade from graphql-java of 21.x and that has (according to > them) breaking changes. As upgrading takes time I wanted to start the process > early with this ticket. -- This message was sent by Atlassian Jira (v8.20.10#820010)
