[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004589#comment-16004589
]
Konrad Windszus commented on SLING-6053:
Yes right, but the current behaviour is more complicated
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004565#comment-16004565
]
Antonio Sanso commented on SLING-6053:
--
[~kwin]
on top
bq. Therefore the longest match for
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004561#comment-16004561
]
Antonio Sanso commented on SLING-6053:
--
[~kwin] said that the committed patch and the current
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004543#comment-16004543
]
Antonio Sanso commented on SLING-6053:
--
[~kwin] gotcha now. Sorry if it took so long.
>
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004535#comment-16004535
]
Konrad Windszus commented on SLING-6053:
But in my example there are only two applicable holders:
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004521#comment-16004521
]
Antonio Sanso commented on SLING-6053:
--
[~kwin] you probably you might want to give a look at my
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004498#comment-16004498
]
Konrad Windszus commented on SLING-6053:
But {{isNodeRequiresAuthHandler("/resource1.test.html",
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004423#comment-16004423
]
Antonio Sanso commented on SLING-6053:
--
[~kwin]
bq. . Then the AuthenticationHolder (not requiring
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004383#comment-16004383
]
Konrad Windszus commented on SLING-6053:
Then the other way round, lets say {{/}} requires
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004373#comment-16004373
]
Antonio Sanso commented on SLING-6053:
--
[~kwin] well I wonder how would be the setting in your use
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004357#comment-16004357
]
Konrad Windszus commented on SLING-6053:
[~asanso] IIUC then
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004335#comment-16004335
]
Antonio Sanso commented on SLING-6053:
--
[~kwindszus] I added a test that covers your scenario in rev.
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002451#comment-16002451
]
ASF GitHub Bot commented on SLING-6053:
---
Github user mkbrv closed the pull request at:
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002438#comment-16002438
]
Antonio Sanso commented on SLING-6053:
--
applied patch in rev. 1794520 applied test patch from
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000473#comment-16000473
]
Konrad Windszus commented on SLING-6053:
Fine by me, just don't forget to also adjust
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000354#comment-16000354
]
Antonio Sanso commented on SLING-6053:
--
[~kwin] I'd be inclined to apply this patch. Would you be
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885681#comment-15885681
]
Antonio Sanso commented on SLING-6053:
--
[~kwin] I did double check and it really looks like
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885603#comment-15885603
]
Antonio Sanso commented on SLING-6053:
--
[~kwin] I need to check but I think that
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15885587#comment-15885587
]
Konrad Windszus commented on SLING-6053:
[~asanso] The patch is only a heuristic and does not work
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882611#comment-15882611
]
Antonio Sanso commented on SLING-6053:
--
Thanks [~mkbrv] . So far I applied your test cases in
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882564#comment-15882564
]
Antonio Sanso commented on SLING-6053:
--
Thanks [~mkbrv]. I will take a look.
> SlingAuthenticator
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490193#comment-15490193
]
Konrad Windszus commented on SLING-6053:
I am not sure this is the correct patch. You also have to
[
https://issues.apache.org/jira/browse/SLING-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15487297#comment-15487297
]
ASF GitHub Bot commented on SLING-6053:
---
GitHub user mkbrv opened a pull request:
23 matches
Mail list logo
