[jira] [Commented] (SLING-6110) ServerSideTeleporter can't read the bundle header Sling-Test-WaitForService-Timeout
[ https://issues.apache.org/jira/browse/SLING-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15760993#comment-15760993 ] Marcel Jolk commented on SLING-6110: Ich bin bis einschließlich 23.12.2016 nicht im Hause. Ihre E-Mail werde ich nach meiner Rückkehr bearbeiten. In dringenden Fällen wenden Sie sich bitte an Herrn Göckel (michael.goec...@cybercon.de). Viele Grüße, Marcel Jolk marcel.j...@cybercon.de Jülicher Str. 26 / Moltkestr. 25 50674 Köln tel +49 228 22 7776 214 Cybercon Gesellschaft für neue Medien mbH Firmensitz: Königswinterer Strasse 374, 53227 Bonn Registergericht: Amtsgericht Bonn, HRB 15523 Geschäftsführer: Oliver Runge, Michael Göckel Umsatzsteuer-ID: DE178714321 > ServerSideTeleporter can't read the bundle header > Sling-Test-WaitForService-Timeout > --- > > Key: SLING-6110 > URL: https://issues.apache.org/jira/browse/SLING-6110 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: JUnit Tests Teleporter 1.0.8, JUnit Core 1.0.18 >Reporter: Marcel Jolk >Assignee: Stefan Seifert > Fix For: JUnit Core 1.0.20 > > > The _Sling-Test-WaitForService-Timeout_ bundle header is not properly read by > the {{ServerSideTeleporter}}. The method {{getService()}} reads the bundle > header using the {{BundleContext}} > ({{bundleContext.getBundle().getHeaders()}}). This {{BundleContext}} is set > in the {{Activator}} class on start of the bundle > {{org.apache.sling.junit.core}}. Therefore {{bundleContext.getBundle()}} > resolves to the bundle {{org.apache.sling.junit.core}}. This bundle does not > have the proper headers. Instead the bundle headers of the bundle, which is > created in the {{ClientSideTeleporter}}, including the class under test, > should be used. Thus its {{BundleContext}} is needed. > I already made the required code changes using {{FrameWorkUtil}} to retrieve > the {{BundleContext}} for the class under test. I'll create a pull request, > which resolves this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6110) ServerSideTeleporter can't read the bundle header Sling-Test-WaitForService-Timeout
[ https://issues.apache.org/jira/browse/SLING-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554911#comment-15554911 ] Marcel Jolk commented on SLING-6110: Still works. Thanks! > ServerSideTeleporter can't read the bundle header > Sling-Test-WaitForService-Timeout > --- > > Key: SLING-6110 > URL: https://issues.apache.org/jira/browse/SLING-6110 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: JUnit Tests Teleporter 1.0.8, JUnit Core 1.0.18 >Reporter: Marcel Jolk >Assignee: Stefan Seifert > Fix For: JUnit Core 1.0.20 > > > The _Sling-Test-WaitForService-Timeout_ bundle header is not properly read by > the {{ServerSideTeleporter}}. The method {{getService()}} reads the bundle > header using the {{BundleContext}} > ({{bundleContext.getBundle().getHeaders()}}). This {{BundleContext}} is set > in the {{Activator}} class on start of the bundle > {{org.apache.sling.junit.core}}. Therefore {{bundleContext.getBundle()}} > resolves to the bundle {{org.apache.sling.junit.core}}. This bundle does not > have the proper headers. Instead the bundle headers of the bundle, which is > created in the {{ClientSideTeleporter}}, including the class under test, > should be used. Thus its {{BundleContext}} is needed. > I already made the required code changes using {{FrameWorkUtil}} to retrieve > the {{BundleContext}} for the class under test. I'll create a pull request, > which resolves this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-6110) ServerSideTeleporter can't read the bundle header Sling-Test-WaitForService-Timeout
[ https://issues.apache.org/jira/browse/SLING-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15554585#comment-15554585 ] ASF GitHub Bot commented on SLING-6110: --- GitHub user marcel-j opened a pull request: https://github.com/apache/sling/pull/178 SLING-6110: use the proper bundleContext in the ServerSideTeleporter … …to retrieve the correct bundle headers You can merge this pull request into a Git repository by running: $ git pull https://github.com/marcel-j/sling trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/178.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #178 commit c400ed4291090da2fb522692a1837265d991db2a Author: Marcel JolkDate: 2016-10-07T09:00:10Z SLING-6110: use the proper bundleContext in the ServerSideTeleporter to retrieve the correct bundle headers > ServerSideTeleporter can't read the bundle header > Sling-Test-WaitForService-Timeout > --- > > Key: SLING-6110 > URL: https://issues.apache.org/jira/browse/SLING-6110 > Project: Sling > Issue Type: Bug > Components: Testing >Affects Versions: JUnit Tests Teleporter 1.0.8, JUnit Core 1.0.18 >Reporter: Marcel Jolk > Fix For: JUnit Core 1.0.20 > > > The _Sling-Test-WaitForService-Timeout_ bundle header is not properly read by > the {{ServerSideTeleporter}}. The method {{getService()}} reads the bundle > header using the {{BundleContext}} > ({{bundleContext.getBundle().getHeaders()}}). This {{BundleContext}} is set > in the {{Activator}} class on start of the bundle > {{org.apache.sling.junit.core}}. Therefore {{bundleContext.getBundle()}} > resolves to the bundle {{org.apache.sling.junit.core}}. This bundle does not > have the proper headers. Instead the bundle headers of the bundle, which is > created in the {{ClientSideTeleporter}}, including the class under test, > should be used. Thus its {{BundleContext}} is needed. > I already made the required code changes using {{FrameWorkUtil}} to retrieve > the {{BundleContext}} for the class under test. I'll create a pull request, > which resolves this issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)