[jira] [Resolved] (SLING-4867) EntityResourceList should be thread-safe
[
https://issues.apache.org/jira/browse/SLING-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-4867.
-
Resolution: Fixed
I think the problem is rather a bug in the installer integration test: it does
not wait until all bundles from the ManyBundlesTest are installed, launches the
next test and that gets a wrong initial state.
Fixed the test case in rev 1765152
I've also improved the state handling in the installer a little bit
> EntityResourceList should be thread-safe
>
>
> Key: SLING-4867
> URL: https://issues.apache.org/jira/browse/SLING-4867
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Core 3.6.6
>Reporter: Julian Sedding
>Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.6.10
>
>
> There was a Jenkins test failure\[0\] due to the following exception. This
> looks like {{EntityResourceList}} should be thread-safe.
> [~cziegeler], I took the liberty to assign the issue to you. Hope that's ok.
> {noformat}
> Exception in thread "OsgiInstallerImpl"
> java.util.ConcurrentModificationException
> at java.util.ArrayList.sort(ArrayList.java:1456)
> at java.util.Collections.sort(Collections.java:141)
> at
> org.apache.sling.installer.core.impl.EntityResourceList.getActiveResource(EntityResourceList.java:125)
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigTaskCreator.createTask(ConfigTaskCreator.java:71)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.getTask(OsgiInstallerImpl.java:632)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.computeTasks(OsgiInstallerImpl.java:612)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:262)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> \[0\] https://builds.apache.org/job/sling-trunk-1.8/1292/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4867) EntityResourceList should be thread-safe
[
https://issues.apache.org/jira/browse/SLING-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-4867.
-
Resolution: Fixed
Can't reproduce the problem any with the additional lock
> EntityResourceList should be thread-safe
>
>
> Key: SLING-4867
> URL: https://issues.apache.org/jira/browse/SLING-4867
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Core 3.6.6
>Reporter: Julian Sedding
>Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.6.10
>
>
> There was a Jenkins test failure\[0\] due to the following exception. This
> looks like {{EntityResourceList}} should be thread-safe.
> [~cziegeler], I took the liberty to assign the issue to you. Hope that's ok.
> {noformat}
> Exception in thread "OsgiInstallerImpl"
> java.util.ConcurrentModificationException
> at java.util.ArrayList.sort(ArrayList.java:1456)
> at java.util.Collections.sort(Collections.java:141)
> at
> org.apache.sling.installer.core.impl.EntityResourceList.getActiveResource(EntityResourceList.java:125)
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigTaskCreator.createTask(ConfigTaskCreator.java:71)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.getTask(OsgiInstallerImpl.java:632)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.computeTasks(OsgiInstallerImpl.java:612)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:262)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> \[0\] https://builds.apache.org/job/sling-trunk-1.8/1292/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4867) EntityResourceList should be thread-safe
[
https://issues.apache.org/jira/browse/SLING-4867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-4867.
-
Resolution: Won't Fix
I'll close this as won't fix as this is either fixed already, or not
reproducible. If the issue appears again, please reopen
> EntityResourceList should be thread-safe
>
>
> Key: SLING-4867
> URL: https://issues.apache.org/jira/browse/SLING-4867
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Core 3.6.6
>Reporter: Julian Sedding
>
> There was a Jenkins test failure\[0\] due to the following exception. This
> looks like {{EntityResourceList}} should be thread-safe.
> [~cziegeler], I took the liberty to assign the issue to you. Hope that's ok.
> {noformat}
> Exception in thread "OsgiInstallerImpl"
> java.util.ConcurrentModificationException
> at java.util.ArrayList.sort(ArrayList.java:1456)
> at java.util.Collections.sort(Collections.java:141)
> at
> org.apache.sling.installer.core.impl.EntityResourceList.getActiveResource(EntityResourceList.java:125)
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigTaskCreator.createTask(ConfigTaskCreator.java:71)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.getTask(OsgiInstallerImpl.java:632)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.computeTasks(OsgiInstallerImpl.java:612)
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:262)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> \[0\] https://builds.apache.org/job/sling-trunk-1.8/1292/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
