Re: [parent pom] missing site distribution management

2022-08-11 Thread Radu Cotescu
Hi Konrad, No concerns - feel free to merge https://github.com/apache/sling-site/pull/96 . Thanks, Radu > On 11 Aug 2022, at 16:36, Konrad Windszus wrote: > > I also ran into that issue recently and I still think that the site goal is > enough

Re: [parent pom] missing site distribution management

2022-08-11 Thread Konrad Windszus
I also ran into that issue recently and I still think that the site goal is enough (no need for stage, https://maven.apache.org/plugins/maven-site-plugin/stage-mojo.html). Every URL we would put into the distributionManagement site URL of the parent would just be a guess and could be wrong.

Re: [parent pom] missing site distribution management

2021-09-21 Thread Radu Cotescu
Hi Konrad, > On 21 Sep 2021, at 19:35, Konrad Windszus wrote: > > Hi Radu, > I never use the site goals "deploy" or "stage" for Sling modules. Instead of > the former we have a rather manual process outlined in >

Re: [parent pom] missing site distribution management

2021-09-21 Thread Konrad Windszus
Hi Radu, I never use the site goals "deploy" or "stage" for Sling modules. Instead of the former we have a rather manual process outlined in https://sling.apache.org/documentation/development/release-management.html#appendix-b-deploy-maven-plugin-documentation-if-applicable. The latter is only

[parent pom] missing site distribution management

2021-09-21 Thread Radu Cotescu
Hello, I noticed that commit [0] removed the site distribution management section. Without this the site:stage goal fails for our Maven plugins, with the following error: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.9.1:stage (default-cli) on project