Re: [Sling Models documentation] discourage the use of @Inject

2023-01-12 Thread Jörg Hoh
Hi all, As the PR got quite complex with its many changes and moves of content, I merged the doc update yesterday, you can check the result at https://sling.apache.org/documentation/bundles/models.html. if you find any inconsistencies or plain errors, please let me know, I plan to do another PR

Re: [Sling Models documentation] discourage the use of @Inject

2022-12-21 Thread Jörg Hoh
Many thanks for the feedback Stefan! I updated the PR. Can someone else help with the conversion of the @Via examples to the injector-specific annotations? Jörg Am Mi., 21. Dez. 2022 um 10:05 Uhr schrieb Stefan Seifert : > thanks for the work! > > to make it easier to comment i've created a

RE: [Sling Models documentation] discourage the use of @Inject

2022-12-21 Thread Stefan Seifert
thanks for the work! to make it easier to comment i've created a pull request with your changes and added some cosmetic comments: https://github.com/apache/sling-site/pull/106 overall, looks very good to me. i think i've never used the @via annotation, cannot help much here. the new

Re: [Sling Models documentation] discourage the use of @Inject

2022-12-17 Thread Jörg Hoh
I just pushed a first draft into https://raw.githubusercontent.com/apache/sling-site/SLING-11711-update-slingmodels-doc/src/main/jbake/content/documentation/bundles/models.md I moved over to the injector-specific annotations and moved the discouraged one to the bottom. On top I restructured the

RE: [Sling Models documentation] discourage the use of @Inject

2022-12-08 Thread Stefan Seifert
+1 using @Inject is not only a performance problem, it also may lead to unexpected results if an injector steps in you are not aware of. stefan > -Original Message- > From: Jörg Hoh > Sent: Thursday, December 8, 2022 10:25 AM > To: Sling Developers List > Subject: [Sling Models