Re: ResourceProviderTrackerTest#testReactivation fails after updating to osgi-mock 2

2018-08-17 Thread Robert Munteanu
lto:cziege...@apache.org] > > Sent: Friday, August 17, 2018 7:42 AM > > To: dev@sling.apache.org; Robert Munteanu > > Subject: Re: ResourceProviderTrackerTest#testReactivation fails > > after > > updating to osgi-mock 2 > > > > I think the test is wrong - the API

RE: ResourceProviderTrackerTest#testReactivation fails after updating to osgi-mock 2

2018-08-17 Thread Stefan Seifert
estReactivation fails after >updating to osgi-mock 2 > >I think the test is wrong - the API of the ResourceProvider states that >if there is more than one provider with the same root path, the one with >the highest service ranking is used. > >As both providers are registe

Re: ResourceProviderTrackerTest#testReactivation fails after updating to osgi-mock 2

2018-08-16 Thread Carsten Ziegeler
I think the test is wrong - the API of the ResourceProvider states that if there is more than one provider with the same root path, the one with the highest service ranking is used. As both providers are registered with the same bundle id, the one registered first has the lower service id and

Re: ResourceProviderTrackerTest#testReactivation fails after updating to osgi-mock 2

2018-08-15 Thread Robert Munteanu
... or maybe the test is correct and the implementation wrong? In which case we should adjust the code to make sure that newer service references are preferred. Robert On Wed, 2018-08-15 at 16:22 +0200, Robert Munteanu wrote: > Thanks for the analysis Stefan, I was able to to follow the code

Re: ResourceProviderTrackerTest#testReactivation fails after updating to osgi-mock 2

2018-08-15 Thread Robert Munteanu
Thanks for the analysis Stefan, I was able to to follow the code and that explains the behaviour change. My opinion on this is that the test is incorrect and that we should remove that part. Carsten, you wrote that test - maybe on have another opinion? Thanks, Robert On Wed, 2018-08-15 at

RE: ResourceProviderTrackerTest#testReactivation fails after updating to osgi-mock 2

2018-08-15 Thread Stefan Seifert
i've created a branch with some cleanup of the unit tests and updating the osgi-mock dependency - but the problem itself is not solved, but i can explain it https://github.com/apache/sling-org-apache-sling-resourceresolver/tree/feature/update-testing-deps - the testReactivation test registers