Re: [DISCUSS] Community Virtual Meetup, August 2023

2023-08-23 Thread Alex Deparvu
It looks good to me, so probably it was fixed. On Wed, Aug 23, 2023 at 8:59 PM David Smiley wrote: > For the first ~30min maybe of the meetup existing, I incorrectly had this > for Friday. Kevin alerted me to the problem and I changed it as fast as I > could. Is there still a problem? > > ~

Re: Crave patch optimization

2023-08-23 Thread Yuvraaj Kelkar
Thanks Eric. That's exactly what we were hoping to achieve: "shift-left" . In fact, the next step is to give users the ability to run the full test suite directly from their laptops, and not have to wait for Github to run an Action. I think that

Re: [DISCUSS] Community Virtual Meetup, August 2023

2023-08-23 Thread David Smiley
For the first ~30min maybe of the meetup existing, I incorrectly had this for Friday. Kevin alerted me to the problem and I changed it as fast as I could. Is there still a problem? ~ David On Wed, Aug 23, 2023 at 11:20 PM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Shows me on

Re: [DISCUSS] Community Virtual Meetup, August 2023

2023-08-23 Thread Ishan Chattopadhyaya
Shows me on meetup.com the following, possibly in my timezone (IST): Friday, August 25, 2023, 9:30 PM to 10:30 PM That's about 36 hours away. Is there something wrong with the meetup.com event that we can fix? On Thu, 24 Aug, 2023, 8:39 am David Smiley, wrote: > Reminder: 13 hours away! >

Re: [DISCUSS] Community Virtual Meetup, August 2023

2023-08-23 Thread David Smiley
Reminder: 13 hours away! Here's the Meetup.com link (includes calendar invite) https://www.meetup.com/apache-solr-virtual-community-meetups/events/295646941/ Maybe not too many people will attend this one (summertime?) but that makes it all the better for those that do attend -- more collaboration

Re: [EXTERNAL] - Re: PR reviewed

2023-08-23 Thread Isabelle Giguere
Hi Mike; Thanks for the heads-up. Task "validateSourcePatterns" fails if there's no logger specific to the test class! I'll fix that... But... Should "validateSourcePatterns" be so picky about logging in test classes? Just a thought. Isabelle Giguère De :

Re: PR reviewed

2023-08-23 Thread Mike Drob
Resending with corrected email address On Wed, Aug 23, 2023 at 11:13 AM Mike Drob wrote: > Hi Isabelle, > > It looks like there is a precommit check issue with the code still, can > you take a look and address that? You should be able to click on > "details" for the failing check, or run it

Re: PR reviewed

2023-08-23 Thread Mike Drob
Hi Isabelle, It looks like there is a precommit check issue with the code still, can you take a look and address that? You should be able to click on "details" for the failing check, or run it locally using ./gradlew check -x test Thanks for your contribution! On Wed, Aug 23, 2023 at 9:52 AM

PR reviewed

2023-08-23 Thread Isabelle Giguere
Hello Solr committers! This PR was reviewed by Christine Poerschke and Alex D. Thank you both  IMHO, the code is as clean as it's going to get. I hope it can be merged some day. https://github.com/apache/solr/pull/1632 Regards;

Re: Crave patch optimization

2023-08-23 Thread Eric Pugh
Thank you for this work. I have found Crave to be really effective in letting me know when small commits have odd side effects. My laptop is older, so I generally can’t run the full test suite the way I want, and seeing the list of green checks from Crave running the tests is always very

Re: 8.11.3 release

2023-08-23 Thread Ishan Chattopadhyaya
Hi Jan, Yes, still targeting September. But I will slip on my initial plan of doing it by first week of September. I'm foreseeing mid September timeframe. Thanks for checking in. Regards, Ishan On Wed, 23 Aug, 2023, 5:05 pm Jan Høydahl, wrote: > Hi, > > Following up on Ishan's proposed 8.11.3

Re: 8.11.3 release

2023-08-23 Thread Jan Høydahl
Hi, Following up on Ishan's proposed 8.11.3 release (https://lists.apache.org/thread/3xjtv1sxqx8f9nvhkc0cb90b2p76nfx2) Does the Lucene project have any bugfix candidates for backporting? Ishan, are you still targeting September? Jan > 1. aug. 2023 kl. 14:57 skrev Ishan Chattopadhyaya : >