Re: Change suggestion: more efficient replica state tracking

2023-09-26 Thread Justin Sweeney
Hey Ilan, curious if you have tried PRS in your implementation or not at this point and what your experience has been if you have tried it? I believe PRS currently publishes DOWNNODE messages to overseer, but they are essentially a no-op by the overseer so they have very little impact. We are runni

Change suggestion: more efficient replica state tracking

2023-09-26 Thread Ilan Ginzburg
*TL;DR; a way to track replica state using EPHEMERAL nodes that disappear automatically when a node goes down.* Hi, When running a cluster with many collections and replicas per node, processing of DOWNNODE messages takes more time. In a public cloud setup, the node that went down can come back q

Re: [DISCUSS] SIP-19 Adopt JSR-330 dependency injection

2023-09-26 Thread Jan Høydahl
Thanks. This is for sure a reason to consider HK2 which we already use. I struggle a bit with un-winding the current class-dependency graph of Solr to figure out where it makes most sense to start a POC. I think perhaps injecting singleton CoreContainer could be a nice start. Do you know of a to

Re: [DISCUSS] SIP-19 Adopt JSR-330 dependency injection

2023-09-26 Thread Jason Gerlowski
+1 to experimenting with DI! One thing that should probably be incorporated into the SIP and resolved at some level is that Solr does have some "non-homegrown" DI currently. Jersey, the JAX-RS framework we're using to serve our v2 APIs, allows some minimal DI in the resource classes that it insta

Re: [DISCUSS] 9.4 release

2023-09-26 Thread Alex Deparvu
Hi, It seems a lot of the upgrade failures are somehow related to the CollapsingQParser ( https://solr.apache.org/guide/solr/latest/query-guide/collapse-and-expand-results.html ). If anyone is familiar with this code, I would appreciate a look at the PR, maybe something pops up. best alex On

How to enable basic auth in tests?

2023-09-26 Thread Eric Pugh
Has anyone found a good pattern for enabling basic auth in our tests? I suspect that some number of tests are basically “Does this work With and Without Basic Auth”, versus being specific to the implementation of BasicAuth. I found TestPullReplicaWithAuth.java, and it has some code to create

Re: [DISCUSS] SIP-19 Adopt JSR-330 dependency injection

2023-09-26 Thread Justin Sweeney
+1 on this SIP and a POC would make sense. I think it could be valuable to update the Motivation section with the anticipated value provided by this SIP, i.e. reduced code maintenance, removing brittle home-grown interfaces, etc. Most of my IOC/DI experience is with Spring and Dagger seems like a b

[DISCUSS] SIP-19 Adopt JSR-330 dependency injection

2023-09-26 Thread Jan Høydahl
This is the discuss thread for SIP-19 JIRA: https://issues.apache.org/jira/browse/SOLR-16998 SIP link: https://cwiki.apache.org/confluence/display/SOLR/SIP-19+Adopt+JSR-330+dependency+injection Use a standardized dependency injection in Solr instead of our home grown @SolrCoreAware, @ResourceLo