Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-03-15 Thread David Smiley
Alright; thanks for your thorough response. If you/someone notices a failure and we need to touch this again, let's follow up with a PR. And I suspect we'll want to factor out the cleanup so more tests might use this without the copy-pasted hack. Perhaps HttpJdkSolrClient could do this cleanup

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-03-15 Thread James Dyer
David, let me try and address your concerns with the approach. I am open to other approaches, however, we need something that will work consistently. I would like for what I have now to run in our CI for at least a week to see if we get more failures or not, before changing it further. I do