Hi,
Gentle reminder, if anyone has knowledge about request cleanup flows and/or
rate limiting please take a look at the proposed PR
https://github.com/apache/solr/pull/1780
Thank you in advance,
alex
On Wed, Jul 12, 2023 at 2:13 PM Alex Deparvu wrote:
> Thanks for confirming Mark.
> I create
Thanks for confirming Mark.
I created https://issues.apache.org/jira/browse/SOLR-16889 with a tentative
patch. some resource cleanup clarifications needed.
best,
alex
On Tue, Jul 11, 2023 at 6:52 PM Mark Miller wrote:
> Yup, though of course the return can't simply be added to that method, but
Yup, though of course the return can't simply be added to that method, but
sendError won't stop the request, it will just cause an error when there is
an attempt to write to the response later.
Hi,
I think there is a bug in the rate limiting code inside ServletUtils [0]:
the error code is set to 429 but the 'return' is missing so the request
will continue to be processed even if the RateLimitManager returns a
'false'. From the client's side, I think the client sees 429 but the server
wil