Re: The design of ClusterStateProvider & ClusterState

2024-04-09 Thread David Smiley
On Fri, Apr 5, 2024 at 8:52 AM Ilan Ginzburg wrote: > > I would suggest doing any such change in two independent steps: > - Moving classes around without any functional change ("pure" refactoring) > - A change to what a class exposes, its behavior etc. > Otherwise it is very hard to track what

Re: The design of ClusterStateProvider & ClusterState

2024-04-05 Thread Ilan Ginzburg
I would suggest doing any such change in two independent steps: - Moving classes around without any functional change ("pure" refactoring) - A change to what a class exposes, its behavior etc. Otherwise it is very hard to track what has simply moved and what has changed. Is the principal

The design of ClusterStateProvider & ClusterState

2024-04-04 Thread David Smiley
I've been looking at HttpClusterStateProvider lately, and of ClusterState. It has a method getClusterState which goes and loads the complete ClusterState (all collections with all state info). ClusterState is immutable. At a massive collection scale, such a method is very disconcerting!