Re: waitForState after collection creation is dumb

2024-02-06 Thread Mark Miller
I don’t recall, but it makes sense. That would be a pretty janky database. It’s a race around the client seeing the collection and seeing it in full. It wouldn’t be as bad if the full collection state was just written out rather than the super legacy related, build it up piece by piece, but even

Re: waitForState after collection creation is dumb

2024-02-06 Thread Gus Heck
Ah, unless someone fixed it since the last time Mark Miller ranted about it, it's rooted in the fact that the call to create a collection returns to the user before the collection is ready to use. IIRC the rant said something like "what database would return from CREATE TABLE before the table was

waitForState after collection creation is dumb

2024-02-06 Thread David Smiley
Hey... about about that click-bait title; ehh? :-D I've noticed that basically any SolrCloudTestCase will create a collection and then call waitForState. I think this is dumb; do we ask our clients to do the same? Then why should our tests do this? I can understand some tests may have