Review request for bz #7871

2020-11-23 Thread Philip Prindeville
Can I please get a review (and commit) of: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7871 Specifically attachment 5731: https://bz.apache.org/SpamAssassin/attachment.cgi?id=5731=view Thanks.

Rules for detecting unnecessary header encoding in Quoted-Printable

2019-01-11 Thread Philip Prindeville
I’m getting a fair amount of Spam where the To, From, and Subject lines have been unnecessarily encoded using QP even though they’re all ASCII. This is a violation of RFC-2822 and Postel’s Law, and a characteristic of Spam more often than Ham (where legitimate MUA’s attempt to use the least

Re: warn: Use of uninitialized value $4 in concatenation (.) or string at Mail/SpamAssassin/Plugin/URIDNSBL.pm line 1042.

2017-06-07 Thread Philip Prindeville
I’m still seeing this now. And yes, for spamhaus. And yes, $ip is being passed in as ‘(‘. It should be possible to get a stack trace and figure out why it’s being passed in as that value... Are we any closer to having a fix for this? I’m leaving a file here:

Re: Poor performance for rule based on 8-bit chars in supposedly text/plain, 7bit message

2016-11-01 Thread Philip Prindeville
> On Oct 31, 2016, at 3:09 PM, RW <rwmailli...@googlemail.com> wrote: > > On Mon, 31 Oct 2016 12:28:27 -0600 > Philip Prindeville wrote: > > >>> PP_MIME_FAKE_ASCII_TEXT: bad, avg S/O=0.62 avg Spam%=0.64 avg >>> Ham%=0.36 > >> I’m going b

Poor performance for rule based on 8-bit chars in supposedly text/plain, 7bit message

2016-10-31 Thread Philip Prindeville
> On Apr 1, 2015, at 2:30 AM, Rules Report Cron > wrote: > > rulesrc/sandbox/kmcgrail/20_bug_7063.cf (1 rules, 1 bad): > > PP_MIME_FAKE_ASCII_TEXT: bad, avg S/O=0.62 avg Spam%=0.64 avg Ham%=0.36 Hi Kevin, I’m going back through the performance of this rule

Results for PP_TOO_MUCH_UNICODE02

2014-08-05 Thread Philip Prindeville
Was wondering if anyone had results from running this rule against a corpus? We don’t see enough messages to have valid statistical measurements, and we apply a lot of other checks (such as GeoIP blacklisting certain countries like VEnezuela, IRan, BulGaria, VietNam, etc) so we don’t have a

Various breakfast pastries and unicode entities

2014-07-20 Thread Philip Prindeville
Hi Kevin, What would be your breakfast food of choice for looking at bz #7068? :-) This rule looks for sequences of #x; in MIME parts that claim to be text/plain, and 7 or 8bit CTE. You can set the threshold ration, i.e. if the ratio of unicode entities to ordinary characters exceeds

Testing patch effectiveness with ruleqa

2014-06-30 Thread Philip Prindeville
I came up with a rule which I’ve found to be fairly effective locally but wanted to test its performance in a broader universe. I know I can use Rule-QA to test existing (committed) rules, but what if I wanted to test my patch and include its performance with my submission? Is there an easy

Re: Plugin for filtering based on local criteria

2014-06-24 Thread Philip Prindeville
On Jun 17, 2014, at 9:07 PM, Kevin A. McGrail kmcgr...@pccc.com wrote: On 6/17/2014 10:49 PM, Philip Prindeville wrote: I’ve contributed fixes to Apache itself since 1997 (though not with any regularity), but can’t remember if I’ve ever had to furnish a CLA or not. Of course. Small fixes

Re: Plugin for filtering based on local criteria

2014-06-17 Thread Philip Prindeville
know I am curious if you could do a bit more description on why this is good to implement, what time of spam you use it to block, etc. in the pm? Regards, KAM On 6/15/2014 10:47 PM, Philip Prindeville wrote: Here’s a first attempt at a module. I based it on Plugin::URIDetail

Having PerMsgStatus.pm do name lookups?

2014-06-16 Thread Philip Prindeville
I opened a bug: https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7054 because I thought that this is something fairly common that the core module could do on behalf of plugins rather than having the modules (a) duplicate the functionality, possibly getting it wrong, and (b) generate a

Plugin for filtering based on local criteria

2014-06-15 Thread Philip Prindeville
Here’s a first attempt at a module. I based it on Plugin::URIDetail. It depends on Net::CIDR::Lite and Geo::IP. If it detects a valid (though not necessarily current) ISP database, it will publish a handler for that. Same with the IP-Lite (or licensed IP) database from MaxMind. We’ve been