[Bug 8060] [review] Fix meta handling for metas without dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060 Henrik Krohns changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #7 from Henrik Krohns --- Committed with few extra additions to basic_meta2.t tests: Sendingtrunk/lib/Mail/SpamAssassin/Conf/Parser.pm Sendingtrunk/lib/Mail/SpamAssassin/Conf.pm Sendingtrunk/lib/Mail/SpamAssassin/Plugin/Check.pm Sendingtrunk/t/basic_meta2.t Transmitting file data done Committing transaction... Committed revision 1904529. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8059] [review] Fix meta handling for URIDNSBL NS/A lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8059 Henrik Krohns changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Henrik Krohns --- +1 Sendingtrunk/lib/Mail/SpamAssassin/Plugin/URIDNSBL.pm Transmitting file data .done Committing transaction... Committed revision 1904528. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7892] T_KAM_HTML_FONT_INVALID false positive for " !important"
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7892 Kevin A. McGrail changed: What|Removed |Added Target Milestone|3.4.6 |4.0.1 CC||kmcgr...@apache.org --- Comment #6 from Kevin A. McGrail --- Marking as a 4.0.1 target -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8057] dcc, pyzor, and extracttext plugins fail if there is a space in the configured executable path
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8057 Kevin A. McGrail changed: What|Removed |Added CC||kmcgr...@apache.org Target Milestone|Undefined |4.0.1 --- Comment #4 from Kevin A. McGrail --- Marking as a 4.0.1 target -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8060] [review] Fix meta handling for metas without dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060 Kevin A. McGrail changed: What|Removed |Added CC||kmcgr...@apache.org --- Comment #6 from Kevin A. McGrail --- +1 from me as well -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8059] [review] Fix meta handling for URIDNSBL NS/A lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8059 Kevin A. McGrail changed: What|Removed |Added CC||kmcgr...@apache.org --- Comment #3 from Kevin A. McGrail --- +1 from me as well -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7735] Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 --- Comment #47 from Henrik Krohns --- The more I've seen complex real world meta rulesets, network rules behaving badly, being blocked etc... I'm wondering if the current "unrun" handling makes more trouble than it's worth. No one has tackled the issue yet on mass checks either: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735#c28 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8057] dcc, pyzor, and extracttext plugins fail if there is a space in the configured executable path
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8057 --- Comment #3 from Mark Martinec --- Created attachment 5841 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5841=edit split-string-like-shell.pl If someone wants to play with it and integrate into suitable places, I'm contributing my implementation of a string-splitting function, which strictly follows parsing rules of a Bourne shell (and bash, etc.). Note that these rules have some traditional idiosyncrasies, as documented in a comment. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8061] Fix meta handling for $suppl_attrib->{rule_hits}
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8061 Henrik Krohns changed: What|Removed |Added Depends on||7735 Referenced Bugs: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 [Bug 7735] Meta rules need to handle missing/unrun dependencies -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7735] Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735
Henrik Krohns changed:
What|Removed |Added
Blocks||8061
Referenced Bugs:
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8061
[Bug 8061] Fix meta handling for $suppl_attrib->{rule_hits}
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8061] Fix meta handling for $suppl_attrib->{rule_hits}
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8061 Henrik Krohns changed: What|Removed |Added Target Milestone|Undefined |4.0.0 CC||apa...@hege.li -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8061] New: Fix meta handling for $suppl_attrib->{rule_hits}
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8061
Bug ID: 8061
Summary: Fix meta handling for $suppl_attrib->{rule_hits}
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: All
OS: All
Status: NEW
Severity: blocker
Priority: P2
Component: Libraries
Assignee: dev@spamassassin.apache.org
Reporter: apa...@hege.li
Target Milestone: Undefined
Per list discussion, meta handling breaks when amavisd for example supplies
$suppl_attrib->{rule_hits} for Check.pm.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8060] [review] Fix meta handling for metas without dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060 Bill Cole changed: What|Removed |Added CC||billc...@apache.org --- Comment #5 from Bill Cole --- +1 to commit -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8059] [review] Fix meta handling for URIDNSBL NS/A lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8059 Bill Cole changed: What|Removed |Added CC||billc...@apache.org --- Comment #2 from Bill Cole --- +1 to commit -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8060] [review] Fix meta handling for metas without dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060 --- Comment #4 from Henrik Krohns --- More I think about it, more it seems to make sense. meta FOO 0 meta FOO 1 Those should not differ in the way they effect any metas. It's just a difference of rule hitting or not. So +1 for my original patch. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8060] [review] Fix meta handling for metas without dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060 --- Comment #3 from Henrik Krohns --- On the other hand, maybe this is an advantage, so user can choose which way to disable a rule? # Disable rule, consider rule unrun, don't let any meta depending on it be run score DISABLED_RULE 0 # Disable rule, consider result not hitting, let any meta depending on it be run meta DISABLED_RULE 0 -- -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7735] Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 Henrik Krohns changed: What|Removed |Added Blocks||8059, 8060 Referenced Bugs: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8059 [Bug 8059] [review] Fix meta handling for URIDNSBL NS/A lookups https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060 [Bug 8060] [review] Fix meta handling for metas without dependencies -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8059] [review] Fix meta handling for URIDNSBL NS/A lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8059 Henrik Krohns changed: What|Removed |Added Depends on||7735 Referenced Bugs: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 [Bug 7735] Meta rules need to handle missing/unrun dependencies -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8060] [review] Fix meta handling for metas without dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060 Henrik Krohns changed: What|Removed |Added Depends on||7735 Referenced Bugs: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735 [Bug 7735] Meta rules need to handle missing/unrun dependencies -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8060] [review] Fix meta handling for metas without dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060 --- Comment #2 from Henrik Krohns --- The patch might affect the common "meta DISABLED_RULE 0" usage, which previously I think was considered an "unrun" rule, now it is considered run rule that did not hit. Which now differs from other common way of "score DISABLED_RULE 0", which still makes rule "unrun". I think both should have identical results, but should be allow metas depending on them to fully evaluate or not? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8060] [review] Fix meta handling for metas without dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060 Henrik Krohns changed: What|Removed |Added Summary|Fix meta handling for metas |[review] Fix meta handling |without dependencies|for metas without ||dependencies Target Milestone|Undefined |4.0.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8060] Fix meta handling for metas without dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060 Henrik Krohns changed: What|Removed |Added CC||apa...@hege.li --- Comment #1 from Henrik Krohns --- Created attachment 5840 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5840=edit Fix metas without deps Fix with minor cleanups and improved test that catches this. Vote to commit. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8060] New: Fix meta handling for metas without dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060
Bug ID: 8060
Summary: Fix meta handling for metas without dependencies
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: All
OS: All
Status: NEW
Severity: blocker
Priority: P2
Component: Libraries
Assignee: dev@spamassassin.apache.org
Reporter: apa...@hege.li
Target Milestone: Undefined
As seen on list, metas without dependencies are not always run correctly.
Depending on rule running order due to perl hashes being random order, SA4TA3
will not evaluate if both subrules did not run before it.
meta __SA4TA3_1 6
meta __SA4TA3_2 2
meta SA4TA3(__SA4TA3_1 > 2) && (__SA4TA3_2 > 1)
This was because metas without dependencies were not recorder in
$pms->{meta_check_ready}, thus do_meta_tests did not run them at all, and
finish_meta_tests is not able to handle this scenario.
Fixed by saving metas without dependencies to $conf->{meta_nodeps} and
initializing $pms->{meta_check_ready} from it.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7892] T_KAM_HTML_FONT_INVALID false positive for " !important"
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7892
tbsmar...@gmail.com changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED |---
CC||tbsmar...@gmail.com
--- Comment #5 from tbsmar...@gmail.com ---
Patch finally arrived at my system - and ... it doesn't fix anything.
Sorryy for not looking at the patch at the time.
Note: I'am not really into perl at all so i may be wrong.
But for me it looks like this revision 1887889 seems to allow this:
color: !important;
Because it's a simple copy & paste of the 7778 solution to allow the special
'inherit' value. However needed is this:
color: white !important;
background-color: white !important;
I guess a fix should look like this:
@@ -515,6 +515,9 @@
if (/^\s*(background-)?color:\s*(.+?)\s*$/i) {
my $whcolor = $1 ? 'bgcolor' : 'fgcolor';
my $value = lc $2;
+ # Strip of trailing !important to prevent parsing as 'invalid
color'
+ # (Bug 7892)
+ $value =~ s/^([^\s]+)\s*!important$/$1/;
if ($value =~ /rgb/) {
$value =~ tr/0-9,//cd;
@@ -527,10 +530,6 @@
# do nothing, just prevent parsing of the valid
# CSS3 property value as 'invalid color' (Bug 7778)
}
-elsif ($value eq '!important') {
- # do nothing, just prevent parsing of the valid
- # CSS3 property value as 'invalid color' (Bug 7892)
-}
else {
$new{$whcolor} = name_to_rgb($value);
}
--
You are receiving this mail because:
You are the assignee for the bug.
