[Bug 8228] Stricter syntax warning in Perl 5.39
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8228 Sidney Markowitz changed: What|Removed |Added Target Milestone|Undefined |4.0.1 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Sidney Markowitz --- % svn ci -m "8228 fix operator precedence error caught by perl 5.39 warning" spamassassin.raw Sendingspamassassin.raw Transmitting file data .done Committing transaction... Committed revision 1916242. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8228] Stricter syntax warning in Perl 5.39
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8228 Sidney Markowitz changed: What|Removed |Added CC||sid...@sidney.com --- Comment #1 from Sidney Markowitz --- Actually, now that I'm reading it over, it looks like the warning has found a longstanding bug. The documentation I linked to uses as an example exactly what is being warned here. It says exit $x ? 0 : 1; # actually parses as: exit($x) ? 0 : 1; spamassassin.raw line 293 is exit $res ? 1 : 0; We intend exit($res ? 1 : 0); not exit($res) ? 1 : 0; right? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8228] New: Stricter syntax warning in Perl 5.39
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8228 Bug ID: 8228 Summary: Stricter syntax warning in Perl 5.39 Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All OS: All Status: NEW Severity: normal Priority: P2 Component: Building & Packaging Assignee: dev@spamassassin.apache.org Reporter: sid...@sidney.com Target Milestone: Undefined Perl 5.39 has a new stricter check for code that may be misleading due to obscure precedence of operators. See https://perldoc.perl.org/blead/perl5396delta and the errors in spamassassin.raw line 293 https://www.cpantesters.org/cpan/report/017fa1c0-dff2-11ee-8d78-4d126e8775ea This just needs to be parenthesized to eliminate the warning. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8227] Detect bad DNS network setup early in build
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8227 --- Comment #4 from Sidney Markowitz --- (In reply to Giovanni Bechis from comment #2) > The bits added to DependencyInfo.pm breaks install on some networks where > SpamAssassin would work by adding "dns_server 127.0.0.1" option. What I was trying to do was overkill anyway. Instead killing the entire build, and not even suppressing all network tests, since most of them won't trigger big DNS replies or whatever is going wrong with multihomed addresses, I can do this: Put the test of getting the txttcp large packet in a function in t/SATest.pm and have only the tests that actually fail when it is a problem call it (not all network tests have to care about it). If it fails, they can skip all tests with a warning message that dns_server may have to be set when running SpamAssassin on that system. Add the check of multihomed to t/spamc_H.t so it can skip the tests with a similar warning if something is wrong with the local DNS resolver that affects getting those records. That will prevent the egregious failure reports on those CPAN test machines that have bad DNS configuration without breaking any builds, and will warn people who need to use dns_server options in their configuration. How does that seem? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8225] askdns TCP fallback not working with UDP truncated TXT response
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8225 Sidney Markowitz changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #10 from Sidney Markowitz --- Clicked the Save button too soon. Trying again to close this. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8225] askdns TCP fallback not working with UDP truncated TXT response
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8225 --- Comment #9 from Sidney Markowitz --- (In reply to Giovanni Bechis from comment #8) > Actually this patch respects "dns_server" option because Yup, you're right, I must be smarter (or more thorough (or luckier)) than I thought I was. Re-closing the issue. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8225] askdns TCP fallback not working with UDP truncated TXT response
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8225 --- Comment #8 from Giovanni Bechis --- Actually this patch respects "dns_server" option because TCP fallback dns server is setup using "get_resolver" method of Mail::SpamAssassin::DnsResolver class which reads its configuration from SpamAssassin configuration files. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8225] askdns TCP fallback not working with UDP truncated TXT response
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8225 Sidney Markowitz changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #7 from Sidney Markowitz --- Reopening to deal with problem noticed in bug 8227 comment 3 that this patch does not respect any dns_server config options when it calls Net::DNS::Resolver -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8227] Detect bad DNS network setup early in build
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8227 Sidney Markowitz changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #3 from Sidney Markowitz --- (In reply to Giovanni Bechis from comment #2) > The bits added to DependencyInfo.pm breaks install on some networks where > SpamAssassin would work by adding "dns_server 127.0.0.1" option. Oh, that's a problem for the fix I did for bug 8225 too, because the calls to Net::DNS::Resolver aren't using the dns_server conf options. I also didn't think about t/config.dist default is run_net_tests=n which this check ignores, breaking the install on systems that will not get test failures. Ok, I'll have to revert that part of the commit. The new t/dnsplatform.t test is still useful, though. If it fails it signals that the failures in the other network tests that fail can be ignored, and that dns_server config options may be necessary to run on that system. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8227] Detect bad DNS network setup early in build
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8227 Giovanni Bechis changed: What|Removed |Added CC||giova...@paclan.it --- Comment #2 from Giovanni Bechis --- The bits added to DependencyInfo.pm breaks install on some networks where SpamAssassin would work by adding "dns_server 127.0.0.1" option. -- You are receiving this mail because: You are the assignee for the bug.
