[Bug 4316] spamd loops spawning children that die immediately.

2005-05-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=4316





--- Additional Comments From [EMAIL PROTECTED]  2005-05-09 01:29 ---
Subject: Re:  spamd loops spawning children that die immediately.

 I suppose I could get shot for asking this, but given the syslog
 issue, is there any support for throwing in an option to log to a file?

You'd only be shot if it was documented in the spamd manual.





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 4260] rewrite DNS code to use a single socket, event-based model

2005-05-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=4260





--- Additional Comments From [EMAIL PROTECTED]  2005-05-09 01:52 ---
 aren't we already dropping the bogus packets immediately?

Those are just the ones that we can tell are bogus because it is, e.g., a reply
to a query for a domain's nameserver that arrives in response to a URIDNSBL 
lookup.

We don't have a way of catching collisions causing a wrong URIDNSBL result.

Actually that gives me an idea for the next several hour test: I could use a
hash and generate a warning for all dropped packets to see how much of a problem
there is that we are not seeing.

BTW, I just realized that we don't have to generate a hash explicitly. Right now
we use the ID as the key in a hash table that associates the packet with the
callback function that is supposed to process it:

  $self-{id_to_callback}-{$id} = $cb; # in bgsend
and
  my $cb = delete $self-{id_to_callback}-{$id}; # in poll_responses

If instead we keyed on $id . $host in bgsend and in poll_response get the host
name from the question section to key on $id . $host we would eliminate
collisions without any more code. The extra memory for the strings is only one
string for each backgrounded DNS query in a single message, then they are
cleaned up.

The reason I'm not $suggesting $id . $host . $type is because when I was testing
I noticed that $type sometimes is left to default in the call to bgsend and
shows up as different values in the reply, and I don't now offhand what to set
it to in bgsend. With port, id, and host name all matching I'm sure it will be 
fine.

Does anyone see a problem with that?



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 4176] [review] RFE: please add pattern for nate.com redirector

2005-05-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-05-09 08:57 ---
Committed revision 169334




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.


[Bug 4260] rewrite DNS code to use a single socket, event-based model

2005-05-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=4260





--- Additional Comments From [EMAIL PROTECTED]  2005-05-09 08:58 ---
Instead of $host, why not use question-data ?  It's easy to get to and much
more thorough.



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 4176] [review] RFE: please add pattern for nate.com redirector

2005-05-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=4176





--- Additional Comments From [EMAIL PROTECTED]  2005-05-09 09:21 ---
Subject: Re:  [review] RFE: please add pattern for nate.com redirector

On Mon, May 09, 2005 at 12:40:22AM -0700, [EMAIL PROTECTED] wrote:
 redirector_pattern /^(?:http://)?chkpt\.zdnet\.com/chkpt/\w+/(.*)$/
 
 why is '(?:http://)?' conditional?  should we not just ensure that any input 
 to
 that match will always be a full URL with protocol, and leave off the
 conditionality?

+1  the rest of the uri_list_canonify() code will make sure it's a FQ URL
anyway.





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.


[Bug 4260] rewrite DNS code to use a single socket, event-based model

2005-05-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=4260





--- Additional Comments From [EMAIL PROTECTED]  2005-05-09 10:03 ---
It's not possible to encode the difference between a final . and no final .
in a question section, so that's not an issue.  The only other issue would be
differences in character case.  RFC 1035 section 2.3.3 states The data
distribution system in the domain system will ensure that consistent
representations are preserved.  Experimentation shows that BIND does preserve
case in the question section.




--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 4144] FORGED_IMS_HTML and FORGED_IMS_TAGS false-positive.

2005-05-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=4144





--- Additional Comments From [EMAIL PROTECTED]  2005-05-09 14:57 ---
Ajay can you please attach a *complete* message, including all of the received
headers?



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3615] RFE: trust_env_sender_networks parameter

2005-05-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3615


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2005-05-09 16:36 ---
always_trust_envelope_sender in 3.1 provides this functionality (bug 4140)

*** This bug has been marked as a duplicate of 4140 ***



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 4301] MSN Groups mails are reported as spam

2005-05-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=4301


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2005-05-09 17:16 ---
*** Bug 4168 has been marked as a duplicate of this bug. ***



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3742] New: previous fix for umask causes potential untie() issues

2004-09-01 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3742

   Summary: previous fix for umask causes potential untie() issues
   Product: Spamassassin
   Version: SVN Trunk (Latest Devel Version)
  Platform: Other
OS/Version: other
Status: NEW
  Severity: blocker
  Priority: P1
 Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: [EMAIL PROTECTED]


Apparently the fix from bug 3731 causes DBM to be unable to untie() on certain 
platforms (at least 
Windows, possibly all,) because we do:

$res = tie ...

so that $res gets a copy of the tie object, and apparently untie() doesn't deal 
well with both the array 
and the object hanging around, netting:

carp untie attempted while $count inner references still exist if 
$count;

according to the perltie doc:

   To get the script to work properly and silence the warning make sure
   there are no valid references to the tied object before untie() is
   called:

   undef $x;
   untie $fred;

patch due shortly.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3740] yahoo bounce are filtered out by spamassassin

2004-09-02 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3740





--- Additional Comments From [EMAIL PROTECTED]  2004-09-01 19:37 ---
Subject: Re:  yahoo bounce are filtered out by spamassassin

 d) failure to properly attach a sample will result in closing of the
 bug as WONTFIX

Actually, it's INVALID in that case.





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3740] yahoo bounce are filtered out by spamassassin

2004-09-02 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3740





--- Additional Comments From [EMAIL PROTECTED]  2004-09-01 21:27 ---
I read your comments enough to form a hypotheses ofthe problem and a solution.
You say that all the information is in what you pasted in the various comments.
I say, once again, that we need a copy of an actual email as received by
MIMEDefang before it is processed, ATTACHED (note that word and the emphasis
again) to this bug report, so we have a real test case with which to verify the
bug *and the fix* before any change to code is checked in.

Are you really saying that the entire header that you got from yahoo.com was
comprised of:

Received: from mta368.mail.scd.yahoo.com (mta368.mail.scd.yahoo.com 
[66.94.234.148])
  by ns2.bizsystems.net with LOCAL id i81JYPNu012882
  for [EMAIL PROTECTED]; Wed, 01 Sep 2004 12:34:29 -0700 (PDT)
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
X-Loop: [EMAIL PROTECTED]
Subject: Delivery failure

Does that mean that the mail server at ns2.bizsystems.net is taking an SMTP
connection refused by mta368.mail.scd.yahoo.com and making it look like an email
sent from MAILER-DAEMON at yahoo.com? That would be a forgery. What is the
explanation for only one Received header with LOCAL ID?

I'm afraid that without being able to reproduce this and without seeing the
actual mail that was delivered and passed through to SpamAssassin there is not
much we can do. And if you can get such a sample, please attach it as an
attachment using Bugzilla's Create New Attachment link so that we get it as an
attachment.





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3744] New: db format conversion not working

2004-09-02 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3744

   Summary: db format conversion not working
   Product: Spamassassin
   Version: SVN Trunk (Latest Devel Version)
  Platform: Sun
OS/Version: Solaris
Status: NEW
  Severity: major
  Priority: P5
 Component: Learner
AssignedTo: dev@spamassassin.apache.org
ReportedBy: [EMAIL PROTECTED]


I am trying to upgrade from 2.64 to 3.0.0-rc2. I am running Solaris 8 and
perl 5.8.0.  I copied the bayes database from our production machine running
2.64 to a test machine which has 3.0.0-rc2.  Both machines are running
Solaris 8. When I ran sa-learn --sync I got:

bayes: bayes db version 2 is not able to be used, aborting! at
/opt/perl/lib/site_perl/5.8.0/Mail/SpamAssassin/BayesStore/DBM.pm line 160.
untie attempted while 1 inner references still exist at
/opt/perl/lib/site_perl/5.8.0/Mail/SpamAssassin/BayesStore/DBM.pm line 493.

When I ran sa-learn --dump I got:

bayes: bayes db version 0 is not able to be used, aborting! at
/opt/perl/lib/site_perl/5.8.0/Mail/SpamAssassin/BayesStore/DBM.pm line 160.
bayes: bayes db version 0 is not able to be used, aborting! at
e_perl/5.8.0/Mail/SpamAssassin/BayesStore/DBM.pm line 160.
ERROR: Bayes dump returned an error, please re-run with -D for more information

I will attach the debug output along with the whole test session.
Note that I could not check to see if this was already known as none of
your mailing list archives have anything later than 29-August in them.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3744] db format conversion not working

2004-09-02 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3744





--- Additional Comments From [EMAIL PROTECTED]  2004-09-02 13:31 ---
Created an attachment (id=2302)
 -- (http://bugzilla.spamassassin.org/attachment.cgi?id=2302action=view)
sa-learn debug output

The test session with the sa-learn debug output



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3742] [review] previous fix for umask causes potential untie() issues

2004-09-02 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3742





--- Additional Comments From [EMAIL PROTECTED]  2004-09-02 13:50 ---
FYI: I was able to reproduce the behavior trying to upgrade from my previous v2 
DB to a v3 DB, 
although the upgrade does complete:

untie attempted while 1 inner references still exist at 
lib/Mail/SpamAssassin/BayesStore/DBM.pm line 
493.
debug: bayes: upgraded database format from v2 to v3 in 163 seconds
debug: refresh: 28211 refresh 
/home/felicity/SA/spamassassin-head/masses/spamassassin/
bayes.mutex
debug: Syncing complete.


Including patch 2300 solves the issue for me.



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3742] [review] previous fix for umask causes potential untie() issues

2004-09-02 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3742





--- Additional Comments From [EMAIL PROTECTED]  2004-09-02 13:55 ---
+1



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3742] [review] previous fix for umask causes potential untie() issues

2004-09-02 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3742





--- Additional Comments From [EMAIL PROTECTED]  2004-09-02 13:59 ---
Subject: Re:  [review] previous fix for umask causes potential untie() issues

+1

Michael





--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3743] Spamd not cleaning up defunct processes

2004-09-03 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3743





--- Additional Comments From [EMAIL PROTECTED]  2004-09-02 16:10 ---
hrm.  it seems like for some reason either 1) the OS isn't sending a SIGCHLD
when the child exits, so the parent doesn't know to wait for it and spawn a new
child, or 2) the parent is somehow not paying attention/able to receive to
signals/was hit by SIGSTOP/etc.

In the logs posted, I can see 8145 being spawned:

Sep  2 17:57:48 larry spamd[9297]: server hit by SIGCHLD, pid 9307
Sep  2 17:57:48 larry spamd[9297]: server successfully spawned child process,
pid 8145

but there is no record of a SIGCHLD being received when it exited.

 Could there be some kind of polling code to verify whether the child processes
are in a zombie state and act accordingly.

Not in the current spamd.  The parent has no interaction with the children
beyond spawning them and cleaning up when a SIGCHLD is received.  That's all the
parent does actually, it sits in a sleep() until a signal comes along to wake 
it up.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3745] no SPEWS testing in the headers tests

2004-09-03 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3745





--- Additional Comments From [EMAIL PROTECTED]  2004-09-02 16:11 ---
worth noting that SPEWS is currently listing our mailing lists, too. ;)



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 2978] patch to add support for fuzzy matching

2004-09-03 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=2978





--- Additional Comments From [EMAIL PROTECTED]  2004-09-02 19:57 ---
Created an attachment (id=2303)
 -- (http://bugzilla.spamassassin.org/attachment.cgi?id=2303action=view)
Scott Crosby's edit-distance script

here's another edit-distance tool.  Scott Crosby pinged me about it and I said
I'd upload it to the bz.  it's FP rate seems a little safer...

samples:

: jm 1174...; cat /usr/share/dict/words | perl ~/DL/distance2.pl viagra 2.0
Agra viagra :  1.5;
miqra viagra :  1.9;
Sagra viagra :  1.8;
ultra viagra :  2;
vajra viagra :  1.8;
vara viagra :  1.5;
viagram viagra :  0.9;
viagraph viagra :  1.8;
viga viagra :  1.5;
vigia viagra :  1.8;
vihara viagra :  1.8;
Vira viagra :  1.5;

: jm 1168...; echo 'l()l!t.a' | perl ~/ftp/distance2.pl lolita 2.0
l()l!t.a lolita :  1.24;




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3238] Score below 10 is not zero-padded causes bad sorting

2004-09-03 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3238





--- Additional Comments From [EMAIL PROTECTED]  2004-09-03 09:08 ---
So, there are a couple of vetos on this, anyone want to change their position?

If we want to do it I kinda like a new _PADSCORE_ or whatever it should be
called that presents a padded (however it is 0 or space) score, but other than
that I have no opinion.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3746] New: README does not mention /etc/opt/mail/spamassassin

2004-09-03 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3746

   Summary: README does not mention /etc/opt/mail/spamassassin
   Product: Spamassassin
   Version: SVN Trunk (Latest Devel Version)
  Platform: Sun
OS/Version: other
Status: NEW
  Severity: minor
  Priority: P5
 Component: Documentation
AssignedTo: dev@spamassassin.apache.org
ReportedBy: [EMAIL PROTECTED]


This is for 3.0.0-rc2.  The README file mentions several places where
configuration files may be located, but does not mention
/etc/opt/mail/spamassassin.  I no longer remember how I found out about
this directory, but that is where my local.cf file is located.

By the way, what would be the correct way to report problems with your
web pages and such?  Right now none of the mailing list archives are
receiving new entries.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3238] Score below 10 is not zero-padded causes bad sorting

2004-09-03 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3238





--- Additional Comments From [EMAIL PROTECTED]  2004-09-03 10:58 ---
Subject: Re:  Score below 10 is not zero-padded causes bad sorting 

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


_PAD0SCORE_ and _PAD00SCORE_ makes sense to me.  I agree that
a three-digit variant is a good idea, given that a blacklisting
will add 100 points.

- --j.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFBOLDTQTcbUG5Y7woRAncTAKC3j0AzNBR3npynyL7t2Be07fW7JQCg7U9D
5kICBtMsX2QJskyENjsVn4g=
=+fHX
-END PGP SIGNATURE-





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3238] Score below 10 is not zero-padded causes bad sorting

2004-09-03 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3238





--- Additional Comments From [EMAIL PROTECTED]  2004-09-03 12:01 ---
Subject: Re:  Score below 10 is not zero-padded causes bad sorting 

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1


OK, I can go with _SCORE(x)_ where x =  , 0, 00,etc.

- --j.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFBOL9rQTcbUG5Y7woRAvMDAKDnIPEC52hIYPM1hkmNgeSoUoFsqQCcCfmf
+4EGI/d/d7NOMivqYhUVAyE=
=GwR3
-END PGP SIGNATURE-





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3746] README does not mention /etc/opt/mail/spamassassin

2004-09-03 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3746





--- Additional Comments From [EMAIL PROTECTED]  2004-09-03 13:04 ---
I see by greping around that local_rules_dir is set to
/etc/opt/mail/spamassassin at make time (at least on Solaris).
I don't find any man pages anywhere.  perldoc Mail::Spamassassin and
perldoc Mail::SpamAssassin::Conf do not show the value of local_rules_dir.
I wish that I could remember how I found out about this directory in the past.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3625] [review] sysklogd rpm install stopped spamd processing

2004-09-03 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3625

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|sysklogd rpm install stopped|[review] sysklogd rpm
   |spamd processing|install stopped spamd
   ||processing



--- Additional Comments From [EMAIL PROTECTED]  2004-09-03 13:18 ---
excellent! marking for review...



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3746] README does not mention /etc/opt/mail/spamassassin

2004-09-04 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3746





--- Additional Comments From [EMAIL PROTECTED]  2004-09-03 18:46 ---
Looking more closely at the README file, I see that it says to look at the
first few lines of spamassassin or spamd to see the values of the __*__
variables.  So either this bug should be closed as WORKSFORME or the
Summary should be changed to man pages missing if indeed they are.
I still can't find them.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3746] README does not mention /etc/opt/mail/spamassassin

2004-09-04 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3746





--- Additional Comments From [EMAIL PROTECTED]  2004-09-03 18:59 ---
the manpages are whereever perl was configured to put them -- which is set at
perl build time...   SA doesn't control that at all.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3748] mass-check hangs

2004-09-04 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3748

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||dev@spamassassin.apache.org
 AssignedTo|dev@spamassassin.apache.org |[EMAIL PROTECTED]
   Severity|normal  |blocker
  Component|Masses  |Libraries
   Priority|P5  |P1
   Target Milestone|Future  |3.0.0



--- Additional Comments From [EMAIL PROTECTED]  2004-09-04 13:48 ---
grrr

I figured out what the problem is:

--=DreamInTech.nfra21WAS2.Mail.Engine40fd71588f855
Content-Type: message/delivery-status

--=DreamInTech.nfra21WAS2.Mail.Engine40fd71588f855


the message subparsing is looking for input, but it's a blank part so it's
looking to STDIN.

grumble grumble   patch forthcoming.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.


[Bug 3749] New: message parser skips blank/invalid(?) parts

2004-09-04 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3749

   Summary: message parser skips blank/invalid(?) parts
   Product: Spamassassin
   Version: SVN Trunk (Latest Devel Version)
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P3
 Component: Libraries
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
CC: dev@spamassassin.apache.org


While debugging bug 3748, I found that we completely skip parts with no body
section.  I don't think this is a major issue since there's nothing in the part
that we need to scan, but we should be adding a node for the part in the tree.



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3749] message parser skips blank/invalid(?) parts

2004-09-04 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3749





--- Additional Comments From [EMAIL PROTECTED]  2004-09-04 14:13 ---
Created an attachment (id=2314)
 -- (http://bugzilla.spamassassin.org/attachment.cgi?id=2314action=view)
sample mail

I don't remember if the text/plain part is actually invalid or not since
there's the header, the blank line, then immediately the boundary.  It's
actually the same behavior as having no blank line there BTW.



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3748] [review] mass-check hangs

2004-09-04 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3748





--- Additional Comments From [EMAIL PROTECTED]  2004-09-04 15:45 ---
Just an FYI: confirmed, the patch fixes the problem here. Thanks. 



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3750] decode_attachments not used

2004-09-05 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3750





--- Additional Comments From [EMAIL PROTECTED]  2004-09-04 16:00 ---
Subject: Re:  decode_attachments not used

On Sat, Sep 04, 2004 at 03:45:09PM -0700, [EMAIL PROTECTED] wrote:
 Just had another think. What I need is to be able to apply all the SA rules in
 the current object to non-text attachments. 2.6x only worked on text 
 attachments

Well, what you really want is to apply all of _your_ rules to all attachments.
You definitely don't want the standard SA rules to do so.

 (and html and variants of course). I need to apply my rules to *all*
 attachments, regardless of whether they are text or not. I need to work on
 Microsoft Word document attachments, Excel spreadsheets, all sorts of stuff 
 like
 that.

 Will 3.x work on all binary attachments? If not, how do I pursuade it to do 
 it?

Not for standard rule types (header, body, rawbody, uri), and you can't.  The
code very deliberatly only looks at leaf node text/* and message/* parts.

It sounds like you want to write a plugin that has custom eval code to go
through the message parts and apply your non-text-based rules.





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 2947] RFE: Test to catch invalid HTML Obfuscation

2004-09-05 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=2947





--- Additional Comments From [EMAIL PROTECTED]  2004-09-04 20:11 ---
Created an attachment (id=2316)
 -- (http://bugzilla.spamassassin.org/attachment.cgi?id=2316action=view)
Proposed obfuscating HTML tag rule

Rule just refined for SARE. Primary authors Bob Menschel and Jesse Houwing. My
corpus mass-check shows no significant overlap with current 3.0.0 distribution
rules. 
OVERALL%   SPAM% HAM% S/ORANK   SCORE  NAME
  6383238897249350.609   0.000.00  (all messages)
100.000  60.9365  39.06350.609   0.000.00  (all messages as %)
  5.973   9.8028   0.1.000   1.002.22  SARE_HTML_INV_TAG




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3675] [review] pick a project logo

2004-09-05 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3675





--- Additional Comments From [EMAIL PROTECTED]  2004-09-04 23:56 ---
Subject: Re:  [review] pick a project logo

 1 - Color scheme - Hot (4.x)
 2 - Line thickness - Fatter (1.x)  ;)

Look at the bottom: thickness 4.3d/4.4d, 4.3e/4.4e, or 4.3f/4.4f?  I
think d is way too fat.  Note that f is much thicker than 4.2 (which I
liked best, but I backed off and asked Christian to experiment in the
middle area since you and I disagreed).

 3 - Logotype integrated - I like it integrated.

 To be honest, I think we may be missing something from the cold
 colour scheme -- I liked the v1.0 variant, with the more hot orange
 envelopes against the cold background.  I'd vote for that if it had
 been an option ;)

1.0 was okay, but I doubt it would work with the green/red-orange
envelopes which I like best so far (in 4.3 and 4.4).  Christian is
leaving colors to last, though.





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3750] decode_attachments not used

2004-09-05 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3750

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-05 04:58 ---
I have found an easy way to implement the functionality I need. Thanks to all
for your help.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3749] message parser skips blank/invalid(?) parts

2004-09-05 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3749

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|[review] message parser |message parser skips
   |skips blank/invalid(?) parts|blank/invalid(?) parts



--- Additional Comments From [EMAIL PROTECTED]  2004-09-05 10:44 ---
taking out of review state



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3751] New: content-type header parsing doesn't catch malformed boundaries

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3751

   Summary: content-type header parsing doesn't catch malformed
boundaries
   Product: Spamassassin
   Version: SVN Trunk (Latest Devel Version)
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P5
 Component: Libraries
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
CC: dev@spamassassin.apache.org


while debugging bug 3749 I found that we strictly followed rfc 1521 for
content-type/boundary parsing:

Content-Type: multipart/mixed;boundary= 
=_NextPart_000_00CF_35AE65B6.B53B4CCB

(there's a space between the = and the open quote)

that's invalid according to the RFC, and so we deemed it invalid and didn't
catch the boundary.  We really should though.

patch forthcoming



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3751] content-type header parsing doesn't catch malformed boundaries

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3751

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Target Milestone|Future  |3.0.0





--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3751] content-type header parsing doesn't catch malformed boundaries

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3751





--- Additional Comments From [EMAIL PROTECTED]  2004-09-05 17:09 ---
Created an attachment (id=2318)
 -- (http://bugzilla.spamassassin.org/attachment.cgi?id=2318action=view)
suggested patch

this patch adds in optional whitespace before a double-quoted boundary.  ie:

boundary=foo

will get foo, but

boundary=foo

won't be caught.  the latter seems to likely to falsely grab a boundary without
the quotes -- for instance:

boundary=  ; charset=...

would make ; the boundary, which isn't right.  if this becomes an issue, we
can try to work in a heuristic to grab the latter malformation.



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3751] [review] content-type header parsing doesn't catch malformed boundaries

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3751

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|content-type header parsing |[review] content-type header
   |doesn't catch malformed |parsing doesn't catch
   |boundaries  |malformed boundaries



--- Additional Comments From [EMAIL PROTECTED]  2004-09-05 17:12 ---
moving to review state

the patch is tested to fix the stated issue.  through testing, so far, the
changes that occur via mass-check are all valid.



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3751] [review] content-type header parsing doesn't catch malformed boundaries

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3751





--- Additional Comments From [EMAIL PROTECTED]  2004-09-05 17:58 ---
just to note, at least mutt and Outlook Express parse the malformed boundary 
out.



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3749] message parser skips blank/invalid(?) parts

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3749

[EMAIL PROTECTED] changed:

   What|Removed |Added

Attachment #2315 is|0   |1
   obsolete||



--- Additional Comments From [EMAIL PROTECTED]  2004-09-05 18:15 ---
Created an attachment (id=2319)
 -- (http://bugzilla.spamassassin.org/attachment.cgi?id=2319action=view)
new version

same as before, but fixes the boundary issues which were causing the issues.



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3749] [review] message parser skips blank/invalid(?) parts

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3749

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|message parser skips|[review] message parser
   |blank/invalid(?) parts  |skips blank/invalid(?) parts



--- Additional Comments From [EMAIL PROTECTED]  2004-09-05 18:16 ---
back to review mode. :)



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3752] New: MICROSOFT_EXECUTABLE rule does not flag recent virus

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3752

   Summary: MICROSOFT_EXECUTABLE rule does not flag recent virus
   Product: Spamassassin
   Version: 2.64
  Platform: All
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P5
 Component: Rules (Eval Tests)
AssignedTo: dev@spamassassin.apache.org
ReportedBy: [EMAIL PROTECTED]


Recently I am hit with a virus that uses a pif file which BASE64 encoded starts
like this:

TVoAAAEC/

Spamassassin's MICROSOFT_EXECUTABLE rule does not pick this up. Since file(1)
does report it as an executable file, I changed the way spamassassin searches
for executables. It's a simple patch for EvalTests.pm



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3752] MICROSOFT_EXECUTABLE rule does not flag recent virus

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3752

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2004-09-06 08:30 ---
Sorry, in the upcoming version 3.0 the MICROSOFT_EXECUTABLE test is no longer 
part of the SpamAssassin rulebase.  I think somebody wanted to write a plugin 
for that but I can't remember who it was (and where its available). 



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3752] MICROSOFT_EXECUTABLE rule does not flag recent virus

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3752

[EMAIL PROTECTED] changed:

   What|Removed |Added

  BugsThisDependsOn||3010





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3754] New: sa-learn: successful return code though file not found

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3754

   Summary: sa-learn: successful return code though file not found
   Product: Spamassassin
   Version: unspecified
  Platform: Other
   URL: http://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=261346repeatmerged=no
OS/Version: other
Status: NEW
  Severity: minor
  Priority: P5
 Component: Learner
AssignedTo: dev@spamassassin.apache.org
ReportedBy: [EMAIL PROTECTED]


Package: spamassassin
Version: 2.63-1
Severity: minor

Hi,

the subject says it all...

sa-learn --spam --mbox /does/not/exist ; echo $?

will demonstrate it.

Eduard.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3753] -H should have long name

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3753





--- Additional Comments From [EMAIL PROTECTED]  2004-09-06 11:18 ---
Ah, I see.  It was missing in the SYNOPSIS.  Added in r43421. 



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3753] -H should have long name

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3753





--- Additional Comments From [EMAIL PROTECTED]  2004-09-06 11:28 ---
Subject: Re:  -H should have long name

 Ah, I see.  It was missing in the SYNOPSIS.  Added in r43421. 

Argh... I was just preparing a patch. :-)




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3753] -H should have long name

2004-09-06 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3753





--- Additional Comments From [EMAIL PROTECTED]  2004-09-06 12:00 ---
Sorry, I didn't even see that it was you who filed/forwarded the bug -- I just 
knew that there's already such a long name because I always thought the name 
sucks :~) 



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3555] Several False Positive Rules on Same Message

2004-09-07 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3555

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2004-09-06 19:15 ---
Message has score of 0, not a problem.




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3756] New: Misplaced close-angle-brackets in PoD doc

2004-09-07 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3756

   Summary: Misplaced close-angle-brackets in PoD doc
   Product: Spamassassin
   Version: SVN Trunk (Latest Devel Version)
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P5
 Component: Documentation
AssignedTo: dev@spamassassin.apache.org
ReportedBy: [EMAIL PROTECTED]


 



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3756] Misplaced close-angle-brackets in PoD doc

2004-09-07 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3756





--- Additional Comments From [EMAIL PROTECTED]  2004-09-06 21:29 ---
Subject: Re:  Misplaced close-angle-brackets in PoD doc

On Mon, Sep 06, 2004 at 09:25:35PM -0700, [EMAIL PROTECTED] wrote:
 Someone want to do up a patch?

It's documentation, just check in the fixed version. ;)





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3649] pyzor check timed out after 10 secs (Bad file descriptor)

2004-09-07 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3649





--- Additional Comments From [EMAIL PROTECTED]  2004-09-07 13:26 ---
Just to keep the status current, tested with 3.0.0-rc3 and pyzor still times 
out.  I understand that this may not be resolved until the SA 3.1.0 release, 
but I hope that release will come very soon after 3.0.0 is released, as I am 
sure there are many SA users that also use Pyzor.

You might also consider adding a statement about Pyzor not working with SA 
3.0.0 in the release notes (that is, if you plan to release without Pyzor 
support), just so that people are not caught off-guard.

Bill




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3649] pyzor check timed out after 10 secs (Bad file descriptor)

2004-09-07 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3649





--- Additional Comments From [EMAIL PROTECTED]  2004-09-07 13:35 ---
Subject: Re:  pyzor check timed out after 10 secs (Bad file descriptor)

Data Point:

No pyzor timeout problems here with RC3, in fact I've been running
some version of the latest and greatest for awhile and haven't seen
any sort of pyzor timeouts.

Michael





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3755] Add configuration setting: use_language

2004-09-07 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3755





--- Additional Comments From [EMAIL PROTECTED]  2004-09-07 13:47 ---
I am planing to implement this. I would like your input on the following idea:

- Add use_language as a $CONF_TYPE_STRING configuration setting with default
  value LANG
- In parse sub replace the $lang variable with the value of use_language if
  different from LANG.
- Move the 30_text_*.cf file from the rules directory to a seperator directory
  (eg lang/)
- Load these file after the userpref file in the init sub.

Is that OK?




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3649] pyzor check timed out after 10 secs (Bad file descriptor)

2004-09-07 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3649





--- Additional Comments From [EMAIL PROTECTED]  2004-09-07 14:02 ---
Exchaged several e-mail with Justin Mason a few weeks ago, and have not heard 
that the issue has been resolved.  Got from bugzilla this on 8/27:

http://bugzilla.spamassassin.org/show_bug.cgi?id=3649

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Target Milestone|3.1.0   |Future

So as far as I know, this is not resolved, unless you can tell me what you did 
to get Pyzor to work with Amavisd-New and SA 3.0.0-x.  If I convert back to SA 
2.64 on the same system, Pyzor works fine.

Bill



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3649] pyzor check timed out after 10 secs (Bad file descriptor)

2004-09-07 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3649





--- Additional Comments From [EMAIL PROTECTED]  2004-09-07 14:15 ---
IIRC I was still waiting for the specific error message that pyzor outputs on 
fd 2.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3649] pyzor check timed out after 10 secs (Bad file descriptor)

2004-09-07 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3649





--- Additional Comments From [EMAIL PROTECTED]  2004-09-07 14:38 ---
Justin, here is the text of our last e-mail exchange on this:

- Original Message - 
From: Justin Mason [EMAIL PROTECTED]

 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA1


 Bill Landry writes:
  - Original Message - 
  From: [EMAIL PROTECTED]
 
   http://bugzilla.spamassassin.org/show_bug.cgi?id=3649
  
   --- Additional Comments From [EMAIL PROTECTED]  2004-08-16
22:56 ---
   ok, that still doesn't contain the pyzor STDERR output.
 
   could you rerun the strace with -f -e write=2?
 
  Justin, maybe the attached strace output will help.  I ran: strace -f -o
  test.txt amavisd debug-sa and captured lots of data.

 nope, that's not it.

 17365 write(2, self.readheaders()\n, 19 unfinished ...
 17366 write(2, self.readheaders()\n, 19 unfinished ...

 those lines need the complete text.

Okay, well I don't know where to go from here.  The feedback I got from Mark
Martinec, the developer of Amavisd-New was:
===
Logging goes to stderr when running in debug mode, e.g.:

  amavisd debug err.log 21

It also goes to stderr if process is not daemonized:

  amavisd foreground  err.log 21
===

but that didn't give you what you wanted either, so, now what...?

Bill
=

But I heard no follow-up...

Bill



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3740] yahoo bounce are filtered out by spamassassin

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3740





--- Additional Comments From [EMAIL PROTECTED]  2004-09-07 17:41 ---
nah, we don't need to patch the code for this; a def_whitelist_from_rcvd
entry fixes it:

 pts rule name  description
 -- --
 0.3 NO_REAL_NAME   From: does not include a real name
 1.8 MSGID_FROM_MTA_ID  Message-Id for external message added locally
 -15 USER_IN_DEF_WHITELIST  From: address is in the default white-list
 2.1 FORGED_YAHOO_RCVD  'From' yahoo.com does not match 'Received' headers
 0.1 MAILTO_TO_SPAM_ADDRURI: Includes a link to a likely spammer email
-1.7 BAYES_00   BODY: Bayesian spam probability is 0 to 1%
[score: 0.0001]


(at least it does as long as the receiving relay -- b.mx.sonic.net
in the sample mail -- is trusted, which it should be.)

patch to follow.




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3751] [review] content-type header parsing doesn't catch malformed boundaries

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3751

[EMAIL PROTECTED] changed:

   What|Removed |Added

Attachment #2320 is|0   |1
   obsolete||



--- Additional Comments From [EMAIL PROTECTED]  2004-09-07 19:41 ---
Created an attachment (id=2324)
 -- (http://bugzilla.spamassassin.org/attachment.cgi?id=2324action=view)
revised patch

still need to remove  characters

tested this patch and it works well, seems to simulate behavior of common MUAs
better than current SVN so I say go with it

One note, it's possible we might get better results being LOOSER than common
MUAs since we could render more HTML, find MIME_HTML_ONLY more often, etc.
More testing is needed there.  At the very least, I think we should consider
being as loose as everyone, not just the most common MUAs.




--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3749] [review] message parser skips blank/invalid(?) parts

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3749

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-07 20:18 ---
committed, again. :)

r43492



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3675] [review] pick a project logo

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3675





--- Additional Comments From [EMAIL PROTECTED]  2004-09-07 21:22 ---
ok, so I haven't posted in a while.

1) line thickness, I think a/d is too thick, and c/f is too thin.  for the 
messages, I'm thinking a 
corporate cartoony style is good -- I want it c/f is too clean cut, but 
a/d is too cartoon-like.

2) font.  to be honest, I don't like any of them, needs to be more stylish imo.

3) colors.  hrm.  I don't like green green red for messages.  if we want the 
pastel feel, 4.3a is pretty 
decent.  I'm not a big fan of the background colors.  yellow is out, green 
feels, well, icky, to me.  kind of 
a '70s thing going on there.

4) integration.  I think I'd rather have the name and graphic separate.


overall, I'm still looking for something with a little more attitude.  I want 
something that is clean and 
non-aggressive, but with some style and flair.  the current listing is, well, 
pretty boring.  
SpamAssassin, ho-hum, you know?



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 2235] Body Tests for Spaced-Out Words

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=2235





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 00:43 ---
Is it possible to write this rule without backtracking (the \1) ?

Backtracking is notoriously slow.




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 2235] Body Tests for Spaced-Out Words

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=2235





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 00:43 ---
Also, Brian did you submit a CLA?




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3757] New: mismatch : hits/required and Spam-Level/Spam-Status

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3757

   Summary: mismatch : hits/required and Spam-Level/Spam-Status
   Product: Spamassassin
   Version: 2.64
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P5
 Component: Rules (Eval Tests)
AssignedTo: dev@spamassassin.apache.org
ReportedBy: [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]


X-Spam-Checker-Version: SpamAssassin 2.64 (2004-01-11) on smtp1.afp.com
X-Spam-Status: No, hits=5.0 required=5.0 tests=BAYES_90,BIZ_TLD,
HTML_IMAGE_ONLY_06,HTML_MESSAGE,HTML_WEB_BUGS,MIME_HTML_NO_CHARSET,
MIME_HTML_ONLY,UPPERCASE_25_50 autolearn=no version=2.64
X-Spam-Level: 
X-MailScanner: Found to be clean



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3757] mismatch : hits/required and Spam-Level/Spam-Status

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3757

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 03:46 ---


*** This bug has been marked as a duplicate of 2607 ***



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 2607] Fixing X-Spam-Status: No, hits=5.0 required=5.0

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=2607

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 03:46 ---
*** Bug 3757 has been marked as a duplicate of this bug. ***



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3740] [review] yahoo bounce are filtered out by spamassassin

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3740





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 03:56 ---
Now my comment:  +1 AFAICS 



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3758] BayesSQL: Updating ham_count for token does not flag a newest_token_age update

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3758





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 12:35 ---
Created an attachment (id=2327)
 -- (http://bugzilla.spamassassin.org/attachment.cgi?id=2327action=view)
Patch File




--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3758] [review] BayesSQL: Updating ham_count for token does not flag a newest_token_age update

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3758

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|BayesSQL: Updating ham_count|[review] BayesSQL: Updating
   |for token does not flag a   |ham_count for token does not
   |newest_token_age update |flag a newest_token_age
   ||update



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 12:37 ---
Please review, it is really trivial but at the core of the _put_token code so
I'm hesitant to just commit.



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3759] SA3: Plugin cache fails for parse_config if plugins are loaded from multiple modules

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3759

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |major
   Target Milestone|Future  |3.0.0



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 13:25 ---
needs investigation



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3758] [review] BayesSQL: Updating ham_count for token does not flag a newest_token_age update

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3758





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 13:26 ---
+1 looks sane to me



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3760] New: BayesSQL: tok_touch_all produces invalid sql when called with no tokens

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3760

   Summary: BayesSQL: tok_touch_all produces invalid sql when called
with no tokens
   Product: Spamassassin
   Version: SVN Trunk (Latest Devel Version)
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P5
 Component: Learner
AssignedTo: dev@spamassassin.apache.org
ReportedBy: [EMAIL PROTECTED]


If no significant tokens are found then tok_touch_all gets called with with an
empty array of tokens.  tok_touch_all doesn't check for this condition so it
generates some bogus SQL code.

a) tok_touch_all shouldn't even be called if it's not going to do anything.

b) tok_touch_all should check for this condition and just return.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3760] BayesSQL: tok_touch_all produces invalid sql when called with no tokens

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3760

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||dev@spamassassin.apache.org
 AssignedTo|dev@spamassassin.apache.org |[EMAIL PROTECTED]
   Target Milestone|Future  |3.0.0



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 14:06 ---
Taking



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.


[Bug 3740] [review] yahoo bounce are filtered out by spamassassin

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3740





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 14:39 ---
+1




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3760] BayesSQL: tok_touch_all produces invalid sql when called with no tokens

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3760





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 14:55 ---
Created an attachment (id=2328)
 -- (http://bugzilla.spamassassin.org/attachment.cgi?id=2328action=view)
Patch File

Moves tok_touch_all call til after the score is determined and returns in
tok_touch_all if no tokens are available for updating.



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3760] [review] BayesSQL: tok_touch_all produces invalid sql when called with no tokens

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3760

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|BayesSQL: tok_touch_all |[review] BayesSQL:
   |produces invalid sql when   |tok_touch_all produces
   |called with no tokens   |invalid sql when called with
   ||no tokens



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 14:56 ---
Moving to review.



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3758] [review] BayesSQL: Updating ham_count for token does not flag a newest_token_age update

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3758

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 15:00 ---
From IRC:
quinlan Herk: +1 on your patch


Committed revision 43545.




--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3760] [review] BayesSQL: tok_touch_all produces invalid sql when called with no tokens

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3760





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 15:10 ---
+1.   I presume it doesn't have major effects on speed...



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3761] New: spamd memory use grows too high (leak?)

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3761

   Summary: spamd memory use grows too high (leak?)
   Product: Spamassassin
   Version: unspecified
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P5
 Component: spamc/spamd
AssignedTo: dev@spamassassin.apache.org
ReportedBy: [EMAIL PROTECTED]


spamd was started at Sep  7 22:45

About 19 hours later, here's memory use:

/etc/init.d  date
Wed Sep  8 17:33:28 EDT 2004

/etc/init.d  ps axu | grep spam
root  2302  0.0  6.5 56084 33660 ?   SSep07   0:48 [spamd]
root  2303  0.0  6.6 60860 34280 ?   SSep07   0:52 [spamd]
root  2304  0.0  6.8 60336 35196 ?   SSep07   0:51 [spamd]
root  2305  0.0  6.3 60032 32840 ?   SSep07   0:38 [spamd]
root  2306  0.0  7.0 61436 36444 ?   SSep07   0:57 [spamd]
root 18780  0.0  0.1  1672  612 pts/1S17:32   0:00 grep spam

/etc/init.d  free
 total   used   free sharedbuffers cached
Mem:515280 500572  14708  0  40440 124084
-/+ buffers/cache: 336048 179232
Swap:   514040 230184 283856

/etc/init.d  ./spam*n restart (reduced to 1 thread to minimize RAM use)
Shutting down spamd:[  OK  ]
Starting spamd: [  OK  ]

/etc/init.d  ps axu | grep spam
root 18879  0.0  0.1  1668  604 pts/1S17:32   0:00 grep spam

/etc/init.d  free
 total   used   free sharedbuffers cached
Mem:515280 387296 127984  0  41000 124836
-/+ buffers/cache: 221460 293820
Swap:   514040 101364 412676

30 minutes later...
/root  date
Wed Sep  8 18:02:12 EDT 2004

/etc/init.d  ps axu | grep spam
root 18893  0.1  5.8 32440 30244 ?   S17:32   0:02 [spamd]



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3740] [review] yahoo bounce are filtered out by spamassassin

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3740

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 15:37 ---
ok, applied - r43549.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3761] spamd memory use grows too high (leak?)

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3761





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 15:39 ---
Please fill out the Version field above.  Is that Mandrake you're running 
under? 



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3759] SA3: Plugin cache fails for parse_config if plugins are loaded from multiple modules

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3759





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 15:44 ---
fwiw, my test case doesn't repro the problem:

ebug: plugin: MyPlugin2=HASH(0x8e855d0) implements 'parse_config'
parse_config called at /home/jm/ftp/sa/trunk/rtst/p2.pm line 22.
debug: using /home/jm/.spamassassin for user state dir

.
debug: registering glue method for check_for_foo (MyPlugin1=HASH(0x8e7b968))
check_for_foo called at /home/jm/ftp/sa/trunk/rtst/p1.pm line 22.
...

both are called OK.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3762] Plugins should be able to be called after learn

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3762

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Target Milestone|Future  |3.0.0



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 15:47 ---
yep, you're right.   +1 on applying this, and IMO it's a trivial fix.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3759] SA3: Plugin cache fails for parse_config if plugins are loaded from multiple modules

2004-09-08 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3759





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 15:52 ---
Here you go:

local.cf

loadplugin Mail::SpamAssassin::Plugin::empty_body
body E_EMPTYBODY eval:esoft_empty_body()
describe E_EMPTYBODY Body is empty
scoreE_EMPTYBODY 2.5

zz_local_cf:

report_safe 0
required_hits 5
auto_whitelist_path /var/spool/mail/.spamassassin/auto-whitelist
auto_whitelist_file_mode 0666
bayes_path /var/spool/mail/.spamassassin/bayes
skip_rbl_checks 1
rbl_timeout 10
use_dcc 0
dcc_timeout 10
dns_available no

loadplugin Mail::SpamAssassin::Plugin::another
another_value 20

emptybody.pm

=head1

To try this out, write these lines to /etc/mail/spamassassin/plugintest.cf:

  loadplugin Mail::SpamAssassin::Plugin::empty_body
  header E_EMPTYBODY eval:empty_body()

=cut

package Mail::SpamAssassin::Plugin::empty_body;

use Mail::SpamAssassin::Plugin;
use strict;
use bytes;

use vars qw(@ISA);
@ISA = qw(Mail::SpamAssassin::Plugin);

# constructor: register the eval rule
sub new {
  my $class = shift;
  my $mailsaobject = shift;

  # some boilerplate...
  $class = ref($class) || $class;
  my $self = $class-SUPER::new($mailsaobject);
  bless ($self, $class);

  # the important bit!
  $self-register_eval_rule (empty_body);

  print registered Mail::SpamAssassin::Plugin::empty_body: $self\n;
  return $self;
}

# and the eval rule itself
sub empty_body {
  my ( $self, $msg ) = @_;

  my $textary = $msg-get_decoded_stripped_body_text_array();

  return 1 if ( join('', @{$textary} ) =~ /^\s*$/ );
#  return 1 if ( $msg =! /^\s*$/ );
  return 0;
}

1;

another.pm
--
=head1

To try this out, write these lines to /etc/mail/spamassassin/plugintest.cf:

  loadplugin Mail::SpamAssassin::Plugin::another
  header E_EMPTYBODY eval:another()

=cut

package Mail::SpamAssassin::Plugin::another;

#use Mail::SpamAssassin::Conf;
use Mail::SpamAssassin::Plugin;
#use Mail::SpamAssassin;
sub dbg { Mail::SpamAssassin::dbg (@_); }
use strict;
use bytes;

use vars qw(@ISA);
@ISA = qw(Mail::SpamAssassin::Plugin);

# constructor: register the eval rule
sub new {
  my $class = shift;
  my $mailsaobject = shift;


  # some boilerplate...
  $class = ref($class) || $class;
  my $self = $class-SUPER::new($mailsaobject);
  bless ($self, $class);

  my $conf = $mailsaobject-{conf};
  $conf-{another_value} = 1;

  # the important bit!
  $self-register_eval_rule (another);

  print registered Mail::SpamAssassin::Plugin::another: $self\n;
  return $self;
}

sub another{
  my ( $self, $msg ) = @_;
  return 0;
}

sub parse_config {
  my ($self, $opts) = @_;

  my $conf = $opts-{conf};
  my $key = $opts-{key};
  my $value = $opts-{value};

  dbg(You'll never see me in the logs with this bug!);
  if ( $key eq 'another_value' ) {
 $self-{main}-{conf}-{esoft_required_hits_learn} = $value;
 return $Mail::SpamAssassin::Plugin::INHIBIT_CALLBACKS;
  }

  return 0;
}

1;



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3763] New: Empty $opts-{'message'} defaults to GLOB, blocking the service

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3763

   Summary: Empty $opts-{'message'} defaults to GLOB, blocking the
service
   Product: Spamassassin
   Version: SVN Trunk (Latest Devel Version)
  Platform: All
   URL: http://www.ijs.si/software/amavisd/trouble-sa-loop.txt
OS/Version: All
Status: NEW
  Severity: major
  Priority: P3
 Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: [EMAIL PROTECTED]


With SA 3.0.0-rc3 (and earlier 3.0.0-pre*): the attached URL contains 
a sample mail message which blocks SA processing when SA is called 
from amavisd-new; mail processing gets stuck until it times out. 
 
The provided sample mail contains an empty attachment of 
Content-Type: message/disposition-notification, which triggers 
a bug in module Mail/SpamAssassin/Message.pm, subroutine new. 
The guilty statement is: 
  my $message = $opts-{'message'} || \*STDIN; 
 
As the $opts-{'message'} is defined in this case, but contains 
an empty string (a false), the $message value defaults to \*STDIN, 
which in case of the amavisd-new environment is a socket for 
communication with MTA. Few lines further, the statement 
  @message = $message; 
tries to read from this socket, and the whole protocol 
gets stuck until a timeout occurs, the mail is requeued 
for the next attempt which is bound to fail again. 
 
A quick fix is to use: 
  my $message = defined $opts-{'message'} || \*STDIN; 
although I'm not sure what the logic about \*STDIN should 
really be. 
 
Regards 
   Mark



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3763] Empty $opts-{'message'} defaults to GLOB, blocking the service

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3763

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 17:16 ---


*** This bug has been marked as a duplicate of 3748 ***



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3748] [review] mass-check hangs

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3748

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 17:16 ---
*** Bug 3763 has been marked as a duplicate of this bug. ***



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3760] [review] BayesSQL: tok_touch_all produces invalid sql when called with no tokens

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3760





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 17:22 ---
+1



--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.


[Bug 3762] [review] Plugins should be able to be called after learn

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3762

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Plugins should be able to be|[review] Plugins should be
   |called after learn  |able to be called after
   ||learn



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 17:27 ---
+1

a few comments.

1) patches really need to be *attached* to the message, not cut/paste (even a 
one line one), as it says 
clearly when a ticket is opened.

2) I think we're going to need to go through and plugin-ize the code a bit 
more.  It was originally 
planned as a way to have eval rules without having to modify EvalTests, but now 
it's becoming a very 
generic way of doing code things without patches -- which is good, but I don't 
want to just start 
randomly adding in calls around.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3762] [review] Plugins should be able to be called after learn

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3762





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 18:06 ---
Subject: Re:  [review] Plugins should be able to be called after learn

On Wed, Sep 08, 2004 at 05:40:35PM -0700, [EMAIL PROTECTED] wrote:
 useful.  the overhead of a new plugin hook should be very minor, though, so we
 can probably pepper them a bit more liberally...

yeah, it's just something I'd like us to sit down and come up with a plan for
3.1.





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3759] SA3: Plugin cache fails for parse_config if plugins are loaded from multiple modules

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3759





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 18:18 ---
Created an attachment (id=2329)
 -- (http://bugzilla.spamassassin.org/attachment.cgi?id=2329action=view)
fix

ok, here's a fix.  The bug only happens if the new plugins are loaded from the
site config path (/etc/mail/spamassassin by default), because by that stage,
SpamAssassin has compiled the list of callbacks for parse_config().

the fix is to invalidate that cached list if a new plugin is loaded.   For
efficiency, and due to a perl shortcoming, only a subset of the callback
methods are invalidated -- the ones that can run at config time -- namely
parse_config() only.

(the shortcoming: perl doesn't have introspection of what methods an
object supports as far as I can see.  worked around, anyway)

I've also folded in the fix for a bug someone reported on the dev list I think
-- using $INHIBIT_CALLBACKS is a misfeature, because it forces plugins to only
support numeric return types on methods, instead of allowing string return
types.   this is bad.   So this drops support for $INHIBIT_CALLBACKS, and
parse_config() implementors that were using that now have to use the
alternative $self-inhibit_further_callbacks() API.  (in reality it
makes virtually no difference to the amount of code required; using
the alternative API is a matter of 10 characters.)




--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3759] [review] Plugin cache fails for parse_config if plugins are loaded from multiple modules

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3759

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|SA3: Plugin cache fails for |[review] Plugin cache fails
   |parse_config if plugins are |for parse_config if plugins
   |loaded from multiple modules|are loaded from multiple
   ||modules





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3762] [review] Plugins should be able to be called after learn

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3762





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 18:30 ---
+1



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3759] [review] Plugin cache fails for parse_config if plugins are loaded from multiple modules

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3759





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 19:28 ---
I've confirmed the fix here.  Thanks!



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3759] [review] Plugin cache fails for parse_config if plugins are loaded from multiple modules

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3759





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 19:30 ---
+1



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3759] [review] Plugin cache fails for parse_config if plugins are loaded from multiple modules

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3759





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 20:18 ---
+1

I'm not really familiar with the Plugin code, but the patch looks ok to me.  
The only issue I found was 
that the POD text is a little messed up, and I've already prompted jm about it. 
 basically instead of gt 
it's Egt.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3759] [review] Plugin cache fails for parse_config if plugins are loaded from multiple modules

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3759

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 20:40 ---
checked in -- r43564.  fix applied for the -Egt pod messiness too



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


  1   2   3   4   5   6   7   8   9   10   >