[Bug 8250] t/tainted_msg.t fails if Test module not installed even though it doesn't need it
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8250 Sidney Markowitz changed: What|Removed |Added Target Milestone|Undefined |4.0.2 CC||sid...@sidney.com Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Sidney Markowitz --- trunk % svn ci -m "bug 8250 - Remove unnecessary use Test;" t/data/taintcheckplugin.pm Sendingt/data/taintcheckplugin.pm Transmitting file data .done Committing transaction... Committed revision 1917349. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8250] New: t/tainted_msg.t fails if Test module not installed even though it doesn't need it
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8250 Bug ID: 8250 Summary: t/tainted_msg.t fails if Test module not installed even though it doesn't need it Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All OS: All Status: NEW Severity: normal Priority: P2 Component: Regression Tests Assignee: dev@spamassassin.apache.org Reporter: sid...@sidney.com Target Milestone: Undefined Test is a core module in perl, but perl on Amazon Linux doesn't have it. t/tainted_msg.t loads a test plugin taintcheckplugin.pm that has "use Test;" but doesn't reference anything from the Test module. The only thing that the "use Test;" line does is cause the test to fail when run under a perl that does not have the Test module. I have a report of that happening from someone who has installed on an Amazon Linux ec2 instance on aws using the perl provided with it. I'll remove the "use Test;" line. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7818] Thinking To Learn Machine Learning Course Online!
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7818 Sidney Markowitz changed: What|Removed |Added Component|spamassassin|spamtrash Assignee|dev@spamassassin.apache.org |sid...@sidney.com -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8249] Implement suppl_attrib 'return_path' and improve documentation
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8249 Kent Oyer changed: What|Removed |Added Attachment #5953|0 |1 is obsolete|| CC||k...@mxguardian.net --- Comment #1 from Kent Oyer --- Created attachment 5954 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5954=edit Revised patch Revised documentation -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8249] New: Implement suppl_attrib 'return_path' and improve documentation
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8249 Bug ID: 8249 Summary: Implement suppl_attrib 'return_path' and improve documentation Product: Spamassassin Version: 4.0.2 Hardware: PC OS: Linux Status: NEW Severity: minor Priority: P2 Component: Libraries Assignee: dev@spamassassin.apache.org Reporter: k...@mxguardian.net Target Milestone: Undefined Created attachment 5953 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5953=edit suppl_attrib patch The documentation for Mail::SpamAssassin hints that you can pass SMTP envelope information to the parse() subroutine through the $suppl_attrib parameter. However, this doesn't seem to be implemented. I have implemented it and improved the documentation for $suppl_attrib based on what I've seen in the code. Let me know if this looks good and I can commit or if more changes are needed. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8248] Search for score on both rule name and description
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8248 Benny Pedersen changed: What|Removed |Added CC||m...@junc.eu --- Comment #2 from Benny Pedersen --- SH_* is spamhaus dqs https://www.spamhaus.com/product/data-query-service/ https://github.com/spamhaus/spamassassin-dqs as i recall now part of spamassassin without the custom plugin ? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8248] Search for score on both rule name and description
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8248 Sidney Markowitz changed: What|Removed |Added CC||sid...@sidney.com --- Comment #1 from Sidney Markowitz --- What tool are you using to customize scores? I don't off the top of my head know of one that is part of SpamAssassin. Could it be something that your ISP provides for configuring your spam filtering? In which case that's who you have to file the enhancement request with. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8247] Add rule for excessive Unicode escapes in From header
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8247 Benny Pedersen changed: What|Removed |Added CC||m...@junc.eu --- Comment #1 from Benny Pedersen --- add an example in attachment, i will properly come up with a rule to catch it, as i understand it you have sample that have multiple UTF-8 in from: ? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8248] New: Search for score on both rule name and description
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8248 Bug ID: 8248 Summary: Search for score on both rule name and description Product: Spamassassin Version: unspecified Hardware: Macintosh OS: Mac OS X Status: NEW Severity: normal Priority: P2 Component: Tools Assignee: dev@spamassassin.apache.org Reporter: docor...@sonic.net Target Milestone: Undefined When I go to /email/spam/scores/ to customize my scores, there is the ability to search for a particular score. It appears to search only the score name. It would be better if it also searched the description. This would help whenever a different or abbreviated word were used in the rule name. For example, if I search on domain I get 11 results. But if I view all rules, there are at least 20 rules with domain in the description but not in the name. In some cases, in the name, domain is abbreviated as "DOM" but in other cases it is not present in the name at all. Some samples: Abbreviated as DOM: PDS_FRNOM_TODOM_DBL_URL 0.001 Customize Reset From Name to domain, double URL PDS_FRNOM_TODOM_NAKED_TO0.528 Customize Reset Naked to From name equals to Domain Name has DOMAIN: PDS_FROM_NAME_TO_DOMAIN 0.713 Customize Reset From:name looks like To:domain Not present in the name at all: SH_DBL_BODY 8 Customize Reset The domain of an email address found in body is listed in DBL SH_DBL_HEADERS 8 Customize Reset A domain found in headers (mail from, reply-to etc..) is listed in DBL -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8247] New: Add rule for excessive Unicode escapes in From header
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8247 Bug ID: 8247 Summary: Add rule for excessive Unicode escapes in From header Product: Spamassassin Version: unspecified Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Rules Assignee: dev@spamassassin.apache.org Reporter: docor...@sonic.net Target Milestone: Undefined I'm noticing most spam that is getting caught has Unicode escapes in the From header, but some gets through. It would be nice to add detection. For example: From: =?UTF-8?Q?GutterHe?= =?UTF-8?Q?ro___Tel?= =?UTF-8?Q?escopic_?= =?UTF-8?Q?__Wand__?= But sometimes they don't set off enough detectors, so the spam gets through. it would be nice to add this as a detection. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8246] SEO stands for “search engine optimization.”
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8246 John Hardin changed: What|Removed |Added Assignee|dev@spamassassin.apache.org |jhar...@impsec.org Status|NEW |RESOLVED Component|Building & Packaging|bzspam Resolution|--- |INVALID --- Comment #1 from John Hardin --- Spam, deleting. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8246] New: SEO stands for “search engine optimization.”
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8246 Bug ID: 8246 Summary: SEO stands for “search engine optimization.” Product: Spamassassin Version: 4.0.1 Hardware: PC OS: Windows 10 Status: NEW Severity: normal Priority: P2 Component: Building & Packaging Assignee: dev@spamassassin.apache.org Reporter: jannatulferdousmokta...@gmail.com Target Milestone: Undefined SEO stands for “search engine optimization.” In simple terms, SEO means the process of improving your website to increase its visibility in Google, Microsoft Bing, and other search engines whenever people search for: Products you sell. Services you provide https://afazrum4.blogspot.com/;>seo -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8245] undefined value as an ARRAY reference in DMARC plugin
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8245 Sidney Markowitz changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Severity|trivial |normal --- Comment #3 from Sidney Markowitz --- This is simpler to reproduce than I expected, and I underestimated the severity. The log message is just a warning, but the plugin eval fails when it happens, as evidenced by a test failure. In a test environment running perl 5.18.4 (or any 5.16 or 5.18), with the modules for SPF, DKIM, and DMARC installed and with net tests enabled in t/config.dist (all the requirements to run t/dmarc.t), this bug causes t/dmarc.t to fail with messages warn: plugin: eval failed: Can't use an undefined value as an ARRAY reference at ../blib/lib/Mail/SpamAssassin/Plugin/DMARC.pm line 336 Committed the fix: trunk % svn ci -m "bug 8245 - fix undefined value error in DMARC in perl 5.16 and 5.18" lib/Mail/SpamAssassin/Plugin/DMARC.pm Sendinglib/Mail/SpamAssassin/Plugin/DMARC.pm Transmitting file data .done Committing transaction... Committed revision 1917179. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8245] undefined value as an ARRAY reference in DMARC plugin
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8245
Sidney Markowitz changed:
What|Removed |Added
Target Milestone|Undefined |4.0.2
Severity|normal |trivial
--- Comment #2 from Sidney Markowitz ---
More testing of
perl -e 'use strict; my $files; my $foo = sort {$a // 0 <=> $b // 0}
@{$files};'
With perl 5.16.3 and 5.18.4 is outputs
Can't use an undefined value as an ARRAY reference at -e line 1.
With perl 5.20.3 and newer it doesn't output that.
The release notes for 5.20.0 mention a change in the treatment of arguments to
sort that is probably what makes the difference.
The following eliminates the warning in the older versions and doesn't change
the results in newer versions:
perl -e 'use strict; my $files; my $foo = sort {$a // 0 <=> $b // 0} @{$files
// []};'
I'll make that change in DMARC.pm
It is only a warning in the log, not an error, and doesn't effect the results.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8245] undefined value as an ARRAY reference in DMARC plugin
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8245
Sidney Markowitz changed:
What|Removed |Added
CC||sid...@sidney.com
--- Comment #1 from Sidney Markowitz ---
I can reproduce it in an email that has a valid authres with no spf and a dkim
that has a result other than pass. However, the warning message is only in
older perls.
$ perlbrew list
* perl-5.38.2
perl-5.18.4
$ perl -e 'use strict; my $files; my $foo = sort {$a // 0 <=> $b // 0}
@{$files};'
$ perl -e 'use strict; my $files; my $foo = sort {$a <=> $b} @{$files};'
Can't use an undefined value as an ARRAY reference at -e line 1.
$ perlbrew switch 5.18.4
$ perl -e 'use strict; my $files; my $foo = sort {$a <=> $b} @{$files};'
Can't use an undefined value as an ARRAY reference at -e line 1.
$ perl -e 'use strict; my $files; my $foo = sort {$a // 0 <=> $b // 0}
@{$files};'
Can't use an undefined value as an ARRAY reference at -e line 1.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8245] New: undefined value as an ARRAY reference in DMARC plugin
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8245
Bug ID: 8245
Summary: undefined value as an ARRAY reference in DMARC plugin
Product: Spamassassin
Version: 4.0.1
Hardware: PC
OS: Mac OS X
Status: NEW
Severity: normal
Priority: P2
Component: Plugins
Assignee: dev@spamassassin.apache.org
Reporter: sid...@sidney.com
Target Milestone: Undefined
This error was reported on users@ mailing list
https://lists.apache.org/thread/r384x26l6bpxz7xsh2fzk79l5nx8p44y
"after updating SA 4.0.0 to 4.0.1, (CentOS 7 - Perl version 5.16.3) I get the
following message in log regarding the DMARC plugin:
plugin: eval failed: Can't use an undefined value as an ARRAY reference at
/usr/share/perl5/Mail/SpamAssassin/Plugin/DMARC.pm line 336."
Looking at DMARC line 336 it looks to me that this could happen if DMARC check
doesn't pass and there are Authentication-Results headers but none with "spf="
in them, so in line 336 $pms->{authres_parsed}{spf} is undef
Is that what is happening? Is it a bug? I'm not familiar with the code.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8244] New: Update rules for Validity DNSBL lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8244 Bug ID: 8244 Summary: Update rules for Validity DNSBL lookups Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: PC OS: Windows 11 Status: NEW Severity: normal Priority: P2 Component: Rules Assignee: dev@spamassassin.apache.org Reporter: eric.hokan...@validity.com Target Milestone: Undefined Created attachment 5952 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5952=edit patch file for validity dnsbl Attached is a patch for your review to update the DNSBL rules recently implemented for Validity IP blocking. After analyzing our DNS logs following the recent changes in bug ID 8233, we don't think they are behaving in a way that was intended. The attached patch is much more effective and efficient rule set. The rules were tested against a local DNS instance using the spamassassin cli: perl -T ./spamassassin -t -D < ./t/data/spam/001 blocked output: pts rule name description -- -- 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.120.211.219 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.120.211.219 listed in sa-accredit.habeas.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [193.120.211.219 listed in sa-trusted.bondedsender.org] -- You are receiving this mail because: You are the assignee for the bug.
[Bug 6928] Add sa-learn option to learn from RFC822 attachment to message rather than full message
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6928 Sidney Markowitz changed: What|Removed |Added CC|milkg0d...@proton.me| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 6928] Add sa-learn option to learn from RFC822 attachment to message rather than full message
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6928 JAKOBMG changed: What|Removed |Added CC||milkg0d...@proton.me -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8242] remove t.co from uridnsbl_skip_domain
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8242 --- Comment #4 from Raymond Dijkxhoorn --- Hashbl has a seperate skiplist that only applies for hashbl. Again it’s not smart to lookup those redirectors on uribl level. You won’t get hits on those! Raymond - SURBL -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8242] remove t.co from uridnsbl_skip_domain
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8242 Giovanni Bechis changed: What|Removed |Added CC||giova...@paclan.it --- Comment #3 from Giovanni Bechis --- (In reply to Raymond Dijkxhoorn from comment #2) > Please don’t. It’s not very smart to lookup those on every domain-bl where > they won’t be listed anyway due to colleteral damage. > > Yes they are abused, and that’s why there are hashbl modules to coop with > this. > HASHBL plugin won't work because it honors uridnsbl_skip_domain configuration option. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8242] remove t.co from uridnsbl_skip_domain
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8242 Raymond Dijkxhoorn changed: What|Removed |Added CC||raym...@prolocation.net --- Comment #2 from Raymond Dijkxhoorn --- Please don’t. It’s not very smart to lookup those on every domain-bl where they won’t be listed anyway due to colleteral damage. Yes they are abused, and that’s why there are hashbl modules to coop with this. This change will only put a burden on the BL operators. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8242] remove t.co from uridnsbl_skip_domain
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8242 Benny Pedersen changed: What|Removed |Added CC||m...@junc.eu --- Comment #1 from Benny Pedersen --- lets blocklist all url forwarders instaed, let it be the rule fro all this kinds of problems, where it hurts sayed that there is many legetim use of urlforwards, i just dont know them yet -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8242] New: remove t.co from uridnsbl_skip_domain
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8242 Bug ID: 8242 Summary: remove t.co from uridnsbl_skip_domain Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Rules Assignee: dev@spamassassin.apache.org Reporter: giova...@paclan.it Target Milestone: Undefined t.co should be removed from uridnsbl_skip_domain list in rules/25_uribl.cf since it's abused. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8240] t/askdns.t broken by our DNS change to spamassassin.org SPF record
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8240 Sidney Markowitz changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Sidney Markowitz --- % svn ci -m "bug 8240 - fix test by using a test subdomain that will not be changed" t/askdns.t Sendingt/askdns.t Transmitting file data .done Committing transaction... Committed revision 1917027. Thanks to Giovanni for setting up a test subdomain with an SPF record -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8241] test more *_File db modules in t/sa_txrep.t
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8241 Sidney Markowitz changed: What|Removed |Added Summary|test modre *_File db|test more *_File db modules |modules in t/sa_txrep.t |in t/sa_txrep.t -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8234] Honor uridnsbl_skip_domain in DNSEval
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8234 Giovanni Bechis changed: What|Removed |Added Resolution|--- |FIXED CC||giova...@paclan.it Status|NEW |RESOLVED --- Comment #4 from Giovanni Bechis --- Sendinglib/Mail/SpamAssassin/Plugin/DNSEval.pm Transmitting file data .done Committing transaction... Committed revision 1917016. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8241] test modre *_File db modules in t/sa_txrep.t
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8241 Sidney Markowitz changed: What|Removed |Added CC||sid...@sidney.com Target Milestone|Undefined |4.0.2 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Sidney Markowitz --- % svn ci -m "bug 8241 - test using all of the supportd db modules that are available" t/sa_txrep.t Sendingt/sa_txrep.t Transmitting file data .done Committing transaction... Committed revision 1917007. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8241] New: test modre *_File db modules in t/sa_txrep.t
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8241 Bug ID: 8241 Summary: test modre *_File db modules in t/sa_txrep.t Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All OS: All Status: NEW Severity: enhancement Priority: P2 Component: Regression Tests Assignee: dev@spamassassin.apache.org Reporter: sid...@sidney.com Target Milestone: Undefined After encountering bug 8237 and bug 8238 which were missed due to never being tested, I've decided to expand t/sa_txrep.t to run the tests on all three db modules that are supported, DB_File, GDBM_File and SDBM_File instead of just the first available one as it does now. The enhanced test skips any that are not available to load. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8089] Failed tests on CPAN, Insecure dependency in mkdir while running with -T switch at ... File/Temp.pm line 542
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8089 Sidney Markowitz changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Sidney Markowitz --- % svn ci -m "bug 8089 - avoid triggering an obscure perl bug on some systems" t/SATest.pm Sendingt/SATest.pm Transmitting file data .done Committing transaction... Committed revision 1917005. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8089] Failed tests on CPAN, Insecure dependency in mkdir while running with -T switch at ... File/Temp.pm line 542
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8089 Sidney Markowitz changed: What|Removed |Added Resolution|WONTFIX |--- Target Milestone|Undefined |4.0.2 Status|RESOLVED|REOPENED --- Comment #5 from Sidney Markowitz --- I have some more insight on this, so I'm re-opening the issue to commit a patch that will keep this apparent Perl bug from triggering. I still can't duplicate an environment in which it happens, but there are a few CPAN test machines running certain old versions of perl where it consistently happens. The trigger is to have a tainted value, for example in variable $pathdir and the expression (-d $pathdir) and File::Spec->file_name_is_absolute($pathdir) followed soon after by a call to File::Temp::tempdir($template, DIR=>"log") The bug makes no sense, but it doesn't have to in order to work around it. The patch for t/SATest.pm I'll upload will do the following, which removes the trigger in two independent ways: - Untaint the path variable before the offending expression - Swap the order of the expression, i.e., the -d comes second. For whatever strange reason, the bug is only triggered if it comes first. Some small cleanup I noticed while editing this: - Remove redundant calls to File::Spec->canonpath since Cwd::realpath($pathdir) already canonicalizes before returning - Replace a few places where variables are untainted in code with calls to untaint_var so untainting is done in a consistent way -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8240] t/askdns.t broken by our DNS change to spamassassin.org SPF record
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8240 --- Comment #2 from Sidney Markowitz --- (In reply to Benny Pedersen from comment #1) > could add as in authres trusted or ignored ? > > basicly i think askdns should not test random spf unless it configured to do > it These are not random, they are spamassassin.org and txttcp.spamassassin.org, so both under our control. The second subdomain only exists for tests like this. Until recently we had no reason to use spamassassin.org for email, so the recird was only for testing too. I guess it depends on exactly what we expect the test cases to cover. If we want to test that it works with a minimal spf record of just 'v-spf1 -all' then the right thing to do is to use another test subdomain. Any domain that has an SPF record that it really uses isn't a good choice for a test case, anyway, as a reason to change it might come up at any time. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8240] t/askdns.t broken by our DNS change to spamassassin.org SPF record
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8240 Benny Pedersen changed: What|Removed |Added CC||m...@junc.eu --- Comment #1 from Benny Pedersen --- could add as in authres trusted or ignored ? basicly i think askdns should not test random spf unless it configured to do it -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8240] New: t/askdns.t broken by our DNS change to spamassassin.org SPF record
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8240 Bug ID: 8240 Summary: t/askdns.t broken by our DNS change to spamassassin.org SPF record Product: Spamassassin Version: 4.0.1 Hardware: All OS: All Status: NEW Severity: normal Priority: P2 Component: Regression Tests Assignee: dev@spamassassin.apache.org Reporter: sid...@sidney.com Target Milestone: Undefined t/askdns.t has a test that looks up the SPF record for spamassassin.org We recently changed the record so we could make use of a spamassassin,org email address. That breaks the test, which looks for an exact match of the TXT record on the nameserver as /^v=spf1 -all$/ We can change the test to match, or we can set up another test subdomain. If we change the test, we can future proof it a bit by making the rule match on /^v=spf1 include:.* -all$/ instead of /^v=spf1 include:raptor.pccc.com -all$/ Any thoughts before I commit a change to the test? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8240] t/askdns.t broken by our DNS change to spamassassin.org SPF record
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8240 Sidney Markowitz changed: What|Removed |Added CC||sid...@sidney.com Target Milestone|Undefined |4.0.2 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8239] Remove dead code from Makefile.PL
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8239 Sidney Markowitz changed: What|Removed |Added Status|NEW |RESOLVED Target Milestone|Undefined |4.0.2 CC||sid...@sidney.com Resolution|--- |FIXED --- Comment #1 from Sidney Markowitz --- % svn ci -m "Bug 8239 remove dead obsolete code from Makefile.PL" Makefile.PL SendingMakefile.PL Transmitting file data .done Committing transaction... Committed revision 1916991. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8239] New: Remove dead code from Makefile.PL
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8239 Bug ID: 8239 Summary: Remove dead code from Makefile.PL Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All OS: All Status: NEW Severity: trivial Priority: P2 Component: Building & Packaging Assignee: dev@spamassassin.apache.org Reporter: sid...@sidney.com Target Milestone: Undefined Similar to bug 8039 I noticed that the block of code in Makefile.PL that sets ATT_KEYS is not used or referred to anywhere. It is left over from revision 5748 that was part of bug 2388 and was only relevant to old versions of MakeMaker that we have since required out of. The code that used it is long gone. I'm committing a patch that removes it. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8237] TxRep/AWL failure using GDBM_File storage
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8237 Sidney Markowitz changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Sidney Markowitz --- % svn ci -m "bug 8237 - properly delete elements of tied hash" lib/Mail/SpamAssassin/DBBasedAddrList.pm Sendinglib/Mail/SpamAssassin/DBBasedAddrList.pm Transmitting file data .done Committing transaction... Committed revision 1916986. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8237] TxRep/AWL failure using GDBM_File storage
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8237 --- Comment #1 from Sidney Markowitz --- (In reply to Sidney Markowitz from comment #0) > autowelcome_list_db_modules GDBM_File That's a typo, use auto_welcomelist_db_modules GDBM_File to test this bug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8238] t/sa_txrep.t fails when using SDBM_File
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8238 Sidney Markowitz changed: What|Removed |Added Target Milestone|Undefined |4.0.2 Status|NEW |RESOLVED Resolution|--- |FIXED CC||sid...@sidney.com --- Comment #1 from Sidney Markowitz --- % svn ci -m "bug 8238 delete SDBM_File files during cleanuo in test" t/sa_txrep.t Sendingt/sa_txrep.t Transmitting file data .done Committing transaction... Committed revision 1916985. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8238] New: t/sa_txrep.t fails when using SDBM_File
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8238
Bug ID: 8238
Summary: t/sa_txrep.t fails when using SDBM_File
Product: Spamassassin
Version: 4.0.1
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Regression Tests
Assignee: dev@spamassassin.apache.org
Reporter: sid...@sidney.com
Target Milestone: Undefined
The t/sa_txrep.t test fails if it is using SDBM_File for storage.
The fix is trivial. The test has unlink("./$userstate/txreptest") to delete the
storage files is creates in the first set of tests before starting a second
set. That is fins with DB_File and GDBM_File, but SDBM_File creates
txreptes.pag and txreptest.dir files which need to be deleted when it is used.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8237] TxRep/AWL failure using GDBM_File storage
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8237 Sidney Markowitz changed: What|Removed |Added Target Milestone|Undefined |4.0.2 CC||sid...@sidney.com -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8237] New: TxRep/AWL failure using GDBM_File storage
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8237
Bug ID: 8237
Summary: TxRep/AWL failure using GDBM_File storage
Product: Spamassassin
Version: 4.0.1
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Libraries
Assignee: dev@spamassassin.apache.org
Reporter: sid...@sidney.com
Target Milestone: Undefined
This bug can be reproduced by editing t/sa_txrep.t to add this line to the
tstprefs
autowelcome_list_db_modules GDBM_File
That breaks the test. I tracked it down to a bug in the remove_entry function
in DBBasedAddrList.pm where the keys are deleted in a loop that starts with
while (my ($key, $value) = each %{$self->{accum}}) {
According to the perldoc https://perldoc.perl.org/functions/each after
explaining that the code we use is safe to use with hashes as an explicit
exception to the ordering behaviour rule against deleting elements of a hash in
an each loop, it goes on to say
"Tied hashes may have a different ordering behaviour to perl's hash
implementation."
And apparently DB_File and SDBM_File don't break when we do that, but GDBM_File
does.
I'm testing a patch now and will upload it soon.
Unfortunately, this does not explain bug 8236 as the SQL code does not use tied
hashes.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8236] New: mail/spamassassin Bug in bayes updating txtrep
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8236 Bug ID: 8236 Summary: mail/spamassassin Bug in bayes updating txtrep Product: Spamassassin Version: 4.0.1 Hardware: PC OS: FreeBSD Status: NEW Severity: normal Priority: P2 Component: spamassassin Assignee: dev@spamassassin.apache.org Reporter: cy.schub...@cschubert.com Target Milestone: Undefined Hi, I am a FreeBSD committer and maintainer of the mail/spamassassin group of packages. One of my users is complaining about the following. I've pasted his email to me below: Starting with spamassassin-4.0.1, which I build with poudriere on April 1, it seems to update the txrep table (mariadb) in a wrong way... If there already was an entry in column email (meaning a real em...@addr.ess), the msgcount column is set to 1 in stead of adding 1 to the value already there! This does not apply to other entrees like IP's and such. Started with 4.0.1, same in 4.0.1_1 Mariadb106, but used p5-DBD-mysql in both! == EXAMPLE== The orders@ email address should have multiple hits in msgcount | username| email | ip | msgcount | totscore | signedby +-+-+--+--+---+--- | luser | _192.168.2.44_ | none | 203 | -224.509 | helo | luser |orders@CLIENT_MAIL.it| none |1 | -172.713 | CLIENT_MAIL.it | luser | e059b4~~eb05ec@sa_generated | none |1 | -0.847882 | 1713003188 | luser | CLIENT_MAIL.it | none | 150 | -216.981 | CLIENT_MAIL.it | luser | 123.4.56.789| none | 308 | -388.25 | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8235] Microsoft has earned removal from the SA default welcomelist
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8235 Bill Cole changed: What|Removed |Added CC||billc...@apache.org Assignee|dev@spamassassin.apache.org |billc...@apache.org -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8235] New: Microsoft has earned removal from the SA default welcomelist
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8235 Bug ID: 8235 Summary: Microsoft has earned removal from the SA default welcomelist Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All OS: All Status: NEW Severity: normal Priority: P2 Component: Rules Assignee: dev@spamassassin.apache.org Reporter: billc...@apache.org Target Milestone: Undefined -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8234] Honor uridnsbl_skip_domain in DNSEval
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8234 Giovanni Bechis changed: What|Removed |Added Attachment #5949|0 |1 is obsolete|| --- Comment #3 from Giovanni Bechis --- Created attachment 5950 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5950=edit uridnsbl_skip_domain for DNSEval added "dnseval:" prefix to dbg calls. subdomains are skipped as well if the parent domain is in uridnsbl_skip_domain config. This is the same behavior than we have in HashBL plugin. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8234] Honor uridnsbl_skip_domain in DNSEval
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8234
Henrik Krohns changed:
What|Removed |Added
CC||apa...@hege.li
--- Comment #2 from Henrik Krohns ---
- missing dbg("dnseval:
- should subdomain.foo.com match uridnsbl_skip_domain foo.com?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 8234] Honor uridnsbl_skip_domain in DNSEval
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8234 Kevin A. McGrail changed: What|Removed |Added CC||kmcgr...@apache.org --- Comment #1 from Kevin A. McGrail --- +1 from me. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8234] New: Honor uridnsbl_skip_domain in DNSEval
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8234 Bug ID: 8234 Summary: Honor uridnsbl_skip_domain in DNSEval Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Libraries Assignee: dev@spamassassin.apache.org Reporter: giova...@paclan.it Target Milestone: Undefined Created attachment 5949 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5949=edit uridnsbl_skip_domain for DNSEval uridnsbl_skip_domain option can be used to prevent SA from running rbl lookups on a particular domain. This option is honored in URIDNSBL and HashBL plugins but not in DNSEval plugin. The attached diff makes DNSEval honor uridnsbl_skip_domain option. This is a behavior change but I think it should be expected. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8233] Add URIBL rules for Validity DNSBL lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8233 Giovanni Bechis changed: What|Removed |Added Resolution|--- |FIXED CC||giova...@paclan.it Status|NEW |RESOLVED --- Comment #5 from Giovanni Bechis --- Committed in revision 1916884. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8233] Add URIBL rules for Validity DNSBL lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8233 Kevin A. McGrail changed: What|Removed |Added CC||kmcgr...@apache.org --- Comment #4 from Kevin A. McGrail --- +1 for inclusion. My biggest concern was if the link was an advertisement. The landing page seems useful and informative. The patch has been well-tested. Getting clear notices when a system exceeds volume is important. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8233] Add URIBL rules for Validity DNSBL lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8233 Giovanni Bechis changed: What|Removed |Added Attachment #5947|0 |1 is obsolete|| --- Comment #3 from Giovanni Bechis --- Created attachment 5948 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5948=edit updated patch without auto-generated files Removed auto-generated files from the patch. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8233] Add URIBL rules for Validity DNSBL lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8233 --- Comment #2 from Eric Hokanson --- Testing procedure for this was I setup a local DNS server to respond to some of the SA test spam message IPs with the 127.255.255.255 A record. I then set my machine’s resolver to that DNS server. I then ran the spamassassin CLI to trigger the blocklist: perl -T ./spamassassin -t -D < ./t/data/spam/001 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8233] Add URIBL rules for Validity DNSBL lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8233 Eric Hokanson changed: What|Removed |Added Attachment #5946|0 |1 is obsolete|| CC||eric.hokan...@validity.com --- Comment #1 from Eric Hokanson --- Created attachment 5947 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5947=edit patch file for validity uribl v2 After some discussion we've updated the URL to link directly to our knowledge base. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8233] New: Add URIBL rules for Validity DNSBL lookups
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8233 Bug ID: 8233 Summary: Add URIBL rules for Validity DNSBL lookups Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: PC OS: Windows 11 Status: NEW Severity: normal Priority: P2 Component: spamassassin Assignee: dev@spamassassin.apache.org Reporter: eric.hokan...@validity.com Target Milestone: Undefined Created attachment 5946 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5946=edit patch file for validity uribl Attached is a patch for your review to add URIBL rules recently implemented for Validity (formerly Return Path) DNSBL lookups. This was tested locally against IP 209.61.190.180 producing the following matches: Content analysis details: (18.8 points, 5.0 required) pts rule name description -- -- 0.0 VALIDITY_BLOCKED_SAFE ADMINISTRATOR NOTICE: The query to Validity was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URI: 209.61.190.180] 0.0 VALIDITY_BLOCKED_RPBL ADMINISTRATOR NOTICE: The query to Validity was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URI: 209.61.190.180] 0.0 VALIDITY_BLOCKED_CERTIFIED ADMINISTRATOR NOTICE: The query to Validity was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URI: 209.61.190.180] ... We would also kindly request an entry on the DNS blocklist wiki page pointing to our knowledge base article: https://knowledge.validity.com/hc/en-us/articles/20961730681243-Accessing-Validity-reputation-data-through-DNS Thank you. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8232] Phishing Army support in the Phishing plugin
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8232 --- Comment #1 from Giovanni Bechis --- Created attachment 5945 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5945=edit Remove proto from urls Attached patch removes protocol from URIs in order to match on both http and https protocols. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8230] REVIEW: Update CREDITS file
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8230 Sidney Markowitz changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Sidney Markowitz --- closing in preparation for the release -- You are receiving this mail because: You are the assignee for the bug.
[Bug 1341] Improve packageability of libspamc
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=1341 Sidney Markowitz changed: What|Removed |Added CC|gearsofwarez773@protonmail. | |com | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 1341] Improve packageability of libspamc
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=1341 gearsofwarez...@protonmail.com changed: What|Removed |Added CC||gearsofwarez773@protonmail. ||com --- Comment #9 from gearsofwarez...@protonmail.com --- Comment on attachment 1215 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=1215 Add install rule to binaries.mk and required stuff to configure aclocal autoconf ./configure make -f binaries.mk install --- Mail-SpamAssassin-2.55/configure.in 2003-03-28 22:25:56.0 +0100 +++ Mail-SpamAssassin-2.55-libspamc/configure.in2003-08-01 23:57:12.0 +0200 @@ -8,6 +8,8 @@ fi AC_PROG_CC +AC_PROG_INSTALL +AM_MKINSTALLDIRS AC_EXEEXT --- Mail-SpamAssassin-2.55/binaries.mk.in 2002-12-19 14:19:08.0 +0100 +++ Mail-SpamAssassin-2.55-libspamc/binaries.mk.in 2003-08-02 00:08:00.0 +0200 @@ -18,6 +18,17 @@ LIBSPAMC_FILES = spamd/libspamc.c spamd/utils.c +top_builddir = . +prefix = @prefix@ +exec_prefix = @exec_prefix@ +libdir = @libdir@ +includedir = @includedir@ +headerdir = $(includedir)/libspamc + +INSTALL = @INSTALL@ +INSTALL_DATA = @INSTALL_DATA@ +MKINSTALLDIRS = @MKINSTALLDIRS@ + all: spamd/spamc$(EXE_EXT) qmail/qmail-spamc true @@ -43,3 +54,12 @@ $(CC) $(CFLAGS) $(QMAIL_SPAMC_FILES) \ -o $@ $(LDFLAGS) $(LIBS) +install: install-libs install-headers + +install-libs: spamd/libspamc$(SHLIBEXT) + $(MKINSTALLDIRS) $(libdir) + $(INSTALL) $< $(libdir) + +install-headers: spamd/libspamc.h + $(MKINSTALLDIRS) $(headerdir) + $(INSTALL_DATA) $< $(headerdir) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8089] Failed tests on CPAN, Insecure dependency in mkdir while running with -T switch at ... File/Temp.pm line 542
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8089 --- Comment #4 from Sidney Markowitz --- The test machines with the problem don't seem to be running any more, but another couple of machines have sprung up with the same thing. These machines run CentOS 7 and FreeBSD 10.1, with perl versions 5.18.4, 5.20.1, 5.20.2, and 5.20.3. I've added File::Temp to the list in Makefile.PL of modules that Mail::SpamAssassin requires. Since File::Temp is a core module included with Perl, this has no effect on building or running, but it will cause the CPAN test reports to show which version of File::Temp is actually installed on the test machine. Even though I've closed this bug as a WONTFIX I'm hoping that when the problem does show up occasionally on some CPAN test machines, this might give a bit more insight. % svn ci -m "Bug 8089 - Add explicit dependency on File::Temp so CPAN test reports show version. Has no other effect on build or running" Makefile.PL SendingMakefile.PL Transmitting file data .done Committing transaction... Committed revision 1916488. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8232] New: Phishing Army support in the Phishing plugin
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8232 Bug ID: 8232 Summary: Phishing Army support in the Phishing plugin Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P2 Component: Plugins Assignee: dev@spamassassin.apache.org Reporter: andre...@gmail.com Target Milestone: Undefined Created attachment 5944 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5944=edit Phishing Army support Hello This patch adds support for the Phishing Army (https://phishing.army/) feed in the Phishing plugin. As this is a domain feed, not an URI one like OpenPhish and PhishTank, the patch adds both http:// and https:// URIs to the PHISHING hash. Not sure if this is the expected behavior, but I can change it if you feel doing that is not appropriate. Thanks, Andre -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8231] Add Pyzor Perl implementation
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8231 --- Comment #2 from Sidney Markowitz --- Two tweaks which I'm not opening a new bug for... One cosmetic bug in the code that gets an error when Pyzor crashes, whose only effect is to not output a dbg message saying no response from server. The other fixes that the perl-only pyzor tests were not being run when the executable Pyzor is not installed. % svn ci -m "bug 8231 - run perl pyzor tests even when python pyzor not installed. Also fix dbg message when pyzor crashes" lib/Mail/SpamAssassin/Plugin/Pyzor.pm t/pyzor.t Sendinglib/Mail/SpamAssassin/Plugin/Pyzor.pm Sendingt/pyzor.t Transmitting file data ..done Committing transaction... Committed revision 1916435. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 4644] remove_header and SQL prefs serialization issue
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=4644 Sidney Markowitz changed: What|Removed |Added CC|patymi...@gmail.com | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 4644] remove_header and SQL prefs serialization issue
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=4644 Mih changed: What|Removed |Added CC||patymi...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8231] Add Pyzor Perl implementation
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8231 Sidney Markowitz changed: What|Removed |Added Target Milestone|Undefined |4.0.1 Resolution|--- |FIXED Status|NEW |RESOLVED CC||sid...@sidney.com --- Comment #1 from Sidney Markowitz --- Closing, which requires a comment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8231] New: Add Pyzor Perl implementation
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8231 Bug ID: 8231 Summary: Add Pyzor Perl implementation Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All OS: All Status: NEW Severity: enhancement Priority: P2 Component: Plugins Assignee: dev@spamassassin.apache.org Reporter: sid...@sidney.com Target Milestone: Undefined This was committed in revision 1910959 without a corresponding Bugzilla issue, so creating this one to document it. The commit adds a Perl implementation of enough of the Pyzor client functionality to be usable by SpamAssassin, to be used as a substitute for the official Python based Pyzor. Adds a config option pyzor_perl that defaults to 0 to enable it. Since the Pyzor protocol is not officially documented, this change uses reverse engineering and best guess effort. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 6510] Mass-check generating nightly rules updates with 0 scores for rules with dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6510 Sidney Markowitz changed: What|Removed |Added CC|gearsofwa...@protonmail.com | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 6510] Mass-check generating nightly rules updates with 0 scores for rules with dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6510 --- Comment #14 from Sidney Markowitz --- The content of attachment 5943 has been deleted for the following reason: spam -- You are receiving this mail because: You are the assignee for the bug.
[Bug 6510] Mass-check generating nightly rules updates with 0 scores for rules with dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6510 --- Comment #13 from gearsofwa...@protonmail.com --- Created attachment 5943 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5943=edit vc -- You are receiving this mail because: You are the assignee for the bug.
[Bug 6510] Mass-check generating nightly rules updates with 0 scores for rules with dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=6510 gearsofwa...@protonmail.com changed: What|Removed |Added CC||gearsofwa...@protonmail.com -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8230] REVIEW: Update CREDITS file
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8230 Sidney Markowitz changed: What|Removed |Added CC||sid...@sidney.com Target Milestone|Undefined |4.0.1 --- Comment #4 from Sidney Markowitz --- axb is not gone yet... % svn ci -m "update copyright, revert credit change" CREDITS SendingCREDITS Transmitting file data .done Committing transaction... Committed revision 1916406. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8229] remove run_sql_pref_tests option in t/config.dist
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8229 Sidney Markowitz changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Sidney Markowitz --- % svn ci -m "bug 8229 - remove run_sql_pref_tests config option, run if possible" t/config.dist t/spamd_sql_prefs.t Sendingt/config.dist Sendingt/spamd_sql_prefs.t Transmitting file data ..done Committing transaction... Committed revision 1916374. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8229] remove run_sql_pref_tests option in t/config.dist
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8229 Giovanni Bechis changed: What|Removed |Added CC||giova...@paclan.it --- Comment #1 from Giovanni Bechis --- +1 to remove option run_sql_pref_tests from t/config.dist -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8230] REVIEW: Update CREDITS file
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8230 --- Comment #3 from AXB --- moved Alex Broens from PMC to Commiter list commit 1916368 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8230] REVIEW: Update CREDITS file
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8230 --- Comment #2 from Bill Cole --- Proposed add and change to credit Kent Oyer and direct credit inquiries to PMC: Index: CREDITS === --- CREDITS (revision 1916367) +++ CREDITS (working copy) @@ -299,6 +299,8 @@ - Tomasz Ostrowski, : perl 5.005 support. + - Kent Oyer, : multiple patches: Razor2 docs, encoding, and HTML parsing. + - Henning P. Schmiedehausen, : adding ? to shell globs. @@ -355,8 +357,8 @@ by Mike Quinn: source of the original SpamAssassin logo. If your name is not here, and you've submitted a patch that was included, - it's just an oversight. Please mail me at and I'll add - you to the list. + it's just an oversight. Please mail the PMC at + and we'll add you to the list. ASF Sponsorship: -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8230] REVIEW: Update CREDITS file
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8230 Bill Cole changed: What|Removed |Added CC||billc...@apache.org Summary|Update CREDITS file.|REVIEW: Update CREDITS file --- Comment #1 from Bill Cole --- Old -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8230] New: Update CREDITS file.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8230 Bug ID: 8230 Summary: Update CREDITS file. Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All OS: All Status: NEW Severity: normal Priority: P2 Component: Documentation Assignee: dev@spamassassin.apache.org Reporter: billc...@apache.org Target Milestone: Undefined -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7323] My Bugs shows more than just my bugs
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7323 Sidney Markowitz changed: What|Removed |Added CC|wbgd1...@gmail.com | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 7323] My Bugs shows more than just my bugs
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7323 James white changed: What|Removed |Added CC||wbgd1...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8229] remove run_sql_pref_tests option in t/config.dist
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8229 Sidney Markowitz changed: What|Removed |Added Target Milestone|Undefined |4.0.1 CC||sid...@sidney.com -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8229] New: remove run_sql_pref_tests option in t/config.dist
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8229 Bug ID: 8229 Summary: remove run_sql_pref_tests option in t/config.dist Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All OS: All Status: NEW Severity: enhancement Priority: P2 Component: Building & Packaging Assignee: dev@spamassassin.apache.org Reporter: sid...@sidney.com Target Milestone: Undefined The option run_sql_pref_tests which in our default t/config.dist is set to n is only used in the test t/spamd_sql_prefs.t I don't see any reason not to run those tests by default, especially since some other tests that are run also use SQLite if the module is available. It was made part of t/config.dist when the file was first committed, but it does not make any sense anymore unless I'm missinog something about it. I propose removing the flag in t/config.dist and the test for it in t/spamd_sql_prefs.t The rationale for making the change is that there is no reason not to get the code coverage of the t/spamd_sql_prefs.t in default test settings like on the CPAN test machines. Any objections or comments about this before I do it? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8189] SORBS no longer works in SPAMASSASSIN
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8189 Sidney Markowitz changed: What|Removed |Added Resolution|--- |INVALID Status|REOPENED|RESOLVED CC||sid...@sidney.com --- Comment #3 from Sidney Markowitz --- >From your comments, I see that you installed an old version of Spamassassin (the current one is 4.0.0, with 4.0.1 to be released soon) and found that the default configuration did not trigger SORBS rules when you think they should. You were able to get it to trigger custom rules that you added to your configuration. That proves that 1) The code in SpamAssassin does properly handle using SORBS as an RBL; and 2) Your configuration after installing SpamAssassin had a problem with SORBS, which you could work around by changing the configuration. You still have a problem, because even though your configuration seems to work, it is doing so by running five different queries to SORBS nameservers instead of just one query to the aggregate server and interpreting the results. This is exactly the kind of problem that you can get help with on the users mailing list. If after a discussion there you have an example of a specific email message that demonstrates a bug in SpamAssassin, you can open a bug report and attach the email along with the steps by which anyone can reproduce the bug. Until then, I am closing this issue again as "invalid". That doesn't mean that your problem is invalid, only that it is not a valid issue for this forum and is better taken to the user mailing list for help getting it resolved. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8218] HTML URIs with linebreaks not parsed with Content-Transfer-Encoding: quoted-printable
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8218 Sidney Markowitz changed: What|Removed |Added CC||sid...@sidney.com --- Comment #1 from Sidney Markowitz --- Created attachment 5942 --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5942=edit Test email Can you attach a full test email that demonstrates the problem? I made your snippet into an email with quoted-printable and ran ./spamassassin -t -D uri,message < uriwraptest.eml Did I miss something? I am testing using current trunk. Here is the debug output showing the correct URL being parsed: Mar 15 20:23:08.229 [99779] dbg: message: _decode_header date: Thu, 2 May 2002 00:02:49 +1200 Mar 15 20:23:08.229 [99779] dbg: message: _decode_header subject: foo Mar 15 20:23:08.229 [99779] dbg: message: _decode_header to: Mar 15 20:23:08.229 [99779] dbg: message: _decode_header from: Mar 15 20:23:08.229 [99779] dbg: message: _decode_header message-id: Mar 15 20:23:08.229 [99779] dbg: message: _decode_header mime-version: 1.0 Mar 15 20:23:08.229 [99779] dbg: message: _decode_header content-type: text/html; charset=US-ASCII Mar 15 20:23:08.229 [99779] dbg: message: _decode_header content-transfer-encoding: quoted-printable Mar 15 20:23:08.230 [99779] dbg: message: main message type: text/html Mar 15 20:23:08.235 [99779] dbg: message: MIME PARSER START Mar 15 20:23:08.235 [99779] dbg: message: parsing normal part Mar 15 20:23:08.235 [99779] dbg: message: storing a body to memory Mar 15 20:23:08.235 [99779] dbg: message: MIME PARSER END Mar 15 20:23:08.235 [99779] dbg: message: decoding quoted-printable Mar 15 20:23:08.235 [99779] dbg: message: contains only US-ASCII characters, declared US-ASCII, not decoding Mar 15 20:23:08.235 [99779] dbg: message: HTML::Parser utf8_mode off (default, assumed Unicode characters) Mar 15 20:23:08.236 [99779] dbg: message: spaces (octets) in HTML: 3 out of 21, chars!? Mar 15 20:23:08.242 [99779] dbg: uri: canonicalizing html uri: http://hashbltest.surbl.org/example_uri Mar 15 20:23:08.242 [99779] dbg: uri: cleaned uri: http://hashbltest.surbl.org/example_uri Mar 15 20:23:08.242 [99779] dbg: uri: added host: hashbltest.surbl.org domain: surbl.org -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8223] Incorrect flagging of spam
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8223 Sidney Markowitz changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED CC||sid...@sidney.com --- Comment #2 from Sidney Markowitz --- I'm closing this as not a valid bug. To the submitter of this bug: This is being done without malice to keep our bug database clean. If you do have an example demonstrates a bug in SpamAssassin and not in your ISP's configuration you are welcome to re-open this issue to provide that example. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8201] Make some tests that fail occasionally more robust
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8201 Sidney Markowitz changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #20 from Sidney Markowitz --- Since I last looked at this, Net::DNS has had several updates for which I worked with the developer to help test and resolve issues related to Windows. Also, we did some changes to handle truncated large UDP DNS packets and implemented TCP retry. I'm still seeing some flaky behavior on Windows test machines on CPAN, but 1) they are not the same tests failing, so it does look like random dropped packets or timeouts, not simple bugs in the code; and 2) I discovered that what the test reports show for the version of Windows are not accurate, only showing the version of Windows that perl was built on. Looking deeper, I found almost all the test machines are running Windows 7, 8, or 8.1. Given that, I'm not going to try to get the test machines to pass 100% of the tests. With that, I close this issue. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8198] Investigate test failures on CPAN for 4.0.1 test builds before final release
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8198 Sidney Markowitz changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #16 from Sidney Markowitz --- Ok, I'm ready to close this. Here are the remaining test failures I see on CPAN test machines that I am giving up on: Some DNS network related issues on test machine(s) running FreeBSD 10.1. It may be related to large UDP packets, or just flaky behavior with UDP packets under heavy load. Whatever it is, I don't care about FreeBSD 10.1 and it doesn't seem like a SpamAssassin issue that needs fixing. One FreeBSD 14.0 test machine fails t/bayesdbm.t consistently. I can't reproduce it on a FreeBSD 14.0 VM. I suspect that the test machine has a mismatch between the version of BerkeleyDB that its perl is compiled with and the version in the system's shared libraries. Or something like that. Not a SpamAssassin bug. DNS network issues on Windows test machines. Doesn't happen on my test VMs. I just discovered that the OS name and version info displayed on the CPAN tests reports are incorrect. They show the OS and version that perl was compiled under, not the version running the program. For anything except Windows that is likely to be close enough, but if a Windows user is running Strawberry Perl 5.X.Y it will show whatever version of Windows was used to build that version of the installer when it was released at the time it was new. So all tests I thought were being run on Windows 10 machines were actually old Windows machines that had installed a recent version of Strawberry Perl. It turns out that most of the Windows test machines on CPAN are running Windows 7, 8, or 8.1. We don't have to care if they exhibit sporadic flaky DNS network behavior during our tests. And those two or so machines running some flavor of Linux that have something strange in their setup of tmp storage that causes all of our tests to fail with an impossible taint error trying to create a temporary directory. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8227] Detect bad DNS network setup early in build
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8227 Bill Cole changed: What|Removed |Added CC||billc...@apache.org --- Comment #7 from Bill Cole --- (In reply to Sidney Markowitz from comment #5) > I can't see why we should care about failures in FreeBSD > 10.1, IMHO We shouldn't. I say that as someone who wrangles a fleet of FreeBSD boxes in my day job. It would be irresponsible to encourage anyone to keep a box that far from modernity functional. If SA builds, that's great, but it would be a waste of time to bad ends for us to do anything to make it work. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8227] Detect bad DNS network setup early in build
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8227 Sidney Markowitz changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #6 from Sidney Markowitz --- % svn ci -m "bug 8227 - Revert addition of DNS test run durimg build" Makefile.PL lib/Mail/SpamAssassin/Util/DependencyInfo.pm SendingMakefile.PL Sendinglib/Mail/SpamAssassin/Util/DependencyInfo.pm Transmitting file data ..done Committing transaction... Committed revision 1916250. Now the only thing that has ben added for this issue is the new t/dnsplatform.t test. I'm closing this as resolved. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8227] Detect bad DNS network setup early in build
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8227 --- Comment #5 from Sidney Markowitz --- I have more information from a test build I uploaded to CPAN to see what their test machines make of it. The results are a bit confusing. What I uploaded is what is in trunk now, which will not generate any report from a test machine that fails the DNS test in Makefile.PL. Despite that, there are a number of failures reported anyway, although from the lower numbers I think that most test machines with problems are failing fast and silently. There are three failures, on the same FreeBSD 10.1 test machine with three runs each using different versions of perl, getting identical failures. They fail t/dnsplatform.t, getting 0 answers to the query of multihomed.dnsbltest.spamassassin.org A even though the identical test in Makefile.PL has to have passed for the build to continue on to run the tests. They also all have the same failures in t/dnsbl.t and t/spamc_H.t I can't do any testing on a FreeBSD 10.1 VM because I can't find any FreeBSD archives that go back that far, other than the basic install images. Another three failures are on a Windows 10 test machine, again three runs with different versions of perl. Those all have failures in t/dnsbl.t, t/hashbl.t, and t/spf.t, but the specific tests that fail are different. I suspect that there are replies being lost randomly. I haven't yet seen any other tests of this upload on Windows machines, and I can't reproduce the problem on my Windows 10 VM. Given that this test is not definitively predictive of the failures, and especially because I can't see why we should care about failures in FreeBSD 10.1, I'll revert all the changes I committed except to keep to new t/dnsplatform.t which is still useful to alert one to a badly configured DNS setup that should either be fixed or require use of the dns_server option. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8228] Stricter syntax warning in Perl 5.39
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8228 Sidney Markowitz changed: What|Removed |Added Target Milestone|Undefined |4.0.1 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Sidney Markowitz --- % svn ci -m "8228 fix operator precedence error caught by perl 5.39 warning" spamassassin.raw Sendingspamassassin.raw Transmitting file data .done Committing transaction... Committed revision 1916242. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8228] Stricter syntax warning in Perl 5.39
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8228 Sidney Markowitz changed: What|Removed |Added CC||sid...@sidney.com --- Comment #1 from Sidney Markowitz --- Actually, now that I'm reading it over, it looks like the warning has found a longstanding bug. The documentation I linked to uses as an example exactly what is being warned here. It says exit $x ? 0 : 1; # actually parses as: exit($x) ? 0 : 1; spamassassin.raw line 293 is exit $res ? 1 : 0; We intend exit($res ? 1 : 0); not exit($res) ? 1 : 0; right? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8228] New: Stricter syntax warning in Perl 5.39
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8228 Bug ID: 8228 Summary: Stricter syntax warning in Perl 5.39 Product: Spamassassin Version: SVN Trunk (Latest Devel Version) Hardware: All OS: All Status: NEW Severity: normal Priority: P2 Component: Building & Packaging Assignee: dev@spamassassin.apache.org Reporter: sid...@sidney.com Target Milestone: Undefined Perl 5.39 has a new stricter check for code that may be misleading due to obscure precedence of operators. See https://perldoc.perl.org/blead/perl5396delta and the errors in spamassassin.raw line 293 https://www.cpantesters.org/cpan/report/017fa1c0-dff2-11ee-8d78-4d126e8775ea This just needs to be parenthesized to eliminate the warning. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8227] Detect bad DNS network setup early in build
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8227 --- Comment #4 from Sidney Markowitz --- (In reply to Giovanni Bechis from comment #2) > The bits added to DependencyInfo.pm breaks install on some networks where > SpamAssassin would work by adding "dns_server 127.0.0.1" option. What I was trying to do was overkill anyway. Instead killing the entire build, and not even suppressing all network tests, since most of them won't trigger big DNS replies or whatever is going wrong with multihomed addresses, I can do this: Put the test of getting the txttcp large packet in a function in t/SATest.pm and have only the tests that actually fail when it is a problem call it (not all network tests have to care about it). If it fails, they can skip all tests with a warning message that dns_server may have to be set when running SpamAssassin on that system. Add the check of multihomed to t/spamc_H.t so it can skip the tests with a similar warning if something is wrong with the local DNS resolver that affects getting those records. That will prevent the egregious failure reports on those CPAN test machines that have bad DNS configuration without breaking any builds, and will warn people who need to use dns_server options in their configuration. How does that seem? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8225] askdns TCP fallback not working with UDP truncated TXT response
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8225 Sidney Markowitz changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #10 from Sidney Markowitz --- Clicked the Save button too soon. Trying again to close this. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8225] askdns TCP fallback not working with UDP truncated TXT response
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8225 --- Comment #9 from Sidney Markowitz --- (In reply to Giovanni Bechis from comment #8) > Actually this patch respects "dns_server" option because Yup, you're right, I must be smarter (or more thorough (or luckier)) than I thought I was. Re-closing the issue. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8225] askdns TCP fallback not working with UDP truncated TXT response
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8225 --- Comment #8 from Giovanni Bechis --- Actually this patch respects "dns_server" option because TCP fallback dns server is setup using "get_resolver" method of Mail::SpamAssassin::DnsResolver class which reads its configuration from SpamAssassin configuration files. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8225] askdns TCP fallback not working with UDP truncated TXT response
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8225 Sidney Markowitz changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #7 from Sidney Markowitz --- Reopening to deal with problem noticed in bug 8227 comment 3 that this patch does not respect any dns_server config options when it calls Net::DNS::Resolver -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8227] Detect bad DNS network setup early in build
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8227 Sidney Markowitz changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #3 from Sidney Markowitz --- (In reply to Giovanni Bechis from comment #2) > The bits added to DependencyInfo.pm breaks install on some networks where > SpamAssassin would work by adding "dns_server 127.0.0.1" option. Oh, that's a problem for the fix I did for bug 8225 too, because the calls to Net::DNS::Resolver aren't using the dns_server conf options. I also didn't think about t/config.dist default is run_net_tests=n which this check ignores, breaking the install on systems that will not get test failures. Ok, I'll have to revert that part of the commit. The new t/dnsplatform.t test is still useful, though. If it fails it signals that the failures in the other network tests that fail can be ignored, and that dns_server config options may be necessary to run on that system. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 8227] Detect bad DNS network setup early in build
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8227 Giovanni Bechis changed: What|Removed |Added CC||giova...@paclan.it --- Comment #2 from Giovanni Bechis --- The bits added to DependencyInfo.pm breaks install on some networks where SpamAssassin would work by adding "dns_server 127.0.0.1" option. -- You are receiving this mail because: You are the assignee for the bug.
