[Bug 3762] [review] Plugins should be able to be called after learn

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3762

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Plugins should be able to be|[review] Plugins should be
   |called after learn  |able to be called after
   ||learn



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 17:27 ---
+1

a few comments.

1) patches really need to be *attached* to the message, not cut/paste (even a 
one line one), as it says 
clearly when a ticket is opened.

2) I think we're going to need to go through and plugin-ize the code a bit 
more.  It was originally 
planned as a way to have eval rules without having to modify EvalTests, but now 
it's becoming a very 
generic way of doing code things without patches -- which is good, but I don't 
want to just start 
randomly adding in calls around.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3762] [review] Plugins should be able to be called after learn

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3762





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 18:06 ---
Subject: Re:  [review] Plugins should be able to be called after learn

On Wed, Sep 08, 2004 at 05:40:35PM -0700, [EMAIL PROTECTED] wrote:
 useful.  the overhead of a new plugin hook should be very minor, though, so we
 can probably pepper them a bit more liberally...

yeah, it's just something I'd like us to sit down and come up with a plan for
3.1.





--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3762] [review] Plugins should be able to be called after learn

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3762





--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 18:30 ---
+1



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.


[Bug 3762] [review] Plugins should be able to be called after learn

2004-09-09 Thread bugzilla-daemon
http://bugzilla.spamassassin.org/show_bug.cgi?id=3762

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2004-09-08 20:43 ---
ok, applied -- r43565.



--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.