https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8229

            Bug ID: 8229
           Summary: remove run_sql_pref_tests option in t/config.dist
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Building & Packaging
          Assignee: dev@spamassassin.apache.org
          Reporter: sid...@sidney.com
  Target Milestone: Undefined

The option run_sql_pref_tests which in our default t/config.dist is set to n is
only used in the test t/spamd_sql_prefs.t

I don't see any reason not to run those tests by default, especially since some
other tests that are run also use SQLite if the module is available.

It was made part of t/config.dist when the file was first committed, but it
does not make any sense anymore unless I'm missinog something about it. I
propose removing the flag in t/config.dist and the test for it in
t/spamd_sql_prefs.t

The rationale for making the change is that there is no reason not to get the
code coverage of the t/spamd_sql_prefs.t in default test settings like on the
CPAN test  machines.

Any objections or comments about this before I do it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to